> From: Heng Qi
> Sent: Thursday, February 9, 2023 12:21 AM
> Thanks for your reply.
> >>> I had one last question. Why do we need to inform the
> >> hash_report_tunnel_type of the outer header in the virtio_net_hdr?
> >>> Is this for debug? Or is there a use case that will process this
Hi Cornelia,
> From: Parav Pandit
> Sent: Wednesday, February 8, 2023 8:43 PM
>
> Currently some fields of the virtio_net_config structure are defined before
> introducing the structure and some are defined after introducing
> virtio_net_config.
> Better to define the configuration layout first
Currently some fields of the virtio_net_config structure are defined
before introducing the structure and some are defined after
introducing virtio_net_config.
Better to define the configuration layout first followed by
description of all the fields.
Device configuration fields are described in
On Thu, 9 Feb 2023 03:35:33 +, Parav Pandit wrote:
> Hi Xuan,
>
> > From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of Xuan Zhuo
>
> > conformance.tex | 26 +++
> > content.tex | 1 +
> > virtio-ism.tex | 573
>
> Can
Hi Xuan,
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Xuan Zhuo
> conformance.tex | 26 +++
> content.tex | 1 +
> virtio-ism.tex | 573
Can you please rebase your patches?
Devices are placed under their own
在 2023/2/8 下午11:04, Parav Pandit 写道:
From: Michael S. Tsirkin
Sent: Wednesday, February 8, 2023 9:48 AM
On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote:
From: Michael S. Tsirkin
Sent: Wednesday, February 8, 2023 9:43 AM
On Wed, Feb 08, 2023 at 02:37:55PM +, Parav
在 2023/2/9 上午4:52, Michael S. Tsirkin 写道:
On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote:
> > From: Michael S. Tsirkin
Sent: Wednesday, February 8, 2023 9:48 AM
On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote:
From: Michael S. Tsirkin
Sent: Wednesday,
在 2023/2/9 上午6:35, Alvaro Karsz 写道:
From: Alvaro Karsz
Sent: Wednesday, February 8, 2023 4:56 PM
Alvaro,
Do you know if any software used it? Can you get some real data?
I implemented this feature in our DPU, so at least 1 vendor is using this
feature
But which software (virtio net
在 2023/2/9 上午1:53, Alvaro Karsz 写道:
> > From: Michael S. Tsirkin
Sent: Wednesday, February 8, 2023 9:48 AM
On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote:
From: Michael S. Tsirkin
Sent: Wednesday, February 8, 2023 9:43 AM
On Wed, Feb 08, 2023 at 02:37:55PM +, Parav
Currently some fields of the virtio_net_config structure are defined
before introducing the structure and some are defined after
introducing virtio_net_config.
Better to define the configuration layout first followed by
description of all the fields.
Device configuration fields are described in
The control VQ of the virtio network device is used beyond advance
steering control. The control VQ dynamically changes multiple features
of the initialized device.
Hence, update this area of control VQ introductory description at few
places and also place the link to its description.
Also
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 4:46 AM
[..]
> > > General question: Is it better to talk about "the receive virtqueue"
> > > (to keep it simple), or "a receive virtqueue" (as there may be several)?
> >
> > For sure Michael can better answer this than me. :) The
> From: Alvaro Karsz
> Sent: Wednesday, February 8, 2023 5:36 PM
>
> > > From: Alvaro Karsz
> > > Sent: Wednesday, February 8, 2023 4:56 PM
> >
> > > > Alvaro,
> > > > Do you know if any software used it? Can you get some real data?
> > >
> > > I implemented this feature in our DPU, so at
On Thu, Feb 09, 2023 at 12:35:42AM +0200, Alvaro Karsz wrote:
> > > From: Alvaro Karsz
> > > Sent: Wednesday, February 8, 2023 4:56 PM
> >
> > > > Alvaro,
> > > > Do you know if any software used it? Can you get some real data?
> > >
> > > I implemented this feature in our DPU, so at least 1
On Thu, Feb 09, 2023 at 12:45:42AM +0200, Alvaro Karsz wrote:
> Maybe we should do something more future friendly.
> We may want to add more coalescing related features in the future.
> * Maybe max/min sets?
> * Maybe to offload the adaptive algo to the DPU?
>
> It will require more feature
Maybe we should do something more future friendly.
We may want to add more coalescing related features in the future.
* Maybe max/min sets?
* Maybe to offload the adaptive algo to the DPU?
It will require more feature bits..
We could rename this new feature from VIRTIO_NET_F_PERQUEUE_NOTF_COAL
> > From: Alvaro Karsz
> > Sent: Wednesday, February 8, 2023 4:56 PM
>
> > > Alvaro,
> > > Do you know if any software used it? Can you get some real data?
> >
> > I implemented this feature in our DPU, so at least 1 vendor is using this
> > feature
>
> But which software (virtio net driver) in
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 5:29 PM
>
> On Wed, Feb 08, 2023 at 10:23:00PM +, Parav Pandit wrote:
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, February 8, 2023 5:16 PM
> > > > > Not having this feature/command even complicates things now that
>
On Wed, Feb 08, 2023 at 10:23:00PM +, Parav Pandit wrote:
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 5:16 PM
> > > > Not having this feature/command even complicates things now that we
> > > > are talking about removing the RX and TX from the per vq command,
> > > >
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 5:16 PM
> > > Not having this feature/command even complicates things now that we
> > > are talking about removing the RX and TX from the per vq command,
> > > how do you change parameters to all TX queues? to all RX queues?
> > >
On Wed, Feb 08, 2023 at 10:08:41PM +, Parav Pandit wrote:
>
> > From: Alvaro Karsz
> > Sent: Wednesday, February 8, 2023 4:56 PM
>
> > > Alvaro,
> > > Do you know if any software used it? Can you get some real data?
> >
> > I implemented this feature in our DPU, so at least 1 vendor is
On Wed, Feb 08, 2023 at 09:05:47PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 3:52 PM
> >
> > On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote:
> > > > > From: Michael S. Tsirkin
> > > > > Sent: Wednesday, February 8, 2023 9:48
> From: Alvaro Karsz
> Sent: Wednesday, February 8, 2023 4:56 PM
> > Alvaro,
> > Do you know if any software used it? Can you get some real data?
>
> I implemented this feature in our DPU, so at least 1 vendor is using this
> feature
But which software (virtio net driver) in which OS is
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 3:52 PM
> >
> > On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote:
> > > > > From: Michael S. Tsirkin
> > > > > Sent: Wednesday, February 8, 2023 9:48 AM
> > > > >
> > > > > On Wed, Feb 08, 2023 at 02:44:37PM +,
> On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote:
> > > > From: Michael S. Tsirkin
> > > > Sent: Wednesday, February 8, 2023 9:48 AM
> > > >
> > > > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote:
> > > > >
> > > > > > From: Michael S. Tsirkin
> > > > > > Sent:
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 3:52 PM
>
> On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote:
> > > > From: Michael S. Tsirkin
> > > > Sent: Wednesday, February 8, 2023 9:48 AM
> > > >
> > > > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit
On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote:
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, February 8, 2023 9:48 AM
> > >
> > > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote:
> > > >
> > > > > From: Michael S. Tsirkin
> > > > > Sent: Wednesday, February
On Wed, Feb 08, 2023 at 07:23:12PM +, Parav Pandit wrote:
> You are right. Two commands are there.
> Regardless the ambiguity remains
> ━━━
> From: Parav Pandit
> Sent: Wednesday, February 8, 2023 8:57 PM
> To: Michael
You are right. Two commands are there.
Regardless the ambiguity remains
From: Parav Pandit
Sent: Wednesday, February 8, 2023 8:57 PM
To: Michael S. Tsirkin
Cc: Heng Qi ; Xuan Zhuo ;
virtio-comment @ lists . oasis-open . org
; virtio-dev @ lists . oasis-open .
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 12:39 PM
> >
> > On Wed, Feb 08, 2023 at 05:30:28PM +, Parav Pandit wrote:
> > > > From: Michael S. Tsirkin
> > > > Sent: Tuesday, February 7, 2023 9:18 AM
> > >
> > > > > Why migration generate too many spurious interrupts?
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 9:48 AM
> >
> > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote:
> > >
> > > > From: Michael S. Tsirkin
> > > > Sent: Wednesday, February 8, 2023 9:43 AM
> > > >
> > > > On Wed, Feb 08, 2023 at 02:37:55PM +,
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 12:39 PM
>
> On Wed, Feb 08, 2023 at 05:30:28PM +, Parav Pandit wrote:
> > > From: Michael S. Tsirkin
> > > Sent: Tuesday, February 7, 2023 9:18 AM
> >
> > > > Why migration generate too many spurious interrupts?
> > >
> > >
On Wed, Feb 08, 2023 at 05:30:28PM +, Parav Pandit wrote:
> > From: Michael S. Tsirkin
> > Sent: Tuesday, February 7, 2023 9:18 AM
>
> > > Why migration generate too many spurious interrupts?
> >
> > Because, you might want to migrate from hardware with to hardware without
> > coalescing
> From: Michael S. Tsirkin
> Sent: Tuesday, February 7, 2023 9:18 AM
> > Why migration generate too many spurious interrupts?
>
> Because, you might want to migrate from hardware with to hardware without
> coalescing features. So you just tell guest "sure I will coalesce" but in
> fact send
>
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 10:20 AM
[..]
> >
> > Most performant data path wouldn't implement and read the extra mode.
> > It is always fw that is going to program same value, or per queue valued or
> disable value in each Q regardless whichever way we
On Wed, Feb 08, 2023 at 03:04:03PM +, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 9:48 AM
> >
> > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote:
> > >
> > > > From: Michael S. Tsirkin
> > > > Sent: Wednesday, February 8, 2023
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 9:48 AM
>
> On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, February 8, 2023 9:43 AM
> > >
> > > On Wed, Feb 08, 2023 at 02:37:55PM +, Parav Pandit
On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 9:43 AM
> >
> > On Wed, Feb 08, 2023 at 02:37:55PM +, Parav Pandit wrote:
> > >
> > > > From: Michael S. Tsirkin
> > > > Sent: Wednesday, February 8, 2023 9:18
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 9:43 AM
>
> On Wed, Feb 08, 2023 at 02:37:55PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, February 8, 2023 9:18 AM
> > >
> > > On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote:
> >
On Wed, Feb 08, 2023 at 02:37:55PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 9:18 AM
> >
> > On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote:
> > > > I see two options.
> > > > 1. Just have per VQ params. Software has the full
On Wed, Feb 08, 2023 at 02:37:55PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 9:18 AM
> >
> > On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote:
> > > > I see two options.
> > > > 1. Just have per VQ params. Software has the full
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 9:18 AM
>
> On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote:
> > > I see two options.
> > > 1. Just have per VQ params. Software has the full knowledge of in which
> > > it is
> operating, and state remains at software
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 9:09 AM
> > > header: it allow users inside the tunnel control queueing outside.
> > > By observing packet loss some information leaks between tunnels.
> > >
> > I likely didn't understand. Can you please explain?
> >
> > Queuing is
Hi Sameer,
On 08.02.2023 14:51, Sameer Pujar wrote:
Thanks Anton for your response.
On 08-02-2023 18:46, Anton Yakovlev wrote:
Hi Sameer,
We were waiting for the extension for audio controls to be accepted into the
VIRTIO specification.
Is audio control extension proposal to VIRTIO sound
On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote:
> > I see two options.
> > 1. Just have per VQ params. Software has the full knowledge of in which it
> > is operating, and state remains at software level.
> > This effectively achieves both the mode.
> >
> > 2. Have a mode cmd,
> > Mode
On Wed, Feb 08, 2023 at 02:05:52PM +, Parav Pandit wrote:
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 8:52 AM
> >
> > On Wed, Feb 08, 2023 at 01:38:36PM +, Parav Pandit wrote:
> > >
> > > > From: Michael S. Tsirkin
> > > > Sent: Wednesday, February 8, 2023 8:32 AM
On Wed, Feb 08, 2023 at 02:00:14PM +, Parav Pandit wrote:
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 8:52 AM
> >
> > On Wed, Feb 08, 2023 at 01:38:36PM +, Parav Pandit wrote:
> > >
> > > > From: Michael S. Tsirkin
> > > > Sent: Wednesday, February 8, 2023 8:32 AM
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 8:52 AM
>
> On Wed, Feb 08, 2023 at 01:38:36PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, February 8, 2023 8:32 AM
> > >
> > > On Wed, Feb 08, 2023 at 05:18:32AM +, Parav Pandit wrote:
>
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 8:52 AM
>
> On Wed, Feb 08, 2023 at 01:38:36PM +, Parav Pandit wrote:
> >
> > > From: Michael S. Tsirkin
> > > Sent: Wednesday, February 8, 2023 8:32 AM
> > >
> > > On Wed, Feb 08, 2023 at 05:18:32AM +, Parav Pandit wrote:
>
On Wed, Feb 08, 2023 at 07:21:45PM +0530, Sameer Pujar wrote:
> Thanks Anton for your response.
>
>
> On 08-02-2023 18:46, Anton Yakovlev wrote:
> > Hi Sameer,
> >
> > We were waiting for the extension for audio controls to be accepted into
> > the
> > VIRTIO specification.
>
> Is audio
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 5:07 AM
> >
> > 2. Have a mode cmd,
> > Mode = (a) per device or (b) per VQ (c) disable After the mode is set,
> > driver can set per device or per VQ.
>
> I like 2 better. I also think a and b are enough. c can be achieved
On Wed, Feb 08, 2023 at 01:38:36PM +, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin
> > Sent: Wednesday, February 8, 2023 8:32 AM
> >
> > On Wed, Feb 08, 2023 at 05:18:32AM +, Parav Pandit wrote:
> > > > From: Heng Qi
> > > > Sent: Tuesday, February 7, 2023 10:25 PM
> > >
> > >
Thanks Anton for your response.
On 08-02-2023 18:46, Anton Yakovlev wrote:
Hi Sameer,
We were waiting for the extension for audio controls to be accepted
into the
VIRTIO specification.
Is audio control extension proposal to VIRTIO sound specification accepted?
We recently resumed our
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 4:56 AM
>
> On Wed, Feb 08, 2023 at 10:20:08AM +0800, Heng Qi wrote:
> >
> >
> > 在 2023/2/7 下午10:29, Michael S. Tsirkin 写道:
> > > On Tue, Feb 07, 2023 at 12:51:26PM +, Parav Pandit wrote:
> > > > > From: Xuan Zhuo
> > > > >
On Wed, Feb 08, 2023 at 07:23:10PM +0800, Heng Qi wrote:
>
>
> 在 2023/2/8 下午6:04, Michael S. Tsirkin 写道:
> > On Wed, Feb 08, 2023 at 09:57:54AM +0800, Heng Qi wrote:
> > >
> > > 在 2023/2/7 下午10:06, Michael S. Tsirkin 写道:
> > > > On Tue, Feb 07, 2023 at 07:16:34PM +0800, Heng Qi wrote:
> > > > >
> From: Michael S. Tsirkin
> Sent: Wednesday, February 8, 2023 8:32 AM
>
> On Wed, Feb 08, 2023 at 05:18:32AM +, Parav Pandit wrote:
> > > From: Heng Qi
> > > Sent: Tuesday, February 7, 2023 10:25 PM
> >
> > [..]
> > > >>
> > > >> Do you think we need both hash_types and
On Wed, Feb 08, 2023 at 05:18:32AM +, Parav Pandit wrote:
> > From: Heng Qi
> > Sent: Tuesday, February 7, 2023 10:25 PM
>
> [..]
> > >>
> > >> Do you think we need both hash_types and hash_tunnel_types?
> > > In struct virtio_net_config we need two fields.
> > > a. supported_hash_types
Hi Sameer,
We were waiting for the extension for audio controls to be accepted into the
VIRTIO specification. We recently resumed our upstreaming efforts and a
colleague of mine should resubmit the patch soon.
On 07.02.2023 08:37, Sameer Pujar wrote:
Hi Anton,
Of late I have been looking
> From: Heng Qi
> Sent: Wednesday, February 8, 2023 1:11 AM
>
>
> 在 2023/2/8 下午1:18, Parav Pandit 写道:
> >> From: Heng Qi
> >> Sent: Tuesday, February 7, 2023 10:25 PM
> > [..]
> Do you think we need both hash_types and hash_tunnel_types?
> >>> In struct virtio_net_config we need two
在 2023/2/8 下午6:10, Michael S. Tsirkin 写道:
On Wed, Feb 08, 2023 at 09:57:54AM +0800, Heng Qi wrote:
I think it's a good idea to do this on top of Alvaro's patch
unifying these two structures.
I saw Alvaro's patch, but it doesn't seem to be stable yet, is there a good
way for me to
unify the
Do you want a new version?
This one seems fine to me.
-
To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org
Seems that we still have some disagreements here.
Should I remove the "best effort" note? I actually think that this is
a good note, but I'll remove it if you think that I should.
Should I replace TX and RX with receive virtqueue and transmit
virtqueue? This may be related to Heng's patch, so
On Wed, Feb 08, 2023 at 09:57:54AM +0800, Heng Qi wrote:
> > I think it's a good idea to do this on top of Alvaro's patch
> > unifying these two structures.
>
> I saw Alvaro's patch, but it doesn't seem to be stable yet, is there a good
> way for me to
> unify the two structures, since a patch
On Wed, Feb 08, 2023 at 02:43:02AM +, Parav Pandit wrote:
>
> > From: Xuan Zhuo
> > Sent: Tuesday, February 7, 2023 9:25 PM
> >
> > On Wed, 8 Feb 2023 02:20:27 +, Parav Pandit wrote:
> > >
> > > > From: Xuan Zhuo
> > > > Sent: Tuesday, February 7, 2023 8:46 PM
> > > >
> > > > On Tue,
On Wed, Feb 08, 2023 at 09:57:54AM +0800, Heng Qi wrote:
>
>
> 在 2023/2/7 下午10:06, Michael S. Tsirkin 写道:
> > On Tue, Feb 07, 2023 at 07:16:34PM +0800, Heng Qi wrote:
> > > Currently, the coalescing profile is directly applied to all queues.
> > > This patch supports configuring the parameters
On Wed, Feb 08, 2023 at 10:20:08AM +0800, Heng Qi wrote:
>
>
> 在 2023/2/7 下午10:29, Michael S. Tsirkin 写道:
> > On Tue, Feb 07, 2023 at 12:51:26PM +, Parav Pandit wrote:
> > > > From: Xuan Zhuo
> > > > Sent: Tuesday, February 7, 2023 6:50 AM
> > > >
> > > > On Tue, 7 Feb 2023 13:25:13 +0200,
On Wed, Feb 08, 2023 at 01:17:55AM +, Parav Pandit wrote:
>
>
> > From: Cornelia Huck
> > Sent: Tuesday, February 7, 2023 5:07 AM
> >
> > On Thu, Feb 02 2023, Parav Pandit wrote:
> >
> > > The control VQ of the virtio network device is used beyond advance
> > > steering control. The
67 matches
Mail list logo
