> From: virtio-dev@lists.oasis-open.org On
> Behalf Of Cornelia Huck
>
> On Thu, Feb 16 2023, Parav Pandit wrote:
>
> >> From: Cornelia Huck
> >> Sent: Thursday, February 16, 2023 11:03 AM
> >>
> >> On Thu, Feb 16 2023, "Michael S. Tsirkin" wrote:
> >>
> >> > On Thu, Feb 16, 2023 at 02:30:0
> From: Alvaro Karsz
> Sent: Thursday, February 16, 2023 9:56 AM
[..]
> +When the device has \field{max_usecs} = 0 or \field{max_packets} = 0, the
> notification conditions are met after every packet received/sent.
> +
> +\subparagraph{RX Example}\label{sec:Device Types / Network Device /
> +D
> From: Heng Qi
> Sent: Thursday, February 16, 2023 9:43 AM
[..]
> #define VIRTIO_NET_CTRL_NOTF_COAL 6
> - #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET 0
> + #define VIRTIO_NET_CTRL_NOTF_COAL_TX_SET 0
Unrelated change. Please remove this hunk.
> #define VIRTIO_NET_CTRL_NOTF_COAL_RX_SET 1
> + #
Place MMIO transport specification in its own file to better maintain it.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/157
Signed-off-by: Parav Pandit
---
content.tex| 554 +
transport-mmio.tex | 552 ++
Now that we have individual files, fix reported spelling errors.
While at it, remove extra white space at end of line.
Signed-off-by: Parav Pandit
---
changelog:
v0->v1:
- removed many trailing white spaces
---
transport-mmio.tex | 90 +++---
1 file chang
Place Channel IO transport specification in its own file to
better maintain it.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/157
Signed-off-by: Parav Pandit
---
content.tex | 603 +---
transport-channelio.tex | 601 +++
Place PCI transport specification in its own file to better maintain it.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/157
Signed-off-by: Parav Pandit
---
content.tex | 1161 +
transport-pci.tex | 1160 +++
Now that we have individual files, fix reported spelling errors.
Signed-off-by: Parav Pandit
---
transport-channelio.tex | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/transport-channelio.tex b/transport-channelio.tex
index 93401a4..e25a7c1 100644
--- a/transport-channel
Now that we have individual files, fix reported spelling errors.
While at it, remove trailing white spaces.
Signed-off-by: Parav Pandit
---
changelog:
v0->v1:
- removed many trailing white spaces
---
transport-pci.tex | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --gi
Problem statement:
Currently several tens of pages worth of transport specification
is situated in single file. Many parts of the specification
are already maintained in separate files.
Such separate files enables better maintenance of the specification overall.
Solution:
Follow the approach simi
> From: Parav Pandit
> Sent: Wednesday, February 8, 2023 11:52 PM
>
> Currently some fields of the virtio_net_config structure are defined before
> introducing the structure and some are defined after introducing
> virtio_net_config.
> Better to define the configuration layout first followed b
On Thu, Feb 16, 2023 at 09:13:12PM +, Parav Pandit wrote:
>
> > From: Cornelia Huck
> > Sent: Thursday, February 16, 2023 3:01 AM
> >
> > On Thu, Feb 16 2023, Parav Pandit wrote:
> >
> > > Cited commit in fixes tag missed to update the reference to drivers
> > > notifications section in pa
> From: Cornelia Huck
> Sent: Thursday, February 16, 2023 3:01 AM
>
> On Thu, Feb 16 2023, Parav Pandit wrote:
>
> > Cited commit in fixes tag missed to update the reference to drivers
> > notifications section in past change log.
> > Fix the reference.
> >
> > Fixes: be2ce1ee17e0 ("content.t
On Thu, Feb 16 2023, Parav Pandit wrote:
>> From: Cornelia Huck
>> Sent: Thursday, February 16, 2023 11:03 AM
>>
>> On Thu, Feb 16 2023, "Michael S. Tsirkin" wrote:
>>
>> > On Thu, Feb 16, 2023 at 02:30:03PM +, Parav Pandit wrote:
>> >>
>> >> > From: Cornelia Huck
>> >> > Sent: Thursday,
On Thu, Feb 16, 2023 at 10:43:01PM +0800, Heng Qi wrote:
> Currently coalescing parameters are grouped for all transmit and receive
> virtqueues. This patch supports setting or getting the parameters for a
> specified virtqueue, and a typical application of this function is netdim[1].
>
> When the
On Thu, Feb 16, 2023 at 10:49:25PM +0800, Heng Qi wrote:
>
>
> 在 2023/2/16 下午10:43, Heng Qi 写道:
> > Currently coalescing parameters are grouped for all transmit and receive
> > virtqueues. This patch supports setting or getting the parameters for a
> > specified virtqueue, and a typical applicati
> From: Cornelia Huck
> Sent: Thursday, February 16, 2023 11:03 AM
>
> On Thu, Feb 16 2023, "Michael S. Tsirkin" wrote:
>
> > On Thu, Feb 16, 2023 at 02:30:03PM +, Parav Pandit wrote:
> >>
> >> > From: Cornelia Huck
> >> > Sent: Thursday, February 16, 2023 9:10 AM
> >> >
> >> > On Tue, F
On Thu, Feb 16 2023, "Michael S. Tsirkin" wrote:
> On Thu, Feb 16, 2023 at 02:30:03PM +, Parav Pandit wrote:
>>
>> > From: Cornelia Huck
>> > Sent: Thursday, February 16, 2023 9:10 AM
>> >
>> > On Tue, Feb 14 2023, Parav Pandit wrote:
>> >
>> > > The control VQ of the virtio network devi
> From: Parav Pandit
> Sent: Thursday, February 16, 2023 11:01 AM
> > The bylaws are here:
> > https://github.com/oasis-tcs/virtio-spec/blob/master/README.md
> > Minor cleanups, including editorial formatting changes, spelling and
> > typo fixes can be committed directly into git for approval as
> From: Michael S. Tsirkin
> Sent: Thursday, February 16, 2023 10:50 AM
>
> On Thu, Feb 16, 2023 at 02:30:03PM +, Parav Pandit wrote:
> >
> > > From: Cornelia Huck
> > > Sent: Thursday, February 16, 2023 9:10 AM
> > >
> > > On Tue, Feb 14 2023, Parav Pandit wrote:
> > >
> > > > The contro
On Thu, Feb 16, 2023 at 02:30:03PM +, Parav Pandit wrote:
>
> > From: Cornelia Huck
> > Sent: Thursday, February 16, 2023 9:10 AM
> >
> > On Tue, Feb 14 2023, Parav Pandit wrote:
> >
> > > The control VQ of the virtio network device is used beyond advance
> > > steering control. The contro
> From: Heng Qi
> Sent: Thursday, February 16, 2023 9:49 AM
> Hi Michael.
>
> I know you suggested in v2 that I split the virtqueue SET and GET commands in
> series, but I have a bit of a problem trying to split because there are some
> statements where SET and GET are glued together.
> Plea
This patch makes several improvements to the notification coalescing
feature, including:
- Consolidating virtio_net_ctrl_coal_tx and virtio_net_ctrl_coal_rx
into a single struct, virtio_net_ctrl_coal, as they are identical.
- Emphasizing that the coalescing commands are best-effort.
- Defining t
> From: Cornelia Huck
> Sent: Thursday, February 16, 2023 9:10 AM
>
> On Tue, Feb 14 2023, Parav Pandit wrote:
>
> > The control VQ of the virtio network device is used beyond advance
> > steering control. The control VQ dynamically changes multiple features
> > of the initialized device.
> >
> From: Heng Qi
> Sent: Thursday, February 16, 2023 9:19 AM
> >> I'm really okay with this, the tunnel type seems to help the software
> >> driver do more things in the future, for example, the driver may not
> >> want to use the outer hash value when forwarding packets. But if
> >> there is rea
On Fri, Feb 03 2023, Parav Pandit wrote:
> Now that we have individual files, fix reported spelling errors.
>
> While at it, remove extra white space at end of line.
>
> Signed-off-by: Parav Pandit
> ---
> transport-mmio.tex | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
On Tue, Feb 14 2023, Parav Pandit wrote:
> The control VQ of the virtio network device is used beyond advance
> steering control. The control VQ dynamically changes multiple features
> of the initialized device.
>
> Hence, update this area of control VQ introductory description at few
> places an
> From: Heng Qi
> Sent: Thursday, February 16, 2023 1:58 AM
>
> I'm really okay with this, the tunnel type seems to help the software driver
> do
> more things in the future, for example, the driver may not want to use the
> outer hash value when forwarding packets. But if there is really no p
On Thu, Feb 16, 2023 at 03:20:17PM +0800, Heng Qi wrote:
>
>
> 在 2023/2/14 上午6:20, Michael S. Tsirkin 写道:
> > On Wed, Feb 08, 2023 at 05:08:36PM +0800, Heng Qi wrote:
> > > If the tunnel is used to encapsulate the packets, the hash calculated
> > > using the outer header of the receive packets is
> > Actually, no.
> > \field{usecs} refers to the field in the struct.
> > usecs refers to the units of measurement.
> >
> > So if for example \field{usecs} = 40, then it evaluates to 40 usecs ->
> > "are met when 40 usecs elapses".
>
> But this is not how it reads, people are not computers, and in
On Thu, Feb 16, 2023 at 10:40:10AM +0200, Alvaro Karsz wrote:
> Hi Heng,
>
> > > +When the device has non-zero \field{usecs} and non-zero
> > > \field{max_packets}, it starts counting usecs and packets upon
> > > receiving/sending a packet.
> > > +The device counts packets and usecs for each rec
Hi Heng,
> > +When the device has non-zero \field{usecs} and non-zero
> > \field{max_packets}, it starts counting usecs and packets upon
> > receiving/sending a packet.
> > +The device counts packets and usecs for each receive virtqueue and
> > transmit virtqueue separately.
> > +In this case,
在 2023/2/16 下午3:32, Alvaro Karsz 写道:
This patch makes several improvements to the notification coalescing
feature, including:
- Consolidating virtio_net_ctrl_coal_tx and virtio_net_ctrl_coal_rx
into a single struct, virtio_net_ctrl_coal, as they are identical.
- Emphasizing that the coales
On Thu, Feb 16 2023, Parav Pandit wrote:
> Cited commit in fixes tag missed to update the reference to drivers
> notifications section in past change log.
> Fix the reference.
>
> Fixes: be2ce1ee17e0 ("content.tex Fix Driver notifications label")
> Signed-off-by: Parav Pandit
> ---
> cl-os.tex
34 matches
Mail list logo
