Re: [virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation

2023-02-27 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 10:41:18AM +0800, Heng Qi wrote: > > The problem is the global qualifier. And it's not even global - > > there are two sets for rx and for tx and does not apply to cvq at all. > > How about "RX/TX coalescing parameters"? > > As Parav suggested, we probably don't need to

[virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation

2023-02-27 Thread Michael S. Tsirkin
On Tue, Feb 28, 2023 at 01:40:29AM +, Parav Pandit wrote: > > > From: Heng Qi > > Sent: Sunday, February 26, 2023 4:37 AM > > > +# Read/Write attributes for coalescing parameters \begin{itemize} \item > Hash # above is not needed. Please remove. > > > +For commands

[virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-02-27 Thread Jason Wang
On Tue, Feb 28, 2023 at 1:49 AM Michael S. Tsirkin wrote: > > On Mon, Feb 27, 2023 at 04:35:09PM +0800, Jason Wang wrote: > > On Mon, Feb 27, 2023 at 3:39 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Feb 27, 2023 at 12:07:17PM +0800, Jason Wang wrote: > > > > Btw, this kind of 1:1 hash

Re: [virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation

2023-02-27 Thread Heng Qi
在 2023/2/28 上午4:19, Michael S. Tsirkin 写道: On Mon, Feb 27, 2023 at 08:45:43PM +0200, Alvaro Karsz wrote: -If the VIRTIO_NET_F_NOTF_COAL feature is negotiated, the driver can -send control commands for dynamically changing the coalescing parameters. +If the VIRTIO_NET_F_NOTF_COAL feature is

[virtio-dev] RE: [PATCH v9] virtio-net: support the virtqueue coalescing moderation

2023-02-27 Thread Parav Pandit
> From: Heng Qi > Sent: Sunday, February 26, 2023 4:37 AM > +# Read/Write attributes for coalescing parameters \begin{itemize} \item Hash # above is not needed. Please remove. > +For commands VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and > VIRTIO_NET_CTRL_NOTF_COAL_RX_SET, \field{max_usecs} > +

Re: [virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation

2023-02-27 Thread Alvaro Karsz
> > I see your point, but a reader will see the "global notifications > > coalescing parameter" concept, and won't know what it is until next > > paragraph. > > Maybe we can have a new list with the notification coalescing concepts > > (like the notification coalescing parameters)? Just throwing

Re: [virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation

2023-02-27 Thread Michael S. Tsirkin
On Mon, Feb 27, 2023 at 08:45:43PM +0200, Alvaro Karsz wrote: > > >> -If the VIRTIO_NET_F_NOTF_COAL feature is negotiated, the driver can > > >> -send control commands for dynamically changing the coalescing > > >> parameters. > > >> +If the VIRTIO_NET_F_NOTF_COAL feature is negotiated, the

Re: [virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation

2023-02-27 Thread Alvaro Karsz
> >> -If the VIRTIO_NET_F_NOTF_COAL feature is negotiated, the driver can > >> -send control commands for dynamically changing the coalescing parameters. > >> +If the VIRTIO_NET_F_NOTF_COAL feature is negotiated, the driver can send > >> the VIRTIO_NET_CTRL_NOTF_COAL_TX_SET > >> +and

[virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-02-27 Thread Michael S. Tsirkin
On Mon, Feb 27, 2023 at 04:35:09PM +0800, Jason Wang wrote: > On Mon, Feb 27, 2023 at 3:39 PM Michael S. Tsirkin wrote: > > > > On Mon, Feb 27, 2023 at 12:07:17PM +0800, Jason Wang wrote: > > > Btw, this kind of 1:1 hash features seems not scalable and flexible. > > > It requires an endless

[virtio-dev] Re: [PATCH 0/3] Rename queue index to queue number

2023-02-27 Thread Michael S. Tsirkin
On Thu, Feb 23, 2023 at 07:46:21AM +0200, Parav Pandit wrote: > 1. Currently, virtqueue is identified between driver and device > interchangeably using either number of index terminology. > > 2. Between PCI and MMIO transport the queue size (depth) is > defined as queue_size and QueueNum

[virtio-dev] Re: [PATCH 2/3] transport-mmio: Rename QueueNum register

2023-02-27 Thread Michael S. Tsirkin
On Thu, Feb 23, 2023 at 07:46:23AM +0200, Parav Pandit wrote: > Currently, the specification uses virtqueue index and number > interchangeably to refer to the virtqueue. > > It is better to identify it using one terminology. > > Two registers QueueNumMax and QueueNum actually reflect the queue

[virtio-dev] Re: [PATCH 0/3] Rename queue index to queue number

2023-02-27 Thread Michael S. Tsirkin
On Mon, Feb 27, 2023 at 04:00:24PM +, Parav Pandit wrote: > > > From: Cornelia Huck > > Sent: Monday, February 27, 2023 3:46 AM > > > > On Thu, Feb 23 2023, Parav Pandit wrote: > > > > > 1. Currently, virtqueue is identified between driver and device > > > interchangeably using either

[virtio-dev] RE: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support the virtqueue coalescing moderation

2023-02-27 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Heng Qi > >>>   \subsubsection{Legacy Interface: Framing > >>> Requirements}\label{sec:Device > >>>   Types / Network Device / Legacy Interface: Framing Requirements} > >>> -- > >> Let's wait for more comments before the next

[virtio-dev] RE: [PATCH 0/3] Rename queue index to queue number

2023-02-27 Thread Parav Pandit
> From: Cornelia Huck > Sent: Monday, February 27, 2023 3:46 AM > > On Thu, Feb 23 2023, Parav Pandit wrote: > > > 1. Currently, virtqueue is identified between driver and device > > interchangeably using either number of index terminology. > > > > 2. Between PCI and MMIO transport the queue

[virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-02-27 Thread Heng Qi
在 2023/2/27 下午4:35, Jason Wang 写道: On Mon, Feb 27, 2023 at 3:39 PM Michael S. Tsirkin wrote: On Mon, Feb 27, 2023 at 12:07:17PM +0800, Jason Wang wrote: Btw, this kind of 1:1 hash features seems not scalable and flexible. It requires an endless extension on bits/fields. Modern NICs allow

[virtio-dev] Re: [PATCH 0/3] Cleanup for PCI transitional common cfg

2023-02-27 Thread Cornelia Huck
On Sat, Feb 25 2023, "Michael S. Tsirkin" wrote: > On Sun, Feb 26, 2023 at 12:29:58AM +0200, Parav Pandit wrote: >> Legacy interface PCI Device layout description has following issues. >> >> 1. repeated 'structure' word >> 2. virtio header was defined the 0.9.5 spec. It is referred with >>

[virtio-dev] Re: [PATCH 0/3] Rename queue index to queue number

2023-02-27 Thread Cornelia Huck
On Thu, Feb 23 2023, Parav Pandit wrote: > 1. Currently, virtqueue is identified between driver and device > interchangeably using either number of index terminology. > > 2. Between PCI and MMIO transport the queue size (depth) is > defined as queue_size and QueueNum respectively. > > To avoid

[virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-02-27 Thread Jason Wang
On Mon, Feb 27, 2023 at 3:39 PM Michael S. Tsirkin wrote: > > On Mon, Feb 27, 2023 at 12:07:17PM +0800, Jason Wang wrote: > > Btw, this kind of 1:1 hash features seems not scalable and flexible. > > It requires an endless extension on bits/fields. Modern NICs allow the > > user to customize the

[virtio-dev] [PATCH] virtio-spi: add the device specification

2023-02-27 Thread Haixu Cui
virtio-spi is a virtual SPI master and it allows a guset to operate and use the physical SPI master controlled by the host. Signed-off-by: Haixu Cui --- content.tex | 2 + device-types/spi/description.tex| 153