[virtio-dev] Re: [virtio-comment] Re: [PATCH v10] virtio-net: support inner header hash

2023-03-15 Thread Parav Pandit
On 3/15/2023 8:10 AM, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 11:23:55PM -0400, Parav Pandit wrote: If not, for now it may be better to skip vxlan and nvegre as they inherently have unique outer header UDP src port based on the inner header. So what's left, GRE? GRE is actually di

[virtio-dev] Re: [PATCH v10] virtio-net: support inner header hash

2023-03-15 Thread Parav Pandit
On 3/15/2023 9:19 AM, Heng Qi wrote: 在 2023/3/15 上午11:23, Parav Pandit 写道: On 3/6/2023 10:48 AM, Heng Qi wrote: [..]   \item[VIRTIO_NET_F_RSS] Requires VIRTIO_NET_F_CTRL_VQ. +\item[VIRTIO_NET_F_HASH_TUNNEL] Requires VIRTIO_NET_F_CTRL_VQ. I think this should also say that HASH_TUNNEL re

[virtio-dev] Re: [virtio-comment] [PATCH 1/1] RFC: virtio-bt: add virtio BT device specification

2023-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2023 at 05:20:09PM +0100, Cornelia Huck wrote: > On Wed, Mar 15 2023, "Michael S. Tsirkin" wrote: > > > On Wed, Mar 15, 2023 at 04:55:59PM +0100, Cornelia Huck wrote: > >> On Fri, Mar 10 2023, Igor Skalkin wrote: > >> > +\subsection{Feature bits}\label{sec:Device Types / BT Devic

[virtio-dev] Re: [virtio-comment] [PATCH 1/1] RFC: virtio-bt: add virtio BT device specification

2023-03-15 Thread Cornelia Huck
On Wed, Mar 15 2023, "Michael S. Tsirkin" wrote: > On Wed, Mar 15, 2023 at 04:55:59PM +0100, Cornelia Huck wrote: >> On Fri, Mar 10 2023, Igor Skalkin wrote: >> > +\subsection{Feature bits}\label{sec:Device Types / BT Device / Feature >> > bits} >> > + >> > +\begin{description} >> > +\item[VIRT

[virtio-dev] Re: [virtio-comment] [PATCH 1/1] RFC: virtio-bt: add virtio BT device specification

2023-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2023 at 04:55:59PM +0100, Cornelia Huck wrote: > On Fri, Mar 10 2023, Igor Skalkin wrote: > > > This PR is aimed as review for comments(RFC) purpose. > > > > * Initial draft version. > > > > Signed-off-by: Igor Skalkin > > --- > > conformance.tex| 12 ++-

[virtio-dev] Re: [virtio-comment] [PATCH 1/1] RFC: virtio-bt: add virtio BT device specification

2023-03-15 Thread Cornelia Huck
On Fri, Mar 10 2023, Igor Skalkin wrote: > This PR is aimed as review for comments(RFC) purpose. > > * Initial draft version. > > Signed-off-by: Igor Skalkin > --- > conformance.tex| 12 ++- > content.tex| 1 + > device-types/bt/description

[virtio-dev] Re: [PATCH V3 0/2] qemu: vhost-user: Support Xen memory mapping quirks

2023-03-15 Thread Stefan Hajnoczi
On Thu, Mar 09, 2023 at 02:20:59PM +0530, Viresh Kumar wrote: > Hello, > > This patchset tries to update the vhost-user protocol to make it support > special > memory mapping required in case of Xen hypervisor. > > The first patch is mostly cleanup and second one introduces a new xen specific >

[virtio-dev] Re: [PATCH V3 2/2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-15 Thread Stefan Hajnoczi
On Thu, Mar 09, 2023 at 02:21:01PM +0530, Viresh Kumar wrote: > The current model of memory mapping at the back-end works fine where a > standard call to mmap() (for the respective file descriptor) is enough > before the front-end can start accessing the guest memory. > > There are other complex c

[virtio-dev] Re: [PATCH V3 1/2] docs: vhost-user: Define memory region separately

2023-03-15 Thread Stefan Hajnoczi
On Thu, Mar 09, 2023 at 02:21:00PM +0530, Viresh Kumar wrote: > The same layout is defined twice, once in "single memory region > description" and then in "memory regions description". > > Separate out details of memory region from these two and reuse the same > definition later on. > > While at

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-blk: Define dev cfg layout before its fields

2023-03-15 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Michael S. Tsirkin > > > Hi Cornelia, > > > > > > Can you please merge this? > > > > Any updates? > > Pushed, thanks! Thank you. - To unsubscribe, e-mail: vir

[virtio-dev] Re: [PATCH v10] virtio-net: support inner header hash

2023-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2023 at 09:19:43PM +0800, Heng Qi wrote: > > Any encapsulation technology that includes UDP/L4 header likely do not > > prefer based on the inner header. This is because the outer header src > > port entropy is added based on the inner header. > > > > I was not able to follow the d

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-blk: Define dev cfg layout before its fields

2023-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2023 at 02:24:27PM +, Parav Pandit wrote: > > > From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of Parav Pandit > > > > > From: Stefan Hajnoczi > > > Sent: Thursday, February 23, 2023 3:46 PM > > > > > > On Thu, Feb 23, 2023 at 03:52:05PM +0200, Parav Pandit

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-03-15 Thread Michael S. Tsirkin
On Wed, Mar 15, 2023 at 08:55:45PM +0800, Heng Qi wrote: > > > 在 2023/3/15 下午7:58, Michael S. Tsirkin 写道: > > On Sat, Mar 11, 2023 at 11:23:08AM +0800, Heng Qi wrote: > > > > > > > > > 在 2023/3/10 上午3:36, Michael S. Tsirkin 写道: > > > > On Thu, Mar 09, 2023 at 12:55:02PM +0800, Heng Qi wrote: >

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-blk: Define dev cfg layout before its fields

2023-03-15 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Parav Pandit > > > From: Stefan Hajnoczi > > Sent: Thursday, February 23, 2023 3:46 PM > > > > On Thu, Feb 23, 2023 at 03:52:05PM +0200, Parav Pandit wrote: > > > Define device configuration layout structure before describing i

Re: [virtio-dev] [PATCH] virtio-spi: add the device specification

2023-03-15 Thread Cornelia Huck
On Mon, Feb 27 2023, Haixu Cui wrote: > virtio-spi is a virtual SPI master and it allows a guset to operate and > use the physical SPI master controlled by the host. > > Signed-off-by: Haixu Cui > --- > content.tex | 2 + > device-types/spi/description.tex|

[virtio-dev] Re: [virtio-comment] Re: [PATCH v10] virtio-net: support inner header hash

2023-03-15 Thread Heng Qi
在 2023/3/15 下午8:10, Michael S. Tsirkin 写道: On Tue, Mar 14, 2023 at 11:23:55PM -0400, Parav Pandit wrote: If not, for now it may be better to skip vxlan and nvegre as they inherently have unique outer header UDP src port based on the inner header. So what's left, GRE? GRE is actually differe

[virtio-dev] Re: [PATCH v10] virtio-net: support inner header hash

2023-03-15 Thread Heng Qi
在 2023/3/15 上午11:23, Parav Pandit 写道: On 3/6/2023 10:48 AM, Heng Qi wrote:   +\item[VIRTIO_NET_F_HASH_TUNNEL(52)] Device supports inner header hash May be to say inner packet header hash.. This make its little more clear about "which header" that you explained in the commit log. Sure

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-03-15 Thread Heng Qi
在 2023/3/15 下午7:58, Michael S. Tsirkin 写道: On Sat, Mar 11, 2023 at 11:23:08AM +0800, Heng Qi wrote: 在 2023/3/10 上午3:36, Michael S. Tsirkin 写道: On Thu, Mar 09, 2023 at 12:55:02PM +0800, Heng Qi wrote: 在 2023/3/8 下午10:39, Michael S. Tsirkin 写道: On Wed, Mar 01, 2023 at 10:56:31AM +0800, Hen

[virtio-dev] Re: [virtio-comment] Re: [PATCH v10] virtio-net: support inner header hash

2023-03-15 Thread Michael S. Tsirkin
On Tue, Mar 14, 2023 at 11:23:55PM -0400, Parav Pandit wrote: > If not, for now it may be better to skip vxlan and nvegre as they inherently > have unique outer header UDP src port based on the inner header. So what's left, GRE? GRE is actually different, in that it's not IP at all. So if we are

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v9] virtio-net: support inner header hash

2023-03-15 Thread Michael S. Tsirkin
On Sat, Mar 11, 2023 at 11:23:08AM +0800, Heng Qi wrote: > > > > 在 2023/3/10 上午3:36, Michael S. Tsirkin 写道: > > On Thu, Mar 09, 2023 at 12:55:02PM +0800, Heng Qi wrote: > > > > > > 在 2023/3/8 下午10:39, Michael S. Tsirkin 写道: > > > > On Wed, Mar 01, 2023 at 10:56:31AM +0800, Heng Qi wrote: > > >

[virtio-dev] Re: [PATCH] transport-pci: Remove duplicate word structure

2023-03-15 Thread Cornelia Huck
On Fri, Mar 10 2023, Parav Pandit wrote: > Remove duplicate word structure. > > Signed-off-by: Parav Pandit > --- > transport-pci.tex | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, pushed as an editorial update. ---

[virtio-dev] Re: [PATCH] virtio-net: Fix virtqueues spelling error

2023-03-15 Thread Cornelia Huck
On Fri, Mar 10 2023, Parav Pandit wrote: > Correct spelling from virtqueus to virtqueues. > > Signed-off-by: Parav Pandit > --- > device-types/net/description.tex | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, pushed as editorial update. -