RE: [virtio-dev] Re: [virtio-comment] Re: [PATCH v12] virtio-net: support inner header hash

2023-04-13 Thread Parav Pandit
> From: Heng Qi > Sent: Friday, April 14, 2023 12:01 AM > > 在 2023/4/14 上午11:10, Jason Wang 写道: > > On Fri, Apr 14, 2023 at 5:46 AM Michael S. Tsirkin wrote: > >> On Thu, Apr 13, 2023 at 07:03:26PM +0800, Heng Qi wrote: > >For example, when the packets of certain > > +tunnels are

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v12] virtio-net: support inner header hash

2023-04-13 Thread Heng Qi
在 2023/4/14 上午11:10, Jason Wang 写道: On Fri, Apr 14, 2023 at 5:46 AM Michael S. Tsirkin wrote: On Thu, Apr 13, 2023 at 07:03:26PM +0800, Heng Qi wrote: For example, when the packets of certain +tunnels are spread across multiple receive queues, these receive queues may have an unbalanced

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v12] virtio-net: support inner header hash

2023-04-13 Thread Heng Qi
在 2023/4/14 上午5:43, Michael S. Tsirkin 写道: On Thu, Apr 13, 2023 at 07:03:26PM +0800, Heng Qi wrote:   For example, when the packets of certain +tunnels are spread across multiple receive queues, these receive queues may have an unbalanced +amount of packets. This can cause a specific

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, April 13, 2023 11:38 PM > > > 1) spec doesn't enforce the size of a specific structure > > Spec will be extended in coming time. > > It's too late to do any new restriction without introducing a flag. We are really diverging from the topic. I don’t think

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 11:18 AM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Thursday, April 13, 2023 11:10 PM > > > > We have two options to satisfy the requirements. > > > (partly taken/repeated from Jason's yday email). > > > > > > 1. AQ (solves reset) + notification for building

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 11:22 AM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Thursday, April 13, 2023 11:18 PM > > > > > > > > > It's a must for ABI and migration compatibility: > > > > > > > > 1) The offset is not necessarily a page boundary > > > > 2) The length is not necessarily

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, April 13, 2023 11:18 PM > > > > > > It's a must for ABI and migration compatibility: > > > > > > 1) The offset is not necessarily a page boundary > > > 2) The length is not necessarily times of a PAGE_SIZE > > > 3) PAGE_SIZE varies among different archs > >

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, April 13, 2023 11:10 PM > > We have two options to satisfy the requirements. > > (partly taken/repeated from Jason's yday email). > > > > 1. AQ (solves reset) + notification for building non transitional > > device that support perform well and it is both

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 11:13 AM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Thursday, April 13, 2023 11:09 PM > > > > > Actually not, I think I've mentioned the reason for several times: > > > > It's a must for ABI and migration compatibility: > > > > 1) The offset is not

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, April 13, 2023 11:09 PM > > Actually not, I think I've mentioned the reason for several times: > > It's a must for ABI and migration compatibility: > > 1) The offset is not necessarily a page boundary > 2) The length is not necessarily times of a

[virtio-dev] Re: [virtio-comment] Re: [PATCH v12] virtio-net: support inner header hash

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 5:46 AM Michael S. Tsirkin wrote: > > On Thu, Apr 13, 2023 at 07:03:26PM +0800, Heng Qi wrote: > > > > For example, when the packets of certain > > > > +tunnels are spread across multiple receive queues, these receive > > > > queues may have an unbalanced > > > > +amount

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 3:39 AM Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, April 13, 2023 1:20 PM > > > > On Thu, Apr 13, 2023 at 01:14:15PM +0800, Jason Wang wrote: > > > > The proposed solution in this series enables it and avoid per > > > > field sw > >

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 1:24 AM Parav Pandit wrote: > > > > On 4/13/2023 1:14 AM, Jason Wang wrote: > > >> For LM BAR length and number should be same between two PCI VFs. But its > >> orthogonal to this point. Such checks will be done anyway. > > > > Quoted the wrong sections, I think it should

[virtio-dev] Re: virtio-iommu hotplug issue

2023-04-13 Thread Akihiko Odaki
On 2023/04/13 22:39, Eric Auger wrote: Hi, On 4/13/23 13:01, Akihiko Odaki wrote: On 2023/04/13 19:40, Jean-Philippe Brucker wrote: Hello, On Thu, Apr 13, 2023 at 01:49:43PM +0900, Akihiko Odaki wrote: Hi, Recently I encountered a problem with the combination of Linux's virtio-iommu driver

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Jason Wang > Sent: Thursday, April 13, 2023 10:37 PM > I'm not sure I get this. With VIRTIO_NET_F_LEGACY_HEADER, we don't need > mediation for datapath. For the control path, mediation is a must for legacy > and > it's very easy to keep it work for modern, what's wrong with that?

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Jason Wang
On Fri, Apr 14, 2023 at 5:08 AM Parav Pandit wrote: > > > > > From: Michael S. Tsirkin > > Sent: Thursday, April 13, 2023 5:02 PM > > > This thing ... you move some code to the card and reduce the amount of > > virtio > > knowledge in software but do not eliminate it completely. > Sure.

[virtio-dev] Re: [virtio-comment] Re: [PATCH v12] virtio-net: support inner header hash

2023-04-13 Thread Michael S. Tsirkin
On Thu, Apr 13, 2023 at 07:03:26PM +0800, Heng Qi wrote: > > >   For example, when the packets of certain > > > +tunnels are spread across multiple receive queues, these receive > > > queues may have an unbalanced > > > +amount of packets. This can cause a specific receive queue to > > > become

[virtio-dev] Re: [virtio-comment] Re: [PATCH v12] virtio-net: support inner header hash

2023-04-13 Thread Michael S. Tsirkin
On Thu, Apr 13, 2023 at 07:03:26PM +0800, Heng Qi wrote: > > >   For example, when the packets of certain > > > +tunnels are spread across multiple receive queues, these receive > > > queues may have an unbalanced > > > +amount of packets. This can cause a specific receive queue to > > > become

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, April 13, 2023 5:02 PM > This thing ... you move some code to the card and reduce the amount of virtio > knowledge in software but do not eliminate it completely. Sure. Practically there is no knowledge other than transporting like a vxlan

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Michael S. Tsirkin
On Thu, Apr 13, 2023 at 01:24:24PM -0400, Parav Pandit wrote: > > > > - work for virtualization (and it work even without dedicated > > > > mediation for some setups) > > > I am not aware where can it work without mediation. Do you know any > > > specific kernel version where it actually works? >

[virtio-dev] RE: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Thursday, April 13, 2023 1:20 PM > > On Thu, Apr 13, 2023 at 01:14:15PM +0800, Jason Wang wrote: > > > The proposed solution in this series enables it and avoid per > > > field sw > > > >>> interpretation and mediation in parsing values etc. > >

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Parav Pandit
On 4/13/2023 1:14 AM, Jason Wang wrote: For LM BAR length and number should be same between two PCI VFs. But its orthogonal to this point. Such checks will be done anyway. Quoted the wrong sections, I think it should be: " length MAY include padding, or fields unused by the driver, or

[virtio-dev] Re: [virtio-comment] Re: [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers

2023-04-13 Thread Michael S. Tsirkin
On Thu, Apr 13, 2023 at 01:14:15PM +0800, Jason Wang wrote: > > The proposed solution in this series enables it and avoid per field sw > > >>> interpretation and mediation in parsing values etc. ... except for reset, notifications, and maybe more down the road. > > >>> I don't think it's

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-13 Thread Michael S. Tsirkin
On Wed, Apr 12, 2023 at 01:37:59PM +0800, Jason Wang wrote: > On Wed, Apr 12, 2023 at 1:25 PM Michael S. Tsirkin wrote: > > > > On Wed, Apr 12, 2023 at 12:53:52PM +0800, Jason Wang wrote: > > > On Wed, Apr 12, 2023 at 12:20 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Apr 12, 2023

[virtio-dev] Re: virtio-iommu hotplug issue

2023-04-13 Thread Eric Auger
Hi, On 4/13/23 13:01, Akihiko Odaki wrote: > On 2023/04/13 19:40, Jean-Philippe Brucker wrote: >> Hello, >> >> On Thu, Apr 13, 2023 at 01:49:43PM +0900, Akihiko Odaki wrote: >>> Hi, >>> >>> Recently I encountered a problem with the combination of Linux's >>> virtio-iommu driver and QEMU when a

[virtio-dev] Virtio-loopback: PoC of a new Hardware Abstraction Layer for non-Hypervisor environments based on Virtio

2023-04-13 Thread Timos Ampelikiotis
Dear virtio-dev community, I would like to introduce you Virtio-loopback, Proof of Concept (PoC) that we have been working on at Virtual Open Systems in the context of the Automotive Grade Linux community (Virtualization & Containers expert group - EG-VIRT). We consider this work as a PoC and we

[virtio-dev] Re: virtio-iommu hotplug issue

2023-04-13 Thread Akihiko Odaki
On 2023/04/13 19:40, Jean-Philippe Brucker wrote: Hello, On Thu, Apr 13, 2023 at 01:49:43PM +0900, Akihiko Odaki wrote: Hi, Recently I encountered a problem with the combination of Linux's virtio-iommu driver and QEMU when a SR-IOV virtual function gets disabled. I'd like to ask you what kind

[virtio-dev] Re: virtio-iommu hotplug issue

2023-04-13 Thread Jean-Philippe Brucker
Hello, On Thu, Apr 13, 2023 at 01:49:43PM +0900, Akihiko Odaki wrote: > Hi, > > Recently I encountered a problem with the combination of Linux's > virtio-iommu driver and QEMU when a SR-IOV virtual function gets disabled. > I'd like to ask you what kind of solution is appropriate here and