[virtio-dev] Re: [PATCH v2 1/2] transport-pci: Introduce legacy registers access commands

2023-05-16 Thread Michael S. Tsirkin
On Sat, May 06, 2023 at 03:01:34AM +0300, Parav Pandit wrote: > +\begin{lstlisting} > +struct virtio_admin_cmd_lreg_wr_data { > + u8 offset; /* Starting byte offset of the register(s) to write */ > + u8 register[]; > +}; > +\end{lstlisting} So to summarize, I think the main comment here

[virtio-dev] Re: [libcamera-devel] [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-16 Thread Tomasz Figa
On Sat, May 6, 2023 at 5:12 PM Laurent Pinchart via libcamera-devel wrote: > > Hello, > > On Fri, May 05, 2023 at 04:55:33PM +0100, Alex Bennée via libcamera-devel > wrote: > > Kieran Bingham writes: > > > > > Hi All, > > > > > > Coming in late, thanks to lei/lore spotting the libcamera keyword.

[virtio-dev] Re: [virtio-comment] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 09:49:19PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, May 16, 2023 5:12 PM > > > > > Nah, we don't need a "break randomly unless it's a full moon and you cross > > your > > heart three times" mode. If you are going to implement support

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 09:41:07PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, May 16, 2023 5:09 PM > > > > Possibly one can set. I don’t know if any actual device really supported > > endianness. > > > No users have asked for it, even asking explicitly to those

[virtio-dev] RE: [virtio-comment] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, May 16, 2023 5:12 PM > > Nah, we don't need a "break randomly unless it's a full moon and you cross > your > heart three times" mode. If you are going to implement support for legacy > emulation implement it in a way that either predictably works or

[virtio-dev] Re: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 09:31:43PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, May 16, 2023 5:25 PM > > > > Flavor of a RHEL has inbuilt. > > > > What does this mean exactly? That virtio core is compiled into kernel? > > That does not matter at all. > > > Why

[virtio-dev] RE: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, May 16, 2023 5:09 PM > > Possibly one can set. I don’t know if any actual device really supported > endianness. > > No users have asked for it, even asking explicitly to those > > non_little_endian > users. > > For sure, ARM BE does exist and Red

[virtio-dev] RE: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, May 16, 2023 5:25 PM > > Flavor of a RHEL has inbuilt. > > What does this mean exactly? That virtio core is compiled into kernel? > That does not matter at all. > Why does it does not matter? What is the definition of driver, is the

[virtio-dev] RE: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, May 16, 2023 5:23 PM > > On Tue, May 16, 2023 at 09:19:02PM +, Parav Pandit wrote: > > > > > From: Michael S. Tsirkin > > > Sent: Tuesday, May 16, 2023 4:58 PM > > > > > > > Let me give you an example. I feel that device specific config > > > >

[virtio-dev] Re: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 08:59:32PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, May 16, 2023 4:48 PM > > > > On Tue, May 16, 2023 at 07:50:48PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Tuesday, May 16, 2023 6:05 AM > > > >

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 09:19:02PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, May 16, 2023 4:58 PM > > > > > Let me give you an example. I feel that device specific config > > > > should allow arbitrary length accesses so that e.g. > > > > mac can be read and

[virtio-dev] RE: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, May 16, 2023 4:58 PM > > > Let me give you an example. I feel that device specific config > > > should allow arbitrary length accesses so that e.g. > > > mac can be read and written atomically. > > > > > > On the other hand, this is not the case for

[virtio-dev] Re: [virtio-comment] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 07:35:20PM +, Parav Pandit wrote: > > > From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of Jason Wang > > Sent: Monday, May 15, 2023 11:55 PM > > > I don’t see how this is being any different than register-offset > > > interface. > > > > It bisects

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 07:29:44PM +, Parav Pandit wrote: > > > From: Jason Wang > > Sent: Tuesday, May 16, 2023 12:08 AM > > > > For guest and by guest are two different things. > > > I am proposing that a cfgq/cmdq should be used directly by the guest > > > driver as > > base line like

[virtio-dev] RE: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, May 16, 2023 4:48 PM > > On Tue, May 16, 2023 at 07:50:48PM +, Parav Pandit wrote: > > > > > From: Michael S. Tsirkin > > > Sent: Tuesday, May 16, 2023 6:05 AM > > > > > > > > SO I propose: > > > > > > \item[ACKNOWLEDGE (1)] Indicates that a

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 07:11:36PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, May 16, 2023 2:22 AM > > > > On Mon, May 15, 2023 at 03:59:41PM +, Parav Pandit wrote: > > > > > > > From: Jason Wang > > > > Sent: Monday, May 15, 2023 3:31 AM > > > > > > > >

[virtio-dev] Re: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 07:50:48PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Tuesday, May 16, 2023 6:05 AM > > > > > SO I propose: > > > > \item[ACKNOWLEDGE (1)] Indicates that a transport driver has found the > > device and recognized it as a valid virtio device

[virtio-dev] Re: [virtio-comment] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 06:45:58PM +, Parav Pandit wrote: > > From: Michael S. Tsirkin > > Sent: Tuesday, May 16, 2023 12:33 AM > > [..] > > > > > A better way is to have an eventq of depth = num_vfs, like many > > > > > other virtio devices have it. > > > > > > > > > > An eventq can hold

[virtio-dev] RE: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, May 16, 2023 6:05 AM > > SO I propose: > > \item[ACKNOWLEDGE (1)] Indicates that a transport driver has found the > device and recognized it as a valid virtio device transport. > > \item[DRIVER (2)] Indicates that a device type specific driver

[virtio-dev] RE: [virtio-comment] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Jason Wang > Sent: Monday, May 15, 2023 11:55 PM > > I don’t see how this is being any different than register-offset interface. > > It bisects more things at hypervisor level that makes things hard to add > > #12th > entry. >

[virtio-dev] RE: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Parav Pandit
> From: Jason Wang > Sent: Tuesday, May 16, 2023 12:08 AM > > For guest and by guest are two different things. > > I am proposing that a cfgq/cmdq should be used directly by the guest driver > > as > base line like any other VQ. > > I'm fine with this, but if I understand correctly, but I

[virtio-dev] RE: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, May 16, 2023 2:22 AM > > On Mon, May 15, 2023 at 03:59:41PM +, Parav Pandit wrote: > > > > > From: Jason Wang > > > Sent: Monday, May 15, 2023 3:31 AM > > > > > > What do we gain from bisecting it? > > > > > > > > > 1) No need to deal with the

[virtio-dev] RE: [virtio-comment] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, May 16, 2023 12:33 AM [..] > > > > A better way is to have an eventq of depth = num_vfs, like many > > > > other virtio devices have it. > > > > > > > > An eventq can hold per VF interrupt entry including the isr value > > > > that you suggest above. >

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-16 Thread Alexander Gordeev
On 12.05.23 06:09, Alexandre Courbot wrote: On Thu, May 11, 2023 at 5:50 PM Alexander Gordeev wrote: On 08.05.23 06:55, Alexandre Courbot wrote: On Fri, May 5, 2023 at 8:55 PM Alexander Gordeev wrote: On 03.05.23 16:04, Cornelia Huck wrote: On Fri, Apr 28 2023, Alexander Gordeev wrote:

[virtio-dev] Re: [libcamera-devel] [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-16 Thread Alexander Gordeev
Hello Laurent, +CC: Andrii On 06.05.23 10:16, Laurent Pinchart wrote: I'm also CC'ing the linux-me...@vger.kernel.org mailing list for these discussions, I'm sure there are folks there who are interested in codec and camera virtualization. On Sat, May 06, 2023 at 11:12:29AM +0300, Laurent

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-16 Thread Alexander Gordeev
On 05.05.23 17:55, Alex Bennée wrote: Kieran Bingham writes: Hi All, Coming in late, thanks to lei/lore spotting the libcamera keyword. + Cc: libcamera-devel to raise awareness of the discussion there. Quoting Alexander Gordeev (2023-05-05 10:57:29) On 03.05.23 17:53, Cornelia Huck

[virtio-dev] Re: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Cornelia Huck
On Tue, May 16 2023, "Michael S. Tsirkin" wrote: > On Tue, May 16, 2023 at 10:24:12AM +0200, Cornelia Huck wrote: >> On Tue, May 16 2023, "Michael S. Tsirkin" wrote: >> >> > On Tue, May 16, 2023 at 06:01:39AM +0300, Parav Pandit wrote: >> >> diff --git a/content.tex b/content.tex >> >> index

[virtio-dev] Re: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2023 at 10:24:12AM +0200, Cornelia Huck wrote: > On Tue, May 16 2023, "Michael S. Tsirkin" wrote: > > > On Tue, May 16, 2023 at 06:01:39AM +0300, Parav Pandit wrote: > >> diff --git a/content.tex b/content.tex > >> index 9df81b8..417d476 100644 > >> --- a/content.tex > >> +++

[virtio-dev] Re: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Cornelia Huck
On Tue, May 16 2023, "Michael S. Tsirkin" wrote: > On Tue, May 16, 2023 at 06:01:39AM +0300, Parav Pandit wrote: >> diff --git a/content.tex b/content.tex >> index 9df81b8..417d476 100644 >> --- a/content.tex >> +++ b/content.tex >> @@ -26,10 +26,10 @@ \section{\field{Device Status}

[virtio-dev] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

2023-05-16 Thread Michael S. Tsirkin
On Mon, May 15, 2023 at 03:59:41PM +, Parav Pandit wrote: > > > From: Jason Wang > > Sent: Monday, May 15, 2023 3:31 AM > > > > What do we gain from bisecting it? > > > > > > 1) No need to deal with the offset in the hardware > > > In context of legacy is doesn’t matter much given that