[virtio-dev] RE: [PATCH v12 3/3] admin: Add group member legacy register access commands

2023-07-07 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Friday, July 7, 2023 5:31 AM > ok getting there. mostly notification needs a bit more work but it's close. Fixed all the comments in v13. Thanks.

[virtio-dev] [PATCH v13] admin: Add group member legacy register access commands

2023-07-07 Thread Parav Pandit
Introduce group member legacy common configuration and legacy device configuration access read/write commands. Group member legacy registers access commands enable group owner driver to access legacy registers on behalf of the guest virtual machine. Usecase: 1. A hypervisor/system needs

[virtio-dev] RE: [PATCH v12 0/3] admin: Access legacy registers using admin commands

2023-07-07 Thread Parav Pandit
> From: Cornelia Huck > Sent: Friday, July 7, 2023 7:46 AM > > Patch summary: > > -- > > patch-1 fix split rows of admin opcode tables by a line > > patch-2 fix section numbering > > Pushed 1+2 as editorial updates. Thanks. -

[virtio-dev] RE: [virtio-comment] Re: [PATCH v12 3/3] admin: Add group member legacy register access commands

2023-07-07 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Michael S. Tsirkin > Sent: Friday, July 7, 2023 10:17 AM > > > > +group member driver SHOULD use the notification address to send a > > > > +driver notification to the device. > > > > > > No group member driver is not involved.

[virtio-dev] Re: [PATCH v12 3/3] admin: Add group member legacy register access commands

2023-07-07 Thread Michael S. Tsirkin
On Fri, Jul 07, 2023 at 01:26:56PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Friday, July 7, 2023 5:31 AM > > [..] > > > +For VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_WRITE and > > > +VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ commands, the driver > > SHOULD set > > > +\field{offse

[virtio-dev] RE: [PATCH v12 3/3] admin: Add group member legacy register access commands

2023-07-07 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Friday, July 7, 2023 5:31 AM [..] > > +For VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_WRITE and > > +VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ commands, the driver > SHOULD set > > +\field{offset} and the length of the \field{data} to refer to a > > +single field within the v

[virtio-dev] Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-07 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Fri, Jul 07, 2023 at 08:58:00AM +0100, Alex Bennée wrote: >> >> "Michael S. Tsirkin" writes: >> >> > On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote: >> >> Currently QEMU has to know some details about the back-end to be able >> >> to setup the g

[virtio-dev] Re: [PATCH v12 0/3] admin: Access legacy registers using admin commands

2023-07-07 Thread Cornelia Huck
On Fri, Jul 07 2023, Parav Pandit wrote: > This short series introduces legacy registers access commands for the owner > group member access the legacy registers of the member VFs. > This short series introduces legacy region access commands by the group owner > device for its member devices. > C

[virtio-dev] Re: [PATCH v11 0/3] admin: Access legacy registers using admin commands

2023-07-07 Thread Cornelia Huck
On Thu, Jul 06 2023, "Michael S. Tsirkin" wrote: > On Fri, Jul 07, 2023 at 12:27:19AM +0300, Parav Pandit wrote: >> This short series introduces legacy registers access commands for the owner >> group member access the legacy registers of the member VFs. >> This short series introduces legacy reg

[virtio-dev] Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-07 Thread Stefano Garzarella
On Thu, Jul 06, 2023 at 05:31:15PM +0100, Alex Bennée wrote: Alex Bennée writes: Currently QEMU has to know some details about the back-end to be able to setup the guest. While various parts of the setup can be delegated to the backend (for example config handling) this is a very piecemeal ap

Re: [virtio-dev] [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-07 Thread Stefano Garzarella
On Tue, Jul 04, 2023 at 04:02:42PM +0100, Alex Bennée wrote: Stefano Garzarella writes: On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote: Currently QEMU has to know some details about the back-end to be able to setup the guest. While various parts of the setup can be delegated to

[virtio-dev] Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-07 Thread Michael S. Tsirkin
On Fri, Jul 07, 2023 at 08:58:00AM +0100, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote: > >> Currently QEMU has to know some details about the back-end to be able > >> to setup the guest. While various parts of the setup ca

[virtio-dev] Re: [PATCH v12 3/3] admin: Add group member legacy register access commands

2023-07-07 Thread Michael S. Tsirkin
On Fri, Jul 07, 2023 at 06:54:01AM +0300, Parav Pandit wrote: > Introduce group member legacy common configuration and legacy device > configuration access read/write commands. > > Group member legacy registers access commands enable group owner driver > software to access legacy registers on beha

Re: [virtio-dev][PATCH 1/2] virtio-spi: define the DEVICE ID for virtio SPI master

2023-07-07 Thread Haixu Cui
Hi Michael S. Tsirkin, Cornelia Huck, I have created an issue https://github.com/oasis-tcs/virtio-spec/issues/174 to request Device ID 45 for SPI master. Please help to deal with it, thank you very much. Best Regards Haixu Cui On 6/30/2023 10:57 PM, Michael S. Tsirkin wrote: On Mon, Apr

[virtio-dev] Re: [virtio-comment] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-07 Thread Michael S. Tsirkin
On Fri, Jul 07, 2023 at 10:12:35AM +0200, Cornelia Huck wrote: > [Also, I notice that the discussion seems to get bogged down in tiny > details, fundamental statements, or a mixture of both. It might > sometimes be helpful to just step back, re-read the original proposal, > and only then answer. Ot

[virtio-dev] Re: [PATCH v11 3/3] admin: Add group member legacy register access commands

2023-07-07 Thread Michael S. Tsirkin
On Fri, Jul 07, 2023 at 03:54:31AM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 6:36 PM > > [..] > > > I notice you decided to silently ignore my suggestion to document how are > > notifications performed. Repeating myself like this is despiriting f

[virtio-dev] Re: [virtio-comment] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-07 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Thursday, July 6, 2023 4:42 PM > > [..] >> > Can we please avoid this over engineering? >> > Interface has the doors open for driver to make wise decision depending on >> its environment. >> >> what if driver can acce

[virtio-dev] Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-07 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote: >> Currently QEMU has to know some details about the back-end to be able >> to setup the guest. While various parts of the setup can be delegated >> to the backend (for example config handling) this is a

Re: [virtio-dev][PATCH 2/2] virtio-spi: add the device specification

2023-07-07 Thread Haixu Cui
Hi Jonathon Reinhart, Thank you so much for all your helpful advice and info! I took a look at latest Linux SPI driver and found, for cs_setup/cs_hold/cs_inactive set in device-tree, there are following two conditions: 1) if SPI controller supports CS timing configuration and CS is