Re: [virtio-dev] virtio-snd and snapshots (e.g. in QEMU) when audio is active

2023-07-21 Thread Roman Kiryanov
On Fri, Jul 21, 2023 at 12:44 AM Matias Ezequiel Vara Larsen wrote: > > Could you please advise what a device is expected to do in this case? > > > > Do you mean what a VMM shall do when taking a snapshot regarding the > virtio-snd device? Thank you for looking into this, Matias. Stefan already p

Re: [virtio-dev] virtio-snd and snapshots (e.g. in QEMU) when audio is active

2023-07-21 Thread Roman Kiryanov
On Thu, Jul 20, 2023 at 8:41 AM Stefan Hajnoczi wrote: > > Could you please advise what a device is expected to do in this case? > > Do you mean QEMU's VirtQueueElement? There are devices in QEMU that > save/load in-flight VirtQueueElements. See qemu_put_virtqueue_element(). Thank you, Stefan. I

[virtio-dev] RE: [virtio-comment] Re: [virtio-dev] [virtio 1.3] Feature freeze has started

2023-07-21 Thread Parav Pandit
> From: virtio-comm...@lists.oasis-open.org open.org> On Behalf Of Cornelia Huck > Sent: Friday, July 21, 2023 9:09 AM > > https://github.com/oasis-tcs/virtio-spec/issues/170 ("The size of > > virtio_net_hdr struct are wrong when VIRTIO_NET_HASH_REPORT feature is > > negotiated.") > > * Can s

[virtio-dev] RE: 1.3 and branching (was: [virtio-dev] Re: [PATCH v12] virtio-net: support device stats)

2023-07-21 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Friday, July 21, 2023 8:42 AM > Yea, makes sense. > I think we are all set WRT what we planned to be in 1.3 - right? > Next step is preparing the changelog and packaging it all as WD, then voting > to > approve it as a CSD/CSPRD and start public review. >

Re: [virtio-dev][PATCH 2/2] virtio-spi: add the device specification

2023-07-21 Thread Harald Mommer
Hello, is there already some virtio SPI Linux driver published to the public to have a chance to look at? Same question for the device side. Is there a qemu device (or something for a different virtualization environment like kvmtool) already published to the public anywhere? The spec made

Re: [virtio-dev] [virtio 1.3] Feature freeze has started

2023-07-21 Thread Cornelia Huck
On Mon, Jul 03 2023, Cornelia Huck wrote: > As outlined in > https://lists.oasis-open.org/archives/virtio/202304/msg00036.html ff., > as part of the release process for the 1.3 version of the virtio spec, > we have now entered feature freeze. This means: > > *** > By July 1st[3rd], all not yet in

[virtio-dev] Re: 1.3 and branching

2023-07-21 Thread Cornelia Huck
On Fri, Jul 21 2023, "Michael S. Tsirkin" wrote: > On Fri, Jul 21, 2023 at 02:24:57PM +0200, Cornelia Huck wrote: >> On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: >> >> > On Wed, Jul 12, 2023 at 02:24:32PM +0200, Cornelia Huck wrote: >> >> On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: >>

[virtio-dev] Re: 1.3 and branching (was: [virtio-dev] Re: [PATCH v12] virtio-net: support device stats)

2023-07-21 Thread Michael S. Tsirkin
On Fri, Jul 21, 2023 at 02:24:57PM +0200, Cornelia Huck wrote: > On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: > > > On Wed, Jul 12, 2023 at 02:24:32PM +0200, Cornelia Huck wrote: > >> On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: > >> > Yes we were supposed to freeze for 1.3. This change

[virtio-dev] 1.3 and branching (was: [virtio-dev] Re: [PATCH v12] virtio-net: support device stats)

2023-07-21 Thread Cornelia Huck
On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: > On Wed, Jul 12, 2023 at 02:24:32PM +0200, Cornelia Huck wrote: >> On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: >> > Yes we were supposed to freeze for 1.3. This change can be merged on a >> > main branch after 1.3 forks and is under review.

Re: [virtio-dev] virtio-snd and snapshots (e.g. in QEMU) when audio is active

2023-07-21 Thread Matias Ezequiel Vara Larsen
Hello Roman, On Wed, Jul 19, 2023 at 04:21:08PM -0700, Roman Kiryanov wrote: > Hi, > > I work in Android Studio Emulator and we use virtio-snd (implemented > ourselves) for audio output/input. According to the spec (1.2), the > device has one TX virtqueue for all output streams and one RX > virtq