Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Jason Wang
On Thu, Dec 21, 2023 at 11:51 AM Heng Qi wrote: > > > > 在 2023/12/21 上午9:41, Jason Wang 写道: > > On Wed, Dec 20, 2023 at 5:31 PM Heng Qi wrote: > >> > >> > >> 在 2023/12/20 下午3:35, Michael S. Tsirkin 写道: > >>> On Wed, Dec 20, 2023 at 02:30:01PM +0800, Heng Qi wrote: > But why are we discussing

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Jason Wang
On Thu, Dec 21, 2023 at 11:43 AM Heng Qi wrote: > > > > 在 2023/12/21 上午9:34, Jason Wang 写道: > > On Wed, Dec 20, 2023 at 3:42 PM Heng Qi wrote: > >> > >> > >> 在 2023/12/20 下午2:59, Jason Wang 写道: > >>> On Wed, Dec 20, 2023 at 2:30 PM Heng Qi wrote: > > 在 2023/12/20 下午1:48, Jason Wang 写道:

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-20 Thread Haixu Cui
Hi Cornelia, Much appreciated for your comments and please refer to my response. On 12/18/2023 7:04 PM, Cornelia Huck wrote: On Tue, Dec 12 2023, Haixu Cui wrote: [BTW: A changelog would be useful, either in the patch or in the cover letter.] Sure, I summarize the major changes between t

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Jason Wang
On Thu, Dec 21, 2023 at 11:45 AM Heng Qi wrote: > > > > 在 2023/12/21 上午9:34, Jason Wang 写道: > > On Wed, Dec 20, 2023 at 3:35 PM Michael S. Tsirkin wrote: > >> On Wed, Dec 20, 2023 at 02:30:01PM +0800, Heng Qi wrote: > >>> But why are we discussing this? > >> I think basically at this point everyo

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Heng Qi
在 2023/12/21 上午9:34, Jason Wang 写道: On Wed, Dec 20, 2023 at 3:35 PM Michael S. Tsirkin wrote: On Wed, Dec 20, 2023 at 02:30:01PM +0800, Heng Qi wrote: But why are we discussing this? I think basically at this point everyone is confused about what the feature does. right now we have packets

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Heng Qi
在 2023/12/21 上午9:34, Jason Wang 写道: On Wed, Dec 20, 2023 at 3:42 PM Heng Qi wrote: 在 2023/12/20 下午2:59, Jason Wang 写道: On Wed, Dec 20, 2023 at 2:30 PM Heng Qi wrote: 在 2023/12/20 下午1:48, Jason Wang 写道: On Wed, Dec 20, 2023 at 12:07 AM Heng Qi wrote: 在 2023/12/19 下午3:53, Jason Wang 写

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Jason Wang
On Thu, Dec 21, 2023 at 9:41 AM Jason Wang wrote: > > On Wed, Dec 20, 2023 at 5:31 PM Heng Qi wrote: > > > > > > > > 在 2023/12/20 下午3:35, Michael S. Tsirkin 写道: > > > On Wed, Dec 20, 2023 at 02:30:01PM +0800, Heng Qi wrote: > > >> But why are we discussing this? > > > I think basically at this po

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Jason Wang
On Wed, Dec 20, 2023 at 5:31 PM Heng Qi wrote: > > > > 在 2023/12/20 下午3:35, Michael S. Tsirkin 写道: > > On Wed, Dec 20, 2023 at 02:30:01PM +0800, Heng Qi wrote: > >> But why are we discussing this? > > I think basically at this point everyone is confused about what > > the feature does. right now w

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Jason Wang
On Wed, Dec 20, 2023 at 3:35 PM Michael S. Tsirkin wrote: > > On Wed, Dec 20, 2023 at 02:30:01PM +0800, Heng Qi wrote: > > But why are we discussing this? > > I think basically at this point everyone is confused about what > the feature does. right now we have packets > with > #define VIRTIO_NET_H

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Jason Wang
On Wed, Dec 20, 2023 at 3:42 PM Heng Qi wrote: > > > > 在 2023/12/20 下午2:59, Jason Wang 写道: > > On Wed, Dec 20, 2023 at 2:30 PM Heng Qi wrote: > >> > >> > >> 在 2023/12/20 下午1:48, Jason Wang 写道: > >>> On Wed, Dec 20, 2023 at 12:07 AM Heng Qi wrote: > > 在 2023/12/19 下午3:53, Jason Wang 写道:

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-20 Thread Cornelia Huck
On Mon, Dec 18 2023, Bill Mills wrote: > On 12/18/23 9:19 AM, Alex Bennée wrote: >> Cornelia Huck writes: >> >>> On Wed, Dec 06 2023, Viresh Kumar wrote: >>> On 05-12-23, 14:18, Cornelia Huck wrote: > On Tue, Dec 05 2023, Viresh Kumar wrote: >> - The transport MUST provide

Re: [virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-20 Thread Cornelia Huck
On Mon, Dec 18 2023, Alex Bennée wrote: > Cornelia Huck writes: > >> On Tue, Dec 05 2023, Alex Bennée wrote: >> >>> Cornelia Huck writes: >>> On Tue, Dec 05 2023, Viresh Kumar wrote: > + > +The device MUST present each event, in a transport defined way, from the > +moment it

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Heng Qi
在 2023/12/20 下午2:59, Jason Wang 写道: On Wed, Dec 20, 2023 at 2:30 PM Heng Qi wrote: 在 2023/12/20 下午1:48, Jason Wang 写道: On Wed, Dec 20, 2023 at 12:07 AM Heng Qi wrote: 在 2023/12/19 下午3:53, Jason Wang 写道: On Mon, Dec 18, 2023 at 12:54 PM Heng Qi wrote: 在 2023/12/18 上午11:10, Jason Wang

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-20 Thread Heng Qi
在 2023/12/20 下午3:35, Michael S. Tsirkin 写道: On Wed, Dec 20, 2023 at 02:30:01PM +0800, Heng Qi wrote: But why are we discussing this? I think basically at this point everyone is confused about what the feature does. right now we have packets with #define VIRTIO_NET_HDR_F_NEEDS_CSUM 1