Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH v3] virtio-can: Device specification.

2024-02-26 Thread Cornelia Huck
On Wed, Feb 21 2024, Marc Kleine-Budde wrote: > On 21.02.2024 14:16:54, Matias Ezequiel Vara Larsen wrote: >> On Wed, Feb 21, 2024 at 01:49:31PM +0100, Marc Kleine-Budde wrote: >> > On 21.02.2024 11:37:58, Matias Ezequiel Vara Larsen wrote: >> > > > > +The length of the \field{sdu} is determined

Re: [virtio-dev] [RFC PATCH v3] virtio-can: Device specification.

2024-02-16 Thread Cornelia Huck
On Fri, Jun 09 2023, Mikhail Golubev-Ciuchea wrote: > From: Harald Mommer > > virtio-can is a virtual CAN device. It provides a way to give access to > a CAN controller from a driver guest. The device is aimed to be used by > driver guests running a HLOS as well as by driver guests running a >

Re: [virtio-dev] [RFC PATCH v3 0/3] Virtio SPI Linux driver compliant to draft spec V10

2024-02-14 Thread Cornelia Huck
On Tue, Feb 13 2024, Harald Mommer wrote: > This is the 3rd RFC version of a virtio SPI Linux driver which is > intended to be compliant with the proposed virtio SPI draft > specification V10. FWIW: this version of the SPI spec has been voted in for virtio 1.4 (and is consequently available on

[virtio-dev] Re: [virtio-comment] [PATCH] sound: add sampling rates 12000Hz and 24000Hz

2024-02-14 Thread Cornelia Huck
On Wed, Feb 14 2024, Anton Yakovlev wrote: > Thanks Pape! > > > On 05.02.2024 23:41, Pape, Andreas (ADITG/ESS3) wrote: >> 24kHz is used for 'super wideband' voice transmission 12kHz is added 'for >> completeness' >> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/184 >> >>

Re: [virtio-dev] [RFC PATCH v3] virtio-can: Device specification.

2024-02-13 Thread Cornelia Huck
On Fri, Jun 09 2023, Mikhail Golubev-Ciuchea wrote: > diff --git a/introduction.tex b/introduction.tex > index b7155bf..d560c63 100644 > --- a/introduction.tex > +++ b/introduction.tex > @@ -101,6 +101,8 @@ \section{Normative References}\label{sec:Normative > References} >

[virtio-dev] Re: [PATCH V2] virtio-transport: Clarify requirements

2024-02-13 Thread Cornelia Huck
On Tue, Jan 30 2024, Viresh Kumar wrote: > The virtio documentation currently doesn't define any generic > requirements that are applicable to all transports. They can be useful > while adding support for a new transport. > > This commit tries to define the same. > > Signed-off-by: Viresh Kumar

[virtio-dev] Re: [virtio-comment] [PATCH] sound: add sampling rates 12000Hz and 24000Hz

2024-02-07 Thread Cornelia Huck
On Mon, Feb 05 2024, "Pape, Andreas (ADITG/ESS3)" wrote: > 24kHz is used for 'super wideband' voice transmission 12kHz is added 'for > completeness' > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/184 > > Signed-off-by: Andreas Pape > --- > device-types/sound/description.tex | 4 +++-

[virtio-dev] Re: [virtio-comment] [RFC PATCH v3] virtio-can: Device specification.

2024-02-02 Thread Cornelia Huck
On Mon, Jan 15 2024, Cornelia Huck wrote: > On Mon, Jan 08 2024, Mikhail Golubev-Ciuchea > wrote: > >> Hi all! >> >> I kindly request a vote. >> >> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/186 > > Oh, that has been a while... I be

Re: [virtio-dev] [PATCH] Define the DEVICE ID of Virtio Cpu balloon device as 47.

2024-01-30 Thread Cornelia Huck
On Mon, Jan 29 2024, Shujun Xue wrote: > Is there ETA for the migration? Well, I wish I knew... > > Bests, > Shujun > > > Cornelia Huck 于2024年1月29日 周一上午6:55写道: > >> On Tue, Jan 23 2024, Shujun Xue wrote: >> >> > The Virtio CPU balloon device is a

[virtio-dev] Re: [virtio] [PATCH] virtio-net: clarify error handling for coalescing

2024-01-29 Thread Cornelia Huck
On Mon, Jan 29 2024, "Michael S. Tsirkin" wrote: > On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote: >> On Wed, Jan 24 2024, "Michael S. Tsirkin" wrote: >> >> > This is not a huge deal since it's a SHOULD anyway, >> > so make

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2024-01-29 Thread Cornelia Huck
On Mon, Jan 29 2024, Viresh Kumar wrote: > On 18-12-23, 15:02, Cornelia Huck wrote: >> Other things that probably should be mandatory: >> >> - A way for the driver to change the device status. Reading it would >> probably be a strong SHOULD. >> - A way to imp

[virtio-dev] Re: [virtio] [PATCH] virtio-net: clarify error handling for coalescing

2024-01-29 Thread Cornelia Huck
On Wed, Jan 24 2024, "Michael S. Tsirkin" wrote: > This is not a huge deal since it's a SHOULD anyway, > so make the new requirement SHOULD too. > > Signed-off-by: Michael S. Tsirkin > --- > device-types/net/description.tex | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff

Re: [virtio-dev] [PATCH] Define the DEVICE ID of Virtio Cpu balloon device as 47.

2024-01-29 Thread Cornelia Huck
On Tue, Jan 23 2024, Shujun Xue wrote: > The Virtio CPU balloon device is a primitive device for managing guest > CPU capacity: the device asks for certain CPU cores to be online, > offline or throttled, and the driver performs the requested operation. > This allows the guest to adapt to changes

[virtio-dev] Re: [virtio-comment] [RFC PATCH v3] virtio-can: Device specification.

2024-01-15 Thread Cornelia Huck
On Mon, Jan 08 2024, Mikhail Golubev-Ciuchea wrote: > Hi all! > > I kindly request a vote. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/186 Oh, that has been a while... I believe that this still fits on top, although it has conflicts with virtio-spi, but nothing that a bit of

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/1] RFC: virtio-bt: add virtio BT device specification

2024-01-15 Thread Cornelia Huck
On Thu, Dec 07 2023, Igor Skalkin wrote: > diff --git a/device-types/bt/description.tex b/device-types/bt/description.tex > new file mode 100644 > index 000..98311f4 > --- /dev/null > +++ b/device-types/bt/description.tex > @@ -0,0 +1,158 @@ > +\section{BT Device}\label{sec:Device Types / BT

Re: [virtio-dev] [PATCH v8] virtio-net: correct conditions for devices to validate packet checksum

2024-01-11 Thread Cornelia Huck
On Thu, Jan 11 2024, Heng Qi wrote: > 在 2024/1/4 下午12:47, Heng Qi 写道: >> >> >> 在 2024/1/3 下午2:35, Heng Qi 写道: >>> There is a historical error in virtio spec: >>>    "If VIRTIO_NET_F_GUEST_CSUM is not negotiated, the device *MUST* >>> set flags >>>     to zero and SHOULD supply a fully

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-22 Thread Cornelia Huck
On Tue, Dec 12 2023, Haixu Cui wrote: > The Virtio SPI (Serial Peripheral Interface) device is a virtual > SPI controller that allows the driver to operate and use the SPI > controller under the control of the host. > > This patch adds the specification for virtio-spi. > > Signed-off-by: Haixu

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-21 Thread Cornelia Huck
On Thu, Dec 21 2023, Haixu Cui wrote: > Hi Cornelia, > > On 12/21/2023 4:44 PM, Cornelia Huck wrote: >> On Thu, Dec 21 2023, Haixu Cui wrote: >>>> Please move inclusion of this new file into content.tex here, instead of >>>> including a not-

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-21 Thread Cornelia Huck
On Thu, Dec 21 2023, Haixu Cui wrote: > Hi Cornelia, > Much appreciated for your comments and please refer to my response. > > On 12/18/2023 7:04 PM, Cornelia Huck wrote: >> On Tue, Dec 12 2023, Haixu Cui wrote: >> >> [BTW: A changelog would be useful, eithe

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-20 Thread Cornelia Huck
On Mon, Dec 18 2023, Bill Mills wrote: > On 12/18/23 9:19 AM, Alex Bennée wrote: >> Cornelia Huck writes: >> >>> On Wed, Dec 06 2023, Viresh Kumar wrote: >>> >>>> On 05-12-23, 14:18, Cornelia Huck wrote: >>>>> On Tue, Dec 05 2

Re: [virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-20 Thread Cornelia Huck
On Mon, Dec 18 2023, Alex Bennée wrote: > Cornelia Huck writes: > >> On Tue, Dec 05 2023, Alex Bennée wrote: >> >>> Cornelia Huck writes: >>> >>>> On Tue, Dec 05 2023, Viresh Kumar wrote: >>>>> + >>>>> +The devi

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-18 Thread Cornelia Huck
On Wed, Dec 06 2023, Viresh Kumar wrote: > On 05-12-23, 14:18, Cornelia Huck wrote: >> On Tue, Dec 05 2023, Viresh Kumar wrote: >> > +\section{Virtio Transport Requirements}\label{sec:Virtio Transport >> > Options / Virtio Transport Requirements} >> >

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-18 Thread Cornelia Huck
On Tue, Dec 05 2023, Alex Bennée wrote: > Cornelia Huck writes: > >> On Tue, Dec 05 2023, Viresh Kumar wrote: >>> + >>> +The device MUST present each event, in a transport defined way, from the >>> +moment it takes place until the driver acknowledges

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-18 Thread Cornelia Huck
On Tue, Dec 12 2023, Haixu Cui wrote: [BTW: A changelog would be useful, either in the patch or in the cover letter.] > The Virtio SPI (Serial Peripheral Interface) device is a virtual > SPI controller that allows the driver to operate and use the SPI > controller under the control of the host.

[virtio-dev] Re: [virtio-comment] Changes coming to this mail list system

2023-12-14 Thread Cornelia Huck
On Tue, Dec 05 2023, Scott McGrath wrote: [dropped non-virtio lists, added the other virtio lists] > The Transition Schedule > > Starting 14 December, there may be as much as several days of system > downtime. During the downtime you will not receive email messages sent to > this list or have

[virtio-dev] virtio 1.3: update

2023-12-11 Thread Cornelia Huck
You may have been wondering what the current state of virtio 1.3 is; the tl;dr is: we have to deal with some unfortunate delays, but it is really nearing release now. The current state - virtio-1.3-csd01 (committee specification draft) has been out for public review, and that 30

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-12-06 Thread Cornelia Huck
On Mon, Dec 04 2023, Haixu Cui wrote: > Hi Huck, > > On 12/1/2023 7:01 PM, Cornelia Huck wrote: >> On Fri, Dec 01 2023, Haixu Cui wrote: >> >>>>> +Note: chipselect is an electrical signal controlled by the SPI >>>>> controller, used to selec

[virtio-dev] Re: [PATCH] virtio-transport: Clarify requirements

2023-12-05 Thread Cornelia Huck
On Tue, Dec 05 2023, Viresh Kumar wrote: > The virtio documentation currently doesn't define any generic > requirements that are applicable to all transports. They can be useful > while adding support for a new transport. > > This commit tries to define the same. Thank you for tackling this,

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-12-01 Thread Cornelia Huck
On Fri, Dec 01 2023, Haixu Cui wrote: >>> +Note: chipselect is an electrical signal controlled by the SPI controller, >>> used to select the >>> +SPI slaves connected to the controller. >> >> I wonder whether another term is now more commonly used... the Wikipedia >> article uses main/sub, is

Re: [virtio-dev] [PATCH V6 2/2] virtio-spi: add the device specification

2023-11-30 Thread Cornelia Huck
On Thu, Nov 30 2023, Haixu Cui wrote: > The Virtio SPI (Serial Peripheral Interface) device is a virtual > SPI controller that allows the driver to operate and use the SPI > controller under the control of the device. > > This patch adds the specification for virtio-spi. > > Signed-off-by: Haixu

[virtio-dev] Re: [virtio-comment] [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-29 Thread Cornelia Huck
On Wed, Nov 29 2023, Viresh Kumar wrote: > On 29-11-23, 18:31, Haixu Cui wrote: >> Hi Viresh, >> >> Thank you for your helpful comments. In next patch, I will clearly point >> this out: > > Great, finally we are on the same page. Thanks Haixu. > >> "For full-duplex read and write

[virtio-dev] Re: [virtio-comment] [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-29 Thread Cornelia Huck
On Wed, Nov 29 2023, Haixu Cui wrote: > Hi Viresh, > > On 11/29/2023 3:30 PM, Viresh Kumar wrote: >> On 28-11-23, 20:58, Haixu Cui wrote: >>> On 11/27/2023 6:17 PM, Viresh Kumar wrote: On 24-11-23, 15:20, Haixu Cui wrote: > +For half-duplex read transfer, \field{rx_buf} is filled by

[virtio-dev] Re: [virtio-comment] Re: [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-27 Thread Cornelia Huck
On Mon, Nov 27 2023, Cornelia Huck wrote: > On Mon, Nov 27 2023, Haixu Cui wrote: > >> On 11/24/2023 11:46 PM, Cornelia Huck wrote: >>> On Fri, Nov 24 2023, Haixu Cui wrote: >>>> +The \field{chip_select_max_number} is the maximum number of chipselect >

[virtio-dev] Re: [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-27 Thread Cornelia Huck
On Mon, Nov 27 2023, Haixu Cui wrote: > On 11/24/2023 11:46 PM, Cornelia Huck wrote: >> On Fri, Nov 24 2023, Haixu Cui wrote: >>> +The \field{chip_select_max_number} is the maximum number of chipselect the >>> host SPI controller supports. >> >>

[virtio-dev] Re: [PATCH] [PATCH v5] virtio-spi: add the device specification

2023-11-24 Thread Cornelia Huck
On Fri, Nov 24 2023, Haixu Cui wrote: > virtio-spi is a virtual SPI (Serial Peripheral Interface) controller and it > allows > a guest to operate and use the host SPI controller. > > This patch adds the specification for virtio-spi. As Mark has already reviewed it from the SPI POV (thanks!),

Re: [virtio-dev] [PATCH] html: add missing enumitem package

2023-09-28 Thread Cornelia Huck
On Wed, Sep 27 2023, "Michael S. Tsirkin" wrote: > makediffhtml.sh currently fails with: > > ! Missing number, treated as zero. > >\c@* > l.25850 \begin{enumerate}[label=\alph* > .] > ? > ! Emergency stop. > >\c@* >

[virtio-dev] [PATCH virtio-1.3] update acknowledgements for 1.3

2023-08-15 Thread Cornelia Huck
Move some names to the section for previous versions, add names of new contributors, etc. Signed-off-by: Cornelia Huck --- acknowledgements.tex | 124 ++- 1 file changed, 75 insertions(+), 49 deletions(-) diff --git a/acknowledgements.tex b

[virtio-dev] [virtio 1.3] Change freeze has started

2023-08-02 Thread Cornelia Huck
As outlined in https://lists.oasis-open.org/archives/virtio/202304/msg00036.html ff., as part of the release process for the 1.3 version of the virtio spec, we have now entered change freeze. This means that the only changes to the main virtio branch will now be those needed for the 1.3 release

Re: [virtio-dev] [virtio 1.3] Feature freeze has started

2023-07-21 Thread Cornelia Huck
On Mon, Jul 03 2023, Cornelia Huck wrote: > As outlined in > https://lists.oasis-open.org/archives/virtio/202304/msg00036.html ff., > as part of the release process for the 1.3 version of the virtio spec, > we have now entered feature freeze. This means: > > *** > By July

[virtio-dev] Re: 1.3 and branching

2023-07-21 Thread Cornelia Huck
On Fri, Jul 21 2023, "Michael S. Tsirkin" wrote: > On Fri, Jul 21, 2023 at 02:24:57PM +0200, Cornelia Huck wrote: >> On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: >> >> > On Wed, Jul 12, 2023 at 02:24:32PM +0200, Cornelia Huck wrote: >> &

[virtio-dev] 1.3 and branching (was: [virtio-dev] Re: [PATCH v12] virtio-net: support device stats)

2023-07-21 Thread Cornelia Huck
On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: > On Wed, Jul 12, 2023 at 02:24:32PM +0200, Cornelia Huck wrote: >> On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: >> > Yes we were supposed to freeze for 1.3. This change can be merged on a >> >

[virtio-dev] Re: [virtio-comment] Re: [PATCH 0/4] Short document fixes to inner hash feature

2023-07-13 Thread Cornelia Huck
On Thu, Jul 13 2023, Cornelia Huck wrote: > On Thu, Jul 13 2023, Parav Pandit wrote: > >> This short patches fixes the editing errors that stops the pdf and html >> generation. >> >> These 3 fixes are for the patch [1] for the github issue [2]. >> >>

[virtio-dev] Re: [PATCH 2/4] virtio-net: Avoid hyphen and extra braces

2023-07-13 Thread Cornelia Huck
On Thu, Jul 13 2023, Parav Pandit wrote: > Avoid hyphen and replace it with white space like rest of the entries. > Also avoid unnecessary braces. > Name RFC as just RFC without special prefix about it. > > This likely resolves the html generation errors. > > Signed-off-by: Parav Pandit > --- >

[virtio-dev] Re: [virtio-comment] [PATCH 1/4] virtio-net: Place C code under listing

2023-07-13 Thread Cornelia Huck
On Thu, Jul 13 2023, Parav Pandit wrote: > With extra white space for the define, pdf generation fails. > Also place the C code under listing. > > Signed-off-by: Parav Pandit > --- > device-types/net/description.tex | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

[virtio-dev] Re: [PATCH 0/4] Short document fixes to inner hash feature

2023-07-13 Thread Cornelia Huck
On Thu, Jul 13 2023, Parav Pandit wrote: > This short patches fixes the editing errors that stops the pdf and html > generation. > > These 3 fixes are for the patch [1] for the github issue [2]. > > [1] https://lists.oasis-open.org/archives/virtio-comment/202307/msg00024.html > [2]

[virtio-dev] RE: [PATCH 3/4] virtio-net: Use table to describe inner hash to rfc mapping

2023-07-13 Thread Cornelia Huck
On Wed, Jul 12 2023, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Wednesday, July 12, 2023 6:41 PM >> Hmm. escapechar did not work then? > > Forgot to mention, I tried it, it didn't work. It seemed to work for me (at least in the pdf) -- I'd prefer that one as a minimal change.

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v21] virtio-net: support inner header hash

2023-07-12 Thread Cornelia Huck
On Wed, Jul 12 2023, Heng Qi wrote: > 在 2023/7/12 下午9:25, Cornelia Huck 写道: >> ...while the changes above give me a fine pdf, the html generated is >> broken. The problem seems to originate in the normative references that >> are added in introduction.tex, but I don't see

[virtio-dev] Re: [virtio-comment] Re: [PATCH v21] virtio-net: support inner header hash

2023-07-12 Thread Cornelia Huck
On Wed, Jul 12 2023, Heng Qi wrote: > 在 2023/7/12 下午8:42, Cornelia Huck 写道: >> On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: >> >>> On Wed, Jul 12, 2023 at 02:22:26PM +0200, Cornelia Huck wrote: >>>> On Mon, Jul 03 2023, Heng Qi wrote: >&

[virtio-dev] Re: [PATCH v21] virtio-net: support inner header hash

2023-07-12 Thread Cornelia Huck
On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: > On Wed, Jul 12, 2023 at 02:22:26PM +0200, Cornelia Huck wrote: >> On Mon, Jul 03 2023, Heng Qi wrote: >> >> (...) >> >> > +\paragraph{Inner Header Hash} >> > +\label{sec:Device

Re: [virtio-dev] Re: [PATCH v12] virtio-net: support device stats

2023-07-12 Thread Cornelia Huck
On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: > On Wed, Jul 12, 2023 at 07:44:01PM +0800, Xuan Zhuo wrote: >> On Wed, 12 Jul 2023 07:34:38 -0400, "Michael S. Tsirkin" >> wrote: >> > On Tue, Mar 15, 2022 at 11:24:02AM +0800, Xuan Zhuo wrote: >> > > This patch allows the driver to obtain some

[virtio-dev] Re: [PATCH v21] virtio-net: support inner header hash

2023-07-12 Thread Cornelia Huck
On Mon, Jul 03 2023, Heng Qi wrote: (...) > +\paragraph{Inner Header Hash} > +\label{sec:Device Types / Network Device / Device Operation / Processing of > Incoming Packets / Inner Header Hash} > + > +If VIRTIO_NET_F_HASH_TUNNEL has been negotiated, the driver can send the > command >

[virtio-dev] Re: [PATCH v14] admin: Add group member legacy register access commands

2023-07-11 Thread Cornelia Huck
On Mon, Jul 10 2023, "Michael S. Tsirkin" wrote: > On Mon, Jul 10, 2023 at 07:17:52PM +0300, Parav Pandit wrote: >> +The \field{flags} value of 0x1 indicates that the notification address is of >> +the owner device, value of 0x2 indicates that the notification address is of >> +the member

Re: [virtio-dev] [PATCH v13] admin: Add group member legacy register access commands

2023-07-10 Thread Cornelia Huck
On Fri, Jul 07 2023, Parav Pandit wrote: (...) > +When the device supports VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_INFO command, the > group s/supports/supports the/ > +owner device hardwires VF BAR0 to zero in the SR-IOV Extended capability. (...) > +\devicenormative{\paragraph}{Legacy

Re: [virtio-dev][PATCH 1/2] virtio-spi: define the DEVICE ID for virtio SPI master

2023-07-10 Thread Cornelia Huck
On Fri, Jul 07 2023, Haixu Cui wrote: > Hi Michael S. Tsirkin, Cornelia Huck, > I have created an issue > https://github.com/oasis-tcs/virtio-spec/issues/174 to request Device ID > 45 for SPI master. Please help to deal with it, thank you very much. Technically, we're in fe

[virtio-dev] Re: [PATCH v12 0/3] admin: Access legacy registers using admin commands

2023-07-07 Thread Cornelia Huck
On Fri, Jul 07 2023, Parav Pandit wrote: > This short series introduces legacy registers access commands for the owner > group member access the legacy registers of the member VFs. > This short series introduces legacy region access commands by the group owner > device for its member devices. >

[virtio-dev] Re: [PATCH v11 0/3] admin: Access legacy registers using admin commands

2023-07-07 Thread Cornelia Huck
On Thu, Jul 06 2023, "Michael S. Tsirkin" wrote: > On Fri, Jul 07, 2023 at 12:27:19AM +0300, Parav Pandit wrote: >> This short series introduces legacy registers access commands for the owner >> group member access the legacy registers of the member VFs. >> This short series introduces legacy

[virtio-dev] Re: [virtio-comment] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-07 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Thursday, July 6, 2023 4:42 PM > > [..] >> > Can we please avoid this over engineering? >> > Interface has the doors open for driver to make wise decision depending on >> its environment. >> >> what if driver can

[virtio-dev] RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Thursday, July 6, 2023 12:28 PM >> >> On Thu, Jul 06 2023, Parav Pandit wrote: >> >> > diff --git a/transport-pci-legacy-regs.tex >> > b/transport-pci-legacy-regs.tex

[virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-06 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: > diff --git a/transport-pci-legacy-regs.tex b/transport-pci-legacy-regs.tex > new file mode 100644 > index 000..ceea28c > --- /dev/null > +++ b/transport-pci-legacy-regs.tex > @@ -0,0 +1,42 @@ > +\subsection{Legacy Interface: Group member device

[virtio-dev] Re: [PATCH v10 3/4] admin: Add group member legacy register access commands

2023-07-06 Thread Cornelia Huck
On Thu, Jul 06 2023, Parav Pandit wrote: > diff --git a/admin-cmds-legacy-interface.tex b/admin-cmds-legacy-interface.tex > new file mode 100644 > index 000..dd01c0a > --- /dev/null > +++ b/admin-cmds-legacy-interface.tex > @@ -0,0 +1,261 @@ > +\subsubsection{Legacy

[virtio-dev] Re: [PATCH v10 2/4] admin: Fix section numbering

2023-07-06 Thread Cornelia Huck
ion > v4->v5: > - new patch > --- > admin.tex | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional

[virtio-dev] RE: [virtio-comment] [PATCH v9 0/4] admin: Access legacy registers using admin commands

2023-07-05 Thread Cornelia Huck
On Wed, Jul 05 2023, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Wednesday, July 5, 2023 7:09 AM >> >> OK I sent a bunch of comments. Pls try to address, unfortunately I didn't go >> in >> depth over the last patch, but I feel it should be squashed into the generic >> legacy

[virtio-dev] Re: [PATCH v9 4/4] transport-pci: Introduce group legacy group member config region access

2023-07-05 Thread Cornelia Huck
On Wed, Jul 05 2023, Parav Pandit wrote: > diff --git a/admin-cmds-legacy-interface.tex b/admin-cmds-legacy-interface.tex > index 09001d5..571b256 100644 > --- a/admin-cmds-legacy-interface.tex > +++ b/admin-cmds-legacy-interface.tex > @@ -150,7 +150,7 @@ \subsubsection{Legacy

[virtio-dev] Re: [PATCH v9 3/4] admin: Add group member legacy register access commands

2023-07-05 Thread Cornelia Huck
On Wed, Jul 05 2023, Parav Pandit wrote: > diff --git a/admin-cmds-legacy-interface.tex b/admin-cmds-legacy-interface.tex > new file mode 100644 > index 000..09001d5 > --- /dev/null > +++ b/admin-cmds-legacy-interface.tex > @@ -0,0 +1,205 @@ > +\subsubsection{Legacy

[virtio-dev] Re: [PATCH v9 2/4] admin: Fix section numbering

2023-07-05 Thread Cornelia Huck
On Wed, Jul 05 2023, Parav Pandit wrote: > Requirements are put one additional level down. Fix it. > > Signed-off-by: Parav Pandit > --- > changelog: > v4->v5: > - new patch > --- > admin.tex | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Same thing applies to the normative

[virtio-dev] Re: [PATCH v9 1/4] admin: Split opcode table rows with a line

2023-07-05 Thread Cornelia Huck
changed, 2 insertions(+) > Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [PATCH v21] virtio-net: support inner header hash

2023-07-04 Thread Cornelia Huck
On Mon, Jul 03 2023, "Michael S. Tsirkin" wrote: > On Mon, Jul 03, 2023 at 11:27:11PM +0800, Heng Qi wrote: >> 1. Currently, a received encapsulated packet has an outer and an inner >> header, but >> the virtio device is unable to calculate the hash for the inner header. The >> same >> flow

[virtio-dev] [virtio 1.3] Feature freeze has started

2023-07-03 Thread Cornelia Huck
As outlined in https://lists.oasis-open.org/archives/virtio/202304/msg00036.html ff., as part of the release process for the 1.3 version of the virtio spec, we have now entered feature freeze. This means: *** By July 1st[3rd], all not yet integrated features that are targeting 1.3 need to have at

[virtio-dev] Re: [virtio-comment] [RFC] virtio 1.3 schedule

2023-06-30 Thread Cornelia Huck
On Thu, Jun 29 2023, "Michael S. Tsirkin" wrote: > On Thu, Jun 29, 2023 at 05:41:34PM +, Parav Pandit wrote: >> Hi Cornelia, Michael, >> >> > From: virtio-comm...@lists.oasis-open.org > > open.org> On Behalf Of Cornelia Huck >> > Sent: W

[virtio-dev] [virtio 1.3] Reminder: Feature freeze coming up on July 1st

2023-06-05 Thread Cornelia Huck
As outlined in https://lists.oasis-open.org/archives/virtio/202304/msg00036.html ff., we'll soon start the process of getting version 1.3 of the virtio spec released. As a first step, we'll enter feature freeze on July 1st. This means: *** By July 1st, all not yet integrated features that are

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-17 Thread Cornelia Huck
>>> I also hope to be able to update virtio-video at a faster pace. Please >>> let me try. >> >> Please hold on a bit - there are two things here. >> >> 1) I'd like to settle the virtio-v4l2/virtio-video argument first to >> make sure we don't get two things clashing head-on. As far as codecs >>

[virtio-dev] Re: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Cornelia Huck
On Tue, May 16 2023, "Michael S. Tsirkin" wrote: > On Tue, May 16, 2023 at 10:24:12AM +0200, Cornelia Huck wrote: >> On Tue, May 16 2023, "Michael S. Tsirkin" wrote: >> >> > On Tue, May 16, 2023 at 06:01:39AM +0300, Parav Pandit wrote: >> >

[virtio-dev] Re: [PATCH] content: Replace guest OS with driver

2023-05-16 Thread Cornelia Huck
On Tue, May 16 2023, "Michael S. Tsirkin" wrote: > On Tue, May 16, 2023 at 06:01:39AM +0300, Parav Pandit wrote: >> diff --git a/content.tex b/content.tex >> index 9df81b8..417d476 100644 >> --- a/content.tex >> +++ b/content.tex >> @@ -26,10 +26,10 @@ \section{\field{Device Status}

[virtio-dev] Re: [PATCH v17 03/11] content: Rename confusing queue_notify_data and vqn names

2023-05-15 Thread Cornelia Huck
On Fri, May 05 2023, Parav Pandit wrote: > diff --git a/content.tex b/content.tex > index 9cf938c..327926f 100644 > --- a/content.tex > +++ b/content.tex > @@ -405,8 +405,12 @@ \section{Driver Notifications} \label{sec:Basic > Facilities of a Virtio Device / > notification to the device. > >

[virtio-dev] Re: [virtio-comment] [PATCH] admin: Fix reference and table formation

2023-05-08 Thread Cornelia Huck
dhat.com/T/#t > > Signed-off-by: Parav Pandit > --- > admin.tex | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Cornelia Huck Let's push this as an editorial change once the main series is merged. -

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-03 Thread Cornelia Huck
On Wed, May 03 2023, Alex Bennée wrote: > Cornelia Huck writes: > >> On Fri, Apr 28 2023, Alexander Gordeev >> wrote: >> >>> On 27.04.23 15:16, Alexandre Courbot wrote: >>>> But in any case, that's irrelevant to the guest-host interface, and I &g

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-03 Thread Cornelia Huck
On Fri, Apr 28 2023, Alexander Gordeev wrote: > On 27.04.23 15:16, Alexandre Courbot wrote: >> But in any case, that's irrelevant to the guest-host interface, and I >> think a big part of the disagreement stems from the misconception that >> V4L2 absolutely needs to be used on either the guest

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-04-25 Thread Cornelia Huck
[I'm replying here, as that seems to be the last message in the thread, and my reply hopefully catches everyone interested here.] To do a very high level summary, we have (at least) two use cases for virtio-video, that unfortunately have quite different requirements. Both want to encode/decode

[virtio-dev] Re: [PATCH v1] device-types/multiple: replace queues with enqueues

2023-04-21 Thread Cornelia Huck
On Thu, Apr 20 2023, Parav Pandit wrote: > Queue is a verb and noun both. Replacing it with enqueue avoids > ambiguity around plural queues noun vs verb; similar to virtio fs device > description. > > Acked-by: Michael S. Tsirkin > Signed-off-by: Parav Pandit > --- > changelog: > v0->v1: > -

[virtio-dev] Re: [PATCH] device-types/multiple: replace queues with enqueues

2023-04-19 Thread Cornelia Huck
On Tue, Apr 11 2023, Parav Pandit wrote: > Queue is a verb and noun both. Replacing it with enqueue avoids > ambiguity around plural queues noun vs verb; similar to virtio fs device > description. Personally, I don't think this patch adds much, but I don't really mind it, either. > >

Re: [virtio-dev] [PATCH v13 03/11] content: Rename confusing queue_notify_data and vqn names

2023-04-18 Thread Cornelia Huck
On Tue, Apr 18 2023, Halil Pasic wrote: > On Mon, 17 Apr 2023 20:53:32 + > Parav Pandit wrote: > >> > From: Halil Pasic >> > Sent: Sunday, April 16, 2023 11:42 PM > [..] >> > >> > > @@ -1053,9 +1059,9 @@ \subsubsection{Available Buffer >> > > Notifications}\label{sec:Virtio Transport

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] [PATCH v13 03/11] content: Rename confusing queue_notify_data and vqn names

2023-04-18 Thread Cornelia Huck
On Tue, Apr 18 2023, Parav Pandit wrote: >> From: Halil Pasic >> Sent: Tuesday, April 18, 2023 7:40 AM >> >> IMHO VIRTIO_F_NOTIFY_CONFIG_DATA should remain aligned with >> VIRTIO_F_NOTIFICATION_DATA in one way or another. Thus way out would be >> to do something like: >>

Re: [virtio-dev][PATCH 2/2] virtio-spi: add the device specification

2023-04-18 Thread Cornelia Huck
On Mon, Apr 17 2023, Haixu Cui wrote: Meta comment: I think you want to send to virtio-comment (feel free to keep virtio-dev on cc:). > virtio-spi is a virtual SPI master and it allows a guset to operate and > use the physical SPI master controlled by the host. > --- >

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-04-17 Thread Cornelia Huck
On Mon, Apr 17 2023, Alexander Gordeev wrote: > Hi Alexandre, > > Thanks for you letter! Sorry, it took me some time to write an answer. > > First of all I'd like to describe my perspective a little bit because it > seems, that in many cases we (and other people writing their feedbacks) >

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-04-17 Thread Cornelia Huck
On Mon, Apr 17 2023, Alexander Gordeev wrote: > Hello Cornelia, > > On 17.04.23 14:56, Cornelia Huck wrote: >> On Sat, Apr 15 2023, Alexandre Courbot wrote: >> >>> If nobody strongly objects, I think this can be pushed a bit more >>> officially. Cornel

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-04-17 Thread Cornelia Huck
On Sat, Apr 15 2023, Alexandre Courbot wrote: > If nobody strongly objects, I think this can be pushed a bit more > officially. Cornelia, would you consider it for inclusion if I > switched the next version of the specification to use V4L2 as the > host/guest protocol? This may take some more

[virtio-dev] Participation (was: Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names)

2023-04-17 Thread Cornelia Huck
On Mon, Apr 17 2023, "Michael S. Tsirkin" wrote: > I am not saying don't give feedback but I'm saying please help us > all be more organized, feedback time really should be within a > day or two, in rare cases up to a week. Given that there are things like weekends, public holidays, etc. one

[virtio-dev] Re: [virtio-comment] [RFC] virtio 1.3 schedule

2023-04-12 Thread Cornelia Huck
On Fri, Apr 07 2023, "Michael S. Tsirkin" wrote: > On Wed, Apr 05, 2023 at 03:57:09PM +0200, Cornelia Huck wrote: >> That said, let me propose the following timeline: >> >> - July 1st 2023: enter feature freeze; all proposed changes must at >> least

[virtio-dev] Re: [virtio-comment] [PATCH] introduction: Add missing helping verb

2023-04-12 Thread Cornelia Huck
On Tue, Apr 11 2023, Parav Pandit wrote: > The terminology of Transitional device and driver is missing the helping > verb 'is' similar to other terminologies. > > Hence, add them to complete the sentence. > > Signed-off-by: Parav Pandit > --- > introduction.tex | 4 ++-- > 1 file changed, 2

Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation

2023-04-11 Thread Cornelia Huck
On Tue, Apr 11 2023, "Michael S. Tsirkin" wrote: > On Tue, Apr 11, 2023 at 10:05:11AM +0200, Cornelia Huck wrote: >> On Thu, Mar 23 2023, Heng Qi wrote: >> >> > Hi all! If after reviewing it you feel it meets the necessary >> > requirements, I ki

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names

2023-04-11 Thread Cornelia Huck
On Fri, Apr 07 2023, "Michael S. Tsirkin" wrote: > On Wed, Apr 05, 2023 at 03:58:55PM +, Parav Pandit wrote: >> For sure "cookie" is better than "config_data" and I don't have objection to >> "cookie". >> >> But I disagree to the claim that "identifier" is less good than "cookie". >> >>

[virtio-dev] Re: [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-11 Thread Cornelia Huck
On Mon, Apr 10 2023, "Michael S. Tsirkin" wrote: > On Mon, Apr 10, 2023 at 07:57:08PM +, Parav Pandit wrote: >> >> > From: Michael S. Tsirkin >> > Sent: Monday, April 10, 2023 3:49 PM >> >> > Attribution is nice but Signed-off-by is not that. >> >> Then what is Signed-off-by for virtio

Re: [virtio-dev] [PATCH v14] virtio-net: support the virtqueue coalescing moderation

2023-04-11 Thread Cornelia Huck
On Thu, Mar 23 2023, Heng Qi wrote: > Hi all! If after reviewing it you feel it meets the necessary > requirements, I kindly request a vote. > > Thanks a lot! > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/166 So this has been voted upon and accepted, but we have further discussion

[virtio-dev] [RFC] virtio 1.3 schedule

2023-04-05 Thread Cornelia Huck
The virtio 1.2 spec has been released on July 1st, 2022, so I think we should come up with a plan for the 1.3 release. Given that it took us several months last time, we need to think about declaring freeze during (northern hemisphere) summer if we want to have a release ready before the

[virtio-dev] Re: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names

2023-04-05 Thread Cornelia Huck
On Wed, Apr 05 2023, "Michael S. Tsirkin" wrote: > On Wed, Apr 05, 2023 at 04:06:50AM +0300, Parav Pandit wrote: >> diff --git a/content.tex b/content.tex >> index cd93db2..d5f8026 100644 >> --- a/content.tex >> +++ b/content.tex >> @@ -405,8 +405,18 @@ \section{Driver Notifications}

[virtio-dev] Re: [PATCH v12 02/10] content.tex Replace virtqueue number with index

2023-04-05 Thread Cornelia Huck
ew patch > --- > content.tex | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number

2023-04-04 Thread Cornelia Huck
On Tue, Apr 04 2023, Halil Pasic wrote: > On Tue, 4 Apr 2023 03:07:26 -0400 > "Michael S. Tsirkin" wrote: > >> > 3. Once interrupt moderation series is merged, rename vqn to vq_index. >> > (really vqn reads better even though history say vq index). >> > Because votes is completed and voting

[virtio-dev] Re: [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-04 Thread Cornelia Huck
On Tue, Apr 04 2023, "Michael S. Tsirkin" wrote: > On Tue, Apr 04, 2023 at 09:54:55AM +0200, Cornelia Huck wrote: >> On Tue, Apr 04 2023, "Michael S. Tsirkin" wrote: >> >> > On Fri, Mar 31, 2023 at 01:58:31AM +0300, Parav Pandit wrote: >>

[virtio-dev] RE: [virtio-comment] [PATCH 0/3] transport-pci: msix summary update

2023-04-04 Thread Cornelia Huck
On Mon, Apr 03 2023, Parav Pandit wrote: > Hi Cornelia, > >> From: Xuan Zhuo >> Sent: Monday, March 27, 2023 2:09 AM >> Series: >> >> Reviewed-by: Xuan Zhuo >> > > It is editorial change rewording the text. > Can you please take this short series forward? Patch 1 (which Michael has already

[virtio-dev] Re: [virtio-comment] RE: [PATCH v10 8/8] virtio-net: Describe RSS using rss rq id

2023-04-04 Thread Cornelia Huck
On Mon, Apr 03 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Thursday, March 30, 2023 5:17 AM >> > +Field \field{indirection_table} is an array of receive virtqueues. >> >> "an array of receive virtqueues identified via their rss_rq_i

  1   2   3   4   5   6   7   >