Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

On 2/21/2019 7:33 PM, si-wei liu wrote: On 2/21/2019 5:39 PM, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at 05:14:44PM -0800, Siwei Liu wrote: Sorry for replying to this ancient thread. There was some remaining issue that I don't think the initial net_failover patch got addressed

[virtio-dev] Re: [Qemu-devel] [PATCH v3 1/5] virtio_net: Add VIRTIO_NET_F_STANDBY feature bit.

On 1/8/2019 4:14 PM, Dongli Zhang wrote: Hi Venu, On 2019/1/9 上午1:25, Venu Busireddy wrote: On 2019-01-09 00:56:38 +0800, Dongli Zhang wrote: I am not familiar with libvirt and I would like to play with this only with qemu. With failover, we need to hotplug the VF on destination server to

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On 11/29/2018 4:24 PM, si-wei liu wrote: On 11/29/2018 3:53 PM, Samudrala, Sridhar wrote: On 11/29/2018 2:53 PM, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On 11/28/2018 9:08 AM, Michael S. Tsirkin wrote: On Mon, Nov 26, 2018 at 12:22:56PM -0800, Samudrala, Sridhar wrote: Update: I have just set the vf mac's address to 0 (ip link set ens2f0 vf 1 mac 00:00:00:00:00:00) after unplugging it (the primary device) and the pings started working again

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On 11/26/2018 7:43 AM, Sameeh Jubran wrote: On Mon, Nov 26, 2018 at 5:13 PM Sameeh Jubran wrote: On Thu, Nov 22, 2018 at 8:27 PM Michael S. Tsirkin wrote: On Wed, Nov 21, 2018 at 10:04:53PM +0200, Sameeh Jubran wrote: On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote: Great to see

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On 11/21/2018 12:04 PM, Sameeh Jubran wrote: On Wed, Nov 21, 2018 at 8:41 PM Michael S. Tsirkin wrote: Great to see you making progress on this! Some comments below: On Wed, Nov 21, 2018 at 05:39:38PM +0200, Sameeh Jubran wrote: I have created a setup which has two hosts (host A and host B)

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On 10/10/2018 7:40 AM, Michael S. Tsirkin wrote: On Thu, Oct 04, 2018 at 10:17:04PM -0700, Samudrala, Sridhar wrote: On 10/4/2018 5:03 PM, Siwei Liu wrote: On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: The VF's MAC can

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On 10/4/2018 5:03 PM, Siwei Liu wrote: On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: The VF's MAC can be updated by PF/host on the fly at any time. One can start with a random MAC but use group ID to pair device instead.

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On 9/18/2018 6:25 AM, Michael S. Tsirkin wrote: On Tue, Sep 18, 2018 at 01:37:35PM +0300, Sameeh Jubran wrote: On Tue, Sep 18, 2018 at 1:21 PM Cornelia Huck wrote: On Wed, 12 Sep 2018 11:22:12 -0400 "Michael S. Tsirkin" wrote: On Wed, Sep 12, 2018 at 08:17:45AM -0700, Samudral

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On 9/7/2018 2:34 PM, Michael S. Tsirkin wrote: On Wed, Aug 15, 2018 at 11:49:15AM -0700, Sridhar Samudrala wrote: VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. Signed-off-by: Sridhar Samudrala

[virtio-dev] Re: [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On 8/27/2018 5:34 AM, Michael S. Tsirkin wrote: On Mon, Aug 27, 2018 at 10:40:35AM +0200, Cornelia Huck wrote: On Wed, 15 Aug 2018 11:49:15 -0700 Sridhar Samudrala wrote: VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net device to act as a standby for another device with

Re: [virtio-dev] Re: [PATCH v3] content: Introduce VIRTIO_NET_F_STANDBY feature

> On Jul 27, 2018, at 6:03 AM, Michael S. Tsirkin wrote: > >> On Fri, Jul 27, 2018 at 02:58:59PM +0200, Cornelia Huck wrote: >> On Wed, 25 Jul 2018 09:40:40 -0700 >> Sridhar Samudrala wrote: >> >>> VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net >>> device to act as a

Re: [virtio-dev] Re: [PATCH v2] content: Introduce VIRTIO_NET_F_STANDBY feature

On 7/24/2018 5:43 AM, Cornelia Huck wrote: On Mon, 23 Jul 2018 10:02:35 -0700 Sridhar Samudrala wrote: VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net device to act as a standby for a primary device with the same MAC address. Signed-off-by: Sridhar Samudrala

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On 6/26/2018 11:21 PM, Siwei Liu wrote: On Tue, Jun 26, 2018 at 5:29 PM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 04:38:26PM -0700, Siwei Liu wrote: On Mon, Jun 25, 2018 at 6:50 PM, Michael S. Tsirkin wrote: On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: Might

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On 6/22/2018 5:17 PM, Siwei Liu wrote: On Fri, Jun 22, 2018 at 4:40 PM, Siwei Liu wrote: On Fri, Jun 22, 2018 at 3:25 PM, Michael S. Tsirkin wrote: On Fri, Jun 22, 2018 at 02:51:11PM -0700, Siwei Liu wrote: On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: On Fri, Jun 22, 2018 at

[virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

this code to management as well, architecturally it does not make too much sense but it might be easier implementation-wise. HTH On Mon, Jun 04, 2018 at 06:41:48PM -0700, Samudrala, Sridhar wrote: Ping on this patch now that the kernel patches are accepted into davem's net-next tree. https://patchwork.

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On 6/12/2018 4:34 AM, Michael S. Tsirkin wrote: On Mon, Jun 11, 2018 at 10:02:45PM -0700, Samudrala, Sridhar wrote: On 6/11/2018 7:17 PM, Michael S. Tsirkin wrote: On Tue, Jun 12, 2018 at 09:54:44AM +0800, Jason Wang wrote: On 2018年06月12日 01:26, Michael S. Tsirkin wrote: On Mon, May 07, 2018

[virtio-dev] Re: [libvirt] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On 6/6/2018 11:52 AM, Ján Tomko wrote: On Wed, Jun 06, 2018 at 11:17:36AM -0700, Samudrala, Sridhar wrote: On 6/4/2018 7:06 PM, Jason Wang wrote: On 2018年06月05日 09:41, Samudrala, Sridhar wrote: Ping on this patch now that the kernel patches are accepted into davem's net-next tree. https

[virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On 6/4/2018 7:06 PM, Jason Wang wrote: On 2018年06月05日 09:41, Samudrala, Sridhar wrote: Ping on this patch now that the kernel patches are accepted into davem's net-next tree. https://patchwork.ozlabs.org/cover/920005/ On 5/7/2018 4:09 PM, Sridhar Samudrala wrote: This feature bit can

[virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

Ping on this patch now that the kernel patches are accepted into davem's net-next tree. https://patchwork.ozlabs.org/cover/920005/ On 5/7/2018 4:09 PM, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with

Re: [virtio-dev] RFC: Use of bridge devices to store pairing information...

On 6/1/2018 8:48 AM, Michael S. Tsirkin wrote: On Fri, Jun 01, 2018 at 08:26:03AM -0700, Samudrala, Sridhar wrote: On 5/31/2018 6:28 PM, Venu Busireddy wrote: I looked at the discussion in the threads [1] and [2], where it was suggested placing the passthrough device behind one bridge

Re: [virtio-dev] RFC: Use of bridge devices to store pairing information...

On 5/31/2018 6:28 PM, Venu Busireddy wrote: I looked at the discussion in the threads [1] and [2], where it was suggested placing the passthrough device behind one bridge, and the virtio device behind another bridge, and storing in those bridges' configuration space some unique identifier that

[virtio-dev] Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On 5/30/2018 7:06 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala wrote: Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar Samudrala Why was this merged? It was never signed off by any

[virtio-dev] Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

On 5/30/2018 7:52 PM, Stephen Hemminger wrote: On Fri, 25 May 2018 16:06:58 -0700 "Samudrala, Sridhar" wrote: On 5/25/2018 3:38 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:13 -0700 Sridhar Samudrala wrote: diff --git a/include/linux/netdevice.h b/include/linux/n

[virtio-dev] Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

'On 5/26/2018 12:51 AM, Jiri Pirko wrote: Sat, May 26, 2018 at 09:22:18AM CEST, sridhar.samudr...@intel.com wrote: On 5/25/2018 4:28 PM, Stephen Hemminger wrote: On Fri, 25 May 2018 16:11:47 -0700 "Samudrala, Sridhar" <sridhar.samudr...@intel.com> wrote: On 5/25/2018

[virtio-dev] Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On 5/25/2018 3:34 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala wrote: --- a/drivers/net/hyperv/Kconfig +++ b/drivers/net/hyperv/Kconfig @@ -2,5 +2,6 @@ config HYPERV_NET tristate "Microsoft Hyper-V virtual network

[virtio-dev] Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

On 5/25/2018 3:37 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:13 -0700 Sridhar Samudrala wrote: + spin_lock(_lock); Since register is not in fast path, this should be a mutex? This is Jiri's comment which made me to switch to spinlock from

[virtio-dev] Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On 5/22/2018 9:12 AM, Jiri Pirko wrote: Fixing the subj, sorry about that. Tue, May 22, 2018 at 05:46:21PM CEST, m...@redhat.com wrote: On Tue, May 22, 2018 at 05:36:14PM +0200, Jiri Pirko wrote: Tue, May 22, 2018 at 05:28:42PM CEST, sridhar.samudr...@intel.com wrote: On 5/22/2018 2:08 AM,

[virtio-dev] Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On 5/22/2018 2:08 AM, Jiri Pirko wrote: Tue, May 22, 2018 at 11:06:37AM CEST, j...@resnulli.us wrote: Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudr...@intel.com wrote: Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar

[virtio-dev] Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On 5/7/2018 3:39 PM, Randy Dunlap wrote: Hi, On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: Signed-off-by: Sridhar Samudrala --- MAINTAINERS|7 + include/linux/netdevice.h | 16 + include/net/net_failover.h | 52 +++ net/Kconfig

[virtio-dev] Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On 5/7/2018 4:46 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same

[virtio-dev] Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On 5/7/2018 4:53 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: +static struct net_device *net_failover_get_bymac(u8 *mac, +struct net_failover_ops **ops) +{ + struct

[virtio-dev] Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On 5/7/2018 4:59 PM, Stephen Hemminger wrote: On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala wrote: + if (netif_running(failover_dev)) { + err = dev_open(slave_dev); + if (err && (err != -EBUSY)) { +

[virtio-dev] Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

On 5/2/2018 1:30 PM, Michael S. Tsirkin wrote: On Wed, May 02, 2018 at 10:51:12AM -0700, Samudrala, Sridhar wrote: On 5/2/2018 9:15 AM, Jiri Pirko wrote: Sat, Apr 28, 2018 at 11:06:01AM CEST, j...@resnulli.us wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote

[virtio-dev] Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

On 5/2/2018 9:15 AM, Jiri Pirko wrote: Sat, Apr 28, 2018 at 11:06:01AM CEST, j...@resnulli.us wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: [...] + + err = netdev_rx_handler_register(slave_dev, net_failover_handle_frame, +

[virtio-dev] Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 5/2/2018 12:50 AM, Jiri Pirko wrote: Wed, May 02, 2018 at 02:20:26AM CEST, sridhar.samudr...@intel.com wrote: On 4/30/2018 12:20 AM, Jiri Pirko wrote: Now I try to change mac of the failover master: [root@test1 ~]# ip link set ens3 addr 52:54:00:b2:a7:f3 RTNETLINK answers: Operation not

[virtio-dev] Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/30/2018 12:20 AM, Jiri Pirko wrote: Now I try to change mac of the failover master: [root@test1 ~]# ip link set ens3 addr 52:54:00:b2:a7:f3 RTNETLINK answers: Operation not supported That I did expect to work. I would expect this would change the mac of the master and both standby and

[virtio-dev] Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/30/2018 12:12 AM, Jiri Pirko wrote: Mon, Apr 30, 2018 at 05:00:33AM CEST, sridhar.samudr...@intel.com wrote: On 4/28/2018 1:24 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when

[virtio-dev] Re: [PATCH net-next v9 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit

On 4/30/2018 12:03 AM, Jiri Pirko wrote: Mon, Apr 30, 2018 at 04:47:03AM CEST, sridhar.samudr...@intel.com wrote: On 4/28/2018 12:50 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:57PM CEST,sridhar.samudr...@intel.com wrote: This feature bit can be used by hypervisor to indicate

[virtio-dev] Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/28/2018 2:42 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:59PM CEST,sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF

[virtio-dev] Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

On 4/28/2018 2:06 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their

[virtio-dev] Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/28/2018 1:24 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF

[virtio-dev] Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

On 4/28/2018 1:15 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST,sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their

[virtio-dev] Re: [PATCH net-next v9 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit

On 4/28/2018 12:50 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:57PM CEST,sridhar.samudr...@intel.com wrote: This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. VIRTIO_NET_F_STANDBY is defined as bit 62

[virtio-dev] Re: [PATCH net-next v9 0/4] Enable virtio_net to act as a standby for a passthru device

On 4/27/2018 10:45 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:56PM CEST, sridhar.samudr...@intel.com wrote: v9: Select NET_FAILOVER automatically when VIRTIO_NET/HYPERV_NET are enabled. (stephen) Tested live migration with virtio-net/AVF(i40evf) configured in failover mode while running

[virtio-dev] Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On 4/26/2018 5:09 PM, Michael S. Tsirkin wrote: On Thu, Apr 26, 2018 at 03:33:26PM -0700, Stephen Hemminger wrote: On Thu, 26 Apr 2018 05:30:05 +0300 "Michael S. Tsirkin" wrote: On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote: On Wed, 25 Apr 2018 16:59:28

[virtio-dev] Re: [PATCH v7 net-next 2/4] net: Introduce generic failover module

On 4/22/2018 10:06 AM, Michael S. Tsirkin wrote: On Thu, Apr 19, 2018 at 06:42:02PM -0700, Sridhar Samudrala wrote: +#if IS_ENABLED(CONFIG_NET_FAILOVER) + +int failover_create(struct net_device *standby_dev, + struct failover **pfailover); Should we rename all these structs

[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On 4/20/2018 8:28 AM, Stephen Hemminger wrote: On Thu, 19 Apr 2018 18:42:04 -0700 Sridhar Samudrala wrote: Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar Samudrala

[virtio-dev] Re: [PATCH v7 net-next 2/4] net: Introduce generic failover module

On 4/19/2018 7:44 PM, Michael S. Tsirkin wrote: On Thu, Apr 19, 2018 at 06:42:02PM -0700, Sridhar Samudrala wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On 4/18/2018 10:07 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 10:00:51PM -0700, Samudrala, Sridhar wrote: On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On 4/17/2018 5:26 PM, Siwei Liu wrote: I ran this with a few folks offline and gathered some good feedbacks that I'd like to share thus revive the discussion. First of all, as illustrated in the reply below, cloud service providers require transparent live migration. Specifically, the main

[virtio-dev] Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

On 4/18/2018 2:25 AM, Jiri Pirko wrote: Wed, Apr 11, 2018 at 09:13:52PM CEST, sridhar.samudr...@intel.com wrote: On 4/11/2018 8:51 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen

[virtio-dev] Re: [RFC PATCH net-next v6 2/4] net: Introduce generic bypass module

On 4/11/2018 8:51 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 08:59:48PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their

[virtio-dev] Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/10/2018 11:03 PM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:59:02PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 8:43 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 8:22 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at

[virtio-dev] Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework

On 4/10/2018 2:26 PM, Stephen Hemminger wrote: On Tue, 10 Apr 2018 11:59:50 -0700 Sridhar Samudrala wrote: Use the registration/notification framework supported by the generic bypass infrastructure. Signed-off-by: Sridhar Samudrala

[virtio-dev] Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/10/2018 8:43 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 8:22 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 3:55 AM, Jiri Pirko wrote: Mon, Apr 09, 2018 at

[virtio-dev] Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/10/2018 8:22 AM, Jiri Pirko wrote: Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudr...@intel.com wrote: On 4/10/2018 3:55 AM, Jiri Pirko wrote: Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudr...@intel.com wrote: On 4/9/2018 1:07 AM, Jiri Pirko wrote: Sat, Apr 07, 2018 at

[virtio-dev] Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/10/2018 3:55 AM, Jiri Pirko wrote: Mon, Apr 09, 2018 at 08:47:06PM CEST, sridhar.samudr...@intel.com wrote: On 4/9/2018 1:07 AM, Jiri Pirko wrote: Sat, Apr 07, 2018 at 12:59:14AM CEST, sridhar.samudr...@intel.com wrote: On 4/6/2018 5:48 AM, Jiri Pirko wrote: Thu, Apr 05, 2018 at

[virtio-dev] Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/9/2018 1:07 AM, Jiri Pirko wrote: Sat, Apr 07, 2018 at 12:59:14AM CEST, sridhar.samudr...@intel.com wrote: On 4/6/2018 5:48 AM, Jiri Pirko wrote: Thu, Apr 05, 2018 at 11:08:22PM CEST, sridhar.samudr...@intel.com wrote: [...] +static int virtnet_bypass_join_child(struct net_device

[virtio-dev] Re: [RFC PATCH net-next v5 2/4] net: Introduce generic bypass module

On 4/6/2018 5:57 AM, Jiri Pirko wrote: Thu, Apr 05, 2018 at 11:08:21PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their

[virtio-dev] Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On 4/6/2018 5:48 AM, Jiri Pirko wrote: Thu, Apr 05, 2018 at 11:08:22PM CEST, sridhar.samudr...@intel.com wrote: + +static void virtnet_bypass_set_rx_mode(struct net_device *dev) +{ + struct virtnet_bypass_info *vbi = netdev_priv(dev); + struct net_device *child_netdev;

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/12/2018 2:08 PM, Jiri Pirko wrote: Mon, Mar 12, 2018 at 09:58:06PM CET, sridhar.samudr...@intel.com wrote: On 3/12/2018 1:12 PM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/12/2018 3:44 PM, Siwei Liu wrote: Apologies, still some comments going. Please see inline. On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/12/2018 1:12 PM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/7/2018 12:11 PM, Michael S. Tsirkin wrote: On Wed, Mar 07, 2018 at 10:06:30AM -0800, Stephen Hemminger wrote: On Wed, 7 Mar 2018 09:50:50 -0800 Alexander Duyck wrote: On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: On Tue, Mar 06,

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/4/2018 10:50 AM, Jiri Pirko wrote: Sun, Mar 04, 2018 at 07:24:12PM CET, alexander.du...@gmail.com wrote: On Sat, Mar 3, 2018 at 11:13 PM, Jiri Pirko wrote: Sun, Mar 04, 2018 at 01:26:53AM CET, alexander.du...@gmail.com wrote: On Sat, Mar 3, 2018 at 1:25 PM, Jiri

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/2/2018 1:11 PM, Siwei Liu wrote: On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/2/2018 8:20 AM, Jiri Pirko wrote: Fri, Mar 02, 2018 at 04:26:25PM CET, alexander.du...@gmail.com wrote: On Fri, Mar 2, 2018 at 12:36 AM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch

[virtio-dev] Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On 2/21/2018 6:35 PM, Samudrala, Sridhar wrote: On 2/21/2018 5:59 PM, Siwei Liu wrote: On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu <losewe...@gmail.com> wrote: I haven't checked emails for

[virtio-dev] Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On 2/21/2018 5:59 PM, Siwei Liu wrote: On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck wrote: On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu wrote: I haven't checked emails for days and did not realize the new revision had already came out. And

[virtio-dev] Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On 2/20/2018 8:29 AM, Jiri Pirko wrote: Tue, Feb 20, 2018 at 05:04:29PM CET, alexander.du...@gmail.com wrote: On Tue, Feb 20, 2018 at 2:42 AM, Jiri Pirko wrote: Fri, Feb 16, 2018 at 07:11:19PM CET, sridhar.samudr...@intel.com wrote: Patch 1 introduces a new feature bit

[virtio-dev] Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On 2/18/2018 10:11 PM, Jakub Kicinski wrote: On Sat, 17 Feb 2018 09:12:01 -0800, Alexander Duyck wrote: We noticed a couple of issues with this approach during testing. - As both 'bypass' and 'backup' netdevs are associated with the same virtio pci device, udev tries to rename both of them

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/28/2018 12:18 PM, Alexander Duyck wrote: On Sun, Jan 28, 2018 at 11:18 AM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: On 1/28/2018 9:35 AM, Alexander Duyck wrote: On Fri, Jan 26, 2018 at 9:58 PM, Jakub Kicinski <kubak...@wp.pl> wrote: On Fri, 26 Jan 2018 21

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/28/2018 9:35 AM, Alexander Duyck wrote: On Fri, Jan 26, 2018 at 9:58 PM, Jakub Kicinski <kubak...@wp.pl> wrote: On Fri, 26 Jan 2018 21:33:01 -0800, Samudrala, Sridhar wrote: 3 netdev model breaks this configuration starting with the creation and naming of the 2 devices to udev n

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/26/2018 2:47 PM, Jakub Kicinski wrote: On Sat, 27 Jan 2018 00:14:20 +0200, Michael S. Tsirkin wrote: On Fri, Jan 26, 2018 at 01:46:42PM -0800, Siwei Liu wrote: and the VM is not expected to do any tuning/optimizations on the VF driver directly, i think the current patch that follows the

[virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/26/2018 8:58 AM, Michael S. Tsirkin wrote: On Thu, Jan 11, 2018 at 09:58:39PM -0800, Sridhar Samudrala wrote: @@ -2859,6 +3123,42 @@ static struct virtio_driver virtio_net_driver = { #endif }; +static int virtio_netdev_event(struct notifier_block *this, +

[virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/23/2018 2:33 AM, Jason Wang wrote: On 2018年01月12日 13:58, Sridhar Samudrala wrote:   static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)   {   struct virtnet_info *vi = netdev_priv(dev);   int qnum = skb_get_queue_mapping(skb);   struct send_queue *sq

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/22/2018 7:36 PM, Alexander Duyck wrote: On Mon, Jan 22, 2018 at 6:04 PM, Michael S. Tsirkin <m...@redhat.com> wrote: On Mon, Jan 22, 2018 at 05:34:37PM -0800, Samudrala, Sridhar wrote: On 1/22/2018 4:05 PM, Michael S. Tsirkin wrote: On Mon, Jan 22, 2018 at 03:27:40PM -0800, Sam

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/22/2018 4:02 PM, Stephen Hemminger wrote: In the case of SwitchDev it should be possible for the port representors and the switch to provide data on which interfaces are bonded on the host side and which aren't. With that data it would be pretty easy to just put together a list of

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/22/2018 4:05 PM, Michael S. Tsirkin wrote: On Mon, Jan 22, 2018 at 03:27:40PM -0800, Samudrala, Sridhar wrote: You could probably even handle the Tx queue selection via a simple eBPF program and map since the input for whatever is used to select Tx should be pretty simple, destination MAC

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/22/2018 1:31 PM, Michael S. Tsirkin wrote: On Wed, Jan 17, 2018 at 01:49:58PM -0800, Alexander Duyck wrote: On Wed, Jan 17, 2018 at 11:57 AM, Michael S. Tsirkin <m...@redhat.com> wrote: On Wed, Jan 17, 2018 at 11:25:41AM -0800, Samudrala, Sridhar wrote: On 1/17/2018 11:02 AM, Mic

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/17/2018 11:02 AM, Michael S. Tsirkin wrote: On Wed, Jan 17, 2018 at 10:15:52AM -0800, Alexander Duyck wrote: On Thu, Jan 11, 2018 at 9:58 PM, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net device to act as a

[virtio-dev] Re: [PATCH net-next 0/2] Enable virtio to act as a master for a passthru device

On 1/3/2018 10:28 AM, Alexander Duyck wrote: On Wed, Jan 3, 2018 at 10:14 AM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: On 1/3/2018 8:59 AM, Alexander Duyck wrote: On Tue, Jan 2, 2018 at 6:16 PM, Jakub Kicinski <kubak...@wp.pl> wrote: On Tue, 2 Jan 2018 16:35:36 -0

[virtio-dev] Re: [PATCH net-next 1/2] virtio_net: Introduce VIRTIO_NET_F_MASTER feature bit

On 1/3/2018 9:43 AM, Michael S. Tsirkin wrote: On Tue, Jan 02, 2018 at 04:35:37PM -0800, Sridhar Samudrala wrote: This feature bit can be used by hypervisor to indicate virtio_net device to act as a master for a directly attached passthru device with the same MAC address. Signed-off-by:

[virtio-dev] Re: [PATCH net-next 0/2] Enable virtio to act as a master for a passthru device

On 1/3/2018 8:59 AM, Alexander Duyck wrote: On Tue, Jan 2, 2018 at 6:16 PM, Jakub Kicinski wrote: On Tue, 2 Jan 2018 16:35:36 -0800, Sridhar Samudrala wrote: This patch series enables virtio to switch over to a VF datapath when a VF netdev is present with the same MAC