[virtio-dev] virtio-net ip restriction.

2023-08-08 Thread Xuan Zhuo
## Background For cloud, the ip restriction is important. Because the user of the vm is untrustworthy. One user may use the ip of another to config the netdevice to receive and send packets. So we need to restrict the ip traffic of the device(or port). ## Implement Now we have these choice: 1.

[virtio-dev] Re: RE: RE: RE: RE: RE: [virtio-comment] RE: RE: RE: RE: [RFC] virtio-net: support access and control the member devices

2023-08-08 Thread Xuan Zhuo
On Tue, 8 Aug 2023 04:16:59 +, Parav Pandit wrote: > > > From: Jason Wang > > Sent: Tuesday, August 8, 2023 9:21 AM > > > > The idea is to introduce filters on the new virtio switch object for tx > > > and rx > > both. > > > > It can be done in this way for sure but the question is why it

[virtio-dev] Re: RE: RE: RE: RE: [virtio-comment] RE: RE: RE: RE: [RFC] virtio-net: support access and control the member devices

2023-08-08 Thread Xuan Zhuo
On Tue, 8 Aug 2023 13:21:23 +0800, Jason Wang wrote: > On Tue, Aug 8, 2023 at 12:38 PM Parav Pandit wrote: > > > > > > > From: Jason Wang > > > Sent: Tuesday, August 8, 2023 10:03 AM > > > > > > This option because it is in use by very big and mature eco system of > > > > multiple > > > sw

[virtio-dev] Re: RE: RE: RE: RE: RE: [virtio-comment] RE: RE: RE: RE: [RFC] virtio-net: support access and control the member devices

2023-08-07 Thread Xuan Zhuo
On Tue, 8 Aug 2023 03:16:44 +, Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Tuesday, August 8, 2023 8:39 AM > > > > > Yes, but even for TX, would it be better to filter the IP as early as > > possible in the > > TX path other than depend on the switch to do that? > > The idea is

[virtio-dev] Re: RE: RE: RE: RE: [virtio-comment] RE: RE: RE: RE: [RFC] virtio-net: support access and control the member devices

2023-08-07 Thread Xuan Zhuo
On Fri, 4 Aug 2023 12:49:04 +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Friday, August 4, 2023 4:03 PM > > > > > > > > > At this point to have port for owner device requires creating a > > > > dedicated > > switching object, to be located sometimes side by side inside

Re: [virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-07-02 Thread Xuan Zhuo
On Wed, 28 Jun 2023 11:41:02 -0400, "Michael S. Tsirkin" wrote: > On Wed, Jun 28, 2023 at 10:21:04AM +0800, Xuan Zhuo wrote: > > On Tue, 27 Jun 2023 12:02:41 -0400, "Michael S. Tsirkin" > > wrote: > > > On Tue, Jun 27, 2023 at 04:23:05PM +0800

[virtio-dev] Re: [virtio-comment] [RFC PATCH] admin-queue: bind the group member to the device

2023-06-27 Thread Xuan Zhuo
On Tue, 27 Jun 2023 12:02:41 -0400, "Michael S. Tsirkin" wrote: > On Tue, Jun 27, 2023 at 04:23:05PM +0800, Xuan Zhuo wrote: > > So, this is how I understand the process of creating vf: > > > > 1. Create a PCI VF, at this time there may be no backend virtio device

[virtio-dev] Re: [virtio-comment] Re: About custom device counter

2023-06-19 Thread Xuan Zhuo
On Mon, 19 Jun 2023 10:25:38 -0400, "Michael S. Tsirkin" wrote: > On Thu, Jun 15, 2023 at 02:23:31PM +0800, Xuan Zhuo wrote: > > On Tue, 13 Jun 2023 05:02:01 -0400, "Michael S. Tsirkin" > > wrote: > > > On Mon, Jun 12, 2023 at 07:27:15PM +0800, Xua

[virtio-dev] Re: [virtio-comment] Re: About custom device counter

2023-06-19 Thread Xuan Zhuo
; > And the device should expose to the user. > > > > > > OK so here, driver is expected to rate limit yes? > > > > > Some implementations of txq are lossy and some are not creating > > backpressure/flow control to driver so driver can rate limit it natura

[virtio-dev] Re: [virtio-comment] Re: About custom device counter

2023-06-18 Thread Xuan Zhuo
On Fri, 16 Jun 2023 10:13:23 -0400, "Michael S. Tsirkin" wrote: > On Thu, Jun 15, 2023 at 02:23:31PM +0800, Xuan Zhuo wrote: > > On Tue, 13 Jun 2023 05:02:01 -0400, "Michael S. Tsirkin" > > wrote: > > > On Mon, Jun 12, 2023 at 07:27:15PM +0800, Xua

[virtio-dev] Re: [virtio-comment] Re: About custom device counter

2023-06-15 Thread Xuan Zhuo
On Tue, 13 Jun 2023 05:02:01 -0400, "Michael S. Tsirkin" wrote: > On Mon, Jun 12, 2023 at 07:27:15PM +0800, Xuan Zhuo wrote: > > On Mon, 12 Jun 2023 02:25:42 -0400, "Michael S. Tsirkin" > > wrote: > > > On Mon, Jun 12, 2023 at 02:12:35PM +0800,

[virtio-dev] Re: [virtio-comment] Re: About custom device counter

2023-06-12 Thread Xuan Zhuo
On Mon, 12 Jun 2023 02:25:42 -0400, "Michael S. Tsirkin" wrote: > On Mon, Jun 12, 2023 at 02:12:35PM +0800, Xuan Zhuo wrote: > > We hope to support device custom counter. That is, virtio spec provides a > > channel for driver and device, and both key and value ar

[virtio-dev] About custom device counter

2023-06-12 Thread Xuan Zhuo
We hope to support device custom counter. That is, virtio spec provides a channel for driver and device, and both key and value are provided by device. We discussed this issue earlier, and after some internal practice, I think it is still necessary to discuss this again. It is very important,

[virtio-dev] [PATCH v4 0/1] introduce virtio-ism: internal shared memory device

2023-05-18 Thread Xuan Zhuo
Alloc/Attach huge region 4. remove host/guest terms v1: 1. cover letter adding explanation of ism vlan 2. spec add gid 3. explain the source of ideas about ism 4. POC support virtio-ism-smc.ko virtio-ism-dev.ko and support virtio-ism-mmap Xuan Zhuo (1): virtio-ism: introduce new

Re: [virtio-dev] Re: Re: [virtio-comment] [PROPOSAL] Virtio Over Fabrics(TCP/RDMA)

2023-04-26 Thread Xuan Zhuo
On Tue, 25 Apr 2023 14:36:04 +0800, Jason Wang wrote: > On Mon, Apr 24, 2023 at 9:38 PM zhenwei pi wrote: > > > > > > > > On 4/24/23 11:40, Jason Wang wrote: > > > On Sun, Apr 23, 2023 at 7:31 PM zhenwei pi > > > wrote: > > >> > > >> Hi, > > >> > > >> In the past years, virtio supports lots of

Re: [virtio-dev] Virtio-loopback: PoC of a new Hardware Abstraction Layer for non-Hypervisor environments based on Virtio

2023-04-18 Thread Xuan Zhuo
On Thu, 13 Apr 2023 16:35:59 +0300, Timos Ampelikiotis wrote: > Dear virtio-dev community, > > I would like to introduce you Virtio-loopback, Proof of Concept (PoC) that > we have been working on at Virtual Open Systems in the context of the > Automotive Grade Linux community (Virtualization &

[virtio-dev] Re: [virtio-comment] [PATCH v3 1/1] virtio-ism: introduce new device virtio-ism

2023-03-24 Thread Xuan Zhuo
On Fri, 24 Mar 2023 00:51:13 -0400, Parav Pandit wrote: > > > On 2/8/2023 10:30 PM, Xuan Zhuo wrote: > > An ISM(Internal Shared Memory) device provides the ability to access memory > > shared between multiple devices. This allows low-overhead communication in > &

[virtio-dev] Re: RE: [virtio-comment] [PATCH v3 1/1] virtio-ism: introduce new device virtio-ism

2023-02-08 Thread Xuan Zhuo
On Thu, 9 Feb 2023 03:35:33 +, Parav Pandit wrote: > Hi Xuan, > > > From: virtio-comm...@lists.oasis-open.org > open.org> On Behalf Of Xuan Zhuo > > > conformance.tex | 26 +++ > > content.tex | 1 + > > virtio-ism.tex | 573 +

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Xuan Zhuo
On Tue, 7 Feb 2023 10:28:37 -0500, "Michael S. Tsirkin" wrote: > On Tue, Feb 07, 2023 at 03:25:55PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > Sent: Tuesday, February 7, 2023 10:09 AM > > > > > > On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz wrote: > > > > >

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-12 Thread Xuan Zhuo
On Thu, 12 Jan 2023 16:41:32 +0100, Halil Pasic wrote: > On Thu, 12 Jan 2023 15:30:58 +0100 > Cornelia Huck wrote: > > > >> > > >> I like that: we don't want to talk about hosts/VMMs/etc. as we > > >> fundamentally deal with devices and drivers, but sharing between guests > > >> is of course the

Re: [virtio-dev] [PATCH] virtio_net: support low and high rate of notification coalescing sets

2022-12-21 Thread Xuan Zhuo
On Wed, 21 Dec 2022 13:48:59 +0200, Alvaro Karsz wrote: > Hi, > > > I want to know which one is better than NetDim(Coalesce Adaptive) in driver. > > > > I know Heng Qi's work in this. > > > > Thanks > > > Why choose? we can have both. > ethtool can handle both pkt_rate_low/pkt_rate_high and >

Re: [virtio-dev] [PATCH] virtio_net: support low and high rate of notification coalescing sets

2022-12-21 Thread Xuan Zhuo
On Wed, 21 Dec 2022 12:17:29 +0200, Alvaro Karsz wrote: > This patch adds a new feature VIRTIO_NET_F_NOTF_COAL_LOW_HIGH, > and adds 2 new commands to VIRTIO_NET_CTRL_NOTF_COAL class: > * VIRTIO_NET_CTRL_NOTF_COAL_LOW_SET - create a low-rate set of > coalescing parameters. the

Re: [virtio-dev] [PATCH 0/2] introduce virtio-ism: internal shared memory device

2022-11-23 Thread Xuan Zhuo
On Wed, 23 Nov 2022 16:27:00 +0100, Jan Kiszka wrote: > On 16.11.22 03:13, Xuan Zhuo wrote: > > On Mon, 14 Nov 2022 22:30:53 +0100, Jan Kiszka > > wrote: > >> On 18.10.22 09:32, Jan Kiszka wrote: > >>> On 17.10.22 09:47, Xuan Zhuo wrote: > >>

Re: [virtio-dev] [PATCH 0/2] introduce virtio-ism: internal shared memory device

2022-11-15 Thread Xuan Zhuo
On Mon, 14 Nov 2022 22:30:53 +0100, Jan Kiszka wrote: > On 18.10.22 09:32, Jan Kiszka wrote: > > On 17.10.22 09:47, Xuan Zhuo wrote: > >> Hello everyone, > >> > >> # Background > >> > >> Nowadays, there is a common scenario to accelerate c

Re: [virtio-dev] [PATCH 0/2] introduce virtio-ism: internal shared memory device

2022-10-18 Thread Xuan Zhuo
On Mon, 17 Oct 2022 16:17:31 +0800, Jason Wang wrote: Hi Jason, I think there may be some problems with the direction we are discussing. Our goal is to add an new ism device. As far as the spec is concerned, we are not concerned with the implementation of the backend. The direction we should

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-17 Thread Xuan Zhuo
FYI: A new rx zerocopy idea, which is different from Eric's tcp mmap zerocopy, the buffer comes from user mode and put to device, no longer requires page alignment, but still depends on split header.

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-08 Thread Xuan Zhuo
On Sat, 8 Oct 2022 12:37:45 +0800, Jason Wang wrote: > On Thu, Sep 29, 2022 at 3:04 PM Michael S. Tsirkin wrote: > > > > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > > > On Wed, Sep 28, 2022 at 9:39 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Sep 26, 2022 at

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-29 Thread Xuan Zhuo
On Thu, 29 Sep 2022 06:06:41 -0400, "Michael S. Tsirkin" wrote: > On Thu, Sep 29, 2022 at 04:24:02PM +0800, Xuan Zhuo wrote: > > On Thu, 29 Sep 2022 03:04:03 -0400, "Michael S. Tsirkin" > > wrote: > > > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Ja

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-29 Thread Xuan Zhuo
On Thu, 29 Sep 2022 03:04:03 -0400, "Michael S. Tsirkin" wrote: > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > > On Wed, Sep 28, 2022 at 9:39 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Sep 26, 2022 at 04:06:17PM +0800, Jason Wang wrote: > > > > > Jason I think the issue

Re: [virtio-dev] Re: [PATCH v7] virtio_net: support split header

2022-09-28 Thread Xuan Zhuo
On Tue, 27 Sep 2022 17:35:09 -0400, "Michael S. Tsirkin" wrote: > On Wed, Sep 14, 2022 at 11:34:43AM +0800, Jason Wang wrote: > > > > 在 2022/9/9 20:38, Xuan Zhuo 写道: > > > On Fri, 9 Sep 2022 07:15:02 -0400, "Michael S. Tsirkin" > > > wr

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-23 Thread Xuan Zhuo
On Fri, 23 Sep 2022 07:04:10 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 23, 2022 at 06:48:56PM +0800, Xuan Zhuo wrote: > > On Fri, 23 Sep 2022 06:44:54 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Sep 23, 2022 at 02:57:27PM +0800, Xu

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-23 Thread Xuan Zhuo
On Fri, 23 Sep 2022 06:44:54 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 23, 2022 at 02:57:27PM +0800, Xuan Zhuo wrote: > > > > > Michael doesn't want to use desc chain, it's not just a performance > > > > > issue. In an > > > > >

[virtio-dev] Re: [PATCH v7] virtio_net: support split header

2022-09-09 Thread Xuan Zhuo
hi Qi also sent another same email today. Due to some email client problems, this email has some confusion in the format, so we can discuss under another one. https://lists.oasis-open.org/archives/virtio-dev/202209/msg00066.html Thanks

[virtio-dev] Re: [PATCH v7] virtio_net: support split header

2022-09-09 Thread Xuan Zhuo
On Fri, 9 Sep 2022 07:15:02 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 09, 2022 at 03:41:54PM +0800, Heng Qi wrote: > > > > > > 在 2022/9/5 上午4:27, Michael S. Tsirkin 写道: > > > On Fri, Sep 02, 2022 at 03:36:25PM +0800, Heng Qi wrote: > > > > We need to clarify that the purpose of header

[virtio-dev] Re: [PATCH v7] virtio_net: support split header

2022-09-05 Thread Xuan Zhuo
On Mon, 5 Sep 2022 16:37:57 +0800, Heng Qi wrote: > > 在 2022/9/5 下午3:52, Xuan Zhuo 写道: > > On Sun, 4 Sep 2022 16:31:59 -0400, "Michael S. Tsirkin" > > wrote: > >> On Fri, Sep 02, 2022 at 04:58:16PM +0800, Heng Qi wrote: > >>> When

[virtio-dev] Re: [PATCH v7] virtio_net: support split header

2022-09-05 Thread Xuan Zhuo
On Sun, 4 Sep 2022 16:31:59 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 02, 2022 at 04:58:16PM +0800, Heng Qi wrote: > > When VIRTIO_NET_F_SPLIT_TRANSPORT_HEADER is negotiated, > > the driver requires that the buffers submitted to receiveq > > MUST be composed of at least two descriptors, >

Re: [virtio-dev] [PATCH v3 2/2] virtio-net: use mtu size as buffer length for big packets

2022-08-29 Thread Xuan Zhuo
5.9 > > Signed-off-by: Gavin Li > Reviewed-by: Gavi Teitz > Reviewed-by: Parav Pandit Reviewed-by: Xuan Zhuo > --- > changelog: > v2->v3 > - Addressed comments from Si-Wei > - Simplify the condition check to enable the optimization > v1->v2 > - Addressed comm

[virtio-dev] Re: [PATCH v3 1/2] virtio-net: introduce and use helper function for guest gso support checks

2022-08-29 Thread Xuan Zhuo
On Tue, 30 Aug 2022 05:26:33 +0300, Gavin Li wrote: > Probe routine is already several hundred lines. > Use helper function for guest gso support check. > > Signed-off-by: Gavin Li > Reviewed-by: Gavi Teitz > Reviewed-by: Parav Pandit Reviewed-by: Xuan Zhuo > ---

Re: [virtio-dev] [PATCH v5] virtio_net: support split header

2022-07-25 Thread Xuan Zhuo
On Mon, 25 Jul 2022 13:04:09 +0200, Cornelia Huck wrote: > On Wed, Jul 20 2022, Xuan Zhuo wrote: > > > The purpose of this feature is to split the header and the payload of > > the packet. > > > > |

[virtio-dev] [PATCH v5] virtio_net: support split header

2022-07-20 Thread Xuan Zhuo
ayload | We can use a buffer plus a separate page when allocating the receive buffer. In this way, we can ensure that all payloads can be independently in a page, which is very beneficial for the zerocopy implemented by the upper layer. Signed-off-by: Xuan Zhuo Reviewed-by: Heng Qi Re

[virtio-dev] Re: [PATCH v4] virtio_net: support split header

2022-06-22 Thread Xuan Zhuo
On Wed, 22 Jun 2022 02:08:19 -0400, "Michael S. Tsirkin" wrote: > On Wed, Jun 22, 2022 at 11:52:30AM +0800, Jason Wang wrote: > > > > 在 2022/6/21 18:54, Michael S. Tsirkin 写道: > > > On Mon, Jun 20, 2022 at 11:13:47AM +0800, Xuan Zhuo wrote: > > > >

[virtio-dev] Re: [PATCH v4] virtio_net: support split header

2022-06-21 Thread Xuan Zhuo
On Tue, 21 Jun 2022 06:54:54 -0400, "Michael S. Tsirkin" wrote: > On Mon, Jun 20, 2022 at 11:13:47AM +0800, Xuan Zhuo wrote: > > On Fri, 17 Jun 2022 05:58:11 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Jun 17, 2022 at 03:16:01PM

[virtio-dev] Re: [PATCH v4] virtio_net: support split header

2022-06-21 Thread Xuan Zhuo
On Tue, 21 Jun 2022 15:12:04 +0800, Jason Wang wrote: > On Mon, Jun 20, 2022 at 3:05 PM Xuan Zhuo wrote: > > > > On Fri, 17 Jun 2022 05:58:11 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Jun 17, 2022 at 03:16:01PM +0800, Xuan Zhuo wrote: > &g

[virtio-dev] Re: [PATCH v4] virtio_net: support split header

2022-06-20 Thread Xuan Zhuo
On Fri, 17 Jun 2022 05:58:11 -0400, "Michael S. Tsirkin" wrote: > On Fri, Jun 17, 2022 at 03:16:01PM +0800, Xuan Zhuo wrote: > > The purpose of this feature is to split the header and the payload of > > the packet. > > > >

[virtio-dev] [PATCH v4] virtio_net: support split header

2022-06-17 Thread Xuan Zhuo
ayload | We can use a buffer plus a separate page when allocating the receive buffer. In this way, we can ensure that all payloads can be independently in a page, which is very beneficial for the zerocopy implemented by the upper layer. Signed-off-by: Xuan Zhuo Reviewed-by: Heng Qi Re

Re: [virtio-dev] [PATCH v3] virtio_net: support split header

2022-06-16 Thread Xuan Zhuo
On Tue, 07 Jun 2022 15:10:18 +0200, Cornelia Huck wrote: > On Mon, Jun 06 2022, Xuan Zhuo wrote: > > > The purpose of this feature is to split the header and the payload of > > the packet. > > > > |

[virtio-dev] Re: [PATCH v3] virtio_net: support split header

2022-06-16 Thread Xuan Zhuo
On Tue, 14 Jun 2022 16:51:58 +0800, Jason Wang wrote: > On Mon, Jun 6, 2022 at 8:11 PM Xuan Zhuo wrote: > > > > The purpose of this feature is to split the header and the payload of > > the packet. > > > > |

[virtio-dev] [PATCH v3] virtio_net: support split header

2022-06-06 Thread Xuan Zhuo
ayload | We can use a buffer plus a separate page when allocating the receive buffer. In this way, we can ensure that all payloads can be independently in a page, which is very beneficial for the zerocopy implemented by the upper layer. Signed-off-by: Xuan Zhuo --- 1. Fix some syntax issues

Re: [virtio-dev] Re: [PATCH v2] virtio_net: support split header

2022-05-31 Thread Xuan Zhuo
On Tue, 31 May 2022 13:59:12 +0800, Xuan Zhuo wrote: > On Tue, 31 May 2022 01:35:17 -0400, "Michael S. Tsirkin" > wrote: > > On Tue, May 31, 2022 at 10:10:52AM +0800, Xuan Zhuo wrote: > > > On Mon, 30 May 2022 14:27:26 -0400, "Michael S. Tsirkin" &

[virtio-dev] Re: [PATCH v2] virtio_net: support split header

2022-05-31 Thread Xuan Zhuo
On Tue, 31 May 2022 01:35:17 -0400, "Michael S. Tsirkin" wrote: > On Tue, May 31, 2022 at 10:10:52AM +0800, Xuan Zhuo wrote: > > On Mon, 30 May 2022 14:27:26 -0400, "Michael S. Tsirkin" > > wrote: > > > On Sat, May 07, 2022 at 03:15:33PM

[virtio-dev] Re: [PATCH v2] virtio_net: support split header

2022-05-30 Thread Xuan Zhuo
On Mon, 30 May 2022 14:27:26 -0400, "Michael S. Tsirkin" wrote: > On Sat, May 07, 2022 at 03:15:33PM +0800, Xuan Zhuo wrote: > > The purpose of this feature is to split the header and the payload of > > the packet. > > > >

[virtio-dev] Re: [PATCH v5] virtio-net: support reset queue

2022-05-26 Thread Xuan Zhuo
On Fri, 29 Apr 2022 10:45:28 +0800, Jason Wang wrote: > > 在 2022/4/24 16:31, Xuan Zhuo 写道: > > A separate reset queue function introduced by Virtqueue Reset. > > > > However, it is currently not defined what to do if the destination queue is > > being reset when v

Re: [virtio-dev] Re: [PATCH v2] virtio_net: support split header

2022-05-26 Thread Xuan Zhuo
On Mon, 9 May 2022 16:41:11 +0800, Jason Wang wrote: > > 在 2022/5/7 15:15, Xuan Zhuo 写道: > > The purpose of this feature is to split the header and the payload of > > the packet. > > > > |receive buffer| &

[virtio-dev] [PATCH v2] virtio_net: support split header

2022-05-07 Thread Xuan Zhuo
ayload | We can use a buffer plus a separate page when allocating the receive buffer. In this way, we can ensure that all payloads can be independently in a page, which is very beneficial for the zerocopy implemented by the upper layer. Signed-off-by: Xuan Zhuo --- conformance.te

Re: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Xuan Zhuo
ange to have reset register > > polarity to be same as that of initial reset value. > > > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/139 > > Fixes: 12998e738621 ("virtio: pci support virtqueue reset") > > Fixes: a4ce81a83780 ("virtio: mmio suppor

[virtio-dev] Re: [PATCH v1] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 03:06:57 +0300, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 10:26:18 -0400, "Michael S. Tsirkin" wrote: > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > > Hi, > > > > > > A recently defined queue_reset registe

Re: RE: [virtio-dev] queue_reset register polarity to improve

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 12:00:24 +, Parav Pandit wrote: > > > From: Xuan Zhuo > > Sent: Sunday, April 24, 2022 3:29 AM > > > > > > A recently defined queue_reset register has a little weird definition that > > we should improve. > > > When driver

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-26 Thread Xuan Zhuo
On Tue, 26 Apr 2022 05:52:17 -0400, "Michael S. Tsirkin" wrote: > On Tue, Apr 26, 2022 at 09:48:29AM +0100, Stefan Hajnoczi wrote: > > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > >

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-26 Thread Xuan Zhuo
On Tue, 26 Apr 2022 09:48:29 +0100, Stefan Hajnoczi wrote: > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > > Hi, > > > > > > A recently defined queue_reset register has a little we

[virtio-dev] [PATCH v5] virtio-net: support reset queue

2022-04-24 Thread Xuan Zhuo
A separate reset queue function introduced by Virtqueue Reset. However, it is currently not defined what to do if the destination queue is being reset when virtio-net is steering in multi-queue mode. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/138 Signed-off-by: Xuan Zhuo

[virtio-dev] Re: [PATCH v4] virtio-net: support reset queue

2022-04-24 Thread Xuan Zhuo
On Sun, 24 Apr 2022 02:53:46 -0400, "Michael S. Tsirkin" wrote: > On Tue, Feb 22, 2022 at 02:52:41PM +0800, Xuan Zhuo wrote: > > This patch defines some requirements for virtio-net to support reset > > queues. > > > > Signed-off-by: Xuan Zhuo > >

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-24 Thread Xuan Zhuo
On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > Hi, > > A recently defined queue_reset register has a little weird definition that we > should improve. > When driver initiate queue reset, it writes queue_reset = 1. > When device is busy resetting the queue, on this driver request, it

Re: [virtio-dev] [PATCH v4] virtio-net: support reset queue

2022-04-23 Thread Xuan Zhuo
On Tue, 22 Feb 2022 14:52:41 +0800, Xuan Zhuo wrote: > This patch defines some requirements for virtio-net to support reset > queues. Is there any problem with this? Thanks. > > Signed-off-by: Xuan Zhuo > --- > content.tex | 5 + > 1 file changed, 5 inserti

[virtio-dev] [PATCH v12] virtio-net: support device stats

2022-03-14 Thread Xuan Zhuo
atomically, try to get stats for all queue pairs in one command. Signed-off-by: Xuan Zhuo Suggested-by: Michael S. Tsirkin --- conformance.tex | 2 + content.tex | 406 +++- 2 files changed, 405 insertions(+), 3 deletions(-) diff --git

[virtio-dev] Re: [PATCH v11] virtio-net: support device stats

2022-03-09 Thread Xuan Zhuo
On Wed, 9 Mar 2022 17:15:46 +0800, Jason Wang wrote: > On Wed, Mar 9, 2022 at 5:08 PM Michael S. Tsirkin wrote: > > > On Wed, Mar 09, 2022 at 04:25:26PM +0800, Xuan Zhuo wrote: > > > On Mon, 7 Mar 2022 15:58:03 +0800, Jason Wang > > wrote: > > > >

[virtio-dev] Re: [PATCH v11] virtio-net: support device stats

2022-03-09 Thread Xuan Zhuo
On Mon, 7 Mar 2022 15:58:03 +0800, Jason Wang wrote: > > 在 2022/3/2 下午4:52, Xuan Zhuo 写道: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such information, > > which can be

Re: [virtio-dev] Re: [PATCH v11] virtio-net: support device stats

2022-03-08 Thread Xuan Zhuo
On Tue, 8 Mar 2022 14:36:02 +0800, Jason Wang wrote: > On Mon, Mar 7, 2022 at 5:07 PM Xuan Zhuo wrote: > > > > On Mon, 7 Mar 2022 15:58:03 +0800, Jason Wang wrote: > > > > > > 在 2022/3/2 下午4:52, Xuan Zhuo 写道: > > > > This patch allows the dri

Re: [virtio-dev] Re: [PATCH v11] virtio-net: support device stats

2022-03-08 Thread Xuan Zhuo
On Tue, 8 Mar 2022 14:36:02 +0800, Jason Wang wrote: > On Mon, Mar 7, 2022 at 5:07 PM Xuan Zhuo wrote: > > > > On Mon, 7 Mar 2022 15:58:03 +0800, Jason Wang wrote: > > > > > > 在 2022/3/2 下午4:52, Xuan Zhuo 写道: > > > > This patch allows the dri

[virtio-dev] Re: [PATCH v11] virtio-net: support device stats

2022-03-07 Thread Xuan Zhuo
On Mon, 7 Mar 2022 15:58:03 +0800, Jason Wang wrote: > > 在 2022/3/2 下午4:52, Xuan Zhuo 写道: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such information, > > which can be

[virtio-dev] [PATCH v11] virtio-net: support device stats

2022-03-02 Thread Xuan Zhuo
atomically, try to get stats for all queue pairs in one command. Signed-off-by: Xuan Zhuo Suggested-by: Michael S. Tsirkin --- v11: 1. Use michael's advice to introduce virtio_net_ctrl_queue_stats to get vq stats based on vq num and type 2. split stats structure v10: 1. use description/item

[virtio-dev] Re: [PATCH v10] virtio-net: support device stats

2022-03-01 Thread Xuan Zhuo
On Tue, 1 Mar 2022 07:25:16 -0500, "Michael S. Tsirkin" wrote: > On Tue, Mar 01, 2022 at 07:32:23PM +0800, Xuan Zhuo wrote: > > > > I have to say, this design is really good. > > > > I think one of the core points of your design is to separate drop stats,

[virtio-dev] Re: [PATCH v10] virtio-net: support device stats

2022-03-01 Thread Xuan Zhuo
On Tue, 1 Mar 2022 06:05:55 -0500, "Michael S. Tsirkin" wrote: > On Tue, Mar 01, 2022 at 04:34:46PM +0800, Xuan Zhuo wrote: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of

[virtio-dev] [PATCH v10] virtio-net: support device stats

2022-03-01 Thread Xuan Zhuo
atomically, try to get stats for all queue pairs in one command. Signed-off-by: Xuan Zhuo --- v10: 1. use description/item for the item of the queue pair 2. use one command to get the stats of all queue pairs v8: 1. Modified based on comments by Cornelia Huck v7: 1. add rx_reset, tx_reset 2

Re: [virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Xuan Zhuo
On Mon, 28 Feb 2022 06:40:33 -0500, "Michael S. Tsirkin" wrote: > On Tue, Feb 15, 2022 at 03:47:43PM +0800, Xuan Zhuo wrote: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of

[virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Xuan Zhuo
On Mon, 28 Feb 2022 06:55:27 -0500, "Michael S. Tsirkin" wrote: > On Mon, Feb 28, 2022 at 07:21:39PM +0800, Xuan Zhuo wrote: > > > struct stats{ > > > /* the counters that doesn't need any features */ > > > /* the counters that needs CSUM

[virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Xuan Zhuo
On Mon, 28 Feb 2022 17:07:54 +0800, Jason Wang wrote: > On Tue, Feb 15, 2022 at 3:47 PM Xuan Zhuo wrote: > > > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such informa

Re: [virtio-dev] [PATCH v9] virtio-net: support device stats

2022-02-24 Thread Xuan Zhuo
On Tue, 15 Feb 2022 15:47:43 +0800, Xuan Zhuo wrote: > This patch allows the driver to obtain some statistics from the device. > > In the back-end implementation, we can count a lot of such information, > which can be used for debugging and judging the running status of the > ba

[virtio-dev] [PATCH v4] virtio-net: support reset queue

2022-02-21 Thread Xuan Zhuo
This patch defines some requirements for virtio-net to support reset queues. Signed-off-by: Xuan Zhuo --- content.tex | 5 + 1 file changed, 5 insertions(+) diff --git a/content.tex b/content.tex index c6f116c..45751f4 100644 --- a/content.tex +++ b/content.tex @@ -4337,6 +4337,10

[virtio-dev] [PATCH v1] virtio_net: support split header

2022-02-21 Thread Xuan Zhuo
layer. Signed-off-by: Xuan Zhuo --- conformance.tex | 2 ++ content.tex | 66 + 2 files changed, 68 insertions(+) diff --git a/conformance.tex b/conformance.tex index 42f8537..e5d2ca8 100644 --- a/conformance.tex +++ b/conformance.tex @@

[virtio-dev] [PATCH v3] virtio-net: support reset queue

2022-02-21 Thread Xuan Zhuo
This patch defines some requirements for virtio-net to support reset queues. Signed-off-by: Xuan Zhuo --- content.tex | 6 ++ 1 file changed, 6 insertions(+) diff --git a/content.tex b/content.tex index c6f116c..e293881 100644 --- a/content.tex +++ b/content.tex @@ -4337,6 +4337,11

[virtio-dev] Re: [PATCH v2] virtio-net: support reset queue

2022-02-20 Thread Xuan Zhuo
On Mon, 21 Feb 2022 12:27:20 +0800, Jason Wang wrote: > > 在 2022/2/10 下午7:03, Xuan Zhuo 写道: > > This patch defines some requirements for virtio-net to support reset > > queues. > > > > Signed-off-by: Xuan Zhuo > > --- > > conform

[virtio-dev] Re: [PATCH v1] virtio-net: support reset queue

2022-02-20 Thread Xuan Zhuo
On Mon, 21 Feb 2022 11:02:54 +0800, Jason Wang wrote: > On Fri, Feb 18, 2022 at 5:27 PM Michael S. Tsirkin wrote: > > > > On Thu, Feb 10, 2022 at 05:26:24PM +0800, Jason Wang wrote: > > > On Thu, Feb 10, 2022 at 5:06 PM Xuan Zhuo > > > wrote: > &

[virtio-dev] Re: [PATCH] virtio_net: support split header

2022-02-15 Thread Xuan Zhuo
On Wed, 16 Feb 2022 12:32:03 +0800, Jason Wang wrote: > On Wed, Feb 16, 2022 at 11:01 AM Xuan Zhuo wrote: > > > > The purpose of this feature is to write the payload of the packet to a > > specified location in the receive buffer after the device re

[virtio-dev] [PATCH] virtio_net: support split header

2022-02-15 Thread Xuan Zhuo
e network header. For MRG_RX, we require that all payloads are placed in the position specified by offset in each receive buffer. So we can also use build_skb() without wasting memory. Because we can reuse the "offset" parts that are not used. Signed-off-by: Xuan Zhuo

[virtio-dev] [PATCH v9] virtio-net: support device stats

2022-02-14 Thread Xuan Zhuo
-by: Xuan Zhuo --- conformance.tex | 2 + content.tex | 135 ++-- 2 files changed, 134 insertions(+), 3 deletions(-) diff --git a/conformance.tex b/conformance.tex index 42f8537..950924e 100644 --- a/conformance.tex +++ b/conformance.tex @@ -142,6

[virtio-dev] [PATCH v2] virtio-net: support reset queue

2022-02-10 Thread Xuan Zhuo
This patch defines some requirements for virtio-net to support reset queues. Signed-off-by: Xuan Zhuo --- conformance.tex | 1 + content.tex | 16 2 files changed, 17 insertions(+) diff --git a/conformance.tex b/conformance.tex index 42f8537..3656da5 100644

[virtio-dev] [PATCH v1] virtio-net: support reset queue

2022-02-10 Thread Xuan Zhuo
This patch defines some requirements for virtio-net to support reset queues. Signed-off-by: Xuan Zhuo --- conformance.tex | 1 + content.tex | 12 2 files changed, 13 insertions(+) diff --git a/conformance.tex b/conformance.tex index 42f8537..3656da5 100644

[virtio-dev] Re: [PATCH] virtio-net: support reset queue

2022-02-09 Thread Xuan Zhuo
On Wed, 9 Feb 2022 04:23:17 -0500, "Michael S. Tsirkin" wrote: > On Wed, Feb 09, 2022 at 05:01:58PM +0800, Xuan Zhuo wrote: > > This patch defines some requirements for virtio-net to support reset > > queues. > > > > Signed-off-by: Xuan Zhuo > > --- &g

[virtio-dev] [PATCH] virtio-net: support reset queue

2022-02-09 Thread Xuan Zhuo
This patch defines some requirements for virtio-net to support reset queues. Signed-off-by: Xuan Zhuo --- conformance.tex | 2 ++ content.tex | 19 +++ 2 files changed, 21 insertions(+) diff --git a/conformance.tex b/conformance.tex index 42f8537..52b4879 100644

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Xuan Zhuo
On Tue, 18 Jan 2022 09:39:04 +0100, Cornelia Huck wrote: > On Tue, Jan 18 2022, Xuan Zhuo wrote: > > >> > > above you said bytes sent. > >> > > >> > I mean, all about GSO are statistics based on big packets. So here is the > >> >

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Tue, 18 Jan 2022 02:16:35 -0500, Michael S. Tsirkin wrote: > On Tue, Jan 18, 2022 at 11:34:25AM +0800, Xuan Zhuo wrote: > > On Tue, 18 Jan 2022 11:26:21 +0800, Jason Wang wrote: > > > On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo > > > wrote: > > > > >

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Tue, 18 Jan 2022 11:26:21 +0800, Jason Wang wrote: > On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo wrote: > > > > On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang wrote: > > > > > > 在 2022/1/17 上午10:14, Xuan Zhuo 写道: > > > > On Sat, 15 Jan 2022 13:17

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Mon, 17 Jan 2022 09:13:41 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 17, 2022 at 04:21:50PM +0800, Xuan Zhuo wrote: > > On Mon, 17 Jan 2022 03:12:20 -0500, Michael S. Tsirkin > > wrote: > > > On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > > &g

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Mon, 17 Jan 2022 03:12:20 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > wrote: > > > On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > > &g

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-16 Thread Xuan Zhuo
On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang wrote: > > 在 2022/1/17 上午10:14, Xuan Zhuo 写道: > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > wrote: > >> On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > >>> This patch allows th

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-16 Thread Xuan Zhuo
On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin wrote: > On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such infor

[virtio-dev] Re: [PATCH v8] virtio-net: support device stats

2022-01-11 Thread Xuan Zhuo
On Tue, 11 Jan 2022 15:52:20 +0100, Cornelia Huck wrote: > On Tue, Jan 11 2022, Xuan Zhuo wrote: > > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such information, > > w

[virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-10 Thread Xuan Zhuo
-by: Xuan Zhuo Reviewed-by: Jason Wang --- v8: 1. Modified based on comments by Cornelia Huck v7: 1. add rx_reset, tx_reset 2. add device normative and dirver normative 3. add comments for *_packets, *_bytres v6: 1. correct the names and descriptions of some stats items v5: 1. add

[virtio-dev] Re: [PATCH v7] virtio-net: support device stats

2022-01-06 Thread Xuan Zhuo
On Thu, 6 Jan 2022 12:00:14 +0800, Jason Wang wrote: > On Wed, Jan 5, 2022 at 10:49 AM Xuan Zhuo wrote: > > > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such informa

  1   2   >