[virtio-dev] Re: [virtio-comment] Re: [RFC PATCH 4/5] virtqueue: constraints for virtqueue state

2023-09-07 Thread Si-Wei Liu
On 9/7/2023 2:34 AM, Zhu, Lingshan wrote: On 9/7/2023 4:09 PM, Eugenio Perez Martin wrote: On Tue, Sep 5, 2023 at 11:08 AM Zhu, Lingshan wrote: On 8/21/2023 5:26 PM, Eugenio Perez Martin wrote: On Fri, Aug 18, 2023 at 11:44 AM Zhu, Lingshan wrote: On 8/17/2023 11:19 PM, Eugenio Pere

[virtio-dev] Re: [virtio-comment] [PATCH v10] virtio-net: Clarify VLAN filter table configuration

2023-01-25 Thread Si-Wei Liu
On 1/25/2023 3:46 PM, Parav Pandit wrote: From: Parav Pandit Sent: Wednesday, January 25, 2023 6:31 PM To: Michael S. Tsirkin ; Halil Pasic From: Michael S. Tsirkin Sent: Wednesday, January 25, 2023 3:56 PM On Wed, Jan 25, 2023 at 07:04:54PM +0100, Halil Pasic wrote: + +When VIRTIO_NET_

[virtio-dev] Re: [PATCH v8] virtio-network: Clarify VLAN filter table configuration

2023-01-09 Thread Si-Wei Liu
://github.com/oasis-tcs/virtio-spec/issues/147 Suggested-by: Si-Wei Liu Signed-off-by: Parav Pandit Reviewed-by: Si-Wei Liu -Siwei --- changelog: v7->v8: - Fixed grammar v6->v7: - Moved VLAN filter table description from requirements to device descrption section - Added MUST and SHO

[virtio-dev] Re: [PATCH v3] virtio-network: Clarify VLAN filter table configuration

2023-01-03 Thread Si-Wei Liu
] https://www.mail-archive.com/qemu-devel@nongnu.org/msg912392.html Fixes: https://github.com/oasis-tcs/virtio-spec/issues/147 Suggested-by: Si-Wei Liu Signed-off-by: Parav Pandit --- changelog: v2->v3: - corrected grammar - simplified description for untagged packets v1->v2: - adapt to ne

Re: [virtio-dev] RE: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets

2022-09-07 Thread Si-Wei Liu
On 9/7/2022 3:11 PM, Parav Pandit wrote: From: Si-Wei Liu Sent: Wednesday, September 7, 2022 5:40 PM On 9/7/2022 12:51 PM, Parav Pandit wrote: And I'd like commit log to include results of perf testing - with indirect feature on Which device do you suggest using for this test? Yo

Re: [virtio-dev] RE: [PATCH v5 2/2] virtio-net: use mtu size as buffer length for big packets

2022-09-07 Thread Si-Wei Liu
On 9/7/2022 12:51 PM, Parav Pandit wrote: And I'd like commit log to include results of perf testing - with indirect feature on Which device do you suggest using for this test? You may use software vhost-net backend with and without fix to compare. Since this driver fix effectively lowers d

Re: [virtio-dev] [PATCH v3 2/2] virtio-net: use mtu size as buffer length for big packets

2022-08-31 Thread Si-Wei Liu
be a better name than big_packets_sg_num, where the comment could be written as "number of skb fragments for big packets" rather than "number of sg entries allocated for big packets". Reviewed-by: Si-Wei Liu + /* Host will merge rx buffers for big p

Re: [virtio-dev] [PATCH v3 1/2] virtio-net: introduce and use helper function for guest gso support checks

2022-08-31 Thread Si-Wei Liu
On 8/29/2022 7:26 PM, Gavin Li wrote: Probe routine is already several hundred lines. Use helper function for guest gso support check. Signed-off-by: Gavin Li Reviewed-by: Gavi Teitz Reviewed-by: Parav Pandit Reviewed-by: Si-Wei Liu --- changelog: v1->v2 - Add new patch --- driv

Re: [virtio-dev] [PATCH RESEND v2 2/2] virtio-net: use mtu size as buffer length for big packets

2022-08-26 Thread Si-Wei Liu
On 8/26/2022 9:41 AM, Parav Pandit wrote: From: Si-Wei Liu Sent: Friday, August 26, 2022 4:52 AM Sorry for the delay. Didn't notice as this thread was not addressed to my work email. Please copy to my work email if it needs my immediate attention. Can you please setup

Re: [virtio-dev] [PATCH RESEND v2 2/2] virtio-net: use mtu size as buffer length for big packets

2022-08-26 Thread Si-Wei Liu
Sorry for the delay. Didn't notice as this thread was not addressed to my work email. Please copy to my work email if it needs my immediate attention. On 8/25/2022 5:38 AM, Gavin Li wrote: Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big packets even when GUEST_* offloads a

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-10 Thread Si-Wei Liu
On 8/9/2022 11:15 PM, Michael S. Tsirkin wrote: On Wed, Aug 10, 2022 at 02:14:07AM -0400, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 04:24:23PM -0700, Si-Wei Liu wrote: On 8/9/2022 3:49 PM, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Tuesday, August 9, 2022 6:26 PM To

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 3:49 PM, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Tuesday, August 9, 2022 6:26 PM To: Parav Pandit Cc: Si-Wei Liu ; Jason Wang ; Gavin Li ; Hemminger, Stephen ; davem ; virtualization ; Virtio-Dev ; jesse.brandeb...@intel.com; alexander.h.du...@intel.com; kubak

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 3:37 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 03:32:26PM -0700, Si-Wei Liu wrote: On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote: From: Si-Wei Liu Sent: Tuesday, August 9, 2022 3:09 PM From: Si-Wei Liu

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 2:37 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 07:18:30PM +, Parav Pandit wrote: From: Si-Wei Liu Sent: Tuesday, August 9, 2022 3:09 PM From: Si-Wei Liu Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a single patch nor this patch, but the

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 2:34 PM, Michael S. Tsirkin wrote: On Tue, Aug 09, 2022 at 11:38:52AM -0700, Si-Wei Liu wrote: On 8/9/2022 12:44 AM, Jason Wang wrote: On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote: On 8/9/2022 7:56 AM, Si-Wei Liu wrote: External email: Use caution opening links or

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 12:18 PM, Parav Pandit wrote: From: Si-Wei Liu Sent: Tuesday, August 9, 2022 3:09 PM From: Si-Wei Liu Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a single patch nor this patch, but the context for the eventual goal is to allow XDP on a MTU=9000 link when

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 11:42 AM, Parav Pandit wrote: From: Si-Wei Liu Sent: Tuesday, August 9, 2022 2:39 PM Currently it is not. Not a single patch nor this patch, but the context for the eventual goal is to allow XDP on a MTU=9000 link when guest users intentionally lower down MTU to 1500. Which

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 12:44 AM, Jason Wang wrote: On Tue, Aug 9, 2022 at 3:07 PM Gavin Li wrote: On 8/9/2022 7:56 AM, Si-Wei Liu wrote: External email: Use caution opening links or attachments On 8/8/2022 12:31 AM, Gavin Li wrote: On 8/6/2022 6:11 AM, Si-Wei Liu wrote: External email: Use

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-09 Thread Si-Wei Liu
On 8/9/2022 12:06 AM, Gavin Li wrote: On 8/9/2022 7:56 AM, Si-Wei Liu wrote: External email: Use caution opening links or attachments On 8/8/2022 12:31 AM, Gavin Li wrote: On 8/6/2022 6:11 AM, Si-Wei Liu wrote: External email: Use caution opening links or attachments On 8/1/2022 9:45

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-08 Thread Si-Wei Liu
On 8/8/2022 12:31 AM, Gavin Li wrote: On 8/6/2022 6:11 AM, Si-Wei Liu wrote: External email: Use caution opening links or attachments On 8/1/2022 9:45 PM, Gavin Li wrote: Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big packets even when GUEST_* offloads are not

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-05 Thread Si-Wei Liu
On 8/5/2022 3:11 PM, Si-Wei Liu wrote: On 8/1/2022 9:45 PM, Gavin Li wrote: Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big packets even when GUEST_* offloads are not present on the device. However, if GSO is not supported, GUEST GSO (virtio term), or GRO HW (netdev

Re: [virtio-dev] [PATCH] virtio-net: use mtu size as buffer length for big packets

2022-08-05 Thread Si-Wei Liu
On 8/1/2022 9:45 PM, Gavin Li wrote: Currently add_recvbuf_big() allocates MAX_SKB_FRAGS segments for big packets even when GUEST_* offloads are not present on the device. However, if GSO is not supported, GUEST GSO (virtio term), or GRO HW (netdev core term) it should have been be called.

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-03-01 Thread si-wei liu
On 3/1/2019 5:27 AM, Michael S. Tsirkin wrote: On Thu, Feb 28, 2019 at 05:30:56PM -0800, si-wei liu wrote: On 2/28/2019 6:26 AM, Michael S. Tsirkin wrote: On Thu, Feb 28, 2019 at 01:32:12AM -0800, si-wei liu wrote: Will the change break userspace further? -Siwei Didn't you

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-28 Thread si-wei liu
On 2/28/2019 6:26 AM, Michael S. Tsirkin wrote: On Thu, Feb 28, 2019 at 01:32:12AM -0800, si-wei liu wrote: Will the change break userspace further? -Siwei Didn't you show userspace is already broken. You can't "further break it", rename already fails. It's a race

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-28 Thread si-wei liu
On 2/27/2019 4:41 PM, Michael S. Tsirkin wrote: On Wed, Feb 27, 2019 at 04:38:00PM -0800, si-wei liu wrote: On 2/27/2019 3:50 PM, Michael S. Tsirkin wrote: On Wed, Feb 27, 2019 at 03:34:56PM -0800, si-wei liu wrote: On 2/27/2019 2:38 PM, Michael S. Tsirkin wrote: On Tue, Feb 26, 2019 at

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-27 Thread si-wei liu
On 2/27/2019 3:50 PM, Michael S. Tsirkin wrote: On Wed, Feb 27, 2019 at 03:34:56PM -0800, si-wei liu wrote: On 2/27/2019 2:38 PM, Michael S. Tsirkin wrote: On Tue, Feb 26, 2019 at 04:17:21PM -0800, si-wei liu wrote: On 2/25/2019 6:08 PM, Michael S. Tsirkin wrote: On Mon, Feb 25, 2019 at

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-27 Thread si-wei liu
On 2/27/2019 2:38 PM, Michael S. Tsirkin wrote: On Tue, Feb 26, 2019 at 04:17:21PM -0800, si-wei liu wrote: On 2/25/2019 6:08 PM, Michael S. Tsirkin wrote: On Mon, Feb 25, 2019 at 04:58:07PM -0800, si-wei liu wrote: On 2/22/2019 7:14 AM, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-27 Thread si-wei liu
On 2/27/2019 1:57 PM, Stephen Hemminger wrote: On Tue, 26 Feb 2019 16:17:21 -0800 si-wei liu wrote: On 2/25/2019 6:08 PM, Michael S. Tsirkin wrote: On Mon, Feb 25, 2019 at 04:58:07PM -0800, si-wei liu wrote: On 2/22/2019 7:14 AM, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at 11:55

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-26 Thread si-wei liu
On 2/25/2019 6:05 PM, Michael S. Tsirkin wrote: On Mon, Feb 25, 2019 at 05:39:12PM -0800, Stephen Hemminger wrote: Moreover, you were suggesting hiding the lower slave devices anyway. There was some discussion about moving them to a hidden network namespace so that they are not visible from

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-26 Thread si-wei liu
On 2/25/2019 6:08 PM, Michael S. Tsirkin wrote: On Mon, Feb 25, 2019 at 04:58:07PM -0800, si-wei liu wrote: On 2/22/2019 7:14 AM, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at 11:55:11PM -0800, si-wei liu wrote: On 2/21/2019 11:00 PM, Samudrala, Sridhar wrote: On 2/21/2019 7:33 PM

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-25 Thread si-wei liu
On 2/22/2019 7:14 AM, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at 11:55:11PM -0800, si-wei liu wrote: On 2/21/2019 11:00 PM, Samudrala, Sridhar wrote: On 2/21/2019 7:33 PM, si-wei liu wrote: On 2/21/2019 5:39 PM, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at 05:14:44PM -0800

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-21 Thread si-wei liu
On 2/21/2019 11:00 PM, Samudrala, Sridhar wrote: On 2/21/2019 7:33 PM, si-wei liu wrote: On 2/21/2019 5:39 PM, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at 05:14:44PM -0800, Siwei Liu wrote: Sorry for replying to this ancient thread. There was some remaining issue that I don&#

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-02-21 Thread si-wei liu
On 2/21/2019 5:39 PM, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at 05:14:44PM -0800, Siwei Liu wrote: Sorry for replying to this ancient thread. There was some remaining issue that I don't think the initial net_failover patch got addressed cleanly, see: https://bugs.launchpad.net/ubuntu

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 2/5] virtio_net: Add support for "Data Path Switching" during Live Migration.

2019-01-10 Thread si-wei liu
On 01/10/2019 07:20 PM, Michael S. Tsirkin wrote: On Thu, Jan 10, 2019 at 06:09:23PM -0800, si-wei liu wrote: On 01/09/2019 07:56 AM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:29:41PM -0500, Venu Busireddy wrote: diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 80d42e1

Re: [virtio-dev] Re: [PATCH v3 0/5] Support for datapath switching during live migration

2019-01-10 Thread si-wei liu
On 01/09/2019 05:39 AM, Michael S. Tsirkin wrote: On Tue, Jan 08, 2019 at 08:55:35PM -0800, si-wei liu wrote: On 1/7/2019 6:25 PM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:45:22PM -0800, si-wei liu wrote: On 01/07/2019 03:32 PM, Michael S. Tsirkin wrote

[virtio-dev] Re: [Qemu-devel] [PATCH v3 2/5] virtio_net: Add support for "Data Path Switching" during Live Migration.

2019-01-10 Thread si-wei liu
On 01/09/2019 07:56 AM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:29:41PM -0500, Venu Busireddy wrote: diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 80d42e1..2a3ffd3 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi/pcihp.c @@ -176,6 +176,25 @@ static void acpi_pcihp_eject_slot(Acp

Re: [virtio-dev] Re: [PATCH v3 0/5] Support for datapath switching during live migration

2019-01-08 Thread si-wei liu
On 1/7/2019 6:25 PM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:45:22PM -0800, si-wei liu wrote: On 01/07/2019 03:32 PM, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 05:29:39PM -0500, Venu Busireddy wrote: Implement the infrastructure to support datapath switching during live

Re: [virtio-dev] Re: [PATCH v3 0/5] Support for datapath switching during live migration

2019-01-07 Thread si-wei liu
management software wants to drive the SR-IOV live migration on its own. It should not conflict with the hidden device model but just offers simplicity of implementation. Si-Wei Liu (2): vfio-pci: Add FAILOVER_PRIMARY_CHANGED event to shorten downtime during failover pci: query

[virtio-dev] Re: [Qemu-devel] [PATCH v3 4/5] vfio-pci: Add FAILOVER_PRIMARY_CHANGED event to shorten downtime during failover

2019-01-07 Thread si-wei liu
On 01/07/2019 03:41 PM, Alex Williamson wrote: On Mon, 7 Jan 2019 18:22:20 -0500 "Michael S. Tsirkin" wrote: On Mon, Jan 07, 2019 at 04:17:17PM -0700, Alex Williamson wrote: On Mon, 7 Jan 2019 17:29:43 -0500 Venu Busireddy wrote: From: Si-Wei Liu When a VF is hotplugge

[virtio-dev] Re: [Qemu-devel] [PATCH 3/3] vfio-pci: Add FAILOVER_PRIMARY_CHANGED event to shorten downtime during failover

2018-12-10 Thread si-wei liu
On 12/10/2018 9:31 AM, Michael S. Tsirkin wrote: On Mon, Dec 10, 2018 at 11:15:48AM -0500, Venu Busireddy wrote: From: Si-Wei Liu When a VF is hotplugged into the guest, datapath switching will be performed immediately, which is sub-optimal in terms of timing, and could end up with

[virtio-dev] Re: [Qemu-devel] [PATCH 2/3] virtio_net: Add support for "Data Path Switching" during Live Migration.

2018-12-10 Thread si-wei liu
On 12/10/2018 9:41 AM, Michael S. Tsirkin wrote: On Mon, Dec 10, 2018 at 11:15:47AM -0500, Venu Busireddy wrote: Added two new events, FAILOVER_PLUG_PRIMARY and FAILOVER_UNPLUG_PRIMARY. The first is emitted when the guest negotiates the F_STANDBY feature bit. The second is emitted when the vi

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-07 Thread si-wei liu
On Tue, Dec 4, 2018 at 5:59 AM Michael S. Tsirkin wrote: On Mon, Dec 03, 2018 at 06:09:19PM -0800, si-wei liu wrote: I agree. But a single flag is not much of an extension. We don't even need it in netlink, can be anywhere in e.g. sysfs. I think sysfs attribute is for exposing the cap

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-12-03 Thread si-wei liu
On 11/29/2018 10:21 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 02:53:08PM -0800, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/29/2018 07:08 PM, Samudrala, Sridhar wrote: On 11/29/2018 4:24 PM, si-wei liu wrote: On 11/29/2018 3:53 PM, Samudrala, Sridhar wrote: On 11/29/2018 2:53 PM, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/29/2018 3:53 PM, Samudrala, Sridhar wrote: On 11/29/2018 2:53 PM, si-wei liu wrote: On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/29/2018 1:17 PM, Michael S. Tsirkin wrote: On Thu, Nov 29, 2018 at 12:14:46PM -0800, si-wei liu wrote: On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-29 Thread si-wei liu
On 11/28/2018 5:15 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 10:39:55AM -0800, Samudrala, Sridhar wrote: On 11/28/2018 9:35 AM, Michael S. Tsirkin wrote: On Wed, Nov

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-28 Thread si-wei liu
On 11/28/2018 12:43 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 12:28:42PM -0800, si-wei liu wrote: On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 10:39:55AM -0800, Samudrala, Sridhar wrote: On 11/28/2018 9:35 AM, Michael S. Tsirkin wrote: On Wed, Nov

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

2018-11-28 Thread si-wei liu
On 11/28/2018 12:06 PM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 10:39:55AM -0800, Samudrala, Sridhar wrote: On 11/28/2018 9:35 AM, Michael S. Tsirkin wrote: On Wed, Nov 28, 2018 at 09:31:32AM -0800, Samudrala, Sridhar wrote: On 11/28/2018 9:08 AM, Michael S. Tsirkin wrote: On Mon

[virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread si-wei liu
On 7/9/2018 6:00 AM, Roman Kagan wrote: On Tue, Jul 03, 2018 at 03:27:23PM -0700, si-wei liu wrote: On 7/3/2018 2:58 AM, Roman Kagan wrote: So how is this coordination going to work? One possibility is that the PV device emits a QMP event upon the guest driver confirming the support for

[virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-03 Thread si-wei liu
On 7/3/2018 2:58 AM, Roman Kagan wrote: On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote: On 7/2/2018 9:14 AM, Roman Kagan wrote: On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: The patch set "Enable virtio_net to act as a standby for a passthru device"

[virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-02 Thread si-wei liu
On 7/2/2018 9:14 AM, Roman Kagan wrote: On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: The patch set "Enable virtio_net to act as a standby for a passthru device" [1] deals with live migration of guests that use passthrough devices. However, that scheme uses the MAC address f

[virtio-dev] [RFC PATCH 1/3] qemu: virtio-bypass should explicitly bind to a passthrough device

2018-04-01 Thread Si-Wei Liu
0:58:80,backup=pci.2:0x3 ... -device vfio-pci,host=02:10.1,id=hostdev0,bus=pci.2,addr=0x3 Signed-off-by: Si-Wei Liu --- hw/net/virtio-net.c | 29 - include/hw/pci/pci.h| 3 ++ include/hw/virtio/virtio-net.h | 2 + incl

[virtio-dev] [RFC PATCH 3/3] virtio_net: make lower netdevs for virtio_bypass hidden

2018-04-01 Thread Si-Wei Liu
g its and : location. Changing BACKUP feature to take these configs into account, such that verifying target device for auto-enslavement no longer relies on the MAC address. Signed-off-by: Si-Wei Liu --- drivers/net/virtio_net.c| 159 include/uapi/

[virtio-dev] [RFC PATCH 0/3] Userspace compatible driver model for virtio_bypass

2018-04-01 Thread Si-Wei Liu
slave, and making it persistent across live migration. And so on.. The current patch series is based on Sridhar's v4 patch "Enable virtio to act as a backup for a passthru device", but I can resync anyway to his upcoming version once posted. Si-Wei Liu (1): qemu: virtio

[virtio-dev] [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

2018-04-01 Thread Si-Wei Liu
h ':' can rightly be used as the namescope for the kernel-only IFF_HIDDEN netdevs. Signed-off-by: Si-Wei Liu --- include/linux/netdevice.h | 12 ++ include/net/net_namespace.h | 2 + net/core/dev.c | 281 ++-- net/core/net_n