Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2024-01-02 Thread Harald Mommer
Hello Haixu, There are such strange usage scenarios that frame size exceeds 32 bits, even 4096 bits. For these strange cases, It's impossible to use only 32 bits bits_per_word_mask to enumerate all the conditions. Seems that a similar situation exists in Linux spi driver also. Assume a

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-25 Thread Haixu Cui
Hello Harald, On 12/22/2023 10:32 PM, Harald Mommer wrote: Hello Haixu, On 22.12.23 03:28, Haixu Cui wrote: Hello Harald, On 12/21/2023 7:25 PM, Harald Mommer wrote: Hello, On 12.12.23 04:33, Haixu Cui wrote: +\field{bits_per_word_mask} is a mask indicating which values of bits_per_word

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-25 Thread Haixu Cui
On 12/22/2023 8:21 PM, Cornelia Huck wrote: On Tue, Dec 12 2023, Haixu Cui wrote: The Virtio SPI (Serial Peripheral Interface) device is a virtual SPI controller that allows the driver to operate and use the SPI controller under the control of the host. This patch adds the specification

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-25 Thread Haixu Cui
On 12/21/2023 5:54 PM, Cornelia Huck wrote: On Thu, Dec 21 2023, Haixu Cui wrote: Hi Cornelia, On 12/21/2023 4:44 PM, Cornelia Huck wrote: On Thu, Dec 21 2023, Haixu Cui wrote: Please move inclusion of this new file into content.tex here, instead of including a not-yet-existing file in

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-22 Thread Harald Mommer
Hello Haixu, On 22.12.23 03:28, Haixu Cui wrote: Hello Harald, On 12/21/2023 7:25 PM, Harald Mommer wrote: Hello, On 12.12.23 04:33, Haixu Cui wrote: +\field{bits_per_word_mask} is a mask indicating which values of bits_per_word are supported. +If bit n of \field{bits_per_word_mask} is set,

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-22 Thread Cornelia Huck
On Tue, Dec 12 2023, Haixu Cui wrote: > The Virtio SPI (Serial Peripheral Interface) device is a virtual > SPI controller that allows the driver to operate and use the SPI > controller under the control of the host. > > This patch adds the specification for virtio-spi. > > Signed-off-by: Haixu

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-21 Thread Haixu Cui
Hello Harald, On 12/21/2023 7:25 PM, Harald Mommer wrote: Hello, On 12.12.23 04:33, Haixu Cui wrote: +\field{bits_per_word_mask} is a mask indicating which values of bits_per_word are supported. +If bit n of \field{bits_per_word_mask} is set, the bits_per_word with value (n+1) is supported.

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-21 Thread Harald Mommer
Hello, On 12.12.23 04:33, Haixu Cui wrote: +\field{bits_per_word_mask} is a mask indicating which values of bits_per_word are supported. +If bit n of \field{bits_per_word_mask} is set, the bits_per_word with value (n+1) is supported. +If all bits are not set, bits_per_word can be any value

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-21 Thread Cornelia Huck
On Thu, Dec 21 2023, Haixu Cui wrote: > Hi Cornelia, > > On 12/21/2023 4:44 PM, Cornelia Huck wrote: >> On Thu, Dec 21 2023, Haixu Cui wrote: Please move inclusion of this new file into content.tex here, instead of including a not-yet-existing file in the previous patch.

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-21 Thread Haixu Cui
Hi Cornelia, On 12/21/2023 4:44 PM, Cornelia Huck wrote: On Thu, Dec 21 2023, Haixu Cui wrote: Hi Cornelia, Much appreciated for your comments and please refer to my response. On 12/18/2023 7:04 PM, Cornelia Huck wrote: On Tue, Dec 12 2023, Haixu Cui wrote: [BTW: A changelog would

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-21 Thread Cornelia Huck
On Thu, Dec 21 2023, Haixu Cui wrote: > Hi Cornelia, > Much appreciated for your comments and please refer to my response. > > On 12/18/2023 7:04 PM, Cornelia Huck wrote: >> On Tue, Dec 12 2023, Haixu Cui wrote: >> >> [BTW: A changelog would be useful, either in the patch or in the cover

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-20 Thread Haixu Cui
Hi Cornelia, Much appreciated for your comments and please refer to my response. On 12/18/2023 7:04 PM, Cornelia Huck wrote: On Tue, Dec 12 2023, Haixu Cui wrote: [BTW: A changelog would be useful, either in the patch or in the cover letter.] Sure, I summarize the major changes between

Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-18 Thread Cornelia Huck
On Tue, Dec 12 2023, Haixu Cui wrote: [BTW: A changelog would be useful, either in the patch or in the cover letter.] > The Virtio SPI (Serial Peripheral Interface) device is a virtual > SPI controller that allows the driver to operate and use the SPI > controller under the control of the host.

[virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

2023-12-11 Thread Haixu Cui
The Virtio SPI (Serial Peripheral Interface) device is a virtual SPI controller that allows the driver to operate and use the SPI controller under the control of the host. This patch adds the specification for virtio-spi. Signed-off-by: Haixu Cui Reviewed-by: Viresh Kumar ---