Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Cornelia Huck
On Tue, Jan 18 2022, Xuan Zhuo wrote: > On Tue, 18 Jan 2022 09:39:04 +0100, Cornelia Huck wrote: >> On Tue, Jan 18 2022, Xuan Zhuo wrote: >> >> >> > > above you said bytes sent. >> >> > >> >> > I mean, all about GSO are statistics based on big packets. So here is >> >> > the >> >> > package

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Xuan Zhuo
On Tue, 18 Jan 2022 09:39:04 +0100, Cornelia Huck wrote: > On Tue, Jan 18 2022, Xuan Zhuo wrote: > > >> > > above you said bytes sent. > >> > > >> > I mean, all about GSO are statistics based on big packets. So here is the > >> > package from Guest, and rx is the package passed to Guest. > >> >

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Cornelia Huck
On Tue, Jan 18 2022, Xuan Zhuo wrote: >> > > above you said bytes sent. >> > >> > I mean, all about GSO are statistics based on big packets. So here is the >> > package from Guest, and rx is the package passed to Guest. >> >> it's a subtle distinction that we need to make. > > I will make this

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Tue, 18 Jan 2022 02:16:35 -0500, Michael S. Tsirkin wrote: > On Tue, Jan 18, 2022 at 11:34:25AM +0800, Xuan Zhuo wrote: > > On Tue, 18 Jan 2022 11:26:21 +0800, Jason Wang wrote: > > > On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 17 Jan 2022 15:06:52 +0800,

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2022 at 11:34:25AM +0800, Xuan Zhuo wrote: > On Tue, 18 Jan 2022 11:26:21 +0800, Jason Wang wrote: > > On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo > > wrote: > > > > > > On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang > > > wrote: > > > > > > > > 在 2022/1/17 上午10:14, Xuan Zhuo

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Tue, 18 Jan 2022 11:26:21 +0800, Jason Wang wrote: > On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo wrote: > > > > On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang wrote: > > > > > > 在 2022/1/17 上午10:14, Xuan Zhuo 写道: > > > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > > > wrote: >

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Jason Wang
On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo wrote: > > On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang wrote: > > > > 在 2022/1/17 上午10:14, Xuan Zhuo 写道: > > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > > wrote: > > >> On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > >

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Mon, 17 Jan 2022 09:13:41 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 17, 2022 at 04:21:50PM +0800, Xuan Zhuo wrote: > > On Mon, 17 Jan 2022 03:12:20 -0500, Michael S. Tsirkin > > wrote: > > > On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > > > > On Sat, 15 Jan 2022 13:17:26

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 04:21:50PM +0800, Xuan Zhuo wrote: > On Mon, 17 Jan 2022 03:12:20 -0500, Michael S. Tsirkin > wrote: > > On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > > wrote: > > > > On Tue, Jan 11, 2022 at

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Mon, 17 Jan 2022 03:12:20 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > wrote: > > > On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > > > > This patch allows the driver

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > wrote: > > On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > > > This patch allows the driver to obtain some statistics from the device. > > > > > > In the back-end

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-16 Thread Xuan Zhuo
On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang wrote: > > 在 2022/1/17 上午10:14, Xuan Zhuo 写道: > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > wrote: > >> On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > >>> This patch allows the driver to obtain some statistics from

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-16 Thread Jason Wang
在 2022/1/17 上午10:14, Xuan Zhuo 写道: On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin wrote: On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: This patch allows the driver to obtain some statistics from the device. In the back-end implementation, we can count a lot of such

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-16 Thread Xuan Zhuo
On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin wrote: > On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such information, > > which can be

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-15 Thread Michael S. Tsirkin
On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > This patch allows the driver to obtain some statistics from the device. > > In the back-end implementation, we can count a lot of such information, > which can be used for debugging and judging the running status of the > back-end. We

[virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-10 Thread Xuan Zhuo
This patch allows the driver to obtain some statistics from the device. In the back-end implementation, we can count a lot of such information, which can be used for debugging and judging the running status of the back-end. We hope to directly display it to the user through ethtool.