[virtio-dev] Re: [virtio-comment] 回复:[virtio-dev] [PATCH v8] virtio_net: support for split transport header

2023-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2023 at 04:20:57AM +, Parav Pandit wrote: > > > > From: Heng Qi > > Sent: Wednesday, February 1, 2023 10:45 PM > > > > 在 2023/2/2 上午9:45, Parav Pandit 写道: > > >> From: Heng Qi > > >> Sent: Wednesday, February 1, 2023 8:18 AM > > > [..] > > > > > >>> Response > > >>> >

[virtio-dev] RE: [virtio-comment] 回复:[virtio-dev] [PATCH v8] virtio_net: support for split transport header

2023-02-01 Thread Parav Pandit
> From: Heng Qi > Sent: Wednesday, February 1, 2023 10:45 PM > > 在 2023/2/2 上午9:45, Parav Pandit 写道: > >> From: Heng Qi > >> Sent: Wednesday, February 1, 2023 8:18 AM > > [..] > > > >>> Response > >>> > >>> Page alignment requirements should not come from the virtio spec. > >>> There are

[virtio-dev] RE: [virtio-comment] 回复:[virtio-dev] [PATCH v8] virtio_net: support for split transport header

2023-02-01 Thread Parav Pandit
> From: Heng Qi > Sent: Wednesday, February 1, 2023 8:18 AM [..] > > Response > > > > Page alignment requirements should not come from the virtio spec. > > There are a variety of cases which may use non page aligned data buffers. > > a. A kernel only consumer can use it who doesn't have

[virtio-dev] RE: [virtio-comment] 回复:[virtio-dev] [PATCH v8] virtio_net: support for split transport header

2023-01-31 Thread Parav Pandit
January 31, 2023 4:23 AM To: virtio-dev ; virtio-comment Cc: Michael S. Tsirkin ; Jason Wang ; Cornelia Huck ; Kangjie Xu ; Xuan Zhuo Subject: [virtio-comment] 回复:[virtio-dev] [PATCH v8] virtio_net: support for split transport header Hi, all. Split header is a technique with important ap

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-20 Thread Heng Qi
On Sat, Oct 08, 2022 at 12:37:45PM +0800, Jason Wang wrote: > On Thu, Sep 29, 2022 at 3:04 PM Michael S. Tsirkin wrote: > > > > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > > > On Wed, Sep 28, 2022 at 9:39 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Sep 26, 2022

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-17 Thread Xuan Zhuo
FYI: A new rx zerocopy idea, which is different from Eric's tcp mmap zerocopy, the buffer comes from user mode and put to device, no longer requires page alignment, but still depends on split header.

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-13 Thread Michael S. Tsirkin
On Thu, Oct 13, 2022 at 02:47:55PM +0800, Jason Wang wrote: > On Wed, Oct 12, 2022 at 1:05 PM Michael S. Tsirkin wrote: > > > > On Wed, Oct 12, 2022 at 11:17:30AM +0800, Jason Wang wrote: > > > On Tue, Oct 11, 2022 at 1:12 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Sat, Oct 08, 2022

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-13 Thread Jason Wang
On Wed, Oct 12, 2022 at 1:05 PM Michael S. Tsirkin wrote: > > On Wed, Oct 12, 2022 at 11:17:30AM +0800, Jason Wang wrote: > > On Tue, Oct 11, 2022 at 1:12 AM Michael S. Tsirkin wrote: > > > > > > On Sat, Oct 08, 2022 at 12:37:45PM +0800, Jason Wang wrote: > > > > On Thu, Sep 29, 2022 at 3:04 PM

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-11 Thread Michael S. Tsirkin
On Wed, Oct 12, 2022 at 11:17:30AM +0800, Jason Wang wrote: > On Tue, Oct 11, 2022 at 1:12 AM Michael S. Tsirkin wrote: > > > > On Sat, Oct 08, 2022 at 12:37:45PM +0800, Jason Wang wrote: > > > On Thu, Sep 29, 2022 at 3:04 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Thu, Sep 29, 2022

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-11 Thread Jason Wang
On Tue, Oct 11, 2022 at 1:12 AM Michael S. Tsirkin wrote: > > On Sat, Oct 08, 2022 at 12:37:45PM +0800, Jason Wang wrote: > > On Thu, Sep 29, 2022 at 3:04 PM Michael S. Tsirkin wrote: > > > > > > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > > > > On Wed, Sep 28, 2022 at 9:39 PM

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-10 Thread Michael S. Tsirkin
On Sat, Oct 08, 2022 at 12:37:45PM +0800, Jason Wang wrote: > On Thu, Sep 29, 2022 at 3:04 PM Michael S. Tsirkin wrote: > > > > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > > > On Wed, Sep 28, 2022 at 9:39 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Sep 26, 2022

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-08 Thread Xuan Zhuo
On Sat, 8 Oct 2022 12:37:45 +0800, Jason Wang wrote: > On Thu, Sep 29, 2022 at 3:04 PM Michael S. Tsirkin wrote: > > > > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > > > On Wed, Sep 28, 2022 at 9:39 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Sep 26, 2022 at

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-10-07 Thread Jason Wang
On Thu, Sep 29, 2022 at 3:04 PM Michael S. Tsirkin wrote: > > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > > On Wed, Sep 28, 2022 at 9:39 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Sep 26, 2022 at 04:06:17PM +0800, Jason Wang wrote: > > > > > Jason I think the issue with

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-29 Thread Xuan Zhuo
On Thu, 29 Sep 2022 06:06:41 -0400, "Michael S. Tsirkin" wrote: > On Thu, Sep 29, 2022 at 04:24:02PM +0800, Xuan Zhuo wrote: > > On Thu, 29 Sep 2022 03:04:03 -0400, "Michael S. Tsirkin" > > wrote: > > > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > > > > On Wed, Sep 28, 2022 at

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-29 Thread Michael S. Tsirkin
On Thu, Sep 29, 2022 at 04:24:02PM +0800, Xuan Zhuo wrote: > On Thu, 29 Sep 2022 03:04:03 -0400, "Michael S. Tsirkin" > wrote: > > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > > > On Wed, Sep 28, 2022 at 9:39 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Sep 26,

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-29 Thread Xuan Zhuo
On Thu, 29 Sep 2022 03:04:03 -0400, "Michael S. Tsirkin" wrote: > On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > > On Wed, Sep 28, 2022 at 9:39 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Sep 26, 2022 at 04:06:17PM +0800, Jason Wang wrote: > > > > > Jason I think the issue

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-29 Thread Michael S. Tsirkin
On Thu, Sep 29, 2022 at 09:48:33AM +0800, Jason Wang wrote: > On Wed, Sep 28, 2022 at 9:39 PM Michael S. Tsirkin wrote: > > > > On Mon, Sep 26, 2022 at 04:06:17PM +0800, Jason Wang wrote: > > > > Jason I think the issue with previous proposals is that they conflict > > > > with

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-28 Thread Jason Wang
On Wed, Sep 28, 2022 at 9:39 PM Michael S. Tsirkin wrote: > > On Mon, Sep 26, 2022 at 04:06:17PM +0800, Jason Wang wrote: > > > Jason I think the issue with previous proposals is that they conflict > > > with VIRTIO_F_ANY_LAYOUT. We have repeatedly found that giving the > > > driver flexibility

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-28 Thread Michael S. Tsirkin
On Mon, Sep 26, 2022 at 04:06:17PM +0800, Jason Wang wrote: > > Jason I think the issue with previous proposals is that they conflict > > with VIRTIO_F_ANY_LAYOUT. We have repeatedly found that giving the > > driver flexibility in arranging the packet in memory is benefitial. > > > Yes, but I

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-27 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 09:43:36AM +0800, Xuan Zhuo wrote: > References: <1663297006-64248-1-git-send-email-hen...@linux.alibaba.com> > <3c3cc916-c605-1ed2-d3ff-d8d8ce668...@redhat.com> > <20220920032824.ga125...@h68b04307.sqa.eu95> > > <1663903426.8765974-1-xuanz...@linux.alibaba.com> > >

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-26 Thread Jason Wang
在 2022/9/23 13:59, Michael S. Tsirkin 写道: On Fri, Sep 23, 2022 at 12:04:28PM +0800, Jason Wang wrote: On Fri, Sep 23, 2022 at 11:33 AM Xuan Zhuo wrote: On Wed, 21 Sep 2022 14:20:19 +0800, Jason Wang wrote: On Tue, Sep 20, 2022 at 11:28 AM Heng Qi wrote: On Tue, Sep 20, 2022 at

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-23 Thread Xuan Zhuo
On Fri, 23 Sep 2022 07:04:10 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 23, 2022 at 06:48:56PM +0800, Xuan Zhuo wrote: > > On Fri, 23 Sep 2022 06:44:54 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Sep 23, 2022 at 02:57:27PM +0800, Xuan Zhuo wrote: > > > > > > > Michael doesn't

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2022 at 06:48:56PM +0800, Xuan Zhuo wrote: > On Fri, 23 Sep 2022 06:44:54 -0400, "Michael S. Tsirkin" > wrote: > > On Fri, Sep 23, 2022 at 02:57:27PM +0800, Xuan Zhuo wrote: > > > > > > Michael doesn't want to use desc chain, it's not just a performance > > > > > > issue. In an

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-23 Thread Xuan Zhuo
On Fri, 23 Sep 2022 06:44:54 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 23, 2022 at 02:57:27PM +0800, Xuan Zhuo wrote: > > > > > Michael doesn't want to use desc chain, it's not just a performance > > > > > issue. In an > > > > > early email, he mentioned that desc chain may be abandoned

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-23 Thread Michael S. Tsirkin
On Fri, Sep 23, 2022 at 02:57:27PM +0800, Xuan Zhuo wrote: > > > > Michael doesn't want to use desc chain, it's not just a performance > > > > issue. In an > > > > early email, he mentioned that desc chain may be abandoned in the > > > > future. So we > > > > have been trying not to rely on desc

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-22 Thread Michael S. Tsirkin
On Fri, Sep 23, 2022 at 12:04:28PM +0800, Jason Wang wrote: > On Fri, Sep 23, 2022 at 11:33 AM Xuan Zhuo wrote: > > > > On Wed, 21 Sep 2022 14:20:19 +0800, Jason Wang wrote: > > > On Tue, Sep 20, 2022 at 11:28 AM Heng Qi wrote: > > > > > > > > On Tue, Sep 20, 2022 at 09:59:22AM +0800, Jason

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-22 Thread Jason Wang
On Fri, Sep 23, 2022 at 11:33 AM Xuan Zhuo wrote: > > On Wed, 21 Sep 2022 14:20:19 +0800, Jason Wang wrote: > > On Tue, Sep 20, 2022 at 11:28 AM Heng Qi wrote: > > > > > > On Tue, Sep 20, 2022 at 09:59:22AM +0800, Jason Wang wrote: > > > > > > > > 在 2022/9/16 10:56, hengqi 写道: > > > > >From:

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-21 Thread Jason Wang
On Wed, Sep 21, 2022 at 2:20 PM Jason Wang wrote: > > On Tue, Sep 20, 2022 at 11:28 AM Heng Qi wrote: > > > > On Tue, Sep 20, 2022 at 09:59:22AM +0800, Jason Wang wrote: > > > > > > 在 2022/9/16 10:56, hengqi 写道: > > > >From: Xuan Zhuo > > > > > > > >The purpose of this feature is to split the

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-21 Thread Jason Wang
On Tue, Sep 20, 2022 at 11:28 AM Heng Qi wrote: > > On Tue, Sep 20, 2022 at 09:59:22AM +0800, Jason Wang wrote: > > > > 在 2022/9/16 10:56, hengqi 写道: > > >From: Xuan Zhuo > > > > > >The purpose of this feature is to split the transport header and the > > >payload > > >of the packet. > > > > >

Re: [virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-19 Thread Jason Wang
在 2022/9/16 10:56, hengqi 写道: From: Xuan Zhuo The purpose of this feature is to split the transport header and the payload of the packet. | receive buffer1(page)| receive buffer2(page) | |<- offset ->| virtnet hdr | mac | ip | tcp |<- hold ->|payload

[virtio-dev] [PATCH v8] virtio_net: support for split transport header

2022-09-15 Thread hengqi
From: Xuan Zhuo The purpose of this feature is to split the transport header and the payload of the packet. | receive buffer1(page)| receive buffer2(page) | |<- offset ->| virtnet hdr | mac | ip | tcp |<- hold ->|payload|