Re: [virtio-dev] [PATCH v9] virtio-net: add Max MTU configuration field

2016-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2016 at 10:20:24AM -0400, Aaron Conole wrote: > > Again, sorry for being late with comments, but I'll vote with no for > > now. I can still change the vote if you can convince me, though. > > No problem, thanks so much for the review. I'm hoping you would be > convinced to change

Re: [virtio-dev] [PATCH v9] virtio-net: add Max MTU configuration field

2016-09-07 Thread Aaron Conole
"Michael S. Tsirkin" writes: > On Wed, Sep 07, 2016 at 11:18:22AM +0200, Cornelia Huck wrote: >> On Tue, 6 Sep 2016 10:31:01 -0400 >> Aaron Conole wrote: >> >> > this as this is up for vote> >> >> > diff --git a/content.tex b/content.tex >> > index

Re: [virtio-dev] [PATCH v9] virtio-net: add Max MTU configuration field

2016-09-07 Thread Aaron Conole
Cornelia Huck writes: > On Tue, 6 Sep 2016 10:31:01 -0400 > Aaron Conole wrote: > > this as this is up for vote> > >> diff --git a/content.tex b/content.tex >> index 4b45678..b90cbad 100644 >> --- a/content.tex >> +++ b/content.tex >> @@ -3049,6

Re: [virtio-dev] [PATCH v9] virtio-net: add Max MTU configuration field

2016-09-07 Thread Michael S. Tsirkin
On Wed, Sep 07, 2016 at 11:18:22AM +0200, Cornelia Huck wrote: > On Tue, 6 Sep 2016 10:31:01 -0400 > Aaron Conole wrote: > > this as this is up for vote> > > > diff --git a/content.tex b/content.tex > > index 4b45678..b90cbad 100644 > > --- a/content.tex > > +++

Re: [virtio-dev] [PATCH v9] virtio-net: add Max MTU configuration field

2016-09-07 Thread Cornelia Huck
On Tue, 6 Sep 2016 10:31:01 -0400 Aaron Conole wrote: > diff --git a/content.tex b/content.tex > index 4b45678..b90cbad 100644 > --- a/content.tex > +++ b/content.tex > @@ -3049,6 +3049,14 @@ features. > \item[VIRTIO_NET_F_CTRL_GUEST_OFFLOADS (2)] Control channel offloads

[virtio-dev] [PATCH v9] virtio-net: add Max MTU configuration field

2016-09-06 Thread Aaron Conole
It is helpful for a host to indicate it's MTU to be set on guest NICs other than the assumed 1500 byte value. This helps in situations where the host network is using Jumbo Frames, or aiding in PMTU discovery by configuring a homogenous network. It is also helpful for sizing receive buffers