[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-12 Thread Heng Qi
On Sun, Feb 12, 2023 at 04:35:37AM -0500, Michael S. Tsirkin wrote: > On Sat, Feb 11, 2023 at 01:47:16PM +, Parav Pandit wrote: > > > > > > > From: Alvaro Karsz > > > Sent: Saturday, February 11, 2023 3:45 AM > > > > > > > Please add short description something like, > > > > > > > > When

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-12 Thread Heng Qi
On Sat, Feb 11, 2023 at 01:47:16PM +, Parav Pandit wrote: > > > > From: Alvaro Karsz > > Sent: Saturday, February 11, 2023 3:45 AM > > > > > Please add short description something like, > > > > > > When the driver prefers to use per virtqueue notifications coalescing, > > > and if > >

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-12 Thread Michael S. Tsirkin
On Fri, Feb 10, 2023 at 07:36:03PM +, Parav Pandit wrote: > > > > From: Heng Qi > > Sent: Friday, February 10, 2023 2:02 AM > > > > Currently, the coalescing profile is directly applied to all queues. > > Say it, > Currently coalescing parameters are grouped for all transmit and receive

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-12 Thread Michael S. Tsirkin
On Sat, Feb 11, 2023 at 01:47:16PM +, Parav Pandit wrote: > > > > From: Alvaro Karsz > > Sent: Saturday, February 11, 2023 3:45 AM > > > > > Please add short description something like, > > > > > > When the driver prefers to use per virtqueue notifications coalescing, > > > and if > >

[virtio-dev] RE: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-11 Thread Parav Pandit
> From: Alvaro Karsz > Sent: Saturday, February 11, 2023 3:45 AM > > > Please add short description something like, > > > > When the driver prefers to use per virtqueue notifications coalescing, and > > if > queue group (transmit or receive) level notification coalescing is enabled, > driver

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-11 Thread Alvaro Karsz
> > Please add short description something like, > > > > When the driver prefers to use per virtqueue notifications coalescing, and > > if queue group (transmit or receive) level notification coalescing is > > enabled, driver SHOULD first disable device level notification coalescing. > > Or it

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-11 Thread Alvaro Karsz
> Please add short description something like, > > When the driver prefers to use per virtqueue notifications coalescing, and if > queue group (transmit or receive) level notification coalescing is enabled, > driver SHOULD first disable device level notification coalescing. > Or it should be, >

[virtio-dev] RE: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Parav Pandit
> From: Heng Qi > Sent: Friday, February 10, 2023 2:02 AM > > Currently, the coalescing profile is directly applied to all queues. Say it, Currently coalescing parameters are grouped for all transmit and receive virtqueues. > This patch supports setting or getting the parameters for a

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Michael S. Tsirkin
On Fri, Feb 10, 2023 at 11:30:40AM +0200, Alvaro Karsz wrote: > > > \devicenormative{\subparagraph}{Notifications Coalescing}{Device Types / > > > Network Device / Device Operation / Control Virtqueue / Notifications > > > Coalescing} > > > > > > -A device SHOULD respond to the

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Alvaro Karsz
> On Fri, Feb 10, 2023 at 03:01:30PM +0800, Heng Qi wrote: > > Currently, the coalescing profile is directly applied to all queues. > > This patch supports setting or getting the parameters for a specified queue, > > and a typical application of this function is NetDIM. > > > > When the traffic

[virtio-dev] Re: [PATCH v2] virtio-net: support the virtqueue coalescing moderation

2023-02-10 Thread Michael S. Tsirkin
On Fri, Feb 10, 2023 at 03:01:30PM +0800, Heng Qi wrote: > Currently, the coalescing profile is directly applied to all queues. > This patch supports setting or getting the parameters for a specified queue, > and a typical application of this function is NetDIM. > > When the traffic between