Re: [virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names

2023-04-17 Thread Halil Pasic
On Mon, 17 Apr 2023 03:04:34 -0400 "Michael S. Tsirkin" wrote: > On Mon, Apr 17, 2023 at 05:18:44AM +0200, Halil Pasic wrote: > > On Tue, 11 Apr 2023 13:35:09 + > > Parav Pandit wrote: > > > > > > From: Cornelia Huck > > > > Sent: Tuesday, April 11, 2023 4:56 AM > > > > > > > >

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names

2023-04-17 Thread Michael S. Tsirkin
On Mon, Apr 17, 2023 at 05:18:44AM +0200, Halil Pasic wrote: > On Tue, 11 Apr 2023 13:35:09 + > Parav Pandit wrote: > > > > From: Cornelia Huck > > > Sent: Tuesday, April 11, 2023 4:56 AM > > > > > > > > Yes, please leave it as F_CONFIG_DATA, as we're just putting some "data" > > >

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names

2023-04-16 Thread Halil Pasic
On Tue, 11 Apr 2023 13:35:09 + Parav Pandit wrote: > > From: Cornelia Huck > > Sent: Tuesday, April 11, 2023 4:56 AM > > > > > Yes, please leave it as F_CONFIG_DATA, as we're just putting some "data" > > there in the end (and F_CONFIG_COOKIE might indeed be confusing for the > > ccw

[virtio-dev] RE: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names

2023-04-11 Thread Parav Pandit
> From: Cornelia Huck > Sent: Tuesday, April 11, 2023 4:56 AM > > Yes, please leave it as F_CONFIG_DATA, as we're just putting some "data" > there in the end (and F_CONFIG_COOKIE might indeed be confusing for the > ccw case.) Since Halil didn't respond for 5+ days + Michel and you propose to

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names

2023-04-11 Thread Cornelia Huck
On Fri, Apr 07 2023, "Michael S. Tsirkin" wrote: > On Wed, Apr 05, 2023 at 03:58:55PM +, Parav Pandit wrote: >> For sure "cookie" is better than "config_data" and I don't have objection to >> "cookie". >> >> But I disagree to the claim that "identifier" is less good than "cookie". >> >>

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [PATCH v12 03/10] content: Rename confusing queue_notify_data and vqn names

2023-04-07 Thread Michael S. Tsirkin
On Wed, Apr 05, 2023 at 03:58:55PM +, Parav Pandit wrote: > > From: Halil Pasic > > Sent: Wednesday, April 5, 2023 11:28 AM > > > > On Wed, 5 Apr 2023 13:21:40 + > > Parav Pandit wrote: > > > > > > VIRTIO_F_NOTIF_CONFIG_DATA is such a narrow usecase, I don't like > > > > burning "vq