Re: RE: [virtio-dev] queue_reset register polarity to improve

2022-04-27 Thread Michael S. Tsirkin
On Wed, Apr 27, 2022 at 04:28:43PM +0800, Xuan Zhuo wrote: > On Tue, 26 Apr 2022 12:00:24 +, Parav Pandit wrote: > > > > > From: Xuan Zhuo > > > Sent: Sunday, April 24, 2022 3:29 AM > > > > > > > > A recently defined queue_reset register has a little weird definition > > > > that > > > we

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 10:26:18 -0400, "Michael S. Tsirkin" wrote: > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > > Hi, > > > > > > A recently defined queue_reset register has a little weird definition > > > that we

Re: RE: [virtio-dev] queue_reset register polarity to improve

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 12:00:24 +, Parav Pandit wrote: > > > From: Xuan Zhuo > > Sent: Sunday, April 24, 2022 3:29 AM > > > > > > A recently defined queue_reset register has a little weird definition that > > we should improve. > > > When driver initiate queue reset, it writes queue_reset = 1.

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-26 Thread Michael S. Tsirkin
On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > Hi, > > > > A recently defined queue_reset register has a little weird definition that > > we should improve. > > When driver initiate queue reset, it writes queue_reset = 1.

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-26 Thread Xuan Zhuo
On Tue, 26 Apr 2022 05:52:17 -0400, "Michael S. Tsirkin" wrote: > On Tue, Apr 26, 2022 at 09:48:29AM +0100, Stefan Hajnoczi wrote: > > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > > > Hi, > > > > > > > > A recently

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-26 Thread Michael S. Tsirkin
On Tue, Apr 26, 2022 at 09:48:29AM +0100, Stefan Hajnoczi wrote: > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > > Hi, > > > > > > A recently defined queue_reset register has a little weird definition > > > that we

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-26 Thread Xuan Zhuo
On Tue, 26 Apr 2022 09:48:29 +0100, Stefan Hajnoczi wrote: > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > > Hi, > > > > > > A recently defined queue_reset register has a little weird definition > > > that we should

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-26 Thread Stefan Hajnoczi
On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > Hi, > > > > A recently defined queue_reset register has a little weird definition that > > we should improve. > > When driver initiate queue reset, it writes queue_reset = 1.

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-24 Thread Xuan Zhuo
On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > Hi, > > A recently defined queue_reset register has a little weird definition that we > should improve. > When driver initiate queue reset, it writes queue_reset = 1. > When device is busy resetting the queue, on this driver request, it