[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 03:57:57PM -0700, Siwei Liu wrote: > On Wed, Apr 25, 2018 at 3:22 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 25, 2018 at 02:38:57PM -0700, Siwei Liu wrote: > >> On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin > >> wrote: > >> > On

[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 05:18:31PM -0700, Stephen Hemminger wrote: > On Wed, 25 Apr 2018 15:57:57 -0700 > Siwei Liu wrote: > > > > > > > I think ideally the infrastructure should suppport flexible matching of > > > NICs - netvsc is already reported to be moving to some kind

[virtio-dev] Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote: > On Wed, 25 Apr 2018 16:59:28 -0700 > Sridhar Samudrala wrote: > > > Use the registration/notification framework supported by the generic > > failover infrastructure. > > > > Signed-off-by: Sridhar

[virtio-dev] Re: [RFC] VIRTIO_F_IO_BARRIER: use I/O barriers in driver

2018-04-25 Thread Paolo Bonzini
On 25/04/2018 10:23, Tiwei Bie wrote: > There will be hardware virtio devices in the future, which > require drivers to use the barriers suitable for I/O device, > compared with software virtio devices which just require > drivers to use the barriers suitable for CPU core. > > To fix the ordering

[virtio-dev] Re: [RFC] VIRTIO_F_IO_BARRIER: use I/O barriers in driver

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 03:23:39PM +0200, Paolo Bonzini wrote: > On 25/04/2018 10:23, Tiwei Bie wrote: > > There will be hardware virtio devices in the future, which > > require drivers to use the barriers suitable for I/O device, > > compared with software virtio devices which just require > >

Re: [virtio-dev] [PATCH] content: document hugetlb page allocation counts

2018-04-25 Thread Jonathan Helman
On 04/19/2018 02:24 AM, Stefan Hajnoczi wrote: On Wed, Apr 18, 2018 at 10:10:19AM -0700, Jonathan Helman wrote: The Linux kernel exports the number of successful and failed hugetlb page allocations via the virtio balloon driver. These two counts need to be documented in this specification.

Re: [virtio-dev] [PATCH] content: document hugetlb page allocation counts

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 11:26:59AM -0700, Jonathan Helman wrote: > > > On 04/19/2018 02:24 AM, Stefan Hajnoczi wrote: > > On Wed, Apr 18, 2018 at 10:10:19AM -0700, Jonathan Helman wrote: > > > The Linux kernel exports the number of successful and failed > > > hugetlb page allocations via the

[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 02:38:57PM -0700, Siwei Liu wrote: > On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin wrote: > > On Mon, Apr 23, 2018 at 12:44:39PM -0700, Siwei Liu wrote: > >> On Mon, Apr 23, 2018 at 10:56 AM, Michael S. Tsirkin > >> wrote: > >> >

[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Siwei Liu
On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin wrote: > On Mon, Apr 23, 2018 at 12:44:39PM -0700, Siwei Liu wrote: >> On Mon, Apr 23, 2018 at 10:56 AM, Michael S. Tsirkin wrote: >> > On Mon, Apr 23, 2018 at 10:44:40AM -0700, Stephen Hemminger wrote: >> >>

[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Siwei Liu
On Wed, Apr 25, 2018 at 3:22 PM, Michael S. Tsirkin wrote: > On Wed, Apr 25, 2018 at 02:38:57PM -0700, Siwei Liu wrote: >> On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin wrote: >> > On Mon, Apr 23, 2018 at 12:44:39PM -0700, Siwei Liu wrote: >> >> On Mon,

[virtio-dev] [PATCH net-next v8 0/4] Enable virtio_net to act as a standby for a passthru device

2018-04-25 Thread Sridhar Samudrala
This is another update based on feedback from MST and Stephen on the last patchset. Hopefully this series can be integrated and any further enhancements can be made on top of this patchset. v8: - Made the failover managment routines more robust by updating the feature bits/other fields in the

[virtio-dev] [PATCH net-next v8 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit

2018-04-25 Thread Sridhar Samudrala
This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. VIRTIO_NET_F_STANDBY is defined as bit 62 as it is a device feature bit. Signed-off-by: Sridhar Samudrala ---

[virtio-dev] [PATCH net-next v8 2/4] net: Introduce generic failover module

2018-04-25 Thread Sridhar Samudrala
This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. It exposes 2 sets of

[virtio-dev] [PATCH net-next v8 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-25 Thread Sridhar Samudrala
This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to enable