[virtio-dev] [PATCH] virtio-gpio: offered -> negotiated

2022-01-25 Thread Michael S. Tsirkin
virtqueues are only discovered after FEATURES_OK. As such it makes no sense to talk about virtqueues being affected by features which are offered but not negotiated, and doing so will confuse the reader. Signed-off-by: Michael S. Tsirkin --- Viresh, others your thoughts on this? Looks like an

[virtio-dev] The virtio spec is now in FREEZE for 1.2

2022-01-25 Thread Cornelia Huck
The virtio spec is now in freeze for the upcoming 1.2 release. What does this mean? - No more issues will be accepted into the 1.2 release, i.e. no more votes will be started. Anything outstanding will be delayed until after we have released 1.2 (which we hope to have done by the end of

[virtio-dev] Re: [PATCH v2 4/4] Add support for MSI-X vectors configuration for PCI VFs

2022-01-25 Thread Michael S. Tsirkin
On Mon, Jan 24, 2022 at 11:39:18AM +0200, Max Gurtovoy wrote: > A typical cloud provider SR-IOV use case is to create many VFs for > use by guest VMs. The VFs may not be assigned to a VM until a user > requests a VM of a certain size, e.g., number of CPUs. A VF may need > MSI-X vectors

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-25 Thread Michael S. Tsirkin
On Tue, Jan 25, 2022 at 12:59:16PM +0200, Max Gurtovoy wrote: > > On 1/25/2022 5:52 AM, Parav Pandit wrote: > > Hi Jason, > > > > > From: Jason Wang > > > Sent: Tuesday, January 25, 2022 8:59 AM > > > > > > 在 2022/1/19 下午12:48, Parav Pandit 写道: > > > > > From: Jason Wang > > > > > Sent:

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-25 Thread Cornelia Huck
On Mon, Jan 24 2022, "Michael S. Tsirkin" wrote: > It's true. However, that's a generic rule and specific devices > can differ. and if you look at specific instances, you will > see that they typically require that the feature is negotiated. > For example: > > \item If the VIRTIO_BLK_F_BLK_SIZE

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-25 Thread Cornelia Huck
On Mon, Jan 24 2022, Halil Pasic wrote: > On Fri, 21 Jan 2022 17:05:07 +0100 > Cornelia Huck wrote: > >> On Fri, Jan 21 2022, Halil Pasic wrote: >> >> > On Thu, 20 Jan 2022 14:05:37 +0100 >> > Cornelia Huck wrote: >> > >> >> On Wed, Jan 19 2022, "Michael S. Tsirkin" wrote: >> >> >> >>

[virtio-dev] Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation

2022-01-25 Thread Michael S. Tsirkin
On Tue, Jan 25, 2022 at 03:57:30PM +0100, Cornelia Huck wrote: > On Mon, Jan 24 2022, "Michael S. Tsirkin" wrote: > > > It's true. However, that's a generic rule and specific devices > > can differ. and if you look at specific instances, you will > > see that they typically require that the

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-25 Thread Jason Wang
On Wed, Jan 26, 2022 at 1:58 PM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Wednesday, January 26, 2022 11:15 AM > > > It does not matter if the SF is created over PCI PF or VF. Its on top of > > > PCI virtio > > device. > > > When/if someone creates SF over PCI VF, PCI VF is

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-25 Thread Jason Wang
On Wed, Jan 26, 2022 at 1:26 PM Parav Pandit wrote: > > > > > From: Jason Wang > > Sent: Wednesday, January 26, 2022 10:35 AM > > > > 在 2022/1/25 上午11:52, Parav Pandit 写道: > > > Hi Jason, > > > > > >> From: Jason Wang > > >> Sent: Tuesday, January 25, 2022 8:59 AM > > >> > > >> 在 2022/1/19

[virtio-dev] Re: [PATCH 4/5] virtio-net: add support for VIRTIO_F_ADMIN_VQ

2022-01-25 Thread Jason Wang
On Tue, Jan 25, 2022 at 3:20 PM Michael S. Tsirkin wrote: > > On Tue, Jan 25, 2022 at 11:53:35AM +0800, Jason Wang wrote: > > On Wed, Jan 19, 2022 at 5:26 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Jan 19, 2022 at 12:16:47PM +0800, Jason Wang wrote: > > > > > We also need > > > > > -

[virtio-dev] Re: [PATCH 4/5] virtio-net: add support for VIRTIO_F_ADMIN_VQ

2022-01-25 Thread Michael S. Tsirkin
On Wed, Jan 26, 2022 at 01:49:05PM +0800, Jason Wang wrote: > On Tue, Jan 25, 2022 at 3:20 PM Michael S. Tsirkin wrote: > > > > On Tue, Jan 25, 2022 at 11:53:35AM +0800, Jason Wang wrote: > > > On Wed, Jan 19, 2022 at 5:26 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Jan 19, 2022

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-25 Thread Jason Wang
在 2022/1/25 上午11:52, Parav Pandit 写道: Hi Jason, From: Jason Wang Sent: Tuesday, January 25, 2022 8:59 AM 在 2022/1/19 下午12:48, Parav Pandit 写道: From: Jason Wang Sent: Wednesday, January 19, 2022 9:33 AM It it means IMS, there's already a proposal[1] that introduce MSI commands via the

[virtio-dev] Re: [PATCH 4/5] virtio-net: add support for VIRTIO_F_ADMIN_VQ

2022-01-25 Thread Jason Wang
On Wed, Jan 26, 2022 at 3:02 PM Michael S. Tsirkin wrote: > > On Wed, Jan 26, 2022 at 01:49:05PM +0800, Jason Wang wrote: > > On Tue, Jan 25, 2022 at 3:20 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jan 25, 2022 at 11:53:35AM +0800, Jason Wang wrote: > > > > On Wed, Jan 19, 2022 at 5:26 PM

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-25 Thread Jason Wang
On Wed, Jan 26, 2022 at 2:25 PM Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Wednesday, January 26, 2022 11:36 AM > > > > On Wed, Jan 26, 2022 at 1:58 PM Parav Pandit wrote: > > > > > > > > > > > > > From: Jason Wang > > > > Sent: Wednesday, January 26, 2022 11:15 AM > > > > > It

[virtio-dev] Re: [PATCH 2/5] Introduce VIRTIO_F_ADMIN_VQ_INDIRECT_DESC/VIRTIO_F_ADMIN_VQ_IN_ORDER

2022-01-25 Thread Jason Wang
On Tue, Jan 25, 2022 at 6:59 PM Max Gurtovoy wrote: > > > On 1/25/2022 5:52 AM, Parav Pandit wrote: > > Hi Jason, > > > >> From: Jason Wang > >> Sent: Tuesday, January 25, 2022 8:59 AM > >> > >> 在 2022/1/19 下午12:48, Parav Pandit 写道: > From: Jason Wang > Sent: Wednesday, January 19,