[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-06 Thread Michael S. Tsirkin
On Tue, Mar 06, 2018 at 03:27:46PM -0800, Alexander Duyck wrote: > > I definitelly vote for a separate common shared code for both netvsc and > > virtio_net - even if you use 2 and 3 netdev model, you could share the > > common code. Strict checks and limitation should be in place. > > Noted. But

[virtio-dev] Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-03-06 Thread Alexander Duyck
On Tue, Mar 6, 2018 at 12:19 PM, Don Dutile wrote: > On 03/05/2018 04:41 PM, Alexander Duyck wrote: >> >> On Mon, Mar 5, 2018 at 12:57 PM, Don Dutile wrote: >>> >>> On 03/01/2018 03:22 PM, Alex Williamson wrote: On Wed, 28 Feb 2018 16:36:38

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-06 Thread Alexander Duyck
On Tue, Mar 6, 2018 at 2:59 PM, Jiri Pirko wrote: > Tue, Mar 06, 2018 at 08:08:21PM CET, alexander.du...@gmail.com wrote: >>On Mon, Mar 5, 2018 at 7:15 PM, Stephen Hemminger >> wrote: >>> On Mon, 5 Mar 2018 14:47:20 -0800 >>> Alexander Duyck

[virtio-dev] [pci PATCH v3 3/3] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

2018-03-06 Thread Alexander Duyck
From: Alexander Duyck Hardware-realized virtio_pci devices can implement SR-IOV, so this patch enables its use. The device in question is an upcoming Intel NIC that implements both a virtio_net PF and virtio_net VFs. These are hardware realizations of what has been

[virtio-dev] [pci PATCH v3 2/3] vfio: Add support for unmanaged or userspace managed SR-IOV

2018-03-06 Thread Alexander Duyck
From: Alexander Duyck This patch is meant to allow assignment of an SR-IOV enabled PF, as in VFs have been generated, with vfio-pci. My understanding is the primary use case for this is something like DPDK running the PF while the VFs are all assigned to guests. A

[virtio-dev] [pci PATCH v3 1/3] pci-iov: Add support for unmanaged SR-IOV

2018-03-06 Thread Alexander Duyck
From: Alexander Duyck This patch is meant to add some basic functionality to support for SR-IOV on devices when the VFs are not managed by the kernel. The functions provided here can be used by drivers such as vfio-pci and virtio to enable SR-IOV on devices that are

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-06 Thread Alexander Duyck
On Mon, Mar 5, 2018 at 7:15 PM, Stephen Hemminger wrote: > On Mon, 5 Mar 2018 14:47:20 -0800 > Alexander Duyck wrote: > >> On Mon, Mar 5, 2018 at 2:30 PM, Jiri Pirko wrote: >> > Mon, Mar 05, 2018 at 05:11:32PM CET,

[virtio-dev] Re: [PATCH 1/4] eth: add speed and duplex definitions

2018-03-06 Thread Michael S. Tsirkin
On Tue, Mar 06, 2018 at 12:53:14PM -0500, Jason Baron wrote: > > > On 03/02/2018 12:54 PM, Michael S. Tsirkin wrote: > > On Thu, Mar 01, 2018 at 10:46:33PM -0500, Jason Baron wrote: > >> Pull in definitions for SPEED_UNKNOWN, DUPLEX_UNKNOWN, DUPLEX_HALF, > >> and DUPLEX_FULL. > >> > >>

Re: [virtio-dev] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net

2018-03-06 Thread Michael S. Tsirkin
On Tue, Mar 06, 2018 at 01:02:06PM -0500, Jason Baron wrote: > > > On 03/04/2018 08:05 AM, Yan Vugenfirer wrote: > > > > > >> On 2 Mar 2018, at 22:19, Michael S. Tsirkin >> > wrote: > >> > >> On Fri, Mar 02, 2018 at 03:14:01PM +0800, Jason Wang wrote:

Re: [virtio-dev] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net

2018-03-06 Thread Jason Baron
On 03/04/2018 08:05 AM, Yan Vugenfirer wrote: > > >> On 2 Mar 2018, at 22:19, Michael S. Tsirkin > > wrote: >> >> On Fri, Mar 02, 2018 at 03:14:01PM +0800, Jason Wang wrote: >>> >>> >>> On 2018年03月02日 11:46, Jason Baron wrote: Although linkspeed

[virtio-dev] Re: [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net

2018-03-06 Thread Jason Baron
On 03/02/2018 03:22 PM, Michael S. Tsirkin wrote: > On Fri, Mar 02, 2018 at 11:59:00AM -0500, Jason Baron wrote: >> On 03/02/2018 02:14 AM, Jason Wang wrote: >>> >>> >>> On 2018年03月02日 11:46, Jason Baron wrote: Although linkspeed and duplex can be set in a linux guest via 'ethtool -s',

[virtio-dev] Re: [PATCH 1/4] eth: add speed and duplex definitions

2018-03-06 Thread Jason Baron
On 03/02/2018 12:54 PM, Michael S. Tsirkin wrote: > On Thu, Mar 01, 2018 at 10:46:33PM -0500, Jason Baron wrote: >> Pull in definitions for SPEED_UNKNOWN, DUPLEX_UNKNOWN, DUPLEX_HALF, >> and DUPLEX_FULL. >> >> Signed-off-by: Jason Baron >> Cc: "Michael S. Tsirkin"

[virtio-dev] Re: [virtio] [PATCH] introduction: add note on bitfield portability

2018-03-06 Thread Cornelia Huck
On Tue, 6 Mar 2018 16:35:46 +0200 "Michael S. Tsirkin" wrote: [You picked my old email address :)] > Signed-off-by: Michael S. Tsirkin > --- > introduction.tex | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/introduction.tex

[virtio-dev] [PATCH] introduction: add note on bitfield portability

2018-03-06 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- introduction.tex | 7 +++ 1 file changed, 7 insertions(+) diff --git a/introduction.tex b/introduction.tex index d0b770e..18ad76e 100644 --- a/introduction.tex +++ b/introduction.tex @@ -175,5 +175,12 @@ packed by C compilers on

[virtio-dev] Re: [PATCH] introduction: document bitfield notation

2018-03-06 Thread Cornelia Huck
On Mon, 5 Mar 2018 23:11:40 +0200 "Michael S. Tsirkin" wrote: > On Mon, Mar 05, 2018 at 05:04:40PM +0100, Cornelia Huck wrote: > > On Mon, 5 Mar 2018 16:26:11 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Mar 05, 2018 at 03:20:35PM +0100, Cornelia