Re: [virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

On Thu, Mar 15, 2018 at 09:15:48AM +0800, Wei Wang wrote: > On 03/14/2018 10:12 PM, Michael S. Tsirkin wrote: > > On Wed, Mar 14, 2018 at 02:03:19PM +0800, Wei Wang wrote: > > > On 03/14/2018 10:53 AM, Michael S. Tsirkin wrote: > > > > On Wed, Mar 14, 2018 at 10:43:01AM +0800, Wei Wang wrote: > >

Re: [virtio-dev] [RFC virtio-net 1/1] content: net: Add VIRTIO_NET_F_CTRL_RSS feature

On 2018年01月26日 00:27, Sameeh Jubran wrote: From: Sameeh Jubran Most modern high end network devices today support configurable hash functions, this commit introduces RSS - Receive Side Scaling - [1] to virtio net device. The RSS is a technology from Microsoft that boosts

[virtio-dev] Re: [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap

On Wed, Mar 14, 2018 at 07:42:59PM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Wed, Mar 14, 2018 at 06:11:37PM +, Dr. David Alan Gilbert wrote: > > > > +used_len = block->used_length - offset; > > > > +addr += used_len; >

[virtio-dev] Re: [PATCH v4 2/4] migration: API to clear bits of guest free pages from the dirty bitmap

On Wed, Mar 14, 2018 at 06:11:37PM +, Dr. David Alan Gilbert wrote: > > +used_len = block->used_length - offset; > > +addr += used_len; > > +} > > + > > +start = offset >> TARGET_PAGE_BITS; > > +npages = used_len >> TARGET_PAGE_BITS; > > +

[virtio-dev] Re: [PATCH 0/7] Packed ring layout wording and typo fixes

On Wed, Mar 14, 2018 at 03:46:11PM +, Stefan Hajnoczi wrote: > These patches tweak the wording and fix typos in v10 of the packed ring layout > spec. > > Michael: Feel free to squash this into your patch series if you agree with the > changes. I don't mind if my authorship disappears. I

[virtio-dev] Re: [PATCH 0/7] Packed ring layout wording and typo fixes

On 03/14/2018 04:46 PM, Stefan Hajnoczi wrote: > These patches tweak the wording and fix typos in v10 of the packed ring layout > spec. All your changes made sense to me (but I'm certainly no authority when it comes to grammar). > > Michael: Feel free to squash this into your patch series if

[virtio-dev] [PATCH 1/7] packed-ring: add missing articles to sentences

There are several sentence structures used throughout the text where an article is missing. For example: ... allocated by driver. or Driver then notifies the device. Standards documents normally use complete sentences so this patch adds the missing articles required before the noun

[virtio-dev] [PATCH 7/7] packed-ring: rephrase "an example driver code"

Either "an example of driver code" or "a driver code example" would work. Signed-off-by: Stefan Hajnoczi --- packed-ring.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packed-ring.tex b/packed-ring.tex index 60b5559..2ef9559 100644 ---

[virtio-dev] [PATCH 5/7] packed-ring: fix plurals

There are two instances where plural needs to be used instead of singular: 1. "descriptor(s)" is used later in the text, so use it consistently instead of starting with "descriptor" and switching later. 2. "What follows is the requirements" -> "What follows are the requirements"

[virtio-dev] [PATCH 2/7] packed-ring: add missing comma

Signed-off-by: Stefan Hajnoczi --- packed-ring.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packed-ring.tex b/packed-ring.tex index 211a989..bb29619 100644 --- a/packed-ring.tex +++ b/packed-ring.tex @@ -55,7 +55,7 @@ available. Similarly, the

[virtio-dev] [PATCH 6/7] packed-ring: fix "the descriptor flags +field+ is updated"

Either it needs to be "the descriptors flags are update" (since "flags" is plural) or "the descriptor flags field is updated". Since "flags" is a name of a specific field, I chose the latter solution. Signed-off-by: Stefan Hajnoczi --- packed-ring.tex | 4 ++-- 1 file

[virtio-dev] [PATCH 4/7] packed-ring: fix capitalization of names

Names are capitalized, like the Element Length field. General terms like descriptor are not capitalized. This patch fixes two instances where this is inconsistent. Signed-off-by: Stefan Hajnoczi --- packed-ring.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[virtio-dev] [PATCH 3/7] packed-ring: fix 'contigious' typo

Signed-off-by: Stefan Hajnoczi --- packed-ring.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packed-ring.tex b/packed-ring.tex index bb29619..8640192 100644 --- a/packed-ring.tex +++ b/packed-ring.tex @@ -161,7 +161,7 @@ data has been written by

[virtio-dev] [PATCH 0/7] Packed ring layout wording and typo fixes

These patches tweak the wording and fix typos in v10 of the packed ring layout spec. Michael: Feel free to squash this into your patch series if you agree with the changes. I don't mind if my authorship disappears. Stefan Hajnoczi (7): packed-ring: add missing articles to sentences

[virtio-dev] Re: [pci PATCH v6 5/5] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs

On Wed, Mar 14, 2018 at 1:56 AM, Christoph Hellwig wrote: >> + >> +/** >> + * pci_pf_stub_white_list - White list of devices to bind pci-pf-stub onto >> + * >> + * This table provides the list of IDs this driver is supposed to bind >> + * onto. You could think of this as a list of

[virtio-dev] Re: [pci PATCH v6 1/5] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

On Wed, Mar 14, 2018 at 1:54 AM, Christoph Hellwig wrote: > On Tue, Mar 13, 2018 at 02:28:49PM -0700, Alexander Duyck wrote: >> From: Alexander Duyck >> >> This patch adds a common configuration function called >> pci_sriov_configure_simple that will

[virtio-dev] Re: [PATCH v4 4/4] migration: use the free page hint feature from balloon

On Wed, Mar 14, 2018 at 02:50:44PM +0800, Wei Wang wrote: > On 03/14/2018 10:51 AM, Michael S. Tsirkin wrote: > > On Wed, Mar 14, 2018 at 10:41:36AM +0800, Wei Wang wrote: > > > On 03/14/2018 12:35 AM, Michael S. Tsirkin wrote: > > > > On Wed, Mar 07, 2018 at 08:34:25PM +0800, Wei Wang wrote: > >

Re: [virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

On Wed, Mar 14, 2018 at 02:03:19PM +0800, Wei Wang wrote: > On 03/14/2018 10:53 AM, Michael S. Tsirkin wrote: > > On Wed, Mar 14, 2018 at 10:43:01AM +0800, Wei Wang wrote: > > > On 03/14/2018 12:49 AM, Michael S. Tsirkin wrote: > > > > On Wed, Mar 07, 2018 at 08:34:24PM +0800, Wei Wang wrote: > >

[virtio-dev] Re: [virtio] [PATCH] github: PULL_REQUEST_TEMPLATE.md

On Wed, Mar 14, 2018 at 05:32:14AM +0200, Michael S. Tsirkin wrote: > Document that we don't accept pull requests at this point. > > Signed-off-by: Michael S. Tsirkin > --- > .github/PULL_REQUEST_TEMPLATE.md | 10 ++ > 1 file changed, 10 insertions(+) > create mode

[virtio-dev] Re: [PATCH v4 4/4] migration: use the free page hint feature from balloon

On 03/14/2018 10:51 AM, Michael S. Tsirkin wrote: On Wed, Mar 14, 2018 at 10:41:36AM +0800, Wei Wang wrote: On 03/14/2018 12:35 AM, Michael S. Tsirkin wrote: On Wed, Mar 07, 2018 at 08:34:25PM +0800, Wei Wang wrote: Start the free page optimization after the migration bitmap is synchronized.

Re: [virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

On 03/14/2018 10:53 AM, Michael S. Tsirkin wrote: On Wed, Mar 14, 2018 at 10:43:01AM +0800, Wei Wang wrote: On 03/14/2018 12:49 AM, Michael S. Tsirkin wrote: On Wed, Mar 07, 2018 at 08:34:24PM +0800, Wei Wang wrote: Signed-off-by: Wei Wang Signed-off-by: Liang Li