Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [PATCH v13] virtio-net: support inner header hash

2023-05-09 Thread Heng Qi
在 2023/5/5 下午10:56, Michael S. Tsirkin 写道: On Fri, May 05, 2023 at 09:51:15PM +0800, Heng Qi wrote: On Thu, Apr 27, 2023 at 01:13:29PM -0400, Michael S. Tsirkin wrote: On Thu, Apr 27, 2023 at 10:28:29AM +0800, Heng Qi wrote: 在 2023/4/26 下午10:48, Michael S. Tsirkin 写道: On Wed, Apr 26

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [PATCH v13] virtio-net: support inner header hash

2023-05-10 Thread Heng Qi
在 2023/5/9 下午11:15, Michael S. Tsirkin 写道: On Tue, May 09, 2023 at 10:22:19PM +0800, Heng Qi wrote: 在 2023/5/5 下午10:56, Michael S. Tsirkin 写道: On Fri, May 05, 2023 at 09:51:15PM +0800, Heng Qi wrote: On Thu, Apr 27, 2023 at 01:13:29PM -0400, Michael S. Tsirkin wrote: On Thu, Apr 27, 2023

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [PATCH v13] virtio-net: support inner header hash

2023-05-11 Thread Heng Qi
On Thu, May 11, 2023 at 02:22:12AM -0400, Michael S. Tsirkin wrote: > On Wed, May 10, 2023 at 05:15:37PM +0800, Heng Qi wrote: > > > > > > 在 2023/5/9 下午11:15, Michael S. Tsirkin 写道: > > > On Tue, May 09, 2023 at 10:22:19PM +0800, Heng Qi wrote: > > > &

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [PATCH v13] virtio-net: support inner header hash

2023-05-12 Thread Heng Qi
On Fri, May 12, 2023 at 02:54:34AM -0400, Michael S. Tsirkin wrote: > On Fri, May 12, 2023 at 02:00:19PM +0800, Heng Qi wrote: > > On Thu, May 11, 2023 at 02:22:12AM -0400, Michael S. Tsirkin wrote: > > > On Wed, May 10, 2023 at 05:15:37PM +0800, Heng Qi wrote: > > > >

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [PATCH v13] virtio-net: support inner header hash

2023-05-14 Thread Heng Qi
在 2023/5/12 下午7:27, Michael S. Tsirkin 写道: On Fri, May 12, 2023 at 03:23:46PM +0800, Heng Qi wrote: On Fri, May 12, 2023 at 02:54:34AM -0400, Michael S. Tsirkin wrote: On Fri, May 12, 2023 at 02:00:19PM +0800, Heng Qi wrote: On Thu, May 11, 2023 at 02:22:12AM -0400, Michael S. Tsirkin

[virtio-dev] [Proposal] Relationship between XDP and rx-csum in virtio-net

2023-05-22 Thread Heng Qi
Currently, the VIRTIO_NET_F_GUEST_CSUM(NETIF_F_RXCSUM) feature of the virtio-net driver conflicts with the loading of the XDP program, which is caused by the problem described in [1][2], that is, XDP may cause errors in partial csumed-related fields and resulting in packet dropping. rx CHECKSUM_

[virtio-dev] Re: [Proposal] Relationship between XDP and rx-csum in virtio-net

2023-05-22 Thread Heng Qi
On Mon, May 22, 2023 at 03:10:05PM -0400, Michael S. Tsirkin wrote: > On Mon, May 22, 2023 at 08:12:00PM +0800, Heng Qi wrote: > > 1) Add a feature bit to the virtio specification to tell the sender that a > > fully > > csumed packet must be sent. > > Who is the

Re: [virtio-dev] Re: [Proposal] Relationship between XDP and rx-csum in virtio-net

2023-05-23 Thread Heng Qi
On Tue, May 23, 2023 at 03:15:37AM -0400, Michael S. Tsirkin wrote: > On Tue, May 23, 2023 at 10:41:18AM +0800, Heng Qi wrote: > > On Mon, May 22, 2023 at 03:10:05PM -0400, Michael S. Tsirkin wrote: > > > On Mon, May 22, 2023 at 08:12:00PM +0800, Heng Qi wrote: > > > &g

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [Proposal] Relationship between XDP and rx-csum in virtio-net

2023-05-23 Thread Heng Qi
On Tue, May 23, 2023 at 09:30:28AM -0400, Michael S. Tsirkin wrote: > On Tue, May 23, 2023 at 05:18:20PM +0800, Heng Qi wrote: > > On Tue, May 23, 2023 at 03:15:37AM -0400, Michael S. Tsirkin wrote: > > > On Tue, May 23, 2023 at 10:41:18AM +0800, Heng Qi wrote: > > > &

Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [Proposal] Relationship between XDP and rx-csum in virtio-net

2023-05-24 Thread Heng Qi
On Wed, May 24, 2023 at 02:07:14AM -0400, Michael S. Tsirkin wrote: > On Tue, May 23, 2023 at 09:51:44PM +0800, Heng Qi wrote: > > On Tue, May 23, 2023 at 09:30:28AM -0400, Michael S. Tsirkin wrote: > > > On Tue, May 23, 2023 at 05:18:20PM +0800, Heng Qi wrote: > > > &

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [Proposal] Relationship between XDP and rx-csum in virtio-net

2023-05-30 Thread Heng Qi
On Tue, May 30, 2023 at 03:33:22PM -0400, Michael S. Tsirkin wrote: > On Wed, May 24, 2023 at 04:12:46PM +0800, Heng Qi wrote: > > On Wed, May 24, 2023 at 02:07:14AM -0400, Michael S. Tsirkin wrote: > > > On Tue, May 23, 2023 at 09:51:44PM +0800, Heng Qi wrote: > > > &

Re: [virtio-dev] Re: [virtio-comment] [PATCH v17] virtio-net: support inner header hash

2023-06-20 Thread Heng Qi
On Tue, Jun 20, 2023 at 08:06:16AM -0400, Michael S. Tsirkin wrote: > On Mon, Jun 12, 2023 at 04:09:20PM +0800, Heng Qi wrote: > > 1. Currently, a received encapsulated packet has an outer and an inner > > header, but > > the virtio device is unable to calculate the hash for

Re: [virtio-dev] RE: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash

2023-06-21 Thread Heng Qi
在 2023/6/22 上午4:52, Parav Pandit 写道: From: Michael S. Tsirkin Sent: Wednesday, June 21, 2023 4:38 PM And the field is RO so no memory cost to exposing it in all VFs. Two structures do not bring the asymmetry. Accessing current and enabled fields via two different mechanism is bringing the

[virtio-dev] Re: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash

2023-06-22 Thread Heng Qi
在 2023/6/22 下午8:32, Parav Pandit 写道: From: Michael S. Tsirkin Sent: Thursday, June 22, 2023 2:23 AM On Wed, Jun 21, 2023 at 08:52:04PM +, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday, June 21, 2023 4:38 PM And the field is RO so no memory cost to exposing it in all V

[virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Heng Qi
在 2023/6/29 上午9:56, Parav Pandit 写道: From: Michael S. Tsirkin Sent: Wednesday, June 28, 2023 3:45 PM Maybe I get it. You want to use the new features as a carrot to force drivers to implement DMA? You suspect they will ignore the spec requirement just because things seem to work? Right b

[virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-28 Thread Heng Qi
On Thu, Jun 29, 2023 at 01:56:34AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, June 28, 2023 3:45 PM > > > > Maybe I get it. You want to use the new features as a carrot to > > > > force drivers to implement DMA? You suspect they will ignore the > > > > spec

Re: [virtio-dev] Re: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-29 Thread Heng Qi
在 2023/6/29 下午7:48, Michael S. Tsirkin 写道: On Thu, Jun 29, 2023 at 10:05:09AM +0800, Heng Qi wrote: 在 2023/6/29 上午9:56, Parav Pandit 写道: From: Michael S. Tsirkin Sent: Wednesday, June 28, 2023 3:45 PM Maybe I get it. You want to use the new features as a carrot to force drivers to

Re: [virtio-dev] RE: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

2023-06-29 Thread Heng Qi
On Thu, Jun 29, 2023 at 04:59:28PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, June 29, 2023 7:48 AM > > > > > > struct virtio_net_hash_config reserved is fine. > > > > > > +1. > > > > > > Inner header hash is orthogonal to RSS, and it's fine to have its own

[virtio-dev] Re: [PATCH 0/4] Short document fixes to inner hash feature

2023-07-13 Thread Heng Qi
ly (I had missed one underscore in the references yesterday...); maybe we can make the intra-reference links in introdcution.tex a bit nicer, but otherwise, this should be the minimal change to make this build: Perfect. Seems like clearly an editorial fix. Heng Qi, in the future I'd like to ask you

<    1   2