[virtio-dev] Re: [PATCH] virtio-net: support device stats

2021-08-18 Thread Xuan Zhuo
On Wed, 18 Aug 2021 12:41:38 +0800, Jason Wang wrote: > On Tue, Aug 17, 2021 at 11:37 AM Xuan Zhuo wrote: > > > > This patch allows the driver to obtain some statistics from the device, > > such as: > > > > 1. queue_N_rx_drops: Rx packets not passed to the driver

[virtio-dev] [PATCH v2] virtio-net: support device stats

2021-08-23 Thread Xuan Zhuo
-by: Xuan Zhuo --- v2: All keys define by this patch. Not defined by each backend. content.tex | 117 1 file changed, 117 insertions(+) diff --git a/content.tex b/content.tex index 70a9765..b9fd10a 100644 --- a/content.tex +++ b/content.tex

[virtio-dev] [PATCH] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-08-12 Thread Xuan Zhuo
VIRTIO_F_RING_RESET is negotiated. Signed-off-by: Xuan Zhuo --- content.tex | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/content.tex b/content.tex index 7cec1c3..70a9765 100644 --- a/content.tex +++ b/content.tex @@ -1001,7 +1001,13 @@ \subsubsection{Common configuration

Re: [virtio-dev] [PATCH] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-08-26 Thread Xuan Zhuo
On Thu, 26 Aug 2021 12:32:34 +0800, Jason Wang wrote: > > 在 2021/8/23 下午4:28, Xuan Zhuo 写道: > > cc jasow...@redhat.com > > > > On Fri, 13 Aug 2021 10:31:05 +0800, Xuan Zhuo > > wrote: > >> This patch allows the driver to reset a queue individually. &

Re: [virtio-dev] [PATCH] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-08-26 Thread Xuan Zhuo
On Fri, 27 Aug 2021 11:41:11 +0800, Jason Wang wrote: > > 在 2021/8/27 上午11:18, Xuan Zhuo 写道: > > On Thu, 26 Aug 2021 12:32:34 +0800, Jason Wang wrote: > >> 在 2021/8/23 下午4:28, Xuan Zhuo 写道: > >>> cc jasow...@redhat.com > >>> > >>> On

Re: [virtio-dev] [PATCH v2] virtio-net: support device stats

2021-08-26 Thread Xuan Zhuo
On Thu, 26 Aug 2021 12:22:25 +0800, Jason Wang wrote: > > 在 2021/8/23 下午4:27, Xuan Zhuo 写道: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such information, > > which can be

Re: [virtio-dev] [PATCH v2] virtio-net: support device stats

2021-08-27 Thread Xuan Zhuo
On Fri, 27 Aug 2021 11:45:55 +0800, Jason Wang wrote: > > 在 2021/8/27 上午11:22, Xuan Zhuo 写道: > > On Thu, 26 Aug 2021 12:22:25 +0800, Jason Wang wrote: > >> 在 2021/8/23 下午4:27, Xuan Zhuo 写道: > >>> This patch allows the driver to obtain some statistics from the de

[virtio-dev] [PATCH] virtio-net: support device stats

2021-08-16 Thread Xuan Zhuo
display it to the user through ethtool. There is no fixed keys, all keys are defined by the backend itself. Finally it can be directly displayed to the user. Signed-off-by: Xuan Zhuo --- content.tex | 99 + 1 file changed, 99 insertions

[virtio-dev] [PATCH] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-09-16 Thread Xuan Zhuo
for AF_XDP, we need to disable a queue to release all the original buffers when AF_XDP setup. And quickly release all the AF_XDP buffers that have been placed in the queue when AF_XDP exits. Signed-off-by: Xuan Zhuo --- content.tex | 32 +--- 1 file changed, 29

[virtio-dev] [PATCH v3] virtio-net: support device stats

2021-09-16 Thread Xuan Zhuo
-by: Xuan Zhuo --- v3 changes: 1. add dev_version 2. use queue_pair_index replace rx_num, tx_num 3. Explain the processing when the device and driver support different numbers of stats content.tex | 115 1 file changed, 115 insertions(+) diff

Re: [virtio-dev] [PATCH v2] virtio-net: support device stats

2021-09-02 Thread Xuan Zhuo
On Thu, 2 Sep 2021 15:39:44 +0800, Jason Wang wrote: > > 在 2021/8/27 下午2:58, Xuan Zhuo 写道: > > On Fri, 27 Aug 2021 11:45:55 +0800, Jason Wang wrote: > >> 在 2021/8/27 上午11:22, Xuan Zhuo 写道: > >>> On Thu, 26 Aug 2021 12:22:25 +0800, Jason Wang > >>> w

[virtio-dev] Re: [PATCH v5 2/3] virtio: pci support virtqueue reset

2021-10-13 Thread Xuan Zhuo
On Wed, 13 Oct 2021 14:05:14 +0800, Jason Wang wrote: > On Fri, Oct 1, 2021 at 1:50 AM Xuan Zhuo wrote: > > > > PCI support virtqueue reset. > > > > virtio_pci_common_cfg add "queue_reset" to support virtqueue reset. > > The driver uses this to sele

[virtio-dev] [PATCH v6 1/3] virtio: introduce virtqueue reset as basic facility

2021-10-14 Thread Xuan Zhuo
for AF_XDP, we need to disable a queue to release all the original buffers when AF_XDP setup. And quickly release all the AF_XDP buffers that have been placed in the queue when AF_XDP exits. Signed-off-by: Xuan Zhuo --- content.tex | 46 ++ 1 file

[virtio-dev] [PATCH v6 2/3] virtio: pci support virtqueue reset

2021-10-14 Thread Xuan Zhuo
PCI support virtqueue reset. virtio_pci_common_cfg add "queue_reset" to support virtqueue reset. The driver uses this to selectively reset the queue. Signed-off-by: Xuan Zhuo --- content.tex | 32 1 file changed, 32 insertions(+) diff --git a/con

[virtio-dev] [PATCH v6 3/3] virtio: mmio support virtqueue reset

2021-10-14 Thread Xuan Zhuo
mmio support virtqueue reset. MMIO Device Register Layout "QueueReady" to support virtqueue reset. The driver uses this to selectively reset the queue. Signed-off-by: Xuan Zhuo --- content.tex | 33 - 1 file changed, 32 insertions(+), 1 deletion(-)

[virtio-dev] [PATCH v6 0/3] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-10-14 Thread Xuan Zhuo
default values after queue reset. v5: It is defined in the transports that the device can modify the default value after reset, and the driver can use a different configuration to re-enable the device. v4: Cornelia Huck helped me more. Thanks. MMIO support this. Thanks Xuan Zhuo (3

[virtio-dev] [PATCH v4 3/3] virtio: mmio support virtqueue reset

2021-09-28 Thread Xuan Zhuo
mmio support virtqueue reset. MMIO Device Register Layout "QueueReady" to support virtqueue reset. The driver uses this to selectively reset the queue. Signed-off-by: Xuan Zhuo --- content.tex | 29 - 1 file changed, 28 insertions(+), 1 deletion(-)

[virtio-dev] [PATCH v4] virtio-net: support device stats

2021-09-28 Thread Xuan Zhuo
-by: Xuan Zhuo --- v4: 1. remove dev_stats_num, {rx|tx}_stats_num 2. Use two commands to get the stats of queue pair and dev respectively v3 changes: 1. add dev_version 2. use queue_pair_index replace rx_num, tx_num 3. Explain the processing when the device and driver support different numbers

[virtio-dev] [PATCH v4 1/3] virtio: introduce virtqueue reset as basic facility

2021-09-28 Thread Xuan Zhuo
for AF_XDP, we need to disable a queue to release all the original buffers when AF_XDP setup. And quickly release all the AF_XDP buffers that have been placed in the queue when AF_XDP exits. Signed-off-by: Xuan Zhuo --- content.tex | 45 + 1 file changed

[virtio-dev] [PATCH v4 2/3] virtio: pci support virtqueue reset

2021-09-28 Thread Xuan Zhuo
PCI support virtqueue reset. virtio_pci_common_cfg add "queue_reset" to support virtqueue reset. The driver uses this to selectively reset the queue. Signed-off-by: Xuan Zhuo --- content.tex | 28 1 file changed, 28 insertions(+) diff --git a/con

[virtio-dev] [PATCH v4 0/3] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-09-28 Thread Xuan Zhuo
. MMIO support this. Thanks Xuan Zhuo (3): virtio: introduce virtqueue reset as basic facility virtio: pci support virtqueue reset virtio: mmio support virtqueue reset content.tex | 102 +++- 1 file changed, 101 insertions(+), 1 deletion

[virtio-dev] [PATCH v3 0/2] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-09-27 Thread Xuan Zhuo
Hi All: This is a new version to support VIRTIO_F_RING_RESET. The feautre extends the basic facility to allow the driver to reset a virtqueue. This main motivation is to support the reset function of the queue of the network device. Please review. Thanks Xuan Zhuo (2): virtio: introduce

[virtio-dev] [PATCH v3 2/2] virtio: pci support virtqueue reset

2021-09-27 Thread Xuan Zhuo
PCI support virtqueue reset. virtio_pci_common_cfg add "queue_reset" to support virtqueue reset. The driver uses this to selectively reset the queue. Signed-off-by: Xuan Zhuo --- content.tex | 21 + 1 file changed, 21 insertions(+) diff --git a/content.tex b/c

[virtio-dev] [PATCH v3 1/2] virtio: introduce virtqueue reset as basic facility

2021-09-27 Thread Xuan Zhuo
for AF_XDP, we need to disable a queue to release all the original buffers when AF_XDP setup. And quickly release all the AF_XDP buffers that have been placed in the queue when AF_XDP exits. Signed-off-by: Xuan Zhuo --- content.tex | 41 + 1 file changed, 41

[virtio-dev] Re: [PATCH v4 1/3] virtio: introduce virtqueue reset as basic facility

2021-09-28 Thread Xuan Zhuo
On Tue, 28 Sep 2021 12:06:01 +0200, Cornelia Huck wrote: > On Tue, Sep 28 2021, Xuan Zhuo wrote: > > > This patch allows the driver to reset a queue individually. > > > > This is very common on general network equipment. By disabling a queue, > > you can quickl

[virtio-dev] Re: [PATCH v3] virtio-net: support device stats

2021-09-28 Thread Xuan Zhuo
On Wed, 29 Sep 2021 10:07:52 +0800, Jason Wang wrote: > On Tue, Sep 28, 2021 at 11:48 AM Xuan Zhuo wrote: > > > > On Tue, 28 Sep 2021 11:25:40 +0800, Jason Wang wrote: > > > On Mon, Sep 27, 2021 at 2:54 PM Xuan Zhuo > > > wrote: > > > > > >

[virtio-dev] Re: [PATCH v4 2/3] virtio: pci support virtqueue reset

2021-09-28 Thread Xuan Zhuo
On Tue, 28 Sep 2021 12:20:46 +0200, Cornelia Huck wrote: > On Tue, Sep 28 2021, Xuan Zhuo wrote: > > > PCI support virtqueue reset. > > > > virtio_pci_common_cfg add "queue_reset" to support virtqueue reset. > > The driver uses this to selectively rese

[virtio-dev] Re: [PATCH v3] virtio-net: support device stats

2021-09-28 Thread Xuan Zhuo
On Wed, 29 Sep 2021 11:07:21 +0800, Jason Wang wrote: > On Wed, Sep 29, 2021 at 10:34 AM Xuan Zhuo wrote: > > > > On Wed, 29 Sep 2021 10:07:52 +0800, Jason Wang wrote: > > > On Tue, Sep 28, 2021 at 11:48 AM Xuan Zhuo > > > wrote: > > > > > >

[virtio-dev] Re: [PATCH v3] virtio-net: support device stats

2021-09-28 Thread Xuan Zhuo
On Wed, 29 Sep 2021 11:24:50 +0800, Jason Wang wrote: > On Wed, Sep 29, 2021 at 11:14 AM Xuan Zhuo wrote: > > > > On Wed, 29 Sep 2021 11:07:21 +0800, Jason Wang wrote: > > > On Wed, Sep 29, 2021 at 10:34 AM Xuan Zhuo > > > wrote: > > > > > >

Re: [virtio-dev] [PATCH v3 2/2] virtio: pci support virtqueue reset

2021-09-28 Thread Xuan Zhuo
On Mon, 27 Sep 2021 16:51:43 +0200, Cornelia Huck wrote: > On Mon, Sep 27 2021, Xuan Zhuo wrote: > > > PCI support virtqueue reset. > > > > virtio_pci_common_cfg add "queue_reset" to support virtqueue reset. > > The driver uses this to selectively rese

[virtio-dev] [PATCH v5 2/3] virtio: pci support virtqueue reset

2021-09-30 Thread Xuan Zhuo
PCI support virtqueue reset. virtio_pci_common_cfg add "queue_reset" to support virtqueue reset. The driver uses this to selectively reset the queue. Signed-off-by: Xuan Zhuo --- content.tex | 32 1 file changed, 32 insertions(+) diff --git a/con

[virtio-dev] [PATCH v5 0/3] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-09-30 Thread Xuan Zhuo
that the device can modify the default value after reset, and the driver can use a different configuration to re-enable the device. v4: Cornelia Huck helped me more. Thanks. MMIO support this. Thanks Xuan Zhuo (3): virtio: introduce virtqueue reset as basic facility virtio: pci support

[virtio-dev] [PATCH v5 1/3] virtio: introduce virtqueue reset as basic facility

2021-09-30 Thread Xuan Zhuo
for AF_XDP, we need to disable a queue to release all the original buffers when AF_XDP setup. And quickly release all the AF_XDP buffers that have been placed in the queue when AF_XDP exits. Signed-off-by: Xuan Zhuo --- content.tex | 46 ++ 1 file

[virtio-dev] [PATCH v5 3/3] virtio: mmio support virtqueue reset

2021-09-30 Thread Xuan Zhuo
mmio support virtqueue reset. MMIO Device Register Layout "QueueReady" to support virtqueue reset. The driver uses this to selectively reset the queue. Signed-off-by: Xuan Zhuo --- content.tex | 33 - 1 file changed, 32 insertions(+), 1 deletion(-)

[virtio-dev] Re: [PATCH v3] virtio-net: support device stats

2021-09-27 Thread Xuan Zhuo
On Mon, 27 Sep 2021 11:50:35 +0800, Jason Wang wrote: > On Thu, Sep 16, 2021 at 5:33 PM Xuan Zhuo wrote: > > > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such informa

Re: [virtio-dev] [PATCH v3 1/2] virtio: introduce virtqueue reset as basic facility

2021-09-27 Thread Xuan Zhuo
On Mon, 27 Sep 2021 16:37:28 +0200, Cornelia Huck wrote: > On Mon, Sep 27 2021, Xuan Zhuo wrote: > > > This patch allows the driver to reset a queue individually. > > > > This is very common on general network equipment. By disabling a queue, > > you can quickl

[virtio-dev] Re: [PATCH v3 1/2] virtio: introduce virtqueue reset as basic facility

2021-09-27 Thread Xuan Zhuo
On Tue, 28 Sep 2021 11:01:55 +0800, Jason Wang wrote: > On Mon, Sep 27, 2021 at 8:32 PM Xuan Zhuo wrote: > > > > This patch allows the driver to reset a queue individually. > > > > This is very common on general network equipment. By disabling a queue, > > y

[virtio-dev] Re: [PATCH v3] virtio-net: support device stats

2021-09-27 Thread Xuan Zhuo
On Tue, 28 Sep 2021 11:25:40 +0800, Jason Wang wrote: > On Mon, Sep 27, 2021 at 2:54 PM Xuan Zhuo wrote: > > > > On Mon, 27 Sep 2021 11:50:35 +0800, Jason Wang wrote: > > > On Thu, Sep 16, 2021 at 5:33 PM Xuan Zhuo > > > wrote: > > > > > &

[virtio-dev] [PATCH v6] virtio-net: support device stats

2021-12-23 Thread Xuan Zhuo
-by: Xuan Zhuo --- v6: 1. correct the names and descriptions of some stats items v5: 1. add VIRTIO_NET_CTRL_STATS_GET_CTRL_VQ 2. more item for virtio_net_ctrl_reply_stats_queue_pair v4: 1. remove dev_stats_num, {rx|tx}_stats_num 2. Use two commands to get the stats of queue pair and dev

[virtio-dev] [PATCH v7] virtio-net: support device stats

2022-01-04 Thread Xuan Zhuo
-by: Xuan Zhuo --- v7: 1. add rx_reset, tx_reset 2. add device normative and dirver normative 3. add comments for *_packets, *_bytres v6: 1. correct the names and descriptions of some stats items v5: 1. add VIRTIO_NET_CTRL_STATS_GET_CTRL_VQ 2. more item for virtio_net_ctrl_reply_stats_queue_pair

Re: [virtio-dev] [PATCH v7 2/3] virtio: pci support virtqueue reset

2021-11-09 Thread Xuan Zhuo
On Tue, 9 Nov 2021 08:33:39 -0500, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2021 at 02:22:42PM +0800, Xuan Zhuo wrote: > > PCI support virtqueue reset. > > > > virtio_pci_common_cfg add "queue_reset" to support virtqueue reset. > > The driver use

[virtio-dev] [PATCH v7 0/3] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-11-07 Thread Xuan Zhuo
support this. Xuan Zhuo (3): virtio: introduce virtqueue reset as basic facility virtio: pci support virtqueue reset virtio: mmio support virtqueue reset content.tex | 111 +++- 1 file changed, 110 insertions(+), 1 deletion(-) -- 2.31.0

[virtio-dev] [PATCH v7 1/3] virtio: introduce virtqueue reset as basic facility

2021-11-07 Thread Xuan Zhuo
for AF_XDP, we need to disable a queue to release all the original buffers when AF_XDP setup. And quickly release all the AF_XDP buffers that have been placed in the queue when AF_XDP exits. Signed-off-by: Xuan Zhuo --- content.tex | 46 ++ 1 file

[virtio-dev] [PATCH v7 2/3] virtio: pci support virtqueue reset

2021-11-07 Thread Xuan Zhuo
PCI support virtqueue reset. virtio_pci_common_cfg add "queue_reset" to support virtqueue reset. The driver uses this to selectively reset the queue. Signed-off-by: Xuan Zhuo --- content.tex | 32 1 file changed, 32 insertions(+) diff --git a/con

[virtio-dev] [PATCH v7 3/3] virtio: mmio support virtqueue reset

2021-11-07 Thread Xuan Zhuo
mmio support virtqueue reset. MMIO Device Register Layout "QueueReady" to support virtqueue reset. The driver uses this to selectively reset the queue. Signed-off-by: Xuan Zhuo --- content.tex | 33 - 1 file changed, 32 insertions(+), 1 deletion(-)

Re: [virtio-dev] [PATCH v7 0/3] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-12-14 Thread Xuan Zhuo
On Mon, 6 Dec 2021 12:00:26 +0800, Jason Wang wrote: > On Mon, Dec 6, 2021 at 11:06 AM Xuan Zhuo wrote: > > > > On Mon, 8 Nov 2021 14:22:40 +0800, Xuan Zhuo > > wrote: > > > Hi All: > > > > > > This is a new version to support VIRTIO_F_RING_RES

[virtio-dev] [PATCH v5] virtio-net: support device stats

2021-12-15 Thread Xuan Zhuo
-by: Xuan Zhuo --- v5: 1. add VIRTIO_NET_CTRL_STATS_GET_CTRL_VQ 2. more item for virtio_net_ctrl_reply_stats_queue_pair v4: 1. remove dev_stats_num, {rx|tx}_stats_num 2. Use two commands to get the stats of queue pair and dev respectively v3 changes: 1. add dev_version 2. use queue_pair_index

Re: [virtio-dev] [PATCH v4] virtio-net: support device stats

2021-12-05 Thread Xuan Zhuo
On Tue, 28 Sep 2021 17:13:40 +0800, Xuan Zhuo wrote: Hi, everybody, is there anything else I need to do with this patch? When will this patch be merged into, so that I can carry out follow-up work. Thanks. > This patch allows the driver to obtain some statistics from the dev

Re: [virtio-dev] [PATCH v7 0/3] virtio: introduce VIRTIO_F_RING_RESET for reset queue

2021-12-05 Thread Xuan Zhuo
On Mon, 8 Nov 2021 14:22:40 +0800, Xuan Zhuo wrote: > Hi All: > > This is a new version to support VIRTIO_F_RING_RESET. The feautre > extends the basic facility to allow the driver to reset a virtqueue. > This main motivation is to support the reset function of the queue of the &

Re: [virtio-dev] [PATCH v4] virtio-net: support device stats

2021-12-08 Thread Xuan Zhuo
On Mon, 6 Dec 2021 12:12:02 +0800, Jason Wang wrote: > On Mon, Dec 6, 2021 at 11:07 AM Xuan Zhuo wrote: > > > > On Tue, 28 Sep 2021 17:13:40 +0800, Xuan Zhuo > > wrote: > > > > Hi, everybody, is there anything else I need to do with this patch? When > >

[virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-10 Thread Xuan Zhuo
-by: Xuan Zhuo Reviewed-by: Jason Wang --- v8: 1. Modified based on comments by Cornelia Huck v7: 1. add rx_reset, tx_reset 2. add device normative and dirver normative 3. add comments for *_packets, *_bytres v6: 1. correct the names and descriptions of some stats items v5: 1. add

[virtio-dev] Re: [PATCH v8] virtio-net: support device stats

2022-01-11 Thread Xuan Zhuo
On Tue, 11 Jan 2022 15:52:20 +0100, Cornelia Huck wrote: > On Tue, Jan 11 2022, Xuan Zhuo wrote: > > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such information, > > w

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-16 Thread Xuan Zhuo
On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin wrote: > On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such infor

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-16 Thread Xuan Zhuo
On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang wrote: > > 在 2022/1/17 上午10:14, Xuan Zhuo 写道: > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > wrote: > >> On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > >>> This patch allows th

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Mon, 17 Jan 2022 03:12:20 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > > On Sat, 15 Jan 2022 13:17:26 -0500, Michael S. Tsirkin > > wrote: > > > On Tue, Jan 11, 2022 at 12:01:25PM +0800, Xuan Zhuo wrote: > > &g

[virtio-dev] [PATCH v9] virtio-net: support device stats

2022-02-14 Thread Xuan Zhuo
-by: Xuan Zhuo --- conformance.tex | 2 + content.tex | 135 ++-- 2 files changed, 134 insertions(+), 3 deletions(-) diff --git a/conformance.tex b/conformance.tex index 42f8537..950924e 100644 --- a/conformance.tex +++ b/conformance.tex @@ -142,6

[virtio-dev] [PATCH v2] virtio-net: support reset queue

2022-02-10 Thread Xuan Zhuo
This patch defines some requirements for virtio-net to support reset queues. Signed-off-by: Xuan Zhuo --- conformance.tex | 1 + content.tex | 16 2 files changed, 17 insertions(+) diff --git a/conformance.tex b/conformance.tex index 42f8537..3656da5 100644

[virtio-dev] Re: [PATCH v11] virtio-net: support device stats

2022-03-07 Thread Xuan Zhuo
On Mon, 7 Mar 2022 15:58:03 +0800, Jason Wang wrote: > > 在 2022/3/2 下午4:52, Xuan Zhuo 写道: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such information, > > which can be

[virtio-dev] [PATCH v12] virtio-net: support device stats

2022-03-14 Thread Xuan Zhuo
atomically, try to get stats for all queue pairs in one command. Signed-off-by: Xuan Zhuo Suggested-by: Michael S. Tsirkin --- conformance.tex | 2 + content.tex | 406 +++- 2 files changed, 405 insertions(+), 3 deletions(-) diff --git

Re: [virtio-dev] Re: [PATCH v11] virtio-net: support device stats

2022-03-08 Thread Xuan Zhuo
On Tue, 8 Mar 2022 14:36:02 +0800, Jason Wang wrote: > On Mon, Mar 7, 2022 at 5:07 PM Xuan Zhuo wrote: > > > > On Mon, 7 Mar 2022 15:58:03 +0800, Jason Wang wrote: > > > > > > 在 2022/3/2 下午4:52, Xuan Zhuo 写道: > > > > This patch allows the dri

[virtio-dev] Re: [PATCH v11] virtio-net: support device stats

2022-03-09 Thread Xuan Zhuo
On Mon, 7 Mar 2022 15:58:03 +0800, Jason Wang wrote: > > 在 2022/3/2 下午4:52, Xuan Zhuo 写道: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such information, > > which can be

[virtio-dev] Re: [PATCH v11] virtio-net: support device stats

2022-03-09 Thread Xuan Zhuo
On Wed, 9 Mar 2022 17:15:46 +0800, Jason Wang wrote: > On Wed, Mar 9, 2022 at 5:08 PM Michael S. Tsirkin wrote: > > > On Wed, Mar 09, 2022 at 04:25:26PM +0800, Xuan Zhuo wrote: > > > On Mon, 7 Mar 2022 15:58:03 +0800, Jason Wang > > wrote: > > > >

Re: [virtio-dev] Re: [PATCH v11] virtio-net: support device stats

2022-03-08 Thread Xuan Zhuo
On Tue, 8 Mar 2022 14:36:02 +0800, Jason Wang wrote: > On Mon, Mar 7, 2022 at 5:07 PM Xuan Zhuo wrote: > > > > On Mon, 7 Mar 2022 15:58:03 +0800, Jason Wang wrote: > > > > > > 在 2022/3/2 下午4:52, Xuan Zhuo 写道: > > > > This patch allows the dri

[virtio-dev] [PATCH v1] virtio_net: support split header

2022-02-21 Thread Xuan Zhuo
layer. Signed-off-by: Xuan Zhuo --- conformance.tex | 2 ++ content.tex | 66 + 2 files changed, 68 insertions(+) diff --git a/conformance.tex b/conformance.tex index 42f8537..e5d2ca8 100644 --- a/conformance.tex +++ b/conformance.tex @@

[virtio-dev] [PATCH v3] virtio-net: support reset queue

2022-02-21 Thread Xuan Zhuo
This patch defines some requirements for virtio-net to support reset queues. Signed-off-by: Xuan Zhuo --- content.tex | 6 ++ 1 file changed, 6 insertions(+) diff --git a/content.tex b/content.tex index c6f116c..e293881 100644 --- a/content.tex +++ b/content.tex @@ -4337,6 +4337,11

Re: [virtio-dev] [PATCH v9] virtio-net: support device stats

2022-02-24 Thread Xuan Zhuo
On Tue, 15 Feb 2022 15:47:43 +0800, Xuan Zhuo wrote: > This patch allows the driver to obtain some statistics from the device. > > In the back-end implementation, we can count a lot of such information, > which can be used for debugging and judging the running status of the > ba

Re: [virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Xuan Zhuo
On Mon, 28 Feb 2022 06:40:33 -0500, "Michael S. Tsirkin" wrote: > On Tue, Feb 15, 2022 at 03:47:43PM +0800, Xuan Zhuo wrote: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of

[virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Xuan Zhuo
On Mon, 28 Feb 2022 06:55:27 -0500, "Michael S. Tsirkin" wrote: > On Mon, Feb 28, 2022 at 07:21:39PM +0800, Xuan Zhuo wrote: > > > struct stats{ > > > /* the counters that doesn't need any features */ > > > /* the counters that needs CSUM

[virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Xuan Zhuo
On Mon, 28 Feb 2022 17:07:54 +0800, Jason Wang wrote: > On Tue, Feb 15, 2022 at 3:47 PM Xuan Zhuo wrote: > > > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such informa

[virtio-dev] [PATCH v10] virtio-net: support device stats

2022-03-01 Thread Xuan Zhuo
atomically, try to get stats for all queue pairs in one command. Signed-off-by: Xuan Zhuo --- v10: 1. use description/item for the item of the queue pair 2. use one command to get the stats of all queue pairs v8: 1. Modified based on comments by Cornelia Huck v7: 1. add rx_reset, tx_reset 2

[virtio-dev] Re: [PATCH v10] virtio-net: support device stats

2022-03-01 Thread Xuan Zhuo
On Tue, 1 Mar 2022 07:25:16 -0500, "Michael S. Tsirkin" wrote: > On Tue, Mar 01, 2022 at 07:32:23PM +0800, Xuan Zhuo wrote: > > > > I have to say, this design is really good. > > > > I think one of the core points of your design is to separate drop stats,

[virtio-dev] [PATCH] virtio_net: support split header

2022-02-15 Thread Xuan Zhuo
e network header. For MRG_RX, we require that all payloads are placed in the position specified by offset in each receive buffer. So we can also use build_skb() without wasting memory. Because we can reuse the "offset" parts that are not used. Signed-off-by: Xuan Zhuo

[virtio-dev] Re: [PATCH] virtio_net: support split header

2022-02-15 Thread Xuan Zhuo
On Wed, 16 Feb 2022 12:32:03 +0800, Jason Wang wrote: > On Wed, Feb 16, 2022 at 11:01 AM Xuan Zhuo wrote: > > > > The purpose of this feature is to write the payload of the packet to a > > specified location in the receive buffer after the device re

[virtio-dev] [PATCH v4] virtio-net: support reset queue

2022-02-21 Thread Xuan Zhuo
This patch defines some requirements for virtio-net to support reset queues. Signed-off-by: Xuan Zhuo --- content.tex | 5 + 1 file changed, 5 insertions(+) diff --git a/content.tex b/content.tex index c6f116c..45751f4 100644 --- a/content.tex +++ b/content.tex @@ -4337,6 +4337,10

[virtio-dev] [PATCH v11] virtio-net: support device stats

2022-03-02 Thread Xuan Zhuo
atomically, try to get stats for all queue pairs in one command. Signed-off-by: Xuan Zhuo Suggested-by: Michael S. Tsirkin --- v11: 1. Use michael's advice to introduce virtio_net_ctrl_queue_stats to get vq stats based on vq num and type 2. split stats structure v10: 1. use description/item

[virtio-dev] Re: [PATCH v10] virtio-net: support device stats

2022-03-01 Thread Xuan Zhuo
On Tue, 1 Mar 2022 06:05:55 -0500, "Michael S. Tsirkin" wrote: > On Tue, Mar 01, 2022 at 04:34:46PM +0800, Xuan Zhuo wrote: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of

[virtio-dev] Re: [PATCH v2] virtio-net: support reset queue

2022-02-20 Thread Xuan Zhuo
On Mon, 21 Feb 2022 12:27:20 +0800, Jason Wang wrote: > > 在 2022/2/10 下午7:03, Xuan Zhuo 写道: > > This patch defines some requirements for virtio-net to support reset > > queues. > > > > Signed-off-by: Xuan Zhuo > > --- > > conform

[virtio-dev] Re: [PATCH v1] virtio-net: support reset queue

2022-02-20 Thread Xuan Zhuo
On Mon, 21 Feb 2022 11:02:54 +0800, Jason Wang wrote: > On Fri, Feb 18, 2022 at 5:27 PM Michael S. Tsirkin wrote: > > > > On Thu, Feb 10, 2022 at 05:26:24PM +0800, Jason Wang wrote: > > > On Thu, Feb 10, 2022 at 5:06 PM Xuan Zhuo > > > wrote: > &

[virtio-dev] [PATCH] virtio-net: support reset queue

2022-02-09 Thread Xuan Zhuo
This patch defines some requirements for virtio-net to support reset queues. Signed-off-by: Xuan Zhuo --- conformance.tex | 2 ++ content.tex | 19 +++ 2 files changed, 21 insertions(+) diff --git a/conformance.tex b/conformance.tex index 42f8537..52b4879 100644

[virtio-dev] Re: [PATCH] virtio-net: support reset queue

2022-02-09 Thread Xuan Zhuo
On Wed, 9 Feb 2022 04:23:17 -0500, "Michael S. Tsirkin" wrote: > On Wed, Feb 09, 2022 at 05:01:58PM +0800, Xuan Zhuo wrote: > > This patch defines some requirements for virtio-net to support reset > > queues. > > > > Signed-off-by: Xuan Zhuo > > --- &g

[virtio-dev] [PATCH v1] virtio-net: support reset queue

2022-02-10 Thread Xuan Zhuo
This patch defines some requirements for virtio-net to support reset queues. Signed-off-by: Xuan Zhuo --- conformance.tex | 1 + content.tex | 12 2 files changed, 13 insertions(+) diff --git a/conformance.tex b/conformance.tex index 42f8537..3656da5 100644

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Tue, 18 Jan 2022 02:16:35 -0500, Michael S. Tsirkin wrote: > On Tue, Jan 18, 2022 at 11:34:25AM +0800, Xuan Zhuo wrote: > > On Tue, 18 Jan 2022 11:26:21 +0800, Jason Wang wrote: > > > On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo > > > wrote: > > > > >

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Tue, 18 Jan 2022 11:26:21 +0800, Jason Wang wrote: > On Mon, Jan 17, 2022 at 3:22 PM Xuan Zhuo wrote: > > > > On Mon, 17 Jan 2022 15:06:52 +0800, Jason Wang wrote: > > > > > > 在 2022/1/17 上午10:14, Xuan Zhuo 写道: > > > > On Sat, 15 Jan 2022 13:17

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-18 Thread Xuan Zhuo
On Tue, 18 Jan 2022 09:39:04 +0100, Cornelia Huck wrote: > On Tue, Jan 18 2022, Xuan Zhuo wrote: > > >> > > above you said bytes sent. > >> > > >> > I mean, all about GSO are statistics based on big packets. So here is the > >> >

Re: [virtio-dev] [PATCH v8] virtio-net: support device stats

2022-01-17 Thread Xuan Zhuo
On Mon, 17 Jan 2022 09:13:41 -0500, Michael S. Tsirkin wrote: > On Mon, Jan 17, 2022 at 04:21:50PM +0800, Xuan Zhuo wrote: > > On Mon, 17 Jan 2022 03:12:20 -0500, Michael S. Tsirkin > > wrote: > > > On Mon, Jan 17, 2022 at 10:14:35AM +0800, Xuan Zhuo wrote: > > &g

[virtio-dev] Re: [PATCH v7] virtio-net: support device stats

2022-01-06 Thread Xuan Zhuo
On Thu, 6 Jan 2022 12:00:14 +0800, Jason Wang wrote: > On Wed, Jan 5, 2022 at 10:49 AM Xuan Zhuo wrote: > > > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such informa

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-24 Thread Xuan Zhuo
On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > Hi, > > A recently defined queue_reset register has a little weird definition that we > should improve. > When driver initiate queue reset, it writes queue_reset = 1. > When device is busy resetting the queue, on this driver request, it

Re: [virtio-dev] [PATCH v4] virtio-net: support reset queue

2022-04-23 Thread Xuan Zhuo
On Tue, 22 Feb 2022 14:52:41 +0800, Xuan Zhuo wrote: > This patch defines some requirements for virtio-net to support reset > queues. Is there any problem with this? Thanks. > > Signed-off-by: Xuan Zhuo > --- > content.tex | 5 + > 1 file changed, 5 inserti

[virtio-dev] [PATCH v5] virtio-net: support reset queue

2022-04-24 Thread Xuan Zhuo
A separate reset queue function introduced by Virtqueue Reset. However, it is currently not defined what to do if the destination queue is being reset when virtio-net is steering in multi-queue mode. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/138 Signed-off-by: Xuan Zhuo

[virtio-dev] Re: [PATCH v4] virtio-net: support reset queue

2022-04-24 Thread Xuan Zhuo
On Sun, 24 Apr 2022 02:53:46 -0400, "Michael S. Tsirkin" wrote: > On Tue, Feb 22, 2022 at 02:52:41PM +0800, Xuan Zhuo wrote: > > This patch defines some requirements for virtio-net to support reset > > queues. > > > > Signed-off-by: Xuan Zhuo > >

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-26 Thread Xuan Zhuo
On Tue, 26 Apr 2022 09:48:29 +0100, Stefan Hajnoczi wrote: > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > > Hi, > > > > > > A recently defined queue_reset register has a little we

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-26 Thread Xuan Zhuo
On Tue, 26 Apr 2022 05:52:17 -0400, "Michael S. Tsirkin" wrote: > On Tue, Apr 26, 2022 at 09:48:29AM +0100, Stefan Hajnoczi wrote: > > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > >

Re: RE: [virtio-dev] queue_reset register polarity to improve

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 12:00:24 +, Parav Pandit wrote: > > > From: Xuan Zhuo > > Sent: Sunday, April 24, 2022 3:29 AM > > > > > > A recently defined queue_reset register has a little weird definition that > > we should improve. > > > When driver

Re: [virtio-dev] queue_reset register polarity to improve

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 10:26:18 -0400, "Michael S. Tsirkin" wrote: > On Sun, Apr 24, 2022 at 03:28:53PM +0800, Xuan Zhuo wrote: > > On Sun, 24 Apr 2022 00:49:19 +, Parav Pandit wrote: > > > Hi, > > > > > > A recently defined queue_reset registe

[virtio-dev] Re: [PATCH v1] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Xuan Zhuo
On Tue, 26 Apr 2022 03:06:57 +0300, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to

[virtio-dev] Re: [PATCH v2] virtio_net: support split header

2022-05-30 Thread Xuan Zhuo
On Mon, 30 May 2022 14:27:26 -0400, "Michael S. Tsirkin" wrote: > On Sat, May 07, 2022 at 03:15:33PM +0800, Xuan Zhuo wrote: > > The purpose of this feature is to split the header and the payload of > > the packet. > > > >

[virtio-dev] Re: [PATCH v2] virtio_net: support split header

2022-05-31 Thread Xuan Zhuo
On Tue, 31 May 2022 01:35:17 -0400, "Michael S. Tsirkin" wrote: > On Tue, May 31, 2022 at 10:10:52AM +0800, Xuan Zhuo wrote: > > On Mon, 30 May 2022 14:27:26 -0400, "Michael S. Tsirkin" > > wrote: > > > On Sat, May 07, 2022 at 03:15:33PM

Re: [virtio-dev] Re: [PATCH v2] virtio_net: support split header

2022-05-31 Thread Xuan Zhuo
On Tue, 31 May 2022 13:59:12 +0800, Xuan Zhuo wrote: > On Tue, 31 May 2022 01:35:17 -0400, "Michael S. Tsirkin" > wrote: > > On Tue, May 31, 2022 at 10:10:52AM +0800, Xuan Zhuo wrote: > > > On Mon, 30 May 2022 14:27:26 -0400, "Michael S. Tsirkin" &

Re: [virtio-dev] Re: [PATCH v2] virtio_net: support split header

2022-05-26 Thread Xuan Zhuo
On Mon, 9 May 2022 16:41:11 +0800, Jason Wang wrote: > > 在 2022/5/7 15:15, Xuan Zhuo 写道: > > The purpose of this feature is to split the header and the payload of > > the packet. > > > > |receive buffer| &

[virtio-dev] Re: [PATCH v5] virtio-net: support reset queue

2022-05-26 Thread Xuan Zhuo
On Fri, 29 Apr 2022 10:45:28 +0800, Jason Wang wrote: > > 在 2022/4/24 16:31, Xuan Zhuo 写道: > > A separate reset queue function introduced by Virtqueue Reset. > > > > However, it is currently not defined what to do if the destination queue is > > being reset when v

  1   2   >