[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/12/2023 3:43 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 1:06 PM On 9/12/2023 2:52 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 12:13 PM Why need P2P for Live Migration? A peer device may be accessing the virtio

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/12/2023 6:16 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 3:45 PM On 9/12/2023 5:35 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 2:38 PM supplementary: As Jason ever pointed out: the two solution can co-exist for sure

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/12/2023 6:25 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 3:47 PM On 9/12/2023 5:28 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 2:36 PM If you want AQ used for LM, it should support nested anyway, don't break

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/12/2023 6:33 PM, Parav Pandit wrote: From: virtio-comm...@lists.oasis-open.org On Behalf Of Zhu, Lingshan Sent: Tuesday, September 12, 2023 3:57 PM It is the base line implementation of leading OS such as Linux kernel. Decade mature stack like vfio recommends support for p2p as base

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/12/2023 5:21 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 2:33 PM admin vq require fixed and dedicated resource to serve the VMs, the question still remains, does is scale to server big amount of devices migration? how many admin vqs do you need to serve

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/12/2023 6:40 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 4:02 PM On 9/12/2023 6:25 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 3:47 PM On 9/12/2023 5:28 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/12/2023 6:41 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 4:05 PM I mean, why do you think my series can not work with P2P Because it misses the intermediate mode STOP that we have in series [1]. [1] https://lists.oasis-open.org/archives/virtio-comment

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/12/2023 9:43 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 6:33 PM On 9/12/2023 5:21 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 2:33 PM admin vq require fixed and dedicated resource to serve the VMs, the question

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/13/2023 10:23 AM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 3:45 PM Do you find the administration commands we proposed in [1] useful for nested case? If not, both will likely diverge. Not till now. I don’t think you reviewed [1] enough. Following

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/12/2023 9:35 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 6:39 PM On 9/12/2023 6:41 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 4:05 PM I mean, why do you think my series can not work with P2P Because it misses the

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/13/2023 12:12 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 13, 2023 9:31 AM On 9/12/2023 9:43 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 6:33 PM On 9/12/2023 5:21 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/13/2023 12:15 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 13, 2023 9:33 AM To: Parav Pandit ; Jason Wang Cc: Michael S. Tsirkin ; epere...@redhat.com; coh...@redhat.com; stefa...@redhat.com; virtio-comment@lists.oasis- open.org; virtio-dev@lists.oasis

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-12 Thread Zhu, Lingshan
On 9/13/2023 12:19 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 13, 2023 9:44 AM On 9/12/2023 9:35 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 12, 2023 6:39 PM On 9/12/2023 6:41 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-14 Thread Zhu, Lingshan
On 9/13/2023 12:36 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 13, 2023 9:51 AM VQ depth defines the VQ's limit. still sounds like limitless and I will stop arguing this as you can see if there is REALLY a queue can be limitless, we even don't need M

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-14 Thread Zhu, Lingshan
On 9/13/2023 12:37 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 13, 2023 9:51 AM we plan to implement a self-contain solution Make sure that works with device reset and FLR. And if not, explain that it is for mediation mode related tricks. also repeated for many

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-14 Thread Zhu, Lingshan
On 9/13/2023 12:39 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 13, 2023 9:52 AM It should be named as SUSPEND_CFG_SPACE.! All of this frankly seems intrusive enough as Michael pointed out. Good luck. it also SUSPEND the data-path Ok so it works like Suspend of

[virtio-dev] Re: [virtio-comment] [PATCH 1/5] virtio: introduce vq state as basic facility

2023-09-14 Thread Zhu, Lingshan
On 9/14/2023 7:25 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:33PM +0800, Zhu Lingshan wrote: This patch adds new device facility to save and restore virtqueue state. The virtqueue state is split into two parts: - The available state: The state that is used for read the next

[virtio-dev] Re: [PATCH 2/5] virtio: introduce SUSPEND bit in device status

2023-09-14 Thread Zhu, Lingshan
On 9/14/2023 7:34 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:34PM +0800, Zhu Lingshan wrote: This patch introduces a new status bit in the device status: SUSPEND. This SUSPEND bit can be used by the driver to suspend a device, in order to stabilize the device states and

[virtio-dev] Re: [PATCH 3/5] virtqueue: constraints for virtqueue state

2023-09-14 Thread Zhu, Lingshan
On 9/14/2023 7:30 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:35PM +0800, Zhu Lingshan wrote: This commit specifies the constraints of the virtqueue state, and the actions should be taken by the device when SUSPEND and DRIVER_OK is set Signed-off-by: Zhu Lingshan Signed-off

[virtio-dev] Re: [PATCH 4/5] virtqueue: ignore resetting vqs when SUSPEND

2023-09-14 Thread Zhu, Lingshan
On 9/14/2023 7:09 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:36PM +0800, Zhu Lingshan wrote: When SUSPEND is set, the device should stabilize the device states and virtqueue states, therefore the device should ignore resetting vqs when SUSPEND is set in device status

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-14 Thread Zhu, Lingshan
On 9/14/2023 7:27 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:37PM +0800, Zhu Lingshan wrote: This patch adds two new le16 fields to common configuration structure to support VIRTIO_F_QUEUE_STATE in PCI transport layer. Signed-off-by: Zhu Lingshan --- transport-pci.tex

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-14 Thread Zhu, Lingshan
On 9/14/2023 7:14 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:32PM +0800, Zhu Lingshan wrote: This series introduces 1)a new SUSPEND bit in the device status Which is used to suspend the device, so that the device states and virtqueue states are stabilized. 2)virtqueue state

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-14 Thread Zhu, Lingshan
On 9/14/2023 7:37 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:32PM +0800, Zhu Lingshan wrote: This series introduces 1)a new SUSPEND bit in the device status Which is used to suspend the device, so that the device states and virtqueue states are stabilized. 2)virtqueue state

[virtio-dev] Re: [PATCH 2/5] virtio: introduce SUSPEND bit in device status

2023-09-17 Thread Zhu, Lingshan
On 9/15/2023 7:10 PM, Michael S. Tsirkin wrote: On Fri, Sep 15, 2023 at 10:57:33AM +0800, Zhu, Lingshan wrote: On 9/14/2023 7:34 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:34PM +0800, Zhu Lingshan wrote: This patch introduces a new status bit in the device status: SUSPEND

[virtio-dev] Re: [virtio-comment] Re: [PATCH 3/5] virtqueue: constraints for virtqueue state

2023-09-17 Thread Zhu, Lingshan
On 9/15/2023 7:16 PM, Michael S. Tsirkin wrote: On Fri, Sep 15, 2023 at 10:59:29AM +0800, Zhu, Lingshan wrote: On 9/14/2023 7:30 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:35PM +0800, Zhu Lingshan wrote: This commit specifies the constraints of the virtqueue state, and

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-17 Thread Zhu, Lingshan
On 9/17/2023 1:32 PM, Parav Pandit wrote: From: virtio-dev@lists.oasis-open.org On Behalf Of Zhu, Lingshan Sent: Friday, September 15, 2023 9:59 AM On 9/14/2023 7:14 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:32PM +0800, Zhu Lingshan wrote: This series introduces 1)a new

[virtio-dev] Re: [virtio-comment] Re: [PATCH 2/5] virtio: introduce SUSPEND bit in device status

2023-09-17 Thread Zhu, Lingshan
On 9/18/2023 12:42 PM, Parav Pandit wrote: From: virtio-comm...@lists.oasis-open.org On Behalf Of Zhu, Lingshan Sent: Monday, September 18, 2023 8:27 AM a new feature bit: VIRTIO_F_RING_SUSPEND_RESET. If this feature bit has been negotiated then the device allow reset a vq after SUSPEND

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-17 Thread Zhu, Lingshan
On 9/18/2023 12:32 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday, September 18, 2023 8:40 AM On 9/17/2023 1:32 PM, Parav Pandit wrote: From: virtio-dev@lists.oasis-open.org On Behalf Of Zhu, Lingshan Sent: Friday, September 15, 2023 9:59 AM On 9/14/2023 7:14 PM, Michael S

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-17 Thread Zhu, Lingshan
CC MST and Jason On 9/18/2023 1:21 PM, Zhu, Lingshan wrote: On 9/18/2023 12:32 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday, September 18, 2023 8:40 AM On 9/17/2023 1:32 PM, Parav Pandit wrote: From: virtio-dev@lists.oasis-open.org On Behalf Of Zhu, Lingshan Sent: Friday

[virtio-dev] Re: [virtio-comment] Re: [PATCH 2/5] virtio: introduce SUSPEND bit in device status

2023-09-17 Thread Zhu, Lingshan
On 9/18/2023 2:17 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday, September 18, 2023 10:45 AM On 9/18/2023 12:42 PM, Parav Pandit wrote: From: virtio-comm...@lists.oasis-open.org On Behalf Of Zhu, Lingshan Sent: Monday, September 18, 2023 8:27 AM a new feature bit

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-17 Thread Zhu, Lingshan
On 9/18/2023 2:37 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday, September 18, 2023 10:55 AM To: Parav Pandit ; virtio-dev@lists.oasis-open.org; Michael S. Tsirkin ; Jason Wang Subject: Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state CC MST and Jason

[virtio-dev] Re: [virtio-comment] Re: [PATCH 2/5] virtio: introduce SUSPEND bit in device status

2023-09-17 Thread Zhu, Lingshan
On 9/18/2023 2:46 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday, September 18, 2023 12:09 PM There is parent object. There is VQ which you propose to do SUSPEND_RESET of the parent virtio device which is already SUSPENDED. that is why we plan to implement a new feature bit to

[virtio-dev] Re: [PATCH 2/5] virtio: introduce SUSPEND bit in device status

2023-09-17 Thread Zhu, Lingshan
On 9/18/2023 10:56 AM, Zhu, Lingshan wrote: On 9/15/2023 7:10 PM, Michael S. Tsirkin wrote: On Fri, Sep 15, 2023 at 10:57:33AM +0800, Zhu, Lingshan wrote: On 9/14/2023 7:34 PM, Michael S. Tsirkin wrote: On Wed, Sep 06, 2023 at 04:16:34PM +0800, Zhu Lingshan wrote: This patch introduces

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-18 Thread Zhu, Lingshan
On 9/18/2023 2:54 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday, September 18, 2023 12:19 PM so admin vq based LM solution can be a side channel attacking surface It will be part of the DSM whenever it will be used in future. Hence, it is not attack surface. I am not sure

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-19 Thread Zhu, Lingshan
On 9/19/2023 3:32 PM, Parav Pandit wrote: From: Jason Wang Sent: Tuesday, September 19, 2023 9:58 AM On Mon, Sep 18, 2023 at 2:55 PM Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday, September 18, 2023 12:19 PM so admin vq based LM solution can be a side channel attacking surface

[virtio-dev] Re: [virtio-comment] Re: [PATCH 3/5] virtqueue: constraints for virtqueue state

2023-09-19 Thread Zhu, Lingshan
On 9/19/2023 1:30 AM, Michael S. Tsirkin wrote: On Mon, Sep 18, 2023 at 11:02:18AM +0800, Zhu, Lingshan wrote: On 9/15/2023 7:16 PM, Michael S. Tsirkin wrote: On Fri, Sep 15, 2023 at 10:59:29AM +0800, Zhu, Lingshan wrote: On 9/14/2023 7:30 PM, Michael S. Tsirkin wrote: On Wed, Sep 06

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-19 Thread Zhu, Lingshan
On 9/19/2023 2:41 AM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday, September 18, 2023 3:05 PM On 9/18/2023 2:54 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday, September 18, 2023 12:19 PM so admin vq based LM solution can be a side channel attacking surface It will be

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-19 Thread Zhu, Lingshan
On 9/19/2023 3:53 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 19, 2023 1:16 PM On 9/19/2023 3:32 PM, Parav Pandit wrote: From: Jason Wang Sent: Tuesday, September 19, 2023 9:58 AM On Mon, Sep 18, 2023 at 2:55 PM Parav Pandit wrote: From: Zhu, Lingshan Sent

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-19 Thread Zhu, Lingshan
On 9/19/2023 4:31 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 19, 2023 1:34 PM In your previous email you wrote, 1. "so lets focus on LM topic, other than confidential computing." 2. "again, TDISP is out of spec and TDISP devices are not migratable.

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-19 Thread Zhu, Lingshan
On 9/19/2023 5:06 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 19, 2023 1:32 PM On 9/19/2023 2:41 AM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday, September 18, 2023 3:05 PM On 9/18/2023 2:54 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Monday

[virtio-dev] Re: [virtio-comment] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-19 Thread Zhu, Lingshan
s in its configuration space. The driver re-write DRIVER_OK to clear SUSPEND, so the device resumes running. This is originally to serve live migration, but I think it can also meet your needs. Thanks, Zhu Lingshan Signed-off-by: Jiqian Chen --- transport-pci.tex | 7 +++ 1 fil

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-19 Thread Zhu, Lingshan
On 9/19/2023 2:49 AM, Michael S. Tsirkin wrote: On Mon, Sep 18, 2023 at 06:41:55PM +, Parav Pandit wrote: Please refer to the code for setting FEATURES_OK. It wont work when one needs to suspend the device. There is no point of doing such work over registers as fundamental framework is

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-19 Thread Zhu, Lingshan
On 9/20/2023 2:08 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 20, 2023 11:36 AM On 9/19/2023 2:49 AM, Michael S. Tsirkin wrote: On Mon, Sep 18, 2023 at 06:41:55PM +, Parav Pandit wrote: Please refer to the code for setting FEATURES_OK. It wont work when one

Re: [virtio-dev] Re: [virtio-comment] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-19 Thread Zhu, Lingshan
On 9/20/2023 2:33 PM, Chen, Jiqian wrote: Hi Lingshan, On 2023/9/20 13:59, Zhu, Lingshan wrote: On 9/19/2023 8:31 PM, Michael S. Tsirkin wrote: On Tue, Sep 19, 2023 at 07:42:42PM +0800, Jiqian Chen wrote: When guest vm does S3, Qemu will reset and clear some things of virtio devices, but

Re: [virtio-dev] Re: [virtio-comment] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 2:58 PM, Parav Pandit wrote: From: Chen, Jiqian Sent: Wednesday, September 20, 2023 12:03 PM If driver write 0 to reset device, can the SUSPEND bit be cleared? It must as reset operation, resets everything else and so the suspend too. (pci_pm_resume->virtio_pci_restore->virtio

Re: [virtio-dev] Re: [virtio-comment] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 3:10 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 20, 2023 12:37 PM The problem to overcome in [1] is, resume operation needs to be synchronous as it involves large part of context to resume back, and hence just asynchronously setting DRIVER_OK is not

Re: [virtio-dev] Re: [virtio-comment] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-20 Thread Zhu, Lingshan
2023/9/20 15:06, Zhu, Lingshan wrote: On 9/20/2023 2:58 PM, Parav Pandit wrote: From: Chen, Jiqian Sent: Wednesday, September 20, 2023 12:03 PM If driver write 0 to reset device, can the SUSPEND bit be cleared? It must as reset operation, resets everything else and so the suspend too. (pci

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 3:17 PM, Chen, Jiqian wrote: Hi Lingshan, On 2023/9/20 14:58, Zhu, Lingshan wrote: On 9/20/2023 2:33 PM, Chen, Jiqian wrote: Hi Lingshan, On 2023/9/20 13:59, Zhu, Lingshan wrote: On 9/19/2023 8:31 PM, Michael S. Tsirkin wrote: On Tue, Sep 19, 2023 at 07:42:42PM +0800

Re: [virtio-dev] Re: [virtio-comment] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 3:32 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 20, 2023 12:58 PM On 9/20/2023 3:10 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 20, 2023 12:37 PM The problem to overcome in [1] is, resume operation needs to be

Re: [virtio-dev] Re: [virtio-comment] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 3:35 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 20, 2023 1:00 PM On 9/20/2023 3:24 PM, Chen, Jiqian wrote: Hi Lingshan, It seems you reply to the wrong email thread. They are not related to my patch. These reply to Parva's comments. @Parva, i

Re: [virtio-dev] Re: [virtio-comment] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 3:51 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 20, 2023 1:17 PM This is not live or device migration. This is restoring the device context initiated by the driver owning the device. restore the device context should be done by the hypervisor before

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Zhu, Lingshan
On Behalf Of *Zhu, Lingshan *Sent:* Wednesday, September 20, 2023 12:01 PM *To:* Parav Pandit ; Michael S. Tsirkin *Cc:* virtio-dev@lists.oasis-open.org; Jason Wang *Subject:* Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state On 9/20/2023 2:08 PM, Parav Pandit wrote:

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Zhu, Lingshan
. Maybe we can close this. Parav *From:* Zhu, Lingshan *Sent:* Wednesday, September 20, 2023 3:15 PM *To:* Parav Pandit ; Michael S. Tsirkin *Cc:* virtio-dev@lists.oasis-open.org; Jason Wang *Subject:* Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state On 9/20/2023

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 6:36 PM, Michael S. Tsirkin wrote: On Wed, Sep 20, 2023 at 02:06:13PM +0800, Zhu, Lingshan wrote: On 9/19/2023 2:49 AM, Michael S. Tsirkin wrote: On Mon, Sep 18, 2023 at 06:41:55PM +, Parav Pandit wrote: Please refer to the code for setting FEATURES_OK. It wont work when

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Zhu, Lingshan
. If you have comments in [1], please reply in [1]. Series [1] clearly describes the usage model at least for one widely used OS = Linux. [1] https://lore.kernel.org/virtio-comment/20230909142911.524407-7-pa...@nvidia.com/T/#md9fcfa1ba997463de8c7fb8c6d1786b224b0bead *From:* Zhu, Lingshan *S

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 6:55 PM, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday, September 20, 2023 4:06 PM I freely admit the finer points of this extended flamewar have been lost on me, and I wager I'm not the only one. I thought you wanted to migrate the device just by accessing the dev

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 7:52 PM, Michael S. Tsirkin wrote: On Wed, Sep 20, 2023 at 07:28:39PM +0800, Zhu, Lingshan wrote: On 9/20/2023 6:55 PM, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday, September 20, 2023 4:06 PM I freely admit the finer points of this extended flamewar have been

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 8:05 PM, Zhu, Lingshan wrote: On 9/20/2023 7:52 PM, Michael S. Tsirkin wrote: On Wed, Sep 20, 2023 at 07:28:39PM +0800, Zhu, Lingshan wrote: On 9/20/2023 6:55 PM, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday, September 20, 2023 4:06 PM I freely admit the

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Zhu, Lingshan
On 9/20/2023 8:05 PM, Michael S. Tsirkin wrote: On Wed, Sep 20, 2023 at 07:22:32PM +0800, Zhu, Lingshan wrote: On 9/20/2023 6:36 PM, Michael S. Tsirkin wrote: On Wed, Sep 20, 2023 at 02:06:13PM +0800, Zhu, Lingshan wrote: On 9/19/2023 2:49 AM, Michael S. Tsirkin wrote: On Mon, Sep 18

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Zhu, Lingshan
First, clearly Zhu Lingshan cares about the mediation use-case, not the un-mediated one. Mediation is clearly heavier but also more powerful in many use-cases - is that obvious or do I need to list the reasons? To mention one example, it supports cross-vendor migration. Which the unmediated varia

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Zhu, Lingshan
On 9/20/2023 9:41 PM, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday, September 20, 2023 6:12 PM And Parav same goes for you - can you summarize Zhu Lingshan's position? Below is my summary about Zhu Lingshan's position: One line summary of his position in my view: 0. Use inb

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Zhu, Lingshan
On 9/21/2023 5:26 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Thursday, September 21, 2023 2:49 PM TDISP devices can not be migrated for now, and the TDISP spec make clear examples of attacking models, your admin vq LM on the PF exactly match the model. I gave hint yesterday to you

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Zhu, Lingshan
On 9/21/2023 7:28 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Thursday, September 21, 2023 3:25 PM On 9/21/2023 5:26 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Thursday, September 21, 2023 2:49 PM TDISP devices can not be migrated for now, and the TDISP spec make clear

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Zhu, Lingshan
On 9/22/2023 11:08 AM, Jason Wang wrote: On Thu, Sep 21, 2023 at 12:19 PM Parav Pandit wrote: From: Jason Wang Sent: Thursday, September 21, 2023 9:39 AM On Thu, Sep 21, 2023 at 12:01 PM Parav Pandit wrote: From: Jason Wang Sent: Thursday, September 21, 2023 8:48 AM As replied in a

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-25 Thread Zhu, Lingshan
On 9/26/2023 11:40 AM, Parav Pandit wrote: From: Jason Wang Sent: Tuesday, September 26, 2023 8:16 AM On Mon, Sep 25, 2023 at 6:41 PM Parav Pandit wrote: From: Jason Wang Sent: Friday, September 22, 2023 8:38 AM Device context has no overlap. I can give you one example, e.g debuggi

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-26 Thread Zhu, Lingshan
On 9/26/2023 2:03 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Tuesday, September 26, 2023 11:07 AM 1. cover letter is missing the problem statement and use case I only reply to this section of comments, this does not mean I agree with you on your other statements, Instead I agree

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-27 Thread Zhu, Lingshan
On 9/26/2023 6:48 PM, Michael S. Tsirkin wrote: On Tue, Sep 26, 2023 at 05:25:42PM +0800, Zhu, Lingshan wrote: We don't want to repeat the discussions, it looks like endless circle with no direction. OK let me try to direct this discussion. You guys were speaking past each other, no d

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-09 Thread Zhu, Lingshan
On 9/27/2023 11:40 PM, Michael S. Tsirkin wrote: On Wed, Sep 27, 2023 at 04:20:01PM +0800, Zhu, Lingshan wrote: On 9/26/2023 6:48 PM, Michael S. Tsirkin wrote: On Tue, Sep 26, 2023 at 05:25:42PM +0800, Zhu, Lingshan wrote: We don't want to repeat the discussions, it looks like en

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-09 Thread Zhu, Lingshan
On 9/27/2023 6:39 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, September 27, 2023 1:50 PM I see his proposal can: 1) meet some customers requirements without nested and bare-metal 2) align with Nvidia production Slightly inaccurate. The work produced is for the virtio spec

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-11 Thread Zhu, Lingshan
On 10/11/2023 6:20 PM, Michael S. Tsirkin wrote: On Mon, Oct 09, 2023 at 06:01:42PM +0800, Zhu, Lingshan wrote: On 9/27/2023 11:40 PM, Michael S. Tsirkin wrote: On Wed, Sep 27, 2023 at 04:20:01PM +0800, Zhu, Lingshan wrote: On 9/26/2023 6:48 PM, Michael S. Tsirkin wrote: On Tue, Sep 26

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-12 Thread Zhu, Lingshan
On 10/12/2023 5:59 PM, Michael S. Tsirkin wrote: On Wed, Oct 11, 2023 at 06:38:32PM +0800, Zhu, Lingshan wrote: On 10/11/2023 6:20 PM, Michael S. Tsirkin wrote: On Mon, Oct 09, 2023 at 06:01:42PM +0800, Zhu, Lingshan wrote: On 9/27/2023 11:40 PM, Michael S. Tsirkin wrote: On Wed, Sep 27

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-12 Thread Zhu, Lingshan
On 10/11/2023 7:52 PM, Parav Pandit wrote: From: Zhu, Lingshan Sent: Wednesday, October 11, 2023 4:09 PM I am sure I have not ignored any questions. What about below one? https://lore.kernel.org/virtio-dev/20230921011221-mutt-send-email-...@kernel.org/ This is to discuss a attacking model

Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-13 Thread Zhu, Lingshan
On 10/12/2023 7:12 PM, Michael S. Tsirkin wrote: On Thu, Oct 12, 2023 at 06:49:51PM +0800, Zhu, Lingshan wrote: On 10/12/2023 5:59 PM, Michael S. Tsirkin wrote: On Wed, Oct 11, 2023 at 06:38:32PM +0800, Zhu, Lingshan wrote: On 10/11/2023 6:20 PM, Michael S. Tsirkin wrote: On Mon, Oct 09

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-13 Thread Zhu, Lingshan
On 10/12/2023 10:38 PM, Michael S. Tsirkin wrote: On Thu, Oct 12, 2023 at 06:49:51PM +0800, Zhu, Lingshan wrote: For PCI based configuration, like MSI, we need to fetch from config space anyway. For others like dirty page, we can store the bitmap in host memory, and use PASID for isolation

<    1   2