[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH v8 1/3] content: Document balloon feature free page hints

2020-11-12 Thread Alexander Duyck
On Wed, Nov 11, 2020 at 11:45 PM Cornelia Huck wrote: > > On Wed, 11 Nov 2020 14:09:23 -0800 > Alexander Duyck wrote: > > > On Wed, Nov 11, 2020 at 10:03 AM Cornelia Huck wrote: > > > > > > On Wed, 16 Sep 2020 09:28:34 -0400 > > > "Michael S. T

[virtio-dev] [PATCH] content: Minor change to clarify free_page_hint_cmd_id

2020-11-12 Thread Alexander Duyck
From: Alexander Duyck The original wording was a bit unclear and could have been misinterpreted as indicating that VIRTIO_BALLOON_FREE_PAGE_HINT was read-only instead of the field free_page_hint_cmd_id. To clarify that break it up into two sentences making it clear that the field is only

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH v8 1/3] content: Document balloon feature free page hints

2020-11-11 Thread Alexander Duyck
On Wed, Nov 11, 2020 at 10:03 AM Cornelia Huck wrote: > > On Wed, 16 Sep 2020 09:28:34 -0400 > "Michael S. Tsirkin" wrote: > > > On Mon, Sep 14, 2020 at 08:13:55AM +0200, Cornelia Huck wrote: > > > On Fri, 11 Sep 2020 08:11:15 -0700 > > > Alexan

[virtio-dev] [PATCH v8 4/3] content: Minor change to clarify free_page_hint_cmd_id

2020-09-14 Thread Alexander Duyck
From: Alexander Duyck The original wording was a bit unclear and could have been misinterpreted as indicating that VIRTIO_BALLOON_FREE_PAGE_HINT was read-only instead of the field free_page_hint_cmd_id. To clarify that break it up into two sentences making it clear that the field is only

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH v8 1/3] content: Document balloon feature free page hints

2020-09-11 Thread Alexander Duyck
On Thu, Sep 10, 2020 at 10:28 PM Jan Kiszka wrote: > > On 04.09.20 18:56, Alexander Duyck wrote: > > On Fri, Sep 4, 2020 at 8:20 AM Jan Kiszka wrote: > >> > >> On 25.08.20 16:45, Alexander Duyck wrote: > >>> From: Alexander Duyck > >>> >

[virtio-dev] Re: [PATCH v8 0/3] virtio-spec: Add documentation for recently added balloon features

2020-09-10 Thread Alexander Duyck
On Tue, Sep 1, 2020 at 7:34 AM Michael S. Tsirkin wrote: > > On Tue, Aug 25, 2020 at 01:40:25PM -0700, Alexander Duyck wrote: > > On Tue, Aug 25, 2020 at 8:01 AM Cornelia Huck wrote: > > > > > > On Tue, 25 Aug 2020 07:44:55 -0700 > > > Alexander Duy

Re: [virtio-dev] [PATCH v8 1/3] content: Document balloon feature free page hints

2020-09-04 Thread Alexander Duyck
On Fri, Sep 4, 2020 at 8:20 AM Jan Kiszka wrote: > > On 25.08.20 16:45, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Free page hints allow the balloon driver to provide information on what > > pages are not currently in use so that we can avoi

[virtio-dev] Re: [PATCH v8 0/3] virtio-spec: Add documentation for recently added balloon features

2020-08-25 Thread Alexander Duyck
On Tue, Aug 25, 2020 at 8:01 AM Cornelia Huck wrote: > > On Tue, 25 Aug 2020 07:44:55 -0700 > Alexander Duyck wrote: > > > This patch set is meant to add documentation for balloon features that have > > been recently added to the Linux kernel[1,2] and that were rece

[virtio-dev] [PATCH v8 2/3] content: Document balloon feature page poison

2020-08-25 Thread Alexander Duyck
From: Alexander Duyck Page poison provides a way for the guest to notify the host that it is initializing or poisoning freed pages with some specific poison value. As a result of this we can infer a couple traits about the guest: 1. Free pages will contain a specific pattern within the guest. 2

[virtio-dev] [PATCH v8 0/3] virtio-spec: Add documentation for recently added balloon features

2020-08-25 Thread Alexander Duyck
commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html --- Alexander Duyck (3): content: Document balloon feature free page hints content: Document balloon feature page poison content: Document balloon feature

[virtio-dev] [PATCH v8 3/3] content: Document balloon feature free page reporting

2020-08-25 Thread Alexander Duyck
From: Alexander Duyck Free page reporting is a feature that allows the guest to proactively report unused pages to the host. By making use of this feature is is possible to reduce the overall memory footprint of the guest in cases where some significant portion of the memory is idle. Add

[virtio-dev] Re: [PATCH v7 0/3] virtio-spec: Add documentation for recently added balloon features

2020-08-24 Thread Alexander Duyck
On Mon, Aug 24, 2020 at 7:10 AM Alexander Duyck wrote: > > This patch set is meant to add documentation for balloon features that have > been recently added to the Linux kernel[1,2] and that were recently added > to QEMU[3]. > > Fixes: https://github.com/oasis-tcs/virtio-spe

[virtio-dev] [PATCH v7 3/3] content: Document balloon feature free page reporting

2020-08-24 Thread Alexander Duyck
From: Alexander Duyck Free page reporting is a feature that allows the guest to proactively report unused pages to the host. By making use of this feature is is possible to reduce the overall memory footprint of the guest in cases where some significant portion of the memory is idle. Add

[virtio-dev] [PATCH v7 2/3] content: Document balloon feature page poison

2020-08-24 Thread Alexander Duyck
From: Alexander Duyck Page poison provides a way for the guest to notify the host that it is initializing or poisoning freed pages with some specific poison value. As a result of this we can infer a couple traits about the guest: 1. Free pages will contain a specific pattern within the guest. 2

[virtio-dev] [PATCH v7 0/3] virtio-spec: Add documentation for recently added balloon features

2020-08-24 Thread Alexander Duyck
1]: https://lore.kernel.org/lkml/20200211224416.29318.44077.stgit@localhost.localdomain/ [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html --- Alexande

[virtio-dev] [PATCH v7 1/3] content: Document balloon feature free page hints

2020-08-24 Thread Alexander Duyck
From: Alexander Duyck Free page hints allow the balloon driver to provide information on what pages are not currently in use so that we can avoid the cost of copying them in migration scenarios. Add a feature description for free page hints describing basic functioning and requirements

[virtio-dev] Re: [virtio-comment] [PATCH RESEND v6 2/3] content: Document balloon feature page poison

2020-08-21 Thread Alexander Duyck
On Fri, Aug 21, 2020 at 11:24 AM David Hildenbrand wrote: > > On 18.08.20 19:32, Alexander Duyck wrote: > > From: Alexander Duyck > > +\devicenormative{\paragraph}{Page Poison}{Device Types / Memory Balloon > > Device / Device Operation / Page Poison} > &g

Re: [virtio-dev] Re: [PATCH RESEND v6 0/3] virtio-spec: Add documentation for recently added balloon features

2020-08-18 Thread Alexander Duyck
On Tue, Aug 18, 2020 at 10:41 AM David Hildenbrand wrote: > > On 18.08.20 19:32, Alexander Duyck wrote: > > I am resending this patch set with the hope of getting final reviews sorted > > out as I had no feedback on v6. If there are no further comments to be made > >

[virtio-dev] [PATCH RESEND v6 0/3] virtio-spec: Add documentation for recently added balloon features

2020-08-18 Thread Alexander Duyck
://lore.kernel.org/lkml/20200211224416.29318.44077.stgit@localhost.localdomain/ [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html --- Alexander Duyck (3

[virtio-dev] [PATCH RESEND v6 1/3] content: Document balloon feature free page hints

2020-08-18 Thread Alexander Duyck
From: Alexander Duyck Free page hints allow the balloon driver to provide information on what pages are not currently in use so that we can avoid the cost of copying them in migration scenarios. Add a feature description for free page hints describing basic functioning and requirements

[virtio-dev] [PATCH RESEND v6 3/3] content: Document balloon feature free page reporting

2020-08-18 Thread Alexander Duyck
From: Alexander Duyck Free page reporting is a feature that allows the guest to proactively report unused pages to the host. By making use of this feature is is possible to reduce the overall memory footprint of the guest in cases where some significant portion of the memory is idle. Add

[virtio-dev] [PATCH RESEND v6 2/3] content: Document balloon feature page poison

2020-08-18 Thread Alexander Duyck
From: Alexander Duyck Page poison provides a way for the guest to notify the host that it is initializing or poisoning freed pages with some specific poison value. As a result of this we can infer a couple traits about the guest: 1. Free pages will contain a specific pattern within the guest. 2

[virtio-dev] Re: [PATCH v6 0/3] virtio-spec: Add documentation for recently added balloon features

2020-08-10 Thread Alexander Duyck
So it has been almost a month since I submitted this and there hasn't been any feedback. I'm wondering if this is ready for acceptance. If so what are the next steps to getting this accepted into the virtio spec? Thanks. - Alex On Mon, Jul 13, 2020 at 11:24 AM Alexander Duyck wrote

[virtio-dev] [PATCH v3 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-07-20 Thread Alexander Duyck
From: Alexander Duyck Recently a feature named Free Page Reporting was added to the virtio balloon. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report

[virtio-dev] [PATCH v3 QEMU 2/3] virtio-balloon: Add locking to prevent possible race when starting hinting

2020-07-20 Thread Alexander Duyck
From: Alexander Duyck There is already locking in place when we are stopping free page hinting but there is not similar protections in place when we start. I can only assume this was overlooked as in most cases the page hinting should not be occurring when we are starting the hinting, however

[virtio-dev] [PATCH v3 QEMU 1/3] virtio-balloon: Prevent guest from starting a report when we didn't request one

2020-07-20 Thread Alexander Duyck
From: Alexander Duyck Based on code review it appears possible for the driver to force the device out of a stopped state when hinting by repeating the last ID it was provided. Prevent this by only allowing a transition to the start state when we are in the requested state. This way the driver

[virtio-dev] [PATCH v3 QEMU 0/3] virtio-balloon: Free page hinting clean-ups

2020-07-20 Thread Alexander Duyck
g Coverity issue Rebased on latest pull of QEMU --- Alexander Duyck (3): virtio-balloon: Prevent guest from starting a report when we didn't request one virtio-balloon: Add locking to prevent possible race when starting hinting virtio-balloon: Replace free page hinting references

[virtio-dev] [PATCH v6 1/3] content: Document balloon feature free page hints

2020-07-13 Thread Alexander Duyck
From: Alexander Duyck Free page hints allow the balloon driver to provide information on what pages are not currently in use so that we can avoid the cost of copying them in migration scenarios. Add a feature description for free page hints describing basic functioning and requirements

[virtio-dev] [PATCH v6 0/3] virtio-spec: Add documentation for recently added balloon features

2020-07-13 Thread Alexander Duyck
://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html --- Alexander Duyck (3): content: Document balloon feature free page hints content: Document balloon feature page poison content: Document balloon feature free page reporting conformance.tex |6 + content.tex

[virtio-dev] [PATCH v6 3/3] content: Document balloon feature free page reporting

2020-07-13 Thread Alexander Duyck
From: Alexander Duyck Free page reporting is a feature that allows the guest to proactively report unused pages to the host. By making use of this feature is is possible to reduce the overall memory footprint of the guest in cases where some significant portion of the memory is idle. Add

[virtio-dev] [PATCH v6 2/3] content: Document balloon feature page poison

2020-07-13 Thread Alexander Duyck
From: Alexander Duyck Page poison provides a way for the guest to notify the host that it is initializing or poisoning freed pages with some specific poison value. As a result of this we can infer a couple traits about the guest: 1. Free pages will contain a specific pattern within the guest. 2

[virtio-dev] Re: [PATCH v5 1/3] content: Document balloon feature page poison

2020-07-09 Thread Alexander Duyck
On Wed, Jul 8, 2020 at 4:03 AM Cornelia Huck wrote: > > On Mon, 06 Jul 2020 14:18:22 -0700 > Alexander Duyck wrote: > > > From: Alexander Duyck > > > > Page poison provides a way for the guest to notify the host that it is > > initializing or poisoning f

[virtio-dev] [PATCH v5 2/3] content: Document balloon feature free page reporting

2020-07-06 Thread Alexander Duyck
From: Alexander Duyck Free page reporting is a feature that allows the guest to proactively report unused pages to the host. By making use of this feature is is possible to reduce the overall memory footprint of the guest in cases where some significant portion of the memory is idle. Add

[virtio-dev] [PATCH v5 1/3] content: Document balloon feature page poison

2020-07-06 Thread Alexander Duyck
From: Alexander Duyck Page poison provides a way for the guest to notify the host that it is initializing or poisoning freed pages with some specific poison value. As a result of this we can infer a couple traits about the guest: 1. Free pages will contain a specific pattern within the guest. 2

[virtio-dev] [PATCH v5 0/3] virtio-spec: Add documentation for recently added balloon features

2020-07-06 Thread Alexander Duyck
--- Alexander Duyck (3): content: Document balloon feature page poison content: Document balloon feature free page reporting content: Document balloon feature free page hints conformance.tex |6 + content.tex | 280 ++- 2 files

[virtio-dev] [PATCH v2 0/3] virtio-balloon: Free page hinting clean-ups

2020-07-06 Thread Alexander Duyck
nd clarify which objects are for free page reporting and which are for free page hinting. Changes from v1: Split first patch into two patches as each addresses a separate issue. Added acked-by for first patch. --- Alexander Duyck (3): virtio-balloon: Prevent guest from starting a repo

[virtio-dev] [PATCH v2 2/3] virtio-balloon: Add locking to prevent possible race when starting hinting

2020-07-06 Thread Alexander Duyck
From: Alexander Duyck There is already locking in place when we are stopping free page hinting but there is not similar protections in place when we start. I can only assume this was overlooked as in most cases the page hinting should not be occurring when we are starting the hinting, however

Re: [virtio-dev] Re: [virtio-comment] [PATCH v4 3/3] content: Document balloon feature free page hints

2020-07-06 Thread Alexander Duyck
On Wed, Jun 24, 2020 at 11:26 AM David Hildenbrand wrote: > > On 27.05.20 06:07, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Free page hints allow the balloon driver to provide information on what > > pages are not currently in use so that we can avoi

[virtio-dev] Re: [PATCH 1/2] virtio-balloon: Prevent guest from starting a report when we didn't request one

2020-06-22 Thread Alexander Duyck
On Mon, Jun 22, 2020 at 1:10 AM David Hildenbrand wrote: > > On 19.06.20 23:53, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Based on code review it appears possible for the driver to force the device > > out of a stopped state when hi

[virtio-dev] [PATCH 2/2] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-19 Thread Alexander Duyck
From: Alexander Duyck Recently a feature named Free Page Reporting was added to the virtio balloon. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report

[virtio-dev] [PATCH 1/2] virtio-balloon: Prevent guest from starting a report when we didn't request one

2020-06-19 Thread Alexander Duyck
From: Alexander Duyck Based on code review it appears possible for the driver to force the device out of a stopped state when hinting by repeating the last ID it was provided. Prevent this by only allowing a transition to the start state when we are in the requested state. This way the driver

[virtio-dev] [PATCH 0/2] virtio-balloon: Free page hinting clean-ups

2020-06-19 Thread Alexander Duyck
containing the same ID it had submitted earlier. The second patch takes care of renaming various hinting objects that were using "reporting" in the name to try and clarify which objects are for free page reporting and which are for free page hinting. --- Alexander Duyck (2): virt

[virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread Alexander Duyck
On Thu, Jun 18, 2020 at 10:10 AM David Hildenbrand wrote: > > >> > >> Ugh, ... > >> > >> @MST, you might have missed that in another discussion, what's your > >> general opinion about removing free page hinting in QEMU (and Linux)? We > >> keep finding issues in the QEMU implementation, including

[virtio-dev] Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread Alexander Duyck
On Thu, Jun 18, 2020 at 5:54 AM David Hildenbrand wrote: > > On 13.06.20 22:07, Alexander Duyck wrote: > > On Tue, May 26, 2020 at 9:14 PM Alexander Duyck > > wrote: > >> > >> From: Alexander Duyck > >> > >> In an upcoming patch a featu

[virtio-dev] Re: [PATCH v25 QEMU 0/3] virtio-balloon: add support for page poison and free page reporting

2020-06-08 Thread Alexander Duyck
It's been almost 2 weeks since I submitted this. Just thought I would follow up and see if there is any ETA on when this might be applied, or if I missed the need to fix something and resubmit. Thanks. - Alex On Tue, May 26, 2020 at 9:13 PM Alexander Duyck wrote: > > This series pr

[virtio-dev] Re: [virtio-comment] [PATCH v4 1/3] content: Document balloon feature page poison

2020-05-29 Thread Alexander Duyck
On Fri, May 29, 2020 at 1:13 AM David Hildenbrand wrote: > > On 27.05.20 06:06, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Page poison provides a way for the guest to notify the host that it is > > initializing or poisoning freed pages w

[virtio-dev] [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-05-26 Thread Alexander Duyck
From: Alexander Duyck In an upcoming patch a feature named Free Page Reporting is about to be added. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report

[virtio-dev] [PATCH v25 QEMU 2/3] virtio-balloon: Provide an interface for free page reporting

2020-05-26 Thread Alexander Duyck
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back

[virtio-dev] [PATCH v25 QEMU 0/3] virtio-balloon: add support for page poison and free page reporting

2020-05-26 Thread Alexander Duyck
el headers were synced Added compat machine code for page-poison feature Changes from v24: Moved free page hinting rename to end of set as feature may be removed entirely Added code to cleanup reporting_vq --- Alexander Duyck (3): virtio-balloon: Implement support for page poison reporting

[virtio-dev] [PATCH v25 QEMU 1/3] virtio-balloon: Implement support for page poison reporting feature

2020-05-26 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison reporting if we want to actually get data on if the guest will be poisoning pages. Add a value for reporting the poison value being used if page poisoning is enabled in the guest. With this we can determine if we

[virtio-dev] [PATCH v4 3/3] content: Document balloon feature free page hints

2020-05-26 Thread Alexander Duyck
From: Alexander Duyck Free page hints allow the balloon driver to provide information on what pages are not currently in use so that we can avoid the cost of copying them in migration scenarios. Add a feature description for free page hints describing basic functioning and requirements

[virtio-dev] [PATCH v4 0/3] virtio-spec: Add documentation for recently added balloon features

2020-05-26 Thread Alexander Duyck
@localhost.localdomain/ [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html --- Alexander Duyck (3): content: Document balloon feature page poison

[virtio-dev] [PATCH v4 1/3] content: Document balloon feature page poison

2020-05-26 Thread Alexander Duyck
From: Alexander Duyck Page poison provides a way for the guest to notify the host that it is initializing or poisoning freed pages with some specific poison value. As a result of this we can infer a couple traits about the guest: 1. Free pages will contain a specific pattern within the guest. 2

[virtio-dev] [PATCH v4 2/3] content: Document balloon feature free page reporting

2020-05-26 Thread Alexander Duyck
From: Alexander Duyck Free page reporting is a feature that allows the guest to proactively report unused pages to the host. By making use of this feature is is possible to reduce the overall memory footprint of the guest in cases where some significant portion of the memory is idle. Add

[virtio-dev] Re: [virtio-comment] [PATCH v3 2/3] content: Document balloon feature page poison

2020-05-26 Thread Alexander Duyck
On Tue, May 26, 2020 at 8:38 AM Cornelia Huck wrote: > > On Tue, 26 May 2020 17:28:00 +0200 > David Hildenbrand wrote: > > > On 26.05.20 16:50, Alexander Duyck wrote: > > > On Tue, May 26, 2020 at 1:24 AM David Hildenbrand > > > wrote: > > > >>

[virtio-dev] Re: [PATCH v2 resubmit] virtio-balloon: Disable free page reporting if page poison reporting is not enabled

2020-05-26 Thread Alexander Duyck
like we are at RC7 now so I am worried this won't make it in before LInus releases 5.7. Thanks. - Alex On Fri, May 15, 2020 at 10:02 AM Alexander Duyck wrote: > > Just following up. It has been a week since I submitted this. I was > hoping we could get it in for 5.7 since this affects

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-26 Thread Alexander Duyck
On Wed, May 20, 2020 at 1:24 AM David Hildenbrand wrote: > > On 19.05.20 23:00, Alexander Duyck wrote: > > On Tue, May 19, 2020 at 9:09 AM David Hildenbrand wrote: [...] > >>>> > >>>> Let's think this through, what about this scenario: > >>>

[virtio-dev] Re: [virtio-comment] [PATCH v3 2/3] content: Document balloon feature page poison

2020-05-26 Thread Alexander Duyck
On Tue, May 26, 2020 at 1:24 AM David Hildenbrand wrote: > > On 20.05.20 18:25, Alexander Duyck wrote: > > On Wed, May 20, 2020 at 2:28 AM David Hildenbrand wrote: > >> > >> On 20.05.20 04:02, Alexander Duyck wrote: > >>> From: Alexander Duy

[virtio-dev] Re: [virtio-comment] [PATCH v3 3/3] content: Document balloon feature free page reporting

2020-05-26 Thread Alexander Duyck
On Tue, May 26, 2020 at 2:06 AM David Hildenbrand wrote: > > On 20.05.20 04:02, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Free page reporting is a feature that allows the guest to proactively > > report unused pages to the host. By making use of t

[virtio-dev] [PATCH v3 3/3] content: Document balloon feature free page reporting

2020-05-19 Thread Alexander Duyck
From: Alexander Duyck Free page reporting is a feature that allows the guest to proactively report unused pages to the host. By making use of this feature is is possible to reduce the overall memory footprint of the guest in cases where some significant portion of the memory is idle. Add

[virtio-dev] [PATCH v3 1/3] content: Document balloon feature free page hints

2020-05-19 Thread Alexander Duyck
From: Alexander Duyck Free page hints allow the balloon driver to provide information on what pages are not currently in use so that we can avoid the cost of copying them in migration scenarios. Add a feature description for free page hints describing basic functioning and requirements. Signed

[virtio-dev] [PATCH v3 2/3] content: Document balloon feature page poison

2020-05-19 Thread Alexander Duyck
From: Alexander Duyck Page poison provides a way for the guest to notify the host of the content expected to be found in pages when they are added back to the guest after being discarded. The feature currently doesn't apply to the existing balloon features, however it will apply to an upcoming

[virtio-dev] [PATCH v3 0/3] virtio-spec: Add documentation for recently added balloon features

2020-05-19 Thread Alexander Duyck
.stgit@localhost.localdomain/ [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html --- Alexander Duyck (3): content: Document balloon feature free

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-19 Thread Alexander Duyck
On Tue, May 19, 2020 at 9:09 AM David Hildenbrand wrote: > > >> I proposed that the driver MUST reinitialize the pages when reusing > >> (which is what Linux does), so then this is true. Reuse implies > >> initializing, implies modification. It's somewhat simpler than what you > >> propose,

[virtio-dev] Re: [virtio-comment] [PATCH v2 3/3] content: Document balloon feature free page reporting

2020-05-19 Thread Alexander Duyck
On Tue, May 19, 2020 at 3:27 AM David Hildenbrand wrote: > > On 15.05.20 19:33, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Free page reporting is a feature that allows the guest to proactively > > report unused pages to the host. By making use of t

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-19 Thread Alexander Duyck
On Mon, May 18, 2020 at 11:54 PM Cornelia Huck wrote: > > On Mon, 18 May 2020 13:15:50 -0700 > Alexander Duyck wrote: > > > On Mon, May 18, 2020 at 6:18 AM David Hildenbrand wrote: > > > > > > On 15.05.20 19:33, Alexander Duyck wrote: > > >

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-19 Thread Alexander Duyck
On Tue, May 19, 2020 at 2:40 AM David Hildenbrand wrote: > > [...] > >>> +\begin{description} > >>> +\item[VIRTIO_BALLOON_CMD_ID_STOP (0)] Any command ID previously supplied > >>> by > >>> + the device is invalid. The driver should halt all hinting until a new > >>> + command ID is supplied. >

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-18 Thread Alexander Duyck
On Mon, May 18, 2020 at 6:18 AM David Hildenbrand wrote: > > On 15.05.20 19:33, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Free page hints allow the balloon driver to provide information on what > > pages are not currently in use so that we can avoi

[virtio-dev] Re: [PATCH v24 QEMU 3/3] virtio-balloon: Provide an interface for free page reporting

2020-05-18 Thread Alexander Duyck
On Fri, May 8, 2020 at 2:30 PM Alexander Duyck wrote: > > From: Alexander Duyck > > Add support for free page reporting. The idea is to function very similar > to how the balloon works in that we basically end up madvising the page as > not being used. However we don't rea

[virtio-dev] Re: [virtio-comment] [PATCH 2/3] content: Document balloon feature page poison

2020-05-15 Thread Alexander Duyck
On Fri, May 15, 2020 at 10:17 AM David Hildenbrand wrote: > > On 08.05.20 19:16, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Page poison provides a way for the guest to notify the host of the content > > expected to be found in pages when they are

[virtio-dev] [PATCH v2 3/3] content: Document balloon feature free page reporting

2020-05-15 Thread Alexander Duyck
From: Alexander Duyck Free page reporting is a feature that allows the guest to proactively report unused pages to the host. By making use of this feature is is possible to reduce the overall memory footprint of the guest in cases where some significant portion of the memory is idle. Add

[virtio-dev] [PATCH v2 2/3] content: Document balloon feature page poison

2020-05-15 Thread Alexander Duyck
From: Alexander Duyck Page poison provides a way for the guest to notify the host of the content expected to be found in pages when they are added back to the guest after being discarded. The feature currently doesn't apply to the existing balloon features, however it will apply to an upcoming

[virtio-dev] [PATCH v2 1/3] content: Document balloon feature free page hints

2020-05-15 Thread Alexander Duyck
From: Alexander Duyck Free page hints allow the balloon driver to provide information on what pages are not currently in use so that we can avoid the cost of copying them in migration scenarios. Add a feature description for free page hints describing basic functioning and requirements. Signed

[virtio-dev] [PATCH v2 0/3] virtio-spec: Add documentation for recently added balloon features

2020-05-15 Thread Alexander Duyck
/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html --- Alexander Duyck (3): content: Document balloon feature free page hints content: Document balloon feature page poison content: Document balloon feature

[virtio-dev] Re: [PATCH 0/3] virtio-spec: Add documentation for recently added balloon features

2020-05-15 Thread Alexander Duyck
On Mon, May 11, 2020 at 5:44 AM David Hildenbrand wrote: > > On 11.05.20 14:38, Cornelia Huck wrote: > > On Fri, 08 May 2020 10:16:14 -0700 > > Alexander Duyck wrote: > > > >> This patch set is meant to add documentation for balloon features that have > >&g

[virtio-dev] Re: [PATCH v2 resubmit] virtio-balloon: Disable free page reporting if page poison reporting is not enabled

2020-05-15 Thread Alexander Duyck
Just following up. It has been a week since I submitted this. I was hoping we could get it in for 5.7 since this affects free page reporting which will be introduced with that kernel release. Thanks. - Alex On Fri, May 8, 2020 at 10:40 AM Alexander Duyck wrote: > > From: Alexander

[virtio-dev] Re: [PATCH 0/3] virtio-spec: Add documentation for recently added balloon features

2020-05-11 Thread Alexander Duyck
On Mon, May 11, 2020 at 5:44 AM David Hildenbrand wrote: > > On 11.05.20 14:38, Cornelia Huck wrote: > > On Fri, 08 May 2020 10:16:14 -0700 > > Alexander Duyck wrote: > > > >> This patch set is meant to add documentation for balloon features that have > >&g

[virtio-dev] Re: [PATCH 3/3] content: Document balloon feature free page reporting

2020-05-11 Thread Alexander Duyck
I have incorporated your feedback. Thanks. - Alex On Mon, May 11, 2020 at 5:36 AM Cornelia Huck wrote: > > On Fri, 08 May 2020 10:16:36 -0700 > Alexander Duyck wrote: > > > From: Alexander Duyck > > > > Free page reporting is a feature that allows the guest to

[virtio-dev] Re: [PATCH 2/3] content: Document balloon feature page poison

2020-05-11 Thread Alexander Duyck
Thanks. I will incorporate the feedback below for v2. On Mon, May 11, 2020 at 5:25 AM Cornelia Huck wrote: > > On Fri, 08 May 2020 10:16:29 -0700 > Alexander Duyck wrote: > > > From: Alexander Duyck > > > > Page poison provides a way for the guest to notify the ho

[virtio-dev] Re: [PATCH 1/3] content: Document balloon feature free page hints

2020-05-11 Thread Alexander Duyck
On Mon, May 11, 2020 at 5:10 AM Cornelia Huck wrote: > > On Fri, 08 May 2020 10:16:22 -0700 > Alexander Duyck wrote: > > > From: Alexander Duyck > > > > Free page hints allow the balloon driver to provide information on what > > pages are not currently

[virtio-dev] [PATCH v24 QEMU 3/3] virtio-balloon: Provide an interface for free page reporting

2020-05-08 Thread Alexander Duyck
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back

[virtio-dev] [PATCH v24 QEMU 2/3] virtio-balloon: Implement support for page poison reporting feature

2020-05-08 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison reporting if we want to actually get data on if the guest will be poisoning pages. Add a value for reporting the poison value being used if page poisoning is enabled in the guest. With this we can determine if we

[virtio-dev] [PATCH v24 QEMU 0/3] virtio-balloon: add support for page poison reporting and free page reporting

2020-05-08 Thread Alexander Duyck
el headers were synced Added compat machine bits for page-poison feature --- Alexander Duyck (3): virtio-balloon: Replace free page hinting references to 'report' with 'hint' virtio-balloon: Implement support for page poison reporting feature virtio-balloon: Provide an inter

[virtio-dev] [PATCH v24 QEMU 1/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-05-08 Thread Alexander Duyck
From: Alexander Duyck In an upcoming patch a feature named Free Page Reporting is about to be added. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report

[virtio-dev] Re: [PATCH v23 QEMU 0/5] virtio-balloon: add support for page poison reporting and free page reporting

2020-05-08 Thread Alexander Duyck
that are adding the functionality, or if this patch-set is good as-is? Thanks. - Alex On Mon, Apr 27, 2020 at 5:53 PM Alexander Duyck wrote: > > This series provides an asynchronous means of reporting free guest pages > to QEMU through virtio-balloon so that the memory associated with those &g

[virtio-dev] [PATCH 1/3] content: Document balloon feature free page hints

2020-05-08 Thread Alexander Duyck
From: Alexander Duyck Free page hints allow the balloon driver to provide information on what pages are not currently in use so that we can avoid the cost of copying them in migration scenarios. Add a feature description for free page hints describing basic functioning and requirements. Signed

[virtio-dev] [PATCH 3/3] content: Document balloon feature free page reporting

2020-05-08 Thread Alexander Duyck
From: Alexander Duyck Free page reporting is a feature that allows the guest to proactively report unused pages to the host. By making use of this feature is is possible to reduce the overall memory footprint of the guest in cases where some significant portion of the memory is idle. Add

[virtio-dev] [PATCH 2/3] content: Document balloon feature page poison

2020-05-08 Thread Alexander Duyck
From: Alexander Duyck Page poison provides a way for the guest to notify the host of the content expected to be found in pages when they are added back to the guest after being discarded. The feature currently doesn't apply to the existing balloon features, however it will apply to an upcoming

[virtio-dev] [PATCH 0/3] virtio-spec: Add documentation for recently added balloon features

2020-05-08 Thread Alexander Duyck
://lore.kernel.org/lkml/20200211224416.29318.44077.stgit@localhost.localdomain/ [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html --- Alexander Duyck (3

[virtio-dev] Re: [virtio-comment] Re: [PATCH RFC 3/3] content: Document balloon feature free page reporting

2020-05-07 Thread Alexander Duyck
On Thu, May 7, 2020 at 8:59 AM Cornelia Huck wrote: > > On Wed, 29 Apr 2020 11:57:57 -0700 > Alexander Duyck wrote: > > > From: Alexander Duyck > > > > Free page reporting is a feature that allows the guest to proactively > > report unused pages to the

[virtio-dev] Re: [PATCH RFC 2/3] content: Document balloon feature page poison

2020-05-07 Thread Alexander Duyck
On Thu, May 7, 2020 at 8:48 AM Cornelia Huck wrote: > > On Wed, 29 Apr 2020 11:57:51 -0700 > Alexander Duyck wrote: > > > From: Alexander Duyck > > > > Page poison provides a way for the guest to notify the host of the content > > expected to be fou

[virtio-dev] Re: [PATCH RFC 1/3] content: Document balloon feature free page hints

2020-05-07 Thread Alexander Duyck
Thanks for the review. For anything below where I didn't comment I am just going with your suggestion. On Thu, May 7, 2020 at 8:35 AM Cornelia Huck wrote: > > On Wed, 29 Apr 2020 11:57:45 -0700 > Alexander Duyck wrote: > > > From: Alexander Duyck > > > > Fre

[virtio-dev] [PATCH RFC 0/3] virtio-spec: Add documentation for recently added balloon features

2020-04-29 Thread Alexander Duyck
/lkml/20200211224416.29318.44077.stgit@localhost.localdomain/ [2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b0c504f154718904ae49349147e3b7e6ae91ffdc [3]: https://lists.oasis-open.org/archives/virtio-dev/202004/msg00180.html --- Alexander Duyck (3): content

[virtio-dev] [PATCH RFC 3/3] content: Document balloon feature free page reporting

2020-04-29 Thread Alexander Duyck
From: Alexander Duyck Free page reporting is a feature that allows the guest to proactively report unused pages to the host. By making use of this feature is is possible to reduce the overall memory footprint of the guest in cases where some significant portion of the memory is idle. Add

[virtio-dev] [PATCH RFC 2/3] content: Document balloon feature page poison

2020-04-29 Thread Alexander Duyck
From: Alexander Duyck Page poison provides a way for the guest to notify the host of the content expected to be found in pages when they are added back to the guest after being discarded. The feature currently doesn't apply to the existing balloon features, however it will apply to an upcoming

[virtio-dev] [PATCH v23 QEMU 4/5] virtio-balloon: Implement support for page poison reporting feature

2020-04-27 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison reporting if we want to actually get data on if the guest will be poisoning pages. Add a value for reporting the poison value being used if page poisoning is enabled in the guest. With this we can determine if we

[virtio-dev] [PATCH v23 QEMU 5/5] virtio-balloon: Provide an interface for free page reporting

2020-04-27 Thread Alexander Duyck
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back

[virtio-dev] [PATCH v23 QEMU 2/5] linux-headers: update to contain virito-balloon free page reporting

2020-04-27 Thread Alexander Duyck
From: Alexander Duyck Sync the latest upstream changes for free page reporting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/standard-headers/linux

[virtio-dev] [PATCH v23 QEMU 0/5] virtio-balloon: add support for page poison reporting and free page reporting

2020-04-27 Thread Alexander Duyck
ches 4 & 5 Added additional comment fixes in patch 3 to remove "reporting" reference Renamed rvq in patch 5 to reporting_vq to improve readability Moved call adding reporting_vq to after free_page_vq to fix VQ ordering --- Alexander Duyck (5): linux-headers:

[virtio-dev] [PATCH v23 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-27 Thread Alexander Duyck
From: Alexander Duyck In an upcoming patch a feature named Free Page Reporting is about to be added. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report

  1   2   3   4   >