[virtio-dev] Re: [PATCH] virtio: introduce SUSPEND bit in device status

2024-02-25 Thread Michael S. Tsirkin
On Fri, Feb 23, 2024 at 03:44:41PM +0800, Zhu, Lingshan wrote: > > > On 2/20/2024 1:09 PM, David Stevens wrote: > > On Tue, Feb 20, 2024 at 1:06 PM Zhu, Lingshan > > wrote: > > > On 2/19/2024 2:46 PM, David Stevens wrote: > > > > On Sun, F

[virtio-dev] Re: [PATCH] virtio: introduce SUSPEND bit in device status

2024-02-19 Thread Michael S. Tsirkin
On Tue, Feb 20, 2024 at 02:09:18PM +0900, David Stevens wrote: > On Tue, Feb 20, 2024 at 1:06 PM Zhu, Lingshan wrote: > > On 2/19/2024 2:46 PM, David Stevens wrote: > > > On Sun, Feb 18, 2024 at 11:11 PM Michael S. Tsirkin > > > wrote: > > >> On Sun

[virtio-dev] Re: [PATCH v4 1/1] Add suspend support for virtio PCI devices

2024-02-18 Thread Michael S. Tsirkin
On Mon, Feb 19, 2024 at 03:46:37PM +0900, David Stevens wrote: > On Fri, Feb 16, 2024 at 5:56 PM Michael S. Tsirkin wrote: > > > > On Fri, Feb 16, 2024 at 05:24:32PM +0900, David Stevens wrote: > > > Add a virtio power management PCI capability to allow drivers to suspend

[virtio-dev] Re: [PATCH] virtio: introduce SUSPEND bit in device status

2024-02-18 Thread Michael S. Tsirkin
On Sun, Feb 18, 2024 at 09:23:06PM +0800, Zhu Lingshan wrote: > This commit allows the driver to suspend the device by > introducing a new status bit SUSPEND in device_status. > > This commit also introduce a new feature bit VIRTIO_F_SUSPEND > which indicating whether the device support SUSPEND. >

[virtio-dev] Re: [v4 PATCH] ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.

2024-02-16 Thread Michael S. Tsirkin
On Fri, Feb 16, 2024 at 02:42:37PM +0100, Takashi Iwai wrote: > On Fri, 16 Feb 2024 12:27:48 +0100, > Michael S. Tsirkin wrote: > > > > On Fri, Feb 16, 2024 at 11:06:43AM +0100, Aiswarya Cyriac wrote: > > > This commit fixes the following warning when

[virtio-dev] Re: [v4 PATCH] ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.

2024-02-16 Thread Michael S. Tsirkin
} > > break; > + default: > + rc = -EINVAL; > + /* We never get here - we listed all values for op_flag */ > + WARN_ON(1); > + goto on_msg_unref; > } > + kfree(tlv); > + return rc; &

[virtio-dev] Re: [PATCH v4 1/1] Add suspend support for virtio PCI devices

2024-02-16 Thread Michael S. Tsirkin
On Fri, Feb 16, 2024 at 05:24:32PM +0900, David Stevens wrote: > Add a virtio power management PCI capability to allow drivers to suspend > virtio PCI devices. This allows drivers to suspend devices at the virtio > level before suspending them at the PCI transport layer. This allows > drivers to do

[virtio-dev] Re: [v3 PATCH] ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.

2024-02-14 Thread Michael S. Tsirkin
On Wed, Feb 14, 2024 at 03:01:10PM +0100, Aiswarya Cyriac wrote: > This commit fixes the following warning when building virtio_snd driver. > > " > *** CID 1583619: Uninitialized variables (UNINIT) > sound/virtio/virtio_kctl.c:294 in virtsnd_kctl_tlv_op() > 288 > 289 break; > 2

[virtio-dev] Re: [PATCH] ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.

2024-02-14 Thread Michael S. Tsirkin
+ default: > >> + virtsnd_ctl_msg_unref(msg); > >> + rc = -EINVAL; > >> + > > >There's already virtsnd_ctl_msg_unref call above. > >Also don't we need virtsnd_ctl_msg_unref on other error paths > >such as EFAULT? > >Unify

[virtio-dev] Re: [PATCH] ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.

2024-02-13 Thread Michael S. Tsirkin
On Tue, Feb 13, 2024 at 10:02:24AM +0100, Takashi Iwai wrote: > On Tue, 13 Feb 2024 09:51:30 +0100, > Aiswarya Cyriac wrote: > > > > Fix the following warning when building virtio_snd driver. > > > > " > > *** CID 1583619: Uninitialized variables (UNINIT) > > sound/virtio/virtio_kctl.c:294 in v

[virtio-dev] Re: [PATCH] ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning.

2024-02-13 Thread Michael S. Tsirkin
On Tue, Feb 13, 2024 at 09:51:30AM +0100, Aiswarya Cyriac wrote: > Fix the following warning when building virtio_snd driver. > > " > *** CID 1583619: Uninitialized variables (UNINIT) > sound/virtio/virtio_kctl.c:294 in virtsnd_kctl_tlv_op() > 288 > 289 break; > 290   } > 291 > 292

[virtio-dev] Re: [virtio] [PATCH] virtio-net: clarify error handling for coalescing

2024-01-29 Thread Michael S. Tsirkin
On Mon, Jan 29, 2024 at 04:06:01PM +0100, Cornelia Huck wrote: > On Wed, Jan 24 2024, "Michael S. Tsirkin" wrote: > > > This is not a huge deal since it's a SHOULD anyway, > > so make the new requirement SHOULD too. > > > > Signed-off-by: Mich

[virtio-dev] Re: [virtio] [PATCH] virtio-net: clarify error handling for coalescing

2024-01-26 Thread Michael S. Tsirkin
On Wed, Jan 24, 2024 at 11:23:08AM +, Parav Pandit wrote: > > > > From: vir...@lists.oasis-open.org On Behalf Of > > Michael S. Tsirkin > > Sent: Wednesday, January 24, 2024 4:46 PM > > To: virtio-comm...@lists.oasis-open.org; virtio-dev@lists.oasis-open.

[virtio-dev] [PATCH] virtio-net: clarify error handling for coalescing

2024-01-24 Thread Michael S. Tsirkin
This is not a huge deal since it's a SHOULD anyway, so make the new requirement SHOULD too. Signed-off-by: Michael S. Tsirkin --- device-types/net/description.tex | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/device-types/net/description.tex b/device-type

[virtio-dev] Re: [PATCH v2] virtio-net: support setting coalescing params for multiple vqs

2024-01-24 Thread Michael S. Tsirkin
On Wed, Jan 24, 2024 at 05:50:28AM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 15, 2024 at 09:06:02PM +0800, Heng Qi wrote: > > Currently, when each time the driver attempts to update the coalescing > > parameters > > for a vq, it needs to kick the device and wait for

[virtio-dev] Re: [PATCH v2] virtio-net: support setting coalescing params for multiple vqs

2024-01-24 Thread Michael S. Tsirkin
On Mon, Jan 15, 2024 at 09:06:02PM +0800, Heng Qi wrote: > Currently, when each time the driver attempts to update the coalescing > parameters > for a vq, it needs to kick the device and wait for the ctrlq response to > return. > The following path is observed: 1. Driver kicks the device; 2. Afte

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [virtio-comment] [PATCH v2] virtio-net: support setting coalescing params for multiple vqs

2024-01-22 Thread Michael S. Tsirkin
On Tue, Jan 23, 2024 at 05:55:02AM +, Parav Pandit wrote: > > From: Michael S. Tsirkin > > Sent: Monday, January 22, 2024 1:06 PM > > > > On Mon, Jan 22, 2024 at 05:03:38AM +, Parav Pandit wrote: > > > > >>> The right test on Linux to do witho

[virtio-dev] Re: [PATCH] Define the DEVICE ID of Virtio Cpu balloon device as 47

2024-01-22 Thread Michael S. Tsirkin
On Mon, Jan 22, 2024 at 11:11:57PM +, Shujun Xue wrote: > The virtio CPU balloon device is a primitive device for managing guest > CPU capacity: the device asks for certain CPU cores to be onlined, > offlined of throttled, and the driver performs the requested operation. > This allows the guest

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] RE: [virtio-comment] [PATCH v2] virtio-net: support setting coalescing params for multiple vqs

2024-01-21 Thread Michael S. Tsirkin
On Mon, Jan 22, 2024 at 05:03:38AM +, Parav Pandit wrote: > > >>> The right test on Linux to do without rtnl lock which is anyway ugly > > >>> and > > >> wrong semantic to use blocking the whole netdev stack. > > >>> (in case if you used that). > > >> Do you have any good directions and attempt

[virtio-dev] Re: [PATCH v2] virtio-net: support setting coalescing params for multiple vqs

2024-01-15 Thread Michael S. Tsirkin
On Mon, Jan 15, 2024 at 09:06:02PM +0800, Heng Qi wrote: > Currently, when each time the driver attempts to update the coalescing > parameters > for a vq, it needs to kick the device and wait for the ctrlq response to > return. > The following path is observed: 1. Driver kicks the device; 2. Afte

Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-19 Thread Michael S. Tsirkin
On Wed, Dec 20, 2023 at 02:30:01PM +0800, Heng Qi wrote: > But why are we discussing this? I think basically at this point everyone is confused about what the feature does. right now we have packets with #define VIRTIO_NET_HDR_F_NEEDS_CSUM 1 -> partial #define VIRTIO_NET_HDR_F_DATA_VALI

[virtio-dev] Re: [virtio-comment] Re: [PATCH v5] virtio-net: device does not deliver partially checksummed packet and may validate the checksum

2023-12-19 Thread Michael S. Tsirkin
EST_CSUM, the > > > packet will contain checksum. And if the device sets DATA_VALID, it > > > means the checksum is validated. > > > > > > Thanks > > > > > > > > > > > >> Since Christmas is coming, I think this feature may be in danger of &g

[virtio-dev] Re: [virtio-comment] [PATCH v3 1/1] Define a low power mode for devices

2023-12-06 Thread Michael S. Tsirkin
On Wed, Dec 06, 2023 at 05:16:04PM +0800, Jason Wang wrote: > On Tue, Dec 5, 2023 at 6:58 PM David Stevens wrote: > > > > On Tue, Dec 5, 2023 at 1:18 PM Jason Wang wrote: > > > > > > On Mon, Dec 4, 2023 at 5:41 PM David Stevens > > > wrote: > > > > > > > > Define a low power mode for virtio dev

[virtio-dev] Re: [virtio-comment] [PATCH v2 0/1] Define low power mode for devices

2023-11-30 Thread Michael S. Tsirkin
On Mon, Nov 13, 2023 at 03:19:49PM +0900, David Stevens wrote: > The virtio spec currently does not include the concept of device power > management. The lack means that there is no good action drivers can take > when they are requested to put the device into a low power state (e.g. > when a guest

[virtio-dev] Re: [virtio-comment] [PATCH v2 1/1] Define a low power mode for devices

2023-11-30 Thread Michael S. Tsirkin
On Mon, Nov 13, 2023 at 03:19:50PM +0900, David Stevens wrote: > Define a low power mode for virtio devices where the devices are > expected to maintain their state. This gives drivers an option for power > management besides simply resetting their device. In the virtualization > use case, this all

[virtio-dev] Re: Using packed virtqueues in Confidential VMs

2023-11-20 Thread Michael S. Tsirkin
t; > To: Reshetova, Elena > > Cc: Michael S. Tsirkin ; virtio-dev@lists.oasis-open.org; > > virtualizat...@lists.linux.dev > > Subject: Using packed virtqueues in Confidential VMs > > > > Hi Elena, > > You raised concerns about using packed virtqueues

Re: Using packed virtqueues in Confidential VMs

2023-11-16 Thread Michael S. Tsirkin
On Thu, Nov 16, 2023 at 03:02:45PM -0500, Stefan Hajnoczi wrote: > Hi Elena, > You raised concerns about using packed virtqueues with untrusted devices at > Linux Plumbers Conference. I reviewed the specification and did not find > fundamental issues that would preclude the use of packed virtqueues

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-11-02 Thread Michael S. Tsirkin
On Thu, Nov 02, 2023 at 12:38:28PM +0100, Babis Chalios wrote: > > On 2/11/23 12:20, Michael S. Tsirkin wrote: > > > > On Thu, Sep 28, 2023 at 08:16:11PM +0200, Babis Chalios wrote: > > > > > > On 27/9/23 23:47, Michael S. Tsirkin wrote: > > > >

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-11-02 Thread Michael S. Tsirkin
On Fri, Sep 22, 2023 at 05:40:50PM +0200, Babis Chalios wrote: > > > On 22/9/23 17:06, Michael S. Tsirkin wrote: > > On Tue, Sep 19, 2023 at 12:11:37PM +0200, Babis Chalios wrote: > > > On 19/9/23 12:01, Michael S. Tsirkin wrote: > > > > On Tue, Sep 19, 202

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-11-02 Thread Michael S. Tsirkin
On Thu, Sep 28, 2023 at 08:16:11PM +0200, Babis Chalios wrote: > > > On 27/9/23 23:47, Michael S. Tsirkin wrote: > > On Wed, Sep 27, 2023 at 12:43:20PM +0200, Babis Chalios wrote: > > > On 22/9/23 18:01, Michael S. Tsirkin wrote: > > > > On Fri, Sep 22, 202

[virtio-dev] Re: [PATCH v6 1/1] content: Add new feature VIRTIO_F_PRESERVE_RESOURCES

2023-10-26 Thread Michael S. Tsirkin
On Thu, Oct 26, 2023 at 10:24:26AM +, Chen, Jiqian wrote: > > On 2023/10/25 11:51, Parav Pandit wrote: > > > > > >> From: Chen, Jiqian > >> Sent: Tuesday, October 24, 2023 5:44 PM > >> > >> On 2023/10/24 18:51, Parav Pandit wrote: > >>> > From: Chen, Jiqian > Sent: Tuesday, Octob

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-10-13 Thread Michael S. Tsirkin
On Fri, Oct 13, 2023 at 09:49:40AM +0200, Babis Chalios wrote: > > > On 28/9/23 20:16, Babis Chalios wrote: > > > > > > On 27/9/23 23:47, Michael S. Tsirkin wrote: > > > On Wed, Sep 27, 2023 at 12:43:20PM +0200, Babis Chalios wrote: > > >

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-12 Thread Michael S. Tsirkin
On Thu, Oct 12, 2023 at 06:49:51PM +0800, Zhu, Lingshan wrote: > For PCI based configuration, like MSI, we need to fetch from config space > anyway. > For others like dirty page, we can store the bitmap in host memory, and use > PASID for isolation. Ok. So how a about a simple interface along the

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-12 Thread Michael S. Tsirkin
On Thu, Oct 12, 2023 at 06:57:35PM +0800, Zhu, Lingshan wrote: > > > On 10/11/2023 7:52 PM, Parav Pandit wrote: > > > From: Zhu, Lingshan > > > Sent: Wednesday, October 11, 2023 4:09 PM > > > I am sure I have not ignored any questions. > > What about below one? > > > > https://lore.kernel.org/v

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-12 Thread Michael S. Tsirkin
On Thu, Oct 12, 2023 at 06:49:51PM +0800, Zhu, Lingshan wrote: > > > On 10/12/2023 5:59 PM, Michael S. Tsirkin wrote: > > On Wed, Oct 11, 2023 at 06:38:32PM +0800, Zhu, Lingshan wrote: > > > > > > On 10/11/2023 6:20 PM, Michael S. Tsirkin wrote: > > >

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-12 Thread Michael S. Tsirkin
On Mon, Oct 09, 2023 at 04:49:33PM +0800, Jason Wang wrote: > > If something is needed for debug please proceed to add such debug interface. > > Most debugging is simply the dumping of device states so I don't know > what you want to say here. Donnu about Parav but I want to say that I'd like to

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-12 Thread Michael S. Tsirkin
On Wed, Oct 11, 2023 at 06:38:32PM +0800, Zhu, Lingshan wrote: > > > On 10/11/2023 6:20 PM, Michael S. Tsirkin wrote: > > On Mon, Oct 09, 2023 at 06:01:42PM +0800, Zhu, Lingshan wrote: > > > > > > On 9/27/2023 11:40 PM, Michael S. Tsirkin wrote: > > >

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-10-11 Thread Michael S. Tsirkin
On Mon, Oct 09, 2023 at 06:01:42PM +0800, Zhu, Lingshan wrote: > > > On 9/27/2023 11:40 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 27, 2023 at 04:20:01PM +0800, Zhu, Lingshan wrote: > > > > > > On 9/26/2023 6:48 PM, Michael S. Tsirkin wrote: > > >

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-09-27 Thread Michael S. Tsirkin
On Wed, Sep 27, 2023 at 12:43:20PM +0200, Babis Chalios wrote: > On 22/9/23 18:01, Michael S. Tsirkin wrote: > > On Fri, Sep 22, 2023 at 05:40:50PM +0200, Babis Chalios wrote: > > > > > > On 22/9/23 17:06, Michael S. Tsirkin wrote: > > > > On Tue, Sep 19,

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-27 Thread Michael S. Tsirkin
On Mon, Sep 25, 2023 at 10:41:12AM +, Parav Pandit wrote: > > > > From: Jason Wang > > Sent: Friday, September 22, 2023 8:38 AM > > > > Device context has no overlap. > > > > I can give you one example, e.g debugging. > > > Almost every feature needs debugging. :) > So I am omitting it for

[virtio-dev] [PATCH] html: add missing enumitem package

2023-09-27 Thread Michael S. Tsirkin
* .] Some web searches turned up suggestions to use enumitem and in fact, virtio.tex already does this - but virtio-html.tex doesn't. Adding \usepackage{enumitem} in virtio-html.tex too fixes the issue. Signed-off-by: Michael S. Tsirkin --- virtio-html.tex | 1 + 1 file changed, 1 inse

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-27 Thread Michael S. Tsirkin
On Wed, Sep 27, 2023 at 04:20:01PM +0800, Zhu, Lingshan wrote: > > > On 9/26/2023 6:48 PM, Michael S. Tsirkin wrote: > > On Tue, Sep 26, 2023 at 05:25:42PM +0800, Zhu, Lingshan wrote: > > > We don't want to repeat the discussions, it looks like endless circle with &

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-27 Thread Michael S. Tsirkin
On Tue, Sep 26, 2023 at 12:37:19PM +0800, Jason Wang wrote: > It's silly to ship a product without any debugging facilities. The way I see it, debugging facilities ideally would be somewhat separate from rest of the driver. For example, imagine an on-device gateway that lets you query the internal

Re: [virtio-dev] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-26 Thread Michael S. Tsirkin
On Tue, Sep 26, 2023 at 11:37:37AM +, Parav Pandit wrote: > Hi Jiqian, > > > From: Chen, Jiqian > > Sent: Tuesday, September 26, 2023 4:30 PM > > > It is not to trigger resume behavior to device by setting unfreeze in my > > scenario. > > You may misunderstand my intention. > > In current k

Re: [virtio-dev] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-26 Thread Michael S. Tsirkin
On Tue, Sep 26, 2023 at 11:00:28AM +, Chen, Jiqian wrote: > On 2023/9/26 10:51, Jason Wang wrote: > > On Tue, Sep 26, 2023 at 10:24 AM Chen, Jiqian wrote: > >> > >> On 2023/9/25 10:52, Jason Wang wrote: > >>> On Fri, Sep 22, 2023 at 4:07 PM Chen, Jiqian wrote: > > Hi Jason, > >

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-26 Thread Michael S. Tsirkin
On Tue, Sep 26, 2023 at 05:25:42PM +0800, Zhu, Lingshan wrote: > We don't want to repeat the discussions, it looks like endless circle with > no direction. OK let me try to direct this discussion. You guys were speaking past each other, no dialog is happening. And as long as it goes on no progress

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-09-22 Thread Michael S. Tsirkin
On Fri, Sep 22, 2023 at 05:40:50PM +0200, Babis Chalios wrote: > > > On 22/9/23 17:06, Michael S. Tsirkin wrote: > > On Tue, Sep 19, 2023 at 12:11:37PM +0200, Babis Chalios wrote: > > > On 19/9/23 12:01, Michael S. Tsirkin wrote: > > > > On Tue, Sep 19, 202

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-09-22 Thread Michael S. Tsirkin
On Tue, Sep 19, 2023 at 12:11:37PM +0200, Babis Chalios wrote: > On 19/9/23 12:01, Michael S. Tsirkin wrote: > > On Tue, Sep 19, 2023 at 09:32:08AM +0200, Babis Chalios wrote: > > > Resending to fix e-mail formatting issues (sorry for the spam) > > > > > > O

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 12:39:31PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 5:53 PM > > > > > Again the thread has been side-tracked, which linux module does what is not > > what it was talking about.

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 10:39:23AM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 3:40 PM > > > > On Thu, Sep 21, 2023 at 09:17:53AM +, Parav Pandit wrote: > > > Vdpa stack make total sense when the

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 09:17:53AM +, Parav Pandit wrote: > Vdpa stack make total sense when the underlying device is not virtio and > hence emulation. Which linux framework is used is kind of beside the point but since you bring this up - not necessarily. E.g. I personally don't care much a

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 09:17:53AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 1:41 PM > > > > I mean to say, > > > Virtio spec has not achieved mediation less, device migration. > > > Vir

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 07:53:18AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 12:51 PM > > > > > As I said, doable without mediation but already done with. > > > > > > > It is not d

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-21 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 06:31:01AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 11:37 AM > > > > We should be enhancing the device context so that more and more items can > > be annotated. > > &g

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 05:54:37AM +, Parav Pandit wrote: > Hi Michael, > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 11:12 AM > > > I was attempting to have each of you see other's point of view. > > It seems clear I was right,

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Thu, Sep 21, 2023 at 03:43:12AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, September 21, 2023 1:34 AM > > > > On Wed, Sep 20, 2023 at 05:21:52PM +, Parav Pandit wrote: > > > > OK so with this summa

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Wed, Sep 20, 2023 at 07:27:05PM +0800, Zhu, Lingshan wrote: > What if a malicious SW dump guest memory through admin vq LM facility? What if malicious SW misconfigures vq through the SUSPEND bit facility? -- MST - To unsubs

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Wed, Sep 20, 2023 at 05:21:52PM +, Parav Pandit wrote: > > OK so with this summary in mind, can you find any advantages to > > inband+mediation that are real or do you just see disadvantages? And > > it's a tricky question because I can see some advantages ;) > > inband + mediation may be u

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Wed, Sep 20, 2023 at 01:41:00PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, September 20, 2023 6:12 PM > > > And Parav same goes for you - can you summarize Zhu Lingshan's position? > > Below is my summary about Zhu

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Wed, Sep 20, 2023 at 01:41:00PM +, Parav Pandit wrote: > 12. Some how register access on single physical card for the PFs and VFs > gives better QoS guarantee than virtqueue as registers can scale infinitely > no matter how many VFs or for multiple VQs because it is per VF. > This makes s

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Wed, Sep 20, 2023 at 08:05:49AM -0400, Michael S. Tsirkin wrote: > On Wed, Sep 20, 2023 at 07:22:32PM +0800, Zhu, Lingshan wrote: > > > > > > On 9/20/2023 6:36 PM, Michael S. Tsirkin wrote: > > > On Wed, Sep 20, 2023 at 02:06:13PM +0800, Zhu, Lingshan wrote: >

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Wed, Sep 20, 2023 at 08:16:13PM +0800, Zhu, Lingshan wrote: > > > On 9/20/2023 8:05 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 20, 2023 at 07:22:32PM +0800, Zhu, Lingshan wrote: > > > > > > On 9/20/2023 6:36 PM, Michael S. Tsirkin wrote: > > >

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Wed, Sep 20, 2023 at 08:05:24PM +0800, Zhu, Lingshan wrote: > > > On 9/20/2023 7:52 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 20, 2023 at 07:28:39PM +0800, Zhu, Lingshan wrote: > > > > > > On 9/20/2023 6:55 PM, Parav Pandit wrote: > > > &g

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Wed, Sep 20, 2023 at 07:22:32PM +0800, Zhu, Lingshan wrote: > > > On 9/20/2023 6:36 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 20, 2023 at 02:06:13PM +0800, Zhu, Lingshan wrote: > > > > > > On 9/19/2023 2:49 AM, Michael S. Tsirkin wrote: > > >

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Wed, Sep 20, 2023 at 07:28:39PM +0800, Zhu, Lingshan wrote: > > > On 9/20/2023 6:55 PM, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > > Sent: Wednesday, September 20, 2023 4:06 PM > > > I freely admit the finer points of this extended flamewar ha

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-20 Thread Michael S. Tsirkin
On Wed, Sep 20, 2023 at 02:06:13PM +0800, Zhu, Lingshan wrote: > > > On 9/19/2023 2:49 AM, Michael S. Tsirkin wrote: > > On Mon, Sep 18, 2023 at 06:41:55PM +, Parav Pandit wrote: > > > > Please refer to the code for setting FEATURES_OK. > > > It wont work

[virtio-dev] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-19 Thread Michael S. Tsirkin
On Tue, Sep 19, 2023 at 12:10:29PM +, Parav Pandit wrote: > Hi Jiqian, > > > From: Jiqian Chen > > Sent: Tuesday, September 19, 2023 5:13 PM > > > > When guest vm does S3, Qemu will reset and clear some things of virtio > > devices, but guest can't aware that, so that may cause some problems

[virtio-dev] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg

2023-09-19 Thread Michael S. Tsirkin
On Tue, Sep 19, 2023 at 07:42:42PM +0800, Jiqian Chen wrote: > When guest vm does S3, Qemu will reset and clear some things of virtio > devices, but guest can't aware that, so that may cause some problems. > For excample, Qemu calls virtio_reset->virtio_gpu_gl_reset when guest > resume, that functi

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-09-19 Thread Michael S. Tsirkin
On Tue, Sep 19, 2023 at 09:32:08AM +0200, Babis Chalios wrote: > Resending to fix e-mail formatting issues (sorry for the spam) > > On 18/9/23 18:30, Babis Chalios wrote: > > > > > > Yes, that's what the driver does now in the RFC patch. > > > > > > However, this just > > > > > > decreases > > > >

Re: [virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-18 Thread Michael S. Tsirkin
On Mon, Sep 18, 2023 at 06:41:55PM +, Parav Pandit wrote: > > Please refer to the code for setting FEATURES_OK. > It wont work when one needs to suspend the device. > There is no point of doing such work over registers as fundamental framework > is over the AQ. Well not really. It's over admi

[virtio-dev] Re: [virtio-comment] Re: [PATCH 3/5] virtqueue: constraints for virtqueue state

2023-09-18 Thread Michael S. Tsirkin
On Mon, Sep 18, 2023 at 11:02:18AM +0800, Zhu, Lingshan wrote: > > > On 9/15/2023 7:16 PM, Michael S. Tsirkin wrote: > > On Fri, Sep 15, 2023 at 10:59:29AM +0800, Zhu, Lingshan wrote: > > > > > > On 9/14/2023 7:30 PM, Michael S. Tsirkin wrote: > > >

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-09-18 Thread Michael S. Tsirkin
On Mon, Sep 18, 2023 at 04:02:54PM +0200, Babis Chalios wrote: > On 18/9/23 15:58, Michael S. Tsirkin wrote: > > On Mon, Sep 18, 2023 at 03:00:43PM +0200, Babis Chalios wrote: > > > > > Right, so I think that there is a race condition between the time the > > > &

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-09-18 Thread Michael S. Tsirkin
On Mon, Sep 18, 2023 at 03:00:43PM +0200, Babis Chalios wrote: > > > > Right, so I think that there is a race condition between the time the > > > driver > > > sees the used buffers of the first > > > batch and until it adds the second batch on the next leak queue. > > > > > > 1. driver adds bat

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-09-18 Thread Michael S. Tsirkin
On Wed, Sep 13, 2023 at 01:19:49PM +0200, Babis Chalios wrote: > > > On 13/9/23 11:37, Michael S. Tsirkin wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know &g

[virtio-dev] Re: [PATCH 3/5] virtqueue: constraints for virtqueue state

2023-09-15 Thread Michael S. Tsirkin
On Fri, Sep 15, 2023 at 10:59:29AM +0800, Zhu, Lingshan wrote: > > > On 9/14/2023 7:30 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 06, 2023 at 04:16:35PM +0800, Zhu Lingshan wrote: > > > This commit specifies the constraints of the virtqueue state, > > > and t

[virtio-dev] Re: [PATCH 2/5] virtio: introduce SUSPEND bit in device status

2023-09-15 Thread Michael S. Tsirkin
On Fri, Sep 15, 2023 at 10:57:33AM +0800, Zhu, Lingshan wrote: > > > On 9/14/2023 7:34 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 06, 2023 at 04:16:34PM +0800, Zhu Lingshan wrote: > > > This patch introduces a new status bit in the device status: SUSPEND. > > &g

[virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-14 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:16:32PM +0800, Zhu Lingshan wrote: > This series introduces > 1)a new SUSPEND bit in the device status > Which is used to suspend the device, so that the device states > and virtqueue states are stabilized. > > 2)virtqueue state and its accessor, to get and set last_avai

[virtio-dev] Re: [PATCH 2/5] virtio: introduce SUSPEND bit in device status

2023-09-14 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:16:34PM +0800, Zhu Lingshan wrote: > This patch introduces a new status bit in the device status: SUSPEND. > > This SUSPEND bit can be used by the driver to suspend a device, > in order to stabilize the device states and virtqueue states. > > Its main use case is live m

[virtio-dev] Re: [PATCH 3/5] virtqueue: constraints for virtqueue state

2023-09-14 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:16:35PM +0800, Zhu Lingshan wrote: > This commit specifies the constraints of the virtqueue state, > and the actions should be taken by the device when SUSPEND > and DRIVER_OK is set > > Signed-off-by: Zhu Lingshan > Signed-off-by: Jason Wang > Signed-off-by: Eugenio P

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-14 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:16:37PM +0800, Zhu Lingshan wrote: > This patch adds two new le16 fields to common configuration structure > to support VIRTIO_F_QUEUE_STATE in PCI transport layer. > > Signed-off-by: Zhu Lingshan > --- > transport-pci.tex | 18 ++ > 1 file changed, 18

[virtio-dev] Re: [virtio-comment] [PATCH 1/5] virtio: introduce vq state as basic facility

2023-09-14 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:16:33PM +0800, Zhu Lingshan wrote: > This patch adds new device facility to save and restore virtqueue > state. The virtqueue state is split into two parts: > > - The available state: The state that is used for read the next > available buffer. > - The used state: The

[virtio-dev] Re: [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-14 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:16:32PM +0800, Zhu Lingshan wrote: > This series introduces > 1)a new SUSPEND bit in the device status > Which is used to suspend the device, so that the device states > and virtqueue states are stabilized. > > 2)virtqueue state and its accessor, to get and set last_avai

[virtio-dev] Re: [PATCH 4/5] virtqueue: ignore resetting vqs when SUSPEND

2023-09-14 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:16:36PM +0800, Zhu Lingshan wrote: > When SUSPEND is set, the device should stabilize the device > states and virtqueue states, therefore the device should > ignore resetting vqs when SUSPEND is set in device status. > > Signed-off-by: Zhu Lingshan And do what? If you

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-09-13 Thread Michael S. Tsirkin
On Wed, Sep 13, 2023 at 11:32:57AM +0200, Babis Chalios wrote: > > I do not understand why this matters though. we know there was a leak, > > why does it matter whether there was one or two leaks? > > > > > In the last RFC implementing this in Linux we sent to LKML [1] we avoid > the > > > issue by

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-13 Thread Michael S. Tsirkin
On Wed, Sep 13, 2023 at 12:45:21PM +0800, Jason Wang wrote: > For example, KVM doesn't use > hardware to log dirty pages. It uses a mix of PML, PTE bit and EPT write protection. -- MST - To unsubscribe, e-mail: virtio-dev-unsu

Re: [virtio-dev] [PATCH RFC 3/3] rng: leak detection support

2023-09-12 Thread Michael S. Tsirkin
On Thu, Aug 31, 2023 at 12:16:22PM +0200, Babis Chalios wrote: > Hi Michael, > > On 21/11/22 17:30, Michael S. Tsirkin wrote: > > Add virtqueues to support reporting entropy leaks (similar to virtio based > > vmgenid). > > > > Signed-off-by: Michael S. Tsirkin

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-11 Thread Michael S. Tsirkin
On Mon, Sep 11, 2023 at 02:30:31PM +0800, Jason Wang wrote: > Customers don't want to have admin stuff, SR-IOV or PASID in the guest > in order to migrate a single virtio device in the nest. Built an alternative facility to implement admin commands then. The advantage of admin commands is they are

[virtio-dev] Re: [virtio-comment] [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-07 Thread Michael S. Tsirkin
On Thu, Sep 07, 2023 at 12:57:58PM +0200, Eugenio Perez Martin wrote: > On Wed, Sep 6, 2023 at 3:49 PM Michael S. Tsirkin wrote: > > > > On Wed, Sep 06, 2023 at 04:38:44PM +0800, Zhu, Lingshan wrote: > > > > > > > > > On 9/6/2023 4:29 PM, Michael S. Tsir

[virtio-dev] Re: [virtio-comment] [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-06 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:38:44PM +0800, Zhu, Lingshan wrote: > > > On 9/6/2023 4:29 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 06, 2023 at 04:16:32PM +0800, Zhu Lingshan wrote: > > > This series introduces > > > 1)a new SUSPEND bit in the device status &

[virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE

2023-09-06 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:16:37PM +0800, Zhu Lingshan wrote: > This patch adds two new le16 fields to common configuration structure > to support VIRTIO_F_QUEUE_STATE in PCI transport layer. > > Signed-off-by: Zhu Lingshan I do not see why this would be pci specific at all. But besides I thou

[virtio-dev] Re: [virtio-comment] [PATCH 0/5] virtio: introduce SUSPEND bit and vq state

2023-09-06 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:16:32PM +0800, Zhu Lingshan wrote: > This series introduces > 1)a new SUSPEND bit in the device status > Which is used to suspend the device, so that the device states > and virtqueue states are stabilized. > > 2)virtqueue state and its accessor, to get and set last_avai

[virtio-dev] Re: [virtio-comment] [PATCH 1/5] virtio: introduce vq state as basic facility

2023-09-06 Thread Michael S. Tsirkin
On Wed, Sep 06, 2023 at 04:16:33PM +0800, Zhu Lingshan wrote: > This patch adds new device facility to save and restore virtqueue > state. The virtqueue state is split into two parts: > > - The available state: The state that is used for read the next > available buffer. > - The used state: The

[virtio-dev] Re: [PATCH] virtio-vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

2023-09-06 Thread Michael S. Tsirkin
On Sat, Sep 02, 2023 at 09:24:26AM +, Bobby Eshleman wrote: > On Sat, Sep 02, 2023 at 04:41:28AM -0400, Michael S. Tsirkin wrote: > > On Sat, Sep 02, 2023 at 04:37:19AM +, Bobby Eshleman wrote: > > > On Fri, Sep 01, 2023 at 09:31:03AM -0400, Michael S. Tsirkin wrote: >

Re: [virtio-dev] RE: RE: RE: RE: [PATCH v16] virtio-net: support device stats

2023-09-04 Thread Michael S. Tsirkin
On Mon, Sep 04, 2023 at 12:21:48PM +, Parav Pandit wrote: > > From: Heng Qi > > Sent: Monday, September 4, 2023 4:41 PM > > > > 在 2023/9/4 下午6:26, Parav Pandit 写道: > > >> From: Xuan Zhuo > > >> Sent: Monday, September 4, 2023 2:23 PM > > > > > >>> "The device MUST NOT pass received packets t

[virtio-dev] Re: [PATCH] virtio-vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

2023-09-02 Thread Michael S. Tsirkin
On Sat, Sep 02, 2023 at 04:37:19AM +, Bobby Eshleman wrote: > On Fri, Sep 01, 2023 at 09:31:03AM -0400, Michael S. Tsirkin wrote: > > On Wed, Aug 30, 2023 at 12:43:03AM +, Bobby Eshleman wrote: > > > On Tue, Aug 29, 2023 at 06:21:35PM -0400, Michael S. Tsirkin wrote: >

[virtio-dev] Re: [PATCH] virtio-vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

2023-09-02 Thread Michael S. Tsirkin
On Sat, Sep 02, 2023 at 04:56:42AM +, Bobby Eshleman wrote: > On Fri, Sep 01, 2023 at 02:45:14PM +0200, Stefano Garzarella wrote: > > On Tue, Aug 29, 2023 at 09:29:45PM +, Bobby Eshleman wrote: > > > This adds support for datagrams to the virtio-vsock device. > > > > > > virtio-vsock alrea

[virtio-dev] Re: [PATCH v16] virtio-net: support device stats

2023-09-01 Thread Michael S. Tsirkin
On Fri, Sep 01, 2023 at 01:58:32PM +, Parav Pandit wrote: > > > > From: Xuan Zhuo > > Sent: Wednesday, August 30, 2023 11:23 AM > > To: virtio-dev@lists.oasis-open.org > > Cc: jasow...@redhat.com; Michael S. Tsirkin ; Parav Pandit > > ; David Edmond

[virtio-dev] Re: [PATCH] virtio-vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

2023-09-01 Thread Michael S. Tsirkin
On Wed, Aug 30, 2023 at 12:43:03AM +, Bobby Eshleman wrote: > On Tue, Aug 29, 2023 at 06:21:35PM -0400, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2023 at 09:29:45PM +, Bobby Eshleman wrote: > > > This adds support for datagrams to the virtio-vsock device. > &g

[virtio-dev] Re: [PATCH] virtio-vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

2023-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2023 at 09:29:45PM +, Bobby Eshleman wrote: > This adds support for datagrams to the virtio-vsock device. > > virtio-vsock already supports stream and seqpacket types. The existing > message types and header fields are extended to support datagrams. > Semantic differences betwe

[virtio-dev] Re: [PATCH] virtio-net: support the outer source port hash for UDP-encapsulated packets

2023-08-07 Thread Michael S. Tsirkin
On Fri, Jul 28, 2023 at 04:46:35PM +0800, Heng Qi wrote: > UDP tunneling protocols usually identify a flow using the outer source UDP > port, which is useful for processing UDP-encapsulated packets, such as > increasing entropy for RSS queue selection or hashing the same flow to the > same receive

  1   2   3   4   5   6   7   8   9   10   >