> > @Taylor Stark Since now have virtio pmem spec merged, we can propose
> > spec changes for "virtio-pmem: Support PCI BAR-relative addresses"
> > support.
> >
> > Best regards,
> > Pankaj
>
> Thanks Pankaj, will do! I'll post the change late next week (I'm
> currently on vacation but being bad a
Thank you!
@Taylor Stark Since now have virtio pmem spec merged, we can propose
spec changes for "virtio-pmem: Support PCI BAR-relative addresses"
support.
Best regards,
Pankaj
On Fri, 15 Oct 2021 at 13:13, Cornelia Huck wrote:
>
> On Fri, Oct 15 2021, Pankaj Gupta wrote:
4.1.
> >
> > Reviewed-by: Stefan Hajnoczi
> > Signed-off-by: Pankaj Gupta
> > ---
> > v5 -> v6
> > Text change in security implication section - Cornelia
> > Added r-o-b from Stefan
> >
> > con
lso, Qemu
> device is merged in Qemu 4.1.
>
> Reviewed-by: Stefan Hajnoczi
> Signed-off-by: Pankaj Gupta
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/78
Thanks,
Pankaj
> ---
> v5 -> v6
> Text change in security implication section - Cornelia
> Added r-o-b fr
Posting virtio specification for virtio pmem device. Virtio pmem is a
paravirtualized device which allows the guest to bypass page cache.
Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu
device is merged in Qemu 4.1.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Pankaj Gupta
> >> >> > +\subsubsection{ Workload specific mapping}\label{sec:Device Types /
> >> >> > PMEM Device / Possible Security Implications / Countermeasures /
> >> >> > Workload}
> >> >> > +For SHARED mappings, for the workload is a single application inside
> >> >> > +the driver and there is no risk
> >> > +\subsubsection{ Workload specific mapping}\label{sec:Device Types /
> >> > PMEM Device / Possible Security Implications / Countermeasures /
> >> > Workload}
> >> > +For SHARED mappings, for the workload is a single application inside
> >> > +the driver and there is no risk in sharing data
> > Posting virtio specification for virtio pmem device. Virtio pmem is a
> > paravirtualized device which allows the guest to bypass page cache.
> > Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu
> > device is merged in Qemu 4.1.
> >
&
Posting virtio specification for virtio pmem device. Virtio pmem is a
paravirtualized device which allows the guest to bypass page cache.
Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu
device is merged in Qemu 4.1.
Signed-off-by: Pankaj Gupta
---
Incorporated all the
> On Tue, Sep 21, 2021 at 12:27:02PM +0200, Pankaj Gupta wrote:
> > Posting virtio specification for virtio pmem device. Virtio pmem is a
> > paravirtualized device which allows the guest to bypass page cache.
> > Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Als
> > Posting virtio specification for virtio pmem device. Virtio pmem is a
> > paravirtualized device which allows the guest to bypass page cache.
> > Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu
> > device is merged in Qemu 4.1.
> >
&
Posting virtio specification for virtio pmem device. Virtio pmem is a
paravirtualized device which allows the guest to bypass page cache.
Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu
device is merged in Qemu 4.1.
Signed-off-by: Pankaj Gupta
---
v3 -> v4
Def
> > > > +Requests have the following format:
> > > > +
> > > > +\begin{lstlisting}
> > > > +struct virtio_pmem_req {
> > > > +le32 type;
> > > > +};
> > > > +\end{lstlisting}
> > > > +
> > > > +\field{type} is the request command type.
> > >
> > > Where are the type constants defined? I was
> > diff --git a/virtio-pmem.tex b/virtio-pmem.tex
> > new file mode 100644
> > index 000..6f1b504
> > --- /dev/null
> > +++ b/virtio-pmem.tex
> > @@ -0,0 +1,122 @@
> > +\section{PMEM Device}\label{sec:Device Types / PMEM Device}
> > +
> > +The virtio pmem device is a persistent memory (NVDIMM)
Posting virtio specification for virtio pmem device. Virtio pmem is a
paravirtualized device which allows the guest to bypass page cache.
Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu
device is merged in Qemu 4.1.
Signed-off-by: Pankaj Gupta
---
v2->v3:
- Suggested t
On Thu, 19 Aug 2021 at 11:39, Stefan Hajnoczi wrote:
>
> On Thu, Aug 19, 2021 at 07:53:48AM +0200, Pankaj Gupta wrote:
> > > >> > +\drivernormative{\subsubsection}{Driver Initialization: Virtio
> > > >> > flush}{Device Types / PMEM Driver / Driver
> > Posting virtio specification for virtio pmem device. Virtio pmem is a
> > paravirtualized device which allows the guest to bypass page cache.
> > Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu
> > device is merged in Qemu 4.1.
> >
&
> >> > +\drivernormative{\subsubsection}{Driver Initialization: Virtio
> >> > flush}{Device Types / PMEM Driver / Driver Initialization / Virtio flush}
> >> > +
> >> > +The driver MUST implement a virtio based flushing interface.
> >>
> >> I think this can be dropped. The only way to make writes p
> > +\section{PMEM Device}\label{sec:Device Types / PMEM Device}
> > +
> > +The virtio pmem device is a persistent memory (NVDIMM) device
> > +provide a virtio based asynchronous flush mechanism. This avoids the
>
> s/provide/that provides/
o.k
>
> > +need of a separate page cache in the guest an
Posting virtio specification for virtio pmem device. Virtio pmem is a
paravirtualized device which allows the guest to bypass page cache.
Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu
device is merged in Qemu 4.1.
Signed-off-by: Pankaj Gupta
---
changes from v1 ->
> > On 04.08.21 13:07, Stefan Hajnoczi wrote:
> > > On Wed, Jul 28, 2021 at 05:04:35PM +0200, Pankaj Gupta wrote:
> > > > +\subsection{Device configuration layout}\label{sec:Device Types / PMEM
> > > > Device / Device configuration layout}
> > >
> > > > +\subsection{Device Initialization}\label{sec:Device Types / PMEM
> > > > Device / Device Initialization}
> > > > +
> > > > +Device hotplugs physical memory to guest address space. Persistent
> > > > memory device
> > > > +is emulated with file backed memory at host side.
> > >
> > > This
ce is merged in Qemu 4.1.
> >
> > Signed-off-by: Pankaj Gupta
> > ---
> > Sorry, It took me long time to get back on this. There is
> > an enhancement to this spec by "Taylor Stark" CCed in the list.
> > Request for feedback and merging.
> >
> &g
> >> > +Also, configures a flush callback function with the corresponding
> >> > region.
> >>
> >> Not sure if that is too specific already... maybe something like "Also,
> >> it configures a notification for when the corresponding region is
> >> flushed."?
> >
> > Maybe will remove this line alt
> +Also, configures a flush callback function with the corresponding
> region.
> >>>
> >>> Not sure if that is too specific already... maybe something like "Also,
> >>> it configures a notification for when the corresponding region is
> >>> flushed."?
> >>
> >> Maybe will remove this li
Hi Cornelia,
> > Posting virtio specification for virtio pmem device. Virtio pmem is a
> > paravirtualized device which allows the guest to bypass page cache.
> > Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu
> > device is merged in Qemu 4.1.
>
Posting virtio specification for virtio pmem device. Virtio pmem is a
paravirtualized device which allows the guest to bypass page cache.
Virtio pmem kernel driver is merged in Upstream Kernel 5.3. Also, Qemu
device is merged in Qemu 4.1.
Signed-off-by: Pankaj Gupta
---
Sorry, It took me long
.com/oasis-tcs/virtio-spec/issues/55
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Pankaj Gupta
> ---
> content.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/content.tex b/content.tex
> index 678afbe..72e832e 100644
> --- a/co
+3106,6 @@ void split_page(struct page *page, unsigned int order)
>
> int __isolate_free_page(struct page *page, unsigned int order)
> {
> - struct free_area *area = &page_zone(page)->free_area[order];
> unsigned long watermark;
> struct zone *zon
> On Thu, 2019-08-22 at 06:43 -0400, Pankaj Gupta wrote:
> > > This series provides an asynchronous means of reporting to a hypervisor
> > > that a guest page is no longer in use and can have the data associated
> > > with it dropped. To do this I have impleme
>
> This series provides an asynchronous means of reporting to a hypervisor
> that a guest page is no longer in use and can have the data associated
> with it dropped. To do this I have implemented functionality that allows
> for what I am referring to as unused page reporting
>
> The functiona
;
> - Provides emulation of persistent memory on host regular
> (non NVDIMM) storage.
> - Allows the guest to bypass the page cache.
>
> Signed-off-by: Pankaj Gupta
> ---
> This is changed version from previous v2 [1], as per suggestions by
> cornelia. Incorporated
>
> On Tue, Aug 13, 2019 at 06:21:33PM +0530, Pankaj Gupta wrote:
> > This patch documents console special case where vq buffers
> > are deleted at port hotunplug time. This behavior is different in
> > other devices where vq buffers are deleted at device unplug time
>
> On Tue, Aug 13, 2019 at 06:21:33PM +0530, Pankaj Gupta wrote:
> > This patch documents console special case where vq buffers
> > are deleted at port hotunplug time. This behavior is different in
> > other devices where vq buffers are deleted at device unplug time
This patch documents console special case where vq buffers
are deleted at port hotunplug time. This behavior is different in
other devices where vq buffers are deleted at device unplug time.
Signed-off-by: Pankaj Gupta
---
content.tex | 2 ++
1 file changed, 2 insertions(+)
diff --git a
; - Allows the guest to bypass the page cache.
> >
> > Signed-off-by: Pankaj Gupta
> > ---
> > This is changed version from previous v2 [1], as per suggestions by
> > cornelia. Incorporated v2 changes suggested by Stefan, Michael &
> > Cornerlia in RFC[2
This patch proposes a virtio specification for new
virtio pmem device. Virtio pmem is a paravirtualized
device which solves two problems:
- Provides emulation of persistent memory on host regular
(non NVDIMM) storage.
- Allows the guest to bypass the page cache.
Signed-off-by: Pankaj Gupta
>
> On Wed, 10 Jul 2019 13:35:12 +0530
> Pankaj Gupta wrote:
>
> > This patch proposes a virtio specification for new
> > virtio pmem device. Virtio pmem is a paravirtualized
> > device which solves two problems:
> >
> > - Provides emulation of pe
previous v1 [1], as per suggestions by
cornelia on RFC[2] with incorporated changes suggested by Stefan, Michael
& Cornerlia.
[1] https://lists.oasis-open.org/archives/virtio-dev/201907/msg4.html
[2] https://lists.oasis-open.org/archives/virtio-dev/201903/msg00083.html
Signed-off-by: Pa
; - Allows the guest to bypass the page cache.
> >
> > This is changed version from previous RFC [1], incorporated
> > changes suggested by Stefan, Michael & Cornerlia.
> >
> > [1] https://lists.oasis-open.org/archives/virtio-dev/201903/msg0008
previous RFC [1], incorporated
changes suggested by Stefan, Michael & Cornerlia.
[1] https://lists.oasis-open.org/archives/virtio-dev/201903/msg00083.html
Signed-off-by: Pankaj Gupta
---
conformance.tex | 23 ++-
content.tex | 1 +
virtio-pmem.tex |
Hi Michael,
Thank you Michael for the review.
>
> On Tue, Mar 26, 2019 at 08:05:07PM +0530, Pankaj Gupta wrote:
> > This patch proposes a virtio specification for new
> > virtio pmem device. Virtio pmem is a paravirtualized
> > device which allows the guest to bypass
> On Mon, Apr 15, 2019 at 11:52:39AM +0530, Pankaj Gupta wrote:
> > We need a device ID for virtio-pmem devices. As 25 is requested by
> > audio device and 26 is requested by virtio-fs, so requesting
> > next available(27). Also, updated the previously requested github
&g
Huck
Signed-off-by: Pankaj Gupta
---
v3:
Added fixes tag and reviewed by.
v2:
Use device ID 27
content.tex | 2 ++
1 file changed, 2 insertions(+)
diff --git a/content.tex b/content.tex
index 193b6e1..aef7476 100644
--- a/content.tex
+++ b/content.tex
@@ -2634,6 +2634,8 @@ \chapter{Device Types
>
> On Fri, Apr 12, 2019 at 10:33:06AM +0530, Pankaj Gupta wrote:
> > We need a device ID for virtio-pmem devices. As 25 is
> > requested by audio device, so requesting next available(26).
> > Also, updated the previously requested github issue[1] for
> > voting.
> &g
.com/oasis-tcs/virtio-spec/issues/38
> >
> > Signed-off-by: Pankaj Gupta
> > ---
> > v2:
> > Use device ID 27
> >
> > content.tex | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/content.tex b/content.tex
>
We need a device ID for virtio-pmem devices. As 25 is requested by
audio device and 26 is requested by virtio-fs, so requesting
next available(27). Also, updated the previously requested github
issue[1] for voting.
[1] https://github.com/oasis-tcs/virtio-spec/issues/38
Signed-off-by: Pankaj
We need a device ID for virtio-pmem devices. As 25 is
requested by audio device, so requesting next available(26).
Also, updated the previously requested github issue[1] for
voting.
[1] https://github.com/oasis-tcs/virtio-spec/issues/38
Signed-off-by: Pankaj Gupta
---
content.tex | 2 ++
1
> --- /dev/null
> +++ b/virtio-pmem.tex
> @@ -0,0 +1,134 @@
> +\section{PMEM Device}\label{sec:Device Types / PMEM Device}
> +
> +The virtio pmem is a fake persistent memory (NVDIMM) device
> +used to bypass the guest page cache and provide a virtio
> +base
> >> new file mode 100644
> >> index 000..04e07bb
> >> --- /dev/null
> >> +++ b/virtio-pmem.tex
> >> @@ -0,0 +1,134 @@
> >> +\section{PMEM Device}\label{sec:Device Types / PMEM Device}
> >> +
> >> +The virtio pmem is a fake persistent memory (NVDIMM) device
> >> +used to bypass the guest page
Hi Stefan,
Thank you for the review. Please find my reply inline.
> > diff --git a/virtio-pmem.tex b/virtio-pmem.tex
> > new file mode 100644
> > index 000..04e07bb
> > --- /dev/null
> > +++ b/virtio-pmem.tex
> > @@ -0,0 +1,134 @@
> > +\section{PMEM Device}\label{sec:Device Types / PMEM Dev
m=153555721901824&w=2
> > [3] https://lkml.org/lkml/2019/1/9/541
> > [4] https://lkml.org/lkml/2019/2/4/1151
> > [5] https://github.com/oasis-tcs/virtio-spec/issues/38
> >
> > Signed-off-by: Pankaj Gupta
> > ---
> > conformance.tex | 14 ++
> &
://lkml.org/lkml/2019/1/9/471
[2] https://marc.info/?l=qemu-devel&m=153555721901824&w=2
[3] https://lkml.org/lkml/2019/1/9/541
[4] https://lkml.org/lkml/2019/2/4/1151
[5] https://github.com/oasis-tcs/virtio-spec/issues/38
Signed-off-by: Pankaj Gupta
---
conformance.tex | 14 ++
con
ping.
I have also opened a github issue[1] for the same.
[1] https://github.com/oasis-tcs/virtio-spec/issues/38
Thanks,
Pankaj
>
> We need a device ID for virtio-pmem devices. As 24 is already
> requested by virtio-mem, so requesting next available(25)
>
> Signed-off-b
Hi Stefan,
> >> We need a device ID for virtio-pmem devices. As 24 is already
> >> requested by virtio-mem, so requesting next available(25)
> >>
> >> Signed-off-by: Pankaj Gupta
> >> ---
> >> content.tex | 2 ++
> >> 1 file chang
We need a device ID for virtio-pmem devices. As 24 is already
requested by virtio-mem, so requesting next available(25)
Signed-off-by: Pankaj Gupta
---
content.tex | 2 ++
1 file changed, 2 insertions(+)
diff --git a/content.tex b/content.tex
index 7a92cb1..ef75dc5 100644
--- a/content.tex
56 matches
Mail list logo