[virtio-dev] net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

Sorry for replying to this ancient thread. There was some remaining issue that I don't think the initial net_failover patch got addressed cleanly, see: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1815268 The renaming of 'eth0' to 'ens4' fails because the udev userspace was not

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

Windows work with that? The current MAC based scheme is very fragile when dealing with errors, and the past lesson learnt leads me to believe that those drivers errors in the hot plug path, even not common, is NOT neglectable. -Siwei On Wed, Oct 10, 2018 at 6:26 PM Siwei Liu wrote: > >

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On Fri, Oct 5, 2018 at 12:18 PM Michael S. Tsirkin wrote: > > On Thu, Oct 04, 2018 at 05:03:14PM -0700, Siwei Liu wrote: > > On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: > > &

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On Tue, Oct 2, 2018 at 5:43 AM Michael S. Tsirkin wrote: > > On Tue, Oct 02, 2018 at 01:42:09AM -0700, Siwei Liu wrote: > > The VF's MAC can be updated by PF/host on the fly at any time. One can > > start with a random MAC but use group ID to pair device instead. And > >

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On Thu, Sep 27, 2018 at 9:32 AM Michael S. Tsirkin wrote: > > On Wed, Sep 26, 2018 at 05:18:38PM -0700, Siwei Liu wrote: > > On Thu, Sep 20, 2018 at 7:23 PM, Michael S. Tsirkin wrote: > > > On Thu, Sep 20, 2018 at 04:57:56PM -0700, Siwei Liu wrote: > > >> On Wed,

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On Thu, Sep 20, 2018 at 7:23 PM, Michael S. Tsirkin wrote: > On Thu, Sep 20, 2018 at 04:57:56PM -0700, Siwei Liu wrote: >> On Wed, Sep 19, 2018 at 8:11 PM, Michael S. Tsirkin wrote: >> > On Tue, Sep 18, 2018 at 11:48:46AM -0700, Siwei Liu wrote: >> >> On Tue, Sep

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On Wed, Sep 19, 2018 at 8:11 PM, Michael S. Tsirkin wrote: > On Tue, Sep 18, 2018 at 11:48:46AM -0700, Siwei Liu wrote: >> On Tue, Sep 18, 2018 at 8:31 AM, Michael S. Tsirkin wrote: >> > On Tue, Sep 18, 2018 at 10:13:37AM -0500, Venu Busireddy wrote: >> >> On 2018-0

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On Tue, Sep 18, 2018 at 11:39 AM, Michael S. Tsirkin wrote: > On Tue, Sep 18, 2018 at 11:30:27AM -0700, Siwei Liu wrote: >> On Tue, Sep 18, 2018 at 6:25 AM, Michael S. Tsirkin wrote: >> > On Tue, Sep 18, 2018 at 01:37:35PM +0300, Sameeh Jubran wrote: >> >> O

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On Tue, Sep 18, 2018 at 8:31 AM, Michael S. Tsirkin wrote: > On Tue, Sep 18, 2018 at 10:13:37AM -0500, Venu Busireddy wrote: >> On 2018-09-18 09:35:48 -0400, Michael S. Tsirkin wrote: >> > On Tue, Sep 18, 2018 at 12:20:52PM +0200, Cornelia Huck wrote: >> > > On Wed, 12 Sep 2018 11:22:12 -0400 >>

Re: [virtio-dev] [PATCH v4] content: Introduce VIRTIO_NET_F_STANDBY feature

On Tue, Sep 18, 2018 at 6:25 AM, Michael S. Tsirkin wrote: > On Tue, Sep 18, 2018 at 01:37:35PM +0300, Sameeh Jubran wrote: >> On Tue, Sep 18, 2018 at 1:21 PM Cornelia Huck wrote: >> > >> > On Wed, 12 Sep 2018 11:22:12 -0400 >> > "Michael S. Tsirkin" wrote: >> > >> > > On Wed, Sep 12, 2018 at

Re: [virtio-dev] Re: [PATCH v2] content: Introduce VIRTIO_NET_F_STANDBY feature

On Thu, Jul 26, 2018 at 1:48 AM, Cornelia Huck wrote: > On Wed, 25 Jul 2018 16:31:05 -0700 > Siwei Liu wrote: > >> On Tue, Jul 24, 2018 at 5:43 AM, Cornelia Huck wrote: >> > On Mon, 23 Jul 2018 10:02:35 -0700 >> > Sridhar Samudrala wrote: >> >

Re: [virtio-dev] Re: [PATCH v2] content: Introduce VIRTIO_NET_F_STANDBY feature

On Tue, Jul 24, 2018 at 5:43 AM, Cornelia Huck wrote: > On Mon, 23 Jul 2018 10:02:35 -0700 > Sridhar Samudrala wrote: > >> VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net >> device to act as a standby for a primary device with the same MAC address. >> >> Signed-off-by:

Re: [virtio-dev] [PATCH] content: Introduce VIRTIO_NET_F_STANDBY feature

On Thu, Jul 19, 2018 at 2:29 PM, Sridhar Samudrala wrote: > VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net > driver to act as a standby for another device with the same MAC address. You should use another feature bit to represent the match-by-MAC grouping. I think

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

On Thu, Jul 12, 2018 at 2:00 PM, Michael S. Tsirkin wrote: > On Thu, Jul 12, 2018 at 01:52:53PM -0700, Siwei Liu wrote: >> The definition is incomplete due to lack of spec. There's no "host" >> part defined yet in the host-guest interface. If match by MAC is an >> i

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

_ On Thu, Jul 12, 2018 at 4:31 AM, Cornelia Huck wrote: > On Thu, 12 Jul 2018 02:37:03 -0700 > Siwei Liu wrote: > >> On Wed, Jul 11, 2018 at 2:53 AM, Cornelia Huck wrote: >> > On Tue, 10 Jul 2018 17:07:37 -0700 >> > Siwei Liu wrote: >> > >&

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

On Wed, Jul 11, 2018 at 2:53 AM, Cornelia Huck wrote: > On Tue, 10 Jul 2018 17:07:37 -0700 > Siwei Liu wrote: > >> On Mon, Jul 9, 2018 at 6:54 PM, Michael S. Tsirkin wrote: >> > On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: >> >> The plan

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

On Mon, Jul 9, 2018 at 6:58 PM, Michael S. Tsirkin wrote: > On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: >> What do we buy >> for using a random address during initial discovery and requiring VF to >> complete the handshake? > > I don't see advantages to using a random address that

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

On Fri, Jul 6, 2018 at 6:54 AM, Cornelia Huck wrote: > On Thu, 5 Jul 2018 17:49:10 -0700 > Siwei Liu wrote: > >> On Wed, Jul 4, 2018 at 5:15 AM, Cornelia Huck wrote: >> > On Tue, 3 Jul 2018 16:31:03 -0700 >> > Siwei Liu wrote: >> > >> >>

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

On Wed, Jul 4, 2018 at 5:15 AM, Cornelia Huck wrote: > On Tue, 3 Jul 2018 16:31:03 -0700 > Siwei Liu wrote: > >> On Tue, Jul 3, 2018 at 7:52 AM, Cornelia Huck wrote: >> > From my point of view, there are several concerns: >> > - This approach assumes a ho

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

On Tue, Jul 3, 2018 at 7:52 AM, Cornelia Huck wrote: > On Tue, 3 Jul 2018 09:28:17 -0500 > Venu Busireddy wrote: > >> On 2018-07-03 12:58:25 +0300, Roman Kagan wrote: >> > On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote: >> > > On 7/2/2018 9:14 AM, Roman Kagan wrote: >> > > > Is the

Re: [virtio-dev] Re: [PATCH v2 3/4] Add "Group Identifier" support to Red Hat PCI bridge.

On Wed, Jun 27, 2018 at 7:14 PM, Michael S. Tsirkin wrote: > On Wed, Jun 27, 2018 at 06:07:59PM -0500, Venu Busireddy wrote: >> On 2018-06-26 23:08:12 -0500, Venu Busireddy wrote: >> > On 2018-06-27 07:02:36 +0300, Michael S. Tsirkin wrote: >> > > On Tue, Jun 26, 2018 at 10:49:33PM -0500, Venu

Re: [virtio-dev] Re: [PATCH v2 0/4] Use of unique identifier for pairing virtio and passthrough devices...

On Tue, Jun 26, 2018 at 9:06 PM, Michael S. Tsirkin wrote: > On Tue, Jun 26, 2018 at 10:49:30PM -0500, Venu Busireddy wrote: >> The patch set "Enable virtio_net to act as a standby for a passthru >> device" [1] deals with live migration of guests that use passthrough >> devices. However, that

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Tue, Jun 26, 2018 at 11:49 PM, Samudrala, Sridhar wrote: > On 6/26/2018 11:21 PM, Siwei Liu wrote: >> >> On Tue, Jun 26, 2018 at 5:29 PM, Michael S. Tsirkin >> wrote: >>> >>> On Tue, Jun 26, 2018 at 04:38:26PM -0700, Siwei Liu wrote: >>>&

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Tue, Jun 26, 2018 at 5:29 PM, Michael S. Tsirkin wrote: > On Tue, Jun 26, 2018 at 04:38:26PM -0700, Siwei Liu wrote: >> On Mon, Jun 25, 2018 at 6:50 PM, Michael S. Tsirkin wrote: >> > On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: >> >>

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Mon, Jun 25, 2018 at 6:50 PM, Michael S. Tsirkin wrote: > On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: >> > > > > Might not neccessarily be something wrong, but it's very limited to >> > > > > prohibit the MAC of VF from changing when enslaved by failover. >> > > > You

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Fri, Jun 22, 2018 at 4:40 PM, Siwei Liu wrote: > On Fri, Jun 22, 2018 at 3:25 PM, Michael S. Tsirkin wrote: >> On Fri, Jun 22, 2018 at 02:51:11PM -0700, Siwei Liu wrote: >>> On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: >>> > On Fri, Jun 22, 2018

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Fri, Jun 22, 2018 at 3:33 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 02:57:39PM -0700, Siwei Liu wrote: >> On Fri, Jun 22, 2018 at 2:32 PM, Michael S. Tsirkin wrote: >> > On Fri, Jun 22, 2018 at 01:21:45PM -0700, Siwei Liu wrote: >> >> On Fri, Jun 2

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Fri, Jun 22, 2018 at 3:25 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 02:51:11PM -0700, Siwei Liu wrote: >> On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: >> > On Fri, Jun 22, 2018 at 01:03:04PM -0700, Siwei Liu wrote: >> >> On Fri, Jun

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Fri, Jun 22, 2018 at 2:47 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 12:43:26PM -0700, Siwei Liu wrote: >> > The semantics are that the primary is always used if present in >> > preference to standby. >> OK. If this is the only semantics of what "

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Fri, Jun 22, 2018 at 2:32 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 01:21:45PM -0700, Siwei Liu wrote: >> On Fri, Jun 22, 2018 at 12:05 PM, Michael S. Tsirkin wrote: >> > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: >> >> On T

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 01:03:04PM -0700, Siwei Liu wrote: >> On Fri, Jun 22, 2018 at 1:00 PM, Siwei Liu wrote: >> > On Thu, Jun 21, 2018 at 7:32 PM, Michael S. Tsirkin >> > wrote: >> >> O

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Fri, Jun 22, 2018 at 12:05 PM, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: >> On Thu, 21 Jun 2018 21:20:13 +0300 >> "Michael S. Tsirkin" wrote: >> >> > On Thu, Jun 21, 2018 at 04:59:13PM +0200, Cornelia Huck wrote: >> > > OK, so what about the

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Fri, Jun 22, 2018 at 1:00 PM, Siwei Liu wrote: > On Thu, Jun 21, 2018 at 7:32 PM, Michael S. Tsirkin wrote: >> On Thu, Jun 21, 2018 at 06:21:55PM -0700, Siwei Liu wrote: >>> On Thu, Jun 21, 2018 at 7:59 AM, Cornelia Huck wrote: >>> > On Wed, 20 Jun 2018 2

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Thu, Jun 21, 2018 at 7:32 PM, Michael S. Tsirkin wrote: > On Thu, Jun 21, 2018 at 06:21:55PM -0700, Siwei Liu wrote: >> On Thu, Jun 21, 2018 at 7:59 AM, Cornelia Huck wrote: >> > On Wed, 20 Jun 2018 22:48:58 +0300 >> > "Michael S. Tsirkin" wrote: >>

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Thu, Jun 21, 2018 at 7:30 PM, Michael S. Tsirkin wrote: > On Thu, Jun 21, 2018 at 06:07:18PM -0700, Siwei Liu wrote: >> On Thu, Jun 21, 2018 at 11:14 AM, Michael S. Tsirkin wrote: >> > On Wed, Jun 13, 2018 at 01:40:59PM +0800, Jason Wang wrote: >> >> &g

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Thu, Jun 21, 2018 at 7:59 AM, Cornelia Huck wrote: > On Wed, 20 Jun 2018 22:48:58 +0300 > "Michael S. Tsirkin" wrote: > >> On Wed, Jun 20, 2018 at 06:06:19PM +0200, Cornelia Huck wrote: >> > In any case, I'm not sure anymore why we'd want the extra uuid. >> >> It's mostly so we can have e.g.

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Thu, Jun 21, 2018 at 11:14 AM, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2018 at 01:40:59PM +0800, Jason Wang wrote: >> >> >> On 2018年06月13日 12:24, Samudrala, Sridhar wrote: >> > On 6/12/2018 7:38 PM, Jason Wang wrote: >> > > >> > > >> > > On 2018年06月12日 19:54, Michael S. Tsirkin wrote: >> >

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Wed, Jun 20, 2018 at 7:34 AM, Cornelia Huck wrote: > On Tue, 19 Jun 2018 13:09:14 -0700 > Siwei Liu wrote: > >> On Tue, Jun 19, 2018 at 3:54 AM, Cornelia Huck wrote: >> > On Fri, 15 Jun 2018 10:06:07 -0700 >> > Siwei Liu wrote: >> > >> &

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Tue, Jun 19, 2018 at 3:54 AM, Cornelia Huck wrote: > On Fri, 15 Jun 2018 10:06:07 -0700 > Siwei Liu wrote: > >> On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: >> > On Thu, 14 Jun 2018 18:57:11 -0700 >> > Siwei Liu wrote: >> > >>

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: > On Thu, 14 Jun 2018 18:57:11 -0700 > Siwei Liu wrote: > >> Thank you for sharing your thoughts, Cornelia. With questions below, I >> think you raised really good points, some of which I don't have answer >&

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

set the FEATURES_OK bit. > This is therefore the earliest point in time that the vfio-handled > device should be visible or usable for the guest. > > On Wed, 13 Jun 2018 18:02:01 -0700 > Siwei Liu wrote: > >> On Tue, Jun 12, 2018 at 5:08 PM, Samudrala, Sridhar >> wro

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Tue, Jun 12, 2018 at 5:08 PM, Samudrala, Sridhar wrote: > On 6/12/2018 4:34 AM, Michael S. Tsirkin wrote: >> >> On Mon, Jun 11, 2018 at 10:02:45PM -0700, Samudrala, Sridhar wrote: >>> >>> On 6/11/2018 7:17 PM, Michael S. Tsirkin wrote: On Tue, Jun 12, 2018 at 09:54:44AM +0800, Jason

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Tue, Jun 12, 2018 at 4:47 AM, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 03:09:26PM -0700, Siwei Liu wrote: >> The thing is cloud service provider might prefer sticking to the same >> level of service agreement (SLA) of keeping VF over migration, > > That req

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

On Tue, Jun 5, 2018 at 2:32 PM, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 02:16:44PM -0700, Siwei Liu wrote: >> Good to see this discussion going. I share the same feeling that the >> decision of plugging the primary (passthrough) should only be made >> until gues

Re: [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

Good to see this discussion going. I share the same feeling that the decision of plugging the primary (passthrough) should only be made until guest driver acknowledges DRIVER_OK and _F_STANDBY. Architecturally this intelligence should be baken to QEMU itself rather than moving up to management

Re: [virtio-dev] [PATCH 0/1] Add "Group Identifier" to virtio PCI capabilities.

On Fri, Jun 1, 2018 at 2:03 PM, Michael S. Tsirkin wrote: > On Fri, Jun 01, 2018 at 01:36:34PM -0700, Siwei Liu wrote: >> On Fri, Jun 1, 2018 at 1:03 PM, Michael S. Tsirkin wrote: >> > On Fri, Jun 01, 2018 at 12:01:26PM -0500, Venu Busireddy wrote: >> >> On 2018-0

Re: [virtio-dev] [PATCH 0/1] Add "Group Identifier" to virtio PCI capabilities.

On Fri, Jun 1, 2018 at 1:03 PM, Michael S. Tsirkin wrote: > On Fri, Jun 01, 2018 at 12:01:26PM -0500, Venu Busireddy wrote: >> On 2018-06-01 18:42:06 +0300, Michael S. Tsirkin wrote: >> > On Wed, May 23, 2018 at 11:16:12AM -0400, Venu Busireddy wrote: >> > > During live migration involving

Re: [virtio-dev] RFC: Use of bridge devices to store pairing information...

On Fri, Jun 1, 2018 at 8:48 AM, Michael S. Tsirkin wrote: > On Fri, Jun 01, 2018 at 08:26:03AM -0700, Samudrala, Sridhar wrote: >> On 5/31/2018 6:28 PM, Venu Busireddy wrote: >> > I looked at the discussion in the threads [1] and [2], where it was >> > suggested placing the passthrough device

[virtio-dev] Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

On Thu, May 31, 2018 at 11:35 AM, Michael S. Tsirkin wrote: > On Wed, May 30, 2018 at 10:06:35PM -0400, Stephen Hemminger wrote: >> On Thu, 24 May 2018 09:55:14 -0700 >> Sridhar Samudrala wrote: >> >> > Use the registration/notification framework supported by the generic >> > failover

[virtio-dev] Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

On Sat, Apr 28, 2018 at 2:42 AM, Jiri Pirko wrote: > Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: >>This patch enables virtio_net to switch over to a VF datapath when a VF >>netdev is present with the same MAC address. It allows live migration >>of a

[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Thu, Apr 26, 2018 at 4:42 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, Apr 26, 2018 at 03:14:46PM -0700, Siwei Liu wrote: >> On Wed, Apr 25, 2018 at 7:28 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Wed, Apr 25, 2018 at 03:57:57PM -0700,

[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Wed, Apr 25, 2018 at 7:28 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Wed, Apr 25, 2018 at 03:57:57PM -0700, Siwei Liu wrote: >> On Wed, Apr 25, 2018 at 3:22 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Wed, Apr 25, 2018 at 02:38:57PM -0700,

[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Wed, Apr 25, 2018 at 3:22 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Wed, Apr 25, 2018 at 02:38:57PM -0700, Siwei Liu wrote: >> On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Mon, Apr 23, 2018 at 12:44:39PM -0700,

[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Mon, Apr 23, 2018 at 12:44:39PM -0700, Siwei Liu wrote: >> On Mon, Apr 23, 2018 at 10:56 AM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Mon, Apr 23, 2018 at 10:44:40AM

[virtio-dev] Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

On Mon, Apr 23, 2018 at 10:56 AM, Michael S. Tsirkin wrote: > On Mon, Apr 23, 2018 at 10:44:40AM -0700, Stephen Hemminger wrote: >> On Mon, 23 Apr 2018 20:24:56 +0300 >> "Michael S. Tsirkin" wrote: >> >> > On Mon, Apr 23, 2018 at 10:04:06AM -0700, Stephen

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

S. Tsirkin wrote: >>>> >>>> On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: >>>>> >>>>> On 4/17/2018 5:26 PM, Siwei Liu wrote: >>>>>> >>>>>> I ran this with a few folks offline and gathered s

Re: [virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Wed, Apr 18, 2018 at 10:00 PM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: > On 4/18/2018 9:41 PM, Michael S. Tsirkin wrote: >> >> On Wed, Apr 18, 2018 at 04:33:34PM -0700, Samudrala, Sridhar wrote: >>> >>> On 4/17/2018 5:26 PM, Siwei Liu wrote

[virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

for hiding lower netdev at that point. Think it would be the best to make everyone understand the big picture in advance before going too far. Thanks, comments welcome. -Siwei On Mon, Apr 9, 2018 at 11:48 PM, Siwei Liu <losewe...@gmail.com> wrote: > On Sun, Apr 8, 2018 at 9:32 AM, Dav

[virtio-dev] Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework

On Tue, Apr 10, 2018 at 4:28 PM, Michael S. Tsirkin wrote: > On Tue, Apr 10, 2018 at 02:26:08PM -0700, Stephen Hemminger wrote: >> On Tue, 10 Apr 2018 11:59:50 -0700 >> Sridhar Samudrala wrote: >> >> > Use the registration/notification framework

[virtio-dev] Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

On Tue, Apr 10, 2018 at 8:43 AM, Jiri Pirko wrote: > Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudr...@intel.com wrote: >>On 4/10/2018 8:22 AM, Jiri Pirko wrote: >>> Tue, Apr 10, 2018 at 05:13:40PM CEST, sridhar.samudr...@intel.com wrote: >>> > On 4/10/2018 3:55 AM, Jiri

[virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Mon, Apr 9, 2018 at 4:03 PM, Stephen Hemminger <step...@networkplumber.org> wrote: > On Mon, 9 Apr 2018 15:30:42 -0700 > Siwei Liu <losewe...@gmail.com> wrote: > >> On Mon, Apr 9, 2018 at 3:15 PM, Andrew Lunn <and...@lunn.ch> wrote: >> >> No, imp

[virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Mon, Apr 9, 2018 at 3:15 PM, Andrew Lunn wrote: >> No, implementation wise I'd avoid changing the class on the fly. What >> I'm looking to is a means to add a secondary class or class aliasing >> mechanism for netdevs that allows mapping for a kernel device >> namespace

[virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Fri, Apr 6, 2018 at 8:19 PM, Andrew Lunn wrote: > Hi Siwei > >> I think everyone seems to agree not to fiddle with the ":" prefix, but >> rather have a new class of network subsystem under /sys/class thus a >> separate device namespace e.g. /sys/class/net-kernel for those >>

Re: [virtio-dev] Re: [RFC PATCH 1/3] qemu: virtio-bypass should explicitly bind to a passthrough device

(click the wrong reply button again, sorry) On Thu, Apr 5, 2018 at 8:31 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > On 04/04/2018 10:02, Siwei Liu wrote: >>> pci_bus_num is almost always a bug if not done within >>> a context of a PCI host, bridge,

[virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Wed, Apr 4, 2018 at 10:37 AM, David Miller wrote: > From: David Ahern > Date: Wed, 4 Apr 2018 11:21:54 -0600 > >> It is a netdev so there is no reason to have a separate ip command to >> inspect it. 'ip link' is the right place. > > I agree on this.

[virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Tue, Apr 3, 2018 at 6:04 PM, David Ahern wrote: > On 4/3/18 9:42 AM, Jiri Pirko wrote: >>> >>> There are other use cases that want to hide a device from userspace. I >> >> What usecases do you have in mind? > > As mentioned in a previous response some kernel drivers create

Re: [virtio-dev] Re: [RFC PATCH 3/3] virtio_net: make lower netdevs for virtio_bypass hidden

On Tue, Apr 3, 2018 at 5:20 AM, Michael S. Tsirkin wrote: > On Sun, Apr 01, 2018 at 05:13:10AM -0400, Si-Wei Liu wrote: >> diff --git a/include/uapi/linux/virtio_net.h >> b/include/uapi/linux/virtio_net.h >> index aa40664..0827b7e 100644 >> --- a/include/uapi/linux/virtio_net.h

[virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Tue, Apr 3, 2018 at 11:19 PM, Jiri Pirko wrote: > Wed, Apr 04, 2018 at 03:04:26AM CEST, dsah...@gmail.com wrote: >>On 4/3/18 9:42 AM, Jiri Pirko wrote: There are other use cases that want to hide a device from userspace. I >>> >>> What usecases do you have in mind?

[virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Tue, Apr 3, 2018 at 8:42 AM, Jiri Pirko wrote: > Sun, Apr 01, 2018 at 06:11:29PM CEST, dsah...@gmail.com wrote: >>On 4/1/18 3:13 AM, Si-Wei Liu wrote: >>> Hidden netdevice is not visible to userspace such that >>> typical network utilites e.g. ip, ifconfig and et al, >>>

[virtio-dev] Re: [RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

On Sun, Apr 1, 2018 at 9:11 AM, David Ahern wrote: > On 4/1/18 3:13 AM, Si-Wei Liu wrote: >> Hidden netdevice is not visible to userspace such that >> typical network utilities e.g. ip, ifconfig and et al, >> cannot sense its existence or configure it. Internally >> hidden

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Tue, Mar 13, 2018 at 5:28 PM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: > On 3/12/2018 3:44 PM, Siwei Liu wrote: >> >> Apologies, still some comments going. Please see inline. >> >> On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala >&

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

Apologies, still some comments going. Please see inline. On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: > This patch enables virtio_net to switch over to a VF datapath when a VF > netdev is present with the same MAC address. It allows live migration > of a

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Sat, Mar 3, 2018 at 8:04 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Fri, Mar 02, 2018 at 03:56:31PM -0800, Siwei Liu wrote: >> On Fri, Mar 2, 2018 at 1:36 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Fri, Mar 02, 2018 at 01:11:56PM -0800, Siwe

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 2, 2018 at 3:12 PM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: > On 3/2/2018 1:11 PM, Siwei Liu wrote: >> >> On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala >> <sridhar.samudr...@intel.com> wrote: >>> >>> This patch

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 2, 2018 at 1:36 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Fri, Mar 02, 2018 at 01:11:56PM -0800, Siwei Liu wrote: >> On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala >> <sridhar.samudr...@intel.com> wrote: >> > This patch enables virtio

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: > This patch enables virtio_net to switch over to a VF datapath when a VF > netdev is present with the same MAC address. It allows live migration > of a VM with a direct attached VF without the need to setup a

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 2, 2018 at 11:42 AM, Michael S. Tsirkin wrote: > On Fri, Mar 02, 2018 at 05:20:17PM +0100, Jiri Pirko wrote: >> >Yeah, this code essentially calls out the "shareable" code with a >> >comment at the start and end of the section what defines the >> >virtio_bypass

[virtio-dev] Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On Fri, Feb 23, 2018 at 2:38 PM, Jiri Pirko wrote: > Fri, Feb 23, 2018 at 11:22:36PM CET, losewe...@gmail.com wrote: > > [...] > No, that's not what I was talking about of course. I thought you mentioned the upgrade scenario this patch would like to address is to

[virtio-dev] Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On Wed, Feb 21, 2018 at 6:35 PM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: > On 2/21/2018 5:59 PM, Siwei Liu wrote: >> >> On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck >> <alexander.du...@gmail.com> wrote: >>> >>> On Wed, Feb

[virtio-dev] Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu <losewe...@gmail.com> wrote: >> I haven't checked emails for days and did not realize the new revision >> had already came out. A

[virtio-dev] Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

I haven't checked emails for days and did not realize the new revision had already came out. And thank you for the effort, this revision really looks to be a step forward towards our use case and is close to what we wanted to do. A few questions in line. On Sat, Feb 17, 2018 at 9:12 AM, Alexander

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Jan 26, 2018 at 8:51 AM, Samudrala, Sridhar <sridhar.samudr...@intel.com> wrote: > > > On 1/26/2018 12:14 AM, Siwei Liu wrote: >> >> On Tue, Jan 23, 2018 at 2:58 PM, Michael S. Tsirkin <m...@redhat.com> >> wrote: >>> >>>

[virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Mon, Jan 22, 2018 at 1:41 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Mon, Jan 22, 2018 at 12:27:14PM -0800, Siwei Liu wrote: >> First off, as mentioned in another thread, the model of stacking up >> virt-bond functionality over virtio seems a wrong direction

[virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

First off, as mentioned in another thread, the model of stacking up virt-bond functionality over virtio seems a wrong direction to me. Essentially the migration process would need to carry over all guest side configurations previously done on the VF/PT and get them moved to the new device being it