On Tue, Jan 14, 2020 at 7:35 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> thank you for the update.
>
> On Dienstag, 14. Januar 2020 08:18:50 CET Keiichi Watanabe wrote:
> > Hi,
> >
> > On Thu, Jan 9, 2020 at 11:21 PM Tomasz Figa wrote:
> > > On Wed, Jan 8, 2020 at 10:52 PM Keiichi Watanabe
>
Hi,
On Tue, Jan 14, 2020 at 7:35 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> thank you for the update.
>
> On Dienstag, 14. Januar 2020 08:18:50 CET Keiichi Watanabe wrote:
> > Hi,
> >
> > On Thu, Jan 9, 2020 at 11:21 PM Tomasz Figa wrote:
> > > On Wed, Jan 8, 2020 at 10:52 PM Keiichi Watanabe
>
Hi Keiichi,
thank you for the update.
On Dienstag, 14. Januar 2020 08:18:50 CET Keiichi Watanabe wrote:
> Hi,
>
> On Thu, Jan 9, 2020 at 11:21 PM Tomasz Figa wrote:
> > On Wed, Jan 8, 2020 at 10:52 PM Keiichi Watanabe
wrote:
> > > Hi Gerd,
> > >
> > > On Thu, Dec 19, 2019 at 10:12 PM Gerd
Hi,
On Thu, Jan 9, 2020 at 11:21 PM Tomasz Figa wrote:
>
> On Wed, Jan 8, 2020 at 10:52 PM Keiichi Watanabe
> wrote:
> >
> > Hi Gerd,
> >
> > On Thu, Dec 19, 2019 at 10:12 PM Gerd Hoffmann wrote:
> > >
> > > Hi,
> > >
> > > > > However that still doesn't let the driver know which buffers
Hi,
> Regarding re-using, the driver can simply re-queue buffers returned by
> the device. If the device needs a buffer as reference frame, it must
> not return the buffer.
Ok, that'll work.
> I'll describe this rule in the next version of the patch.
Good. You should also add a note about
Hi Gerd,
On Thu, Dec 19, 2019 at 10:12 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > > However that still doesn't let the driver know which buffers will be
> > > dequeued when. A simple example of this scenario is when the guest is
> > > done displaying a frame and requeues the buffer back to the
Hi Gerd,
Thank you so much for the review. I'm sorry for not replying earlier.
On Thu, Dec 19, 2019 at 10:02 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > > Not clearly defined in the spec: When is the decoder supposed to send
> > > the response for a queue request? When it finished decoding (i.e.
On Wed, Jan 8, 2020 at 10:11 PM Dmitry Sepp wrote:
>
> Hi Tomasz, Keiichi,
>
> On Mittwoch, 8. Januar 2020 13:46:25 CET Tomasz Figa wrote:
> > On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe
> wrote:
> > > Hi Dmitry,
> > >
> > > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp
> wrote:
> > > > Hi
Hi Tomasz, Keiichi,
On Mittwoch, 8. Januar 2020 13:46:25 CET Tomasz Figa wrote:
> On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe
wrote:
> > Hi Dmitry,
> >
> > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp
wrote:
> > > Hi Keiichi,
> > >
> > > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi
On Wed, Jan 8, 2020 at 9:46 PM Tomasz Figa wrote:
>
> On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe wrote:
> >
> > Hi Dmitry,
> >
> > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp
> > wrote:
> > >
> > > Hi Keiichi,
> > >
> > > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote:
> >
On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe wrote:
>
> Hi Dmitry,
>
> On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp
> wrote:
> >
> > Hi Keiichi,
> >
> > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote:
> > > Hi Dmitry,
> > >
> > > On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp
> >
Hi Dmitry,
On Wed, Dec 18, 2019 at 10:02 PM Keiichi Watanabe wrote:
>
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities to
> encode and decode video stream respectively.
> Though video encoder and decoder are provided as different devices, they
Hi Dmitry,
On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote:
> > Hi Dmitry,
> >
> > On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp
> wrote:
> > > Hi Keiichi,
> > >
> > > thanks for the updates, please see my
Hi Keiichi,
On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp
wrote:
> > Hi Keiichi,
> >
> > thanks for the updates, please see my comments below.
> >
> > On Dienstag, 7. Januar 2020 14:24:31 CET Keiichi Watanabe
Hi Dmitry,
On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> thanks for the updates, please see my comments below.
>
> On Dienstag, 7. Januar 2020 14:24:31 CET Keiichi Watanabe wrote:
> > Hi Dmitry,
> >
> > On Mon, Jan 6, 2020 at 11:59 PM Dmitry Sepp
> wrote:
> > > Hi,
> > >
Hi Keiichi,
thanks for the updates, please see my comments below.
On Dienstag, 7. Januar 2020 14:24:31 CET Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Mon, Jan 6, 2020 at 11:59 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > a couple of new comments:
> >
> > On Mittwoch, 18. Dezember 2019 14:02:14
Hi Dmitry,
On Mon, Jan 6, 2020 at 11:59 PM Dmitry Sepp wrote:
>
> Hi,
>
> a couple of new comments:
>
> On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provide functionalities
> > to encode and
Hi,
a couple of new comments:
On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities
> to encode and decode video stream respectively.
> Though video encoder and decoder are provided
Hi Dmitry,
On Sat, Jan 4, 2020 at 12:47 AM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provide functionalities
> > to encode and decode video stream
Hi,
On Montag, 6. Januar 2020 09:33:35 CET Gerd Hoffmann wrote:
> Hi,
>
> > > We also see the need to add a max_streams value to this structure so as
> > > to
> > > explicitly provide a limit on the number of streams the guest can
> > > create.
> >
> > What would be the advantage over just
Hi,
> How should one deal with multiplanar formats? Do we create one resource per
> plane? Otherwise we need a way to send mem entries for each plane in one
> request.
DRM uses arrays of handles and offsets (see struct drm_framebuffer). A
handle references a gem object (roughly the same as
Hi,
> > We also see the need to add a max_streams value to this structure so as to
> > explicitly provide a limit on the number of streams the guest can create.
>
> What would be the advantage over just trying to create one and
> failing? The maximum number would be only meaningful for the
On Mon, Dec 30, 2019 at 9:16 PM Dmitry Sepp wrote:
>
>
> On Donnerstag, 19. Dezember 2019 14:28:23 CET Dmitry Sepp wrote:
> > Hi Keiichi,
> >
> > Thank you for the update. Please see some comments below.
> >
> > Also, we need to bring the virtio_video_control back as it is in fact used
> > by the
Hi Keiichi,
On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities
> to encode and decode video stream respectively.
> Though video encoder and decoder are provided as different
On Donnerstag, 19. Dezember 2019 14:28:23 CET Dmitry Sepp wrote:
> Hi Keiichi,
>
> Thank you for the update. Please see some comments below.
>
> Also, we need to bring the virtio_video_control back as it is in fact used
> by the driver to enumerate supported encoder controls. But yes, it still
On Sat, Dec 21, 2019 at 12:46 AM Dmitry Sepp
wrote:
> On Freitag, 20. Dezember 2019 16:26:50 CET Keiichi Watanabe wrote:
> > On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp
> > wrote:
> > > On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote:
[snip]
> > > > +enum virtio_video_format
Hi Keiichi,
On Freitag, 20. Dezember 2019 16:26:50 CET Keiichi Watanabe wrote:
> Hi Dmitry,
> Thanks for the feedback.
>
> On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp
>
> wrote:
> > Hi Keiichi,
> >
> > Thank you for the update. Please see some comments below.
> >
> > Also, we need to bring
Hi Keiichi,
On Freitag, 20. Dezember 2019 15:05:02 CET Keiichi Watanabe wrote:
> Hi Frediano,
> Thanks for reviewing!
>
> On Thu, Dec 19, 2019 at 2:29 AM Frediano Ziglio wrote:
> > > From: Dmitry Sepp
> > >
> > > The virtio video encoder device and decoder device provide
> > > functionalities
Hi Dmitry,
Thanks for the feedback.
On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp
wrote:
>
> Hi Keiichi,
>
> Thank you for the update. Please see some comments below.
>
> Also, we need to bring the virtio_video_control back as it is in fact used by
> the driver to enumerate supported encoder
Hi Frediano,
Thanks for reviewing!
On Thu, Dec 19, 2019 at 2:29 AM Frediano Ziglio wrote:
>
> >
> > From: Dmitry Sepp
> >
> > The virtio video encoder device and decoder device provide functionalities
> > to
> > encode and decode video stream respectively.
> > Though video encoder and decoder
Hi Keiichi,
Thank you for the update. Please see some comments below.
Also, we need to bring the virtio_video_control back as it is in fact used by
the driver to enumerate supported encoder controls. But yes, it still needs to
be documemnted, it's true.
On Mittwoch, 18. Dezember 2019 14:02:14
Hi,
> > However that still doesn't let the driver know which buffers will be
> > dequeued when. A simple example of this scenario is when the guest is
> > done displaying a frame and requeues the buffer back to the decoder.
> > Then the decoder will not choose it for decoding next frames into
Hi,
> > Not clearly defined in the spec: When is the decoder supposed to send
> > the response for a queue request? When it finished decoding (i.e. frame
> > is ready for playback), or when it doesn't need the buffer any more for
> > decoding (i.e. buffer can be re-queued or pages can be
Hi,
> > I also can't see why the flag is needed in the first place. The driver
> > should know which buffers are queued still and be able to figure
> > whenever the drain is complete or not without depending on that flag.
> > So I'd suggest to simply drop it.
> This flag is used not for drain
On Thu, Dec 19, 2019 at 7:55 PM Dmitry Sepp wrote:
>
> Hi Tomasz,
>
> On Donnerstag, 19. Dezember 2019 10:59:02 CET Tomasz Figa wrote:
> > On Thu, Dec 19, 2019 at 6:48 PM Dmitry Sepp
> wrote:
> > > Hi,
> > >
> > > On Donnerstag, 19. Dezember 2019 08:46:39 CET Gerd Hoffmann wrote:
> > > > On Wed,
Hi Tomasz,
On Donnerstag, 19. Dezember 2019 10:59:02 CET Tomasz Figa wrote:
> On Thu, Dec 19, 2019 at 6:48 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > On Donnerstag, 19. Dezember 2019 08:46:39 CET Gerd Hoffmann wrote:
> > > On Wed, Dec 18, 2019 at 11:08:37PM +0900, Tomasz Figa wrote:
> > > > On Wed,
On Thu, Dec 19, 2019 at 6:48 PM Dmitry Sepp wrote:
>
> Hi,
>
> On Donnerstag, 19. Dezember 2019 08:46:39 CET Gerd Hoffmann wrote:
> > On Wed, Dec 18, 2019 at 11:08:37PM +0900, Tomasz Figa wrote:
> > > On Wed, Dec 18, 2019 at 10:40 PM Gerd Hoffmann wrote:
> > > > Hi,
> > > >
> > > > > +The
On Thu, Dec 19, 2019 at 6:26 PM Dmitry Sepp wrote:
>
> Hi Gerd,
>
> On Mittwoch, 18. Dezember 2019 14:40:37 CET Gerd Hoffmann wrote:
> > Hi,
> >
> > > +The device MUST mark the last buffer with the
> > > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain
> > > +sequence.
> >
> >
Hi,
On Donnerstag, 19. Dezember 2019 08:46:39 CET Gerd Hoffmann wrote:
> On Wed, Dec 18, 2019 at 11:08:37PM +0900, Tomasz Figa wrote:
> > On Wed, Dec 18, 2019 at 10:40 PM Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > +The device MUST mark the last buffer with the
> > > >
Hi Gerd,
On Mittwoch, 18. Dezember 2019 14:40:37 CET Gerd Hoffmann wrote:
> Hi,
>
> > +The device MUST mark the last buffer with the
> > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain
> > +sequence.
>
> No, that would build a race condition into the protocol. The device
>
On Wed, Dec 18, 2019 at 11:08:37PM +0900, Tomasz Figa wrote:
> On Wed, Dec 18, 2019 at 10:40 PM Gerd Hoffmann wrote:
> >
> > Hi,
> >
> > > +The device MUST mark the last buffer with the
> > > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain
> > > +sequence.
> >
> > No, that
On Wed, Dec 18, 2019 at 10:40 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > +The device MUST mark the last buffer with the
> > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain
> > +sequence.
>
> No, that would build a race condition into the protocol. The device
> could complete the
Hi,
> +The device MUST mark the last buffer with the
> +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain
> +sequence.
No, that would build a race condition into the protocol. The device
could complete the last buffer after the driver has sent the drain
command but before the
43 matches
Mail list logo
