Re: [virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-27 Thread Michael S. Tsirkin
On Wed, Jun 27, 2018 at 01:27:55PM +0800, Wei Wang wrote: > On 06/27/2018 11:58 AM, Michael S. Tsirkin wrote: > > On Wed, Jun 27, 2018 at 11:00:05AM +0800, Wei Wang wrote: > > > On 06/27/2018 10:41 AM, Michael S. Tsirkin wrote: > > > > On Wed, Jun 27, 2018 at 09:24:18AM +0800, Wei Wang wrote: > >

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Wei Wang
On 06/27/2018 11:58 AM, Michael S. Tsirkin wrote: On Wed, Jun 27, 2018 at 11:00:05AM +0800, Wei Wang wrote: On 06/27/2018 10:41 AM, Michael S. Tsirkin wrote: On Wed, Jun 27, 2018 at 09:24:18AM +0800, Wei Wang wrote: On 06/26/2018 09:34 PM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Michael S. Tsirkin
On Wed, Jun 27, 2018 at 11:00:05AM +0800, Wei Wang wrote: > On 06/27/2018 10:41 AM, Michael S. Tsirkin wrote: > > On Wed, Jun 27, 2018 at 09:24:18AM +0800, Wei Wang wrote: > > > On 06/26/2018 09:34 PM, Michael S. Tsirkin wrote: > > > > On Tue, Jun 26, 2018 at 08:27:44PM +0800, Wei Wang wrote: > >

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Wei Wang
On 06/27/2018 10:41 AM, Michael S. Tsirkin wrote: On Wed, Jun 27, 2018 at 09:24:18AM +0800, Wei Wang wrote: On 06/26/2018 09:34 PM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 08:27:44PM +0800, Wei Wang wrote: On 06/26/2018 11:56 AM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Michael S. Tsirkin
On Wed, Jun 27, 2018 at 09:24:18AM +0800, Wei Wang wrote: > On 06/26/2018 09:34 PM, Michael S. Tsirkin wrote: > > On Tue, Jun 26, 2018 at 08:27:44PM +0800, Wei Wang wrote: > > > On 06/26/2018 11:56 AM, Michael S. Tsirkin wrote: > > > > On Tue, Jun 26, 2018 at 11:46:35AM +0800, Wei Wang wrote: > >

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Wei Wang
On 06/26/2018 09:34 PM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 08:27:44PM +0800, Wei Wang wrote: On 06/26/2018 11:56 AM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 11:46:35AM +0800, Wei Wang wrote: + if (!arrays) + return NULL; + + for (i = 0; i <

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Michael S. Tsirkin
On Tue, Jun 26, 2018 at 08:27:44PM +0800, Wei Wang wrote: > On 06/26/2018 11:56 AM, Michael S. Tsirkin wrote: > > On Tue, Jun 26, 2018 at 11:46:35AM +0800, Wei Wang wrote: > > > > > > > > > > > > > > > + if (!arrays) > > > > > + return NULL; > > > > > + > > > > > + for (i =

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-26 Thread Wei Wang
On 06/26/2018 11:56 AM, Michael S. Tsirkin wrote: On Tue, Jun 26, 2018 at 11:46:35AM +0800, Wei Wang wrote: + if (!arrays) + return NULL; + + for (i = 0; i < max_array_num; i++) { So we are getting a ton of memory here just to free it up a bit later. Why

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-25 Thread Michael S. Tsirkin
On Tue, Jun 26, 2018 at 11:46:35AM +0800, Wei Wang wrote: > On 06/26/2018 09:37 AM, Michael S. Tsirkin wrote: > > On Mon, Jun 25, 2018 at 08:05:10PM +0800, Wei Wang wrote: > > > > > @@ -326,17 +353,6 @@ static void stats_handle_request(struct > > > virtio_balloon *vb) > > >

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-25 Thread Wei Wang
On 06/26/2018 09:37 AM, Michael S. Tsirkin wrote: On Mon, Jun 25, 2018 at 08:05:10PM +0800, Wei Wang wrote: @@ -326,17 +353,6 @@ static void stats_handle_request(struct virtio_balloon *vb) virtqueue_kick(vq); } -static void virtballoon_changed(struct virtio_device *vdev) -{ -

[virtio-dev] Re: [PATCH v34 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 08:05:10PM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free page hints by sending a new cmd id > to the