[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Tue, Mar 13, 2018 at 5:28 PM, Samudrala, Sridhar wrote: > On 3/12/2018 3:44 PM, Siwei Liu wrote: >> >> Apologies, still some comments going. Please see inline. >> >> On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala >> wrote: >>> >>>

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Tue, Mar 13, 2018 at 05:28:07PM -0700, Samudrala, Sridhar wrote: > > I am not sure if it's a good idea to leave the > > virtio_bypass around if running into failure: the guest is not > > migratable as the VF doesn't have a backup path, > > Are you talking about a failure when registering

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/12/2018 2:08 PM, Jiri Pirko wrote: Mon, Mar 12, 2018 at 09:58:06PM CET, sridhar.samudr...@intel.com wrote: On 3/12/2018 1:12 PM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/12/2018 3:44 PM, Siwei Liu wrote: Apologies, still some comments going. Please see inline. On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

Apologies, still some comments going. Please see inline. On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: > This patch enables virtio_net to switch over to a VF datapath when a VF > netdev is present with the same MAC address. It allows live migration > of a

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Sat, Mar 3, 2018 at 8:04 PM, Michael S. Tsirkin wrote: > On Fri, Mar 02, 2018 at 03:56:31PM -0800, Siwei Liu wrote: >> On Fri, Mar 2, 2018 at 1:36 PM, Michael S. Tsirkin wrote: >> > On Fri, Mar 02, 2018 at 01:11:56PM -0800, Siwei Liu wrote: >> >> On Thu, Mar

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/12/2018 1:12 PM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/7/2018 12:11 PM, Michael S. Tsirkin wrote: On Wed, Mar 07, 2018 at 10:06:30AM -0800, Stephen Hemminger wrote: On Wed, 7 Mar 2018 09:50:50 -0800 Alexander Duyck wrote: On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: On Tue, Mar 06,

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Wed, Mar 07, 2018 at 10:06:30AM -0800, Stephen Hemminger wrote: > On Wed, 7 Mar 2018 09:50:50 -0800 > Alexander Duyck wrote: > > > On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: > > > On Tue, Mar 06, 2018 at 03:27:46PM -0800, Alexander

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Wed, Mar 7, 2018 at 10:06 AM, Stephen Hemminger wrote: > On Wed, 7 Mar 2018 09:50:50 -0800 > Alexander Duyck wrote: > >> On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: >> > On Tue, Mar 06, 2018 at 03:27:46PM

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: > On Tue, Mar 06, 2018 at 03:27:46PM -0800, Alexander Duyck wrote: >> > I definitelly vote for a separate common shared code for both netvsc and >> > virtio_net - even if you use 2 and 3 netdev model, you could share the

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Tue, Mar 06, 2018 at 03:27:46PM -0800, Alexander Duyck wrote: > > I definitelly vote for a separate common shared code for both netvsc and > > virtio_net - even if you use 2 and 3 netdev model, you could share the > > common code. Strict checks and limitation should be in place. > > Noted. But

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Tue, Mar 6, 2018 at 2:59 PM, Jiri Pirko wrote: > Tue, Mar 06, 2018 at 08:08:21PM CET, alexander.du...@gmail.com wrote: >>On Mon, Mar 5, 2018 at 7:15 PM, Stephen Hemminger >> wrote: >>> On Mon, 5 Mar 2018 14:47:20 -0800 >>> Alexander Duyck

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Mon, Mar 5, 2018 at 7:15 PM, Stephen Hemminger wrote: > On Mon, 5 Mar 2018 14:47:20 -0800 > Alexander Duyck wrote: > >> On Mon, Mar 5, 2018 at 2:30 PM, Jiri Pirko wrote: >> > Mon, Mar 05, 2018 at 05:11:32PM CET,

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Mon, Mar 5, 2018 at 2:30 PM, Jiri Pirko wrote: > Mon, Mar 05, 2018 at 05:11:32PM CET, step...@networkplumber.org wrote: >>On Mon, 5 Mar 2018 10:21:18 +0100 >>Jiri Pirko wrote: >> >>> Sun, Mar 04, 2018 at 10:58:34PM CET, alexander.du...@gmail.com wrote: >>>

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/4/2018 10:50 AM, Jiri Pirko wrote: Sun, Mar 04, 2018 at 07:24:12PM CET, alexander.du...@gmail.com wrote: On Sat, Mar 3, 2018 at 11:13 PM, Jiri Pirko wrote: Sun, Mar 04, 2018 at 01:26:53AM CET, alexander.du...@gmail.com wrote: On Sat, Mar 3, 2018 at 1:25 PM, Jiri

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Sat, Mar 3, 2018 at 11:13 PM, Jiri Pirko wrote: > Sun, Mar 04, 2018 at 01:26:53AM CET, alexander.du...@gmail.com wrote: >>On Sat, Mar 3, 2018 at 1:25 PM, Jiri Pirko wrote: >>> Sat, Mar 03, 2018 at 07:04:57PM CET, alexander.du...@gmail.com wrote: On Sat,

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 02, 2018 at 03:56:31PM -0800, Siwei Liu wrote: > On Fri, Mar 2, 2018 at 1:36 PM, Michael S. Tsirkin wrote: > > On Fri, Mar 02, 2018 at 01:11:56PM -0800, Siwei Liu wrote: > >> On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala > >> wrote:

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 02, 2018 at 02:26:48PM -0800, Siwei Liu wrote: > On Fri, Mar 2, 2018 at 1:31 PM, Michael S. Tsirkin wrote: > > On Fri, Mar 02, 2018 at 12:44:56PM -0800, Siwei Liu wrote: > >> On Fri, Mar 2, 2018 at 12:10 PM, Michael S. Tsirkin > >> wrote: > >> > On

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Sat, Mar 3, 2018 at 1:25 PM, Jiri Pirko wrote: > Sat, Mar 03, 2018 at 07:04:57PM CET, alexander.du...@gmail.com wrote: >>On Sat, Mar 3, 2018 at 3:31 AM, Jiri Pirko wrote: >>> Fri, Mar 02, 2018 at 08:42:47PM CET, m...@redhat.com wrote: On Fri, Mar 02,

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Sat, Mar 3, 2018 at 3:31 AM, Jiri Pirko wrote: > Fri, Mar 02, 2018 at 08:42:47PM CET, m...@redhat.com wrote: >>On Fri, Mar 02, 2018 at 05:20:17PM +0100, Jiri Pirko wrote: >>> >Yeah, this code essentially calls out the "shareable" code with a >>> >comment at the start and end

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 2, 2018 at 3:12 PM, Samudrala, Sridhar wrote: > On 3/2/2018 1:11 PM, Siwei Liu wrote: >> >> On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala >> wrote: >>> >>> This patch enables virtio_net to switch over to a VF datapath

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 2, 2018 at 1:36 PM, Michael S. Tsirkin wrote: > On Fri, Mar 02, 2018 at 01:11:56PM -0800, Siwei Liu wrote: >> On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala >> wrote: >> > This patch enables virtio_net to switch over to a VF datapath

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/2/2018 1:11 PM, Siwei Liu wrote: On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 02, 2018 at 12:56:21PM -0800, Samudrala, Sridhar wrote: > > > On 3/2/2018 12:44 PM, Siwei Liu wrote: > > On Fri, Mar 2, 2018 at 12:10 PM, Michael S. Tsirkin wrote: > > > On Fri, Mar 02, 2018 at 11:52:27AM -0800, Samudrala, Sridhar wrote: > > > > > > > > On 3/2/2018

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 02, 2018 at 12:44:56PM -0800, Siwei Liu wrote: > On Fri, Mar 2, 2018 at 12:10 PM, Michael S. Tsirkin wrote: > > On Fri, Mar 02, 2018 at 11:52:27AM -0800, Samudrala, Sridhar wrote: > >> > >> > >> On 3/2/2018 11:41 AM, Michael S. Tsirkin wrote: > >> > On Fri, Mar 02,

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: > This patch enables virtio_net to switch over to a VF datapath when a VF > netdev is present with the same MAC address. It allows live migration > of a VM with a direct attached VF without the need to setup a

Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 2, 2018 at 11:42 AM, Michael S. Tsirkin wrote: > On Fri, Mar 02, 2018 at 05:20:17PM +0100, Jiri Pirko wrote: >> >Yeah, this code essentially calls out the "shareable" code with a >> >comment at the start and end of the section what defines the >> >virtio_bypass

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 02, 2018 at 11:52:27AM -0800, Samudrala, Sridhar wrote: > > > On 3/2/2018 11:41 AM, Michael S. Tsirkin wrote: > > On Fri, Mar 02, 2018 at 07:26:25AM -0800, Alexander Duyck wrote: > > > The design limits things to a 1:1 relationship since we just have the > > > child and backup

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 02, 2018 at 05:20:17PM +0100, Jiri Pirko wrote: > >Yeah, this code essentially calls out the "shareable" code with a > >comment at the start and end of the section what defines the > >virtio_bypass functionality. It would just be a matter of mostly > >cutting and pasting to put it into

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 02, 2018 at 07:26:25AM -0800, Alexander Duyck wrote: > The design limits things to a 1:1 relationship since we just have the > child and backup pointers, but I don't think I am seeing exception > handling to prevent us from overwriting the child pointers so there > may be a leak there.

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 2, 2018 at 8:37 AM, Samudrala, Sridhar wrote: > > > On 3/2/2018 8:20 AM, Jiri Pirko wrote: > > Fri, Mar 02, 2018 at 04:26:25PM CET, alexander.du...@gmail.com wrote: > > On Fri, Mar 2, 2018 at 12:36 AM, Jiri Pirko wrote: > > Thu, Mar 01,

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On 3/2/2018 8:20 AM, Jiri Pirko wrote: Fri, Mar 02, 2018 at 04:26:25PM CET, alexander.du...@gmail.com wrote: On Fri, Mar 2, 2018 at 12:36 AM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Mar 2, 2018 at 12:36 AM, Jiri Pirko wrote: > Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: >>This patch enables virtio_net to switch over to a VF datapath when a VF >>netdev is present with the same MAC address. It allows live migration >>of a