Re: [virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-12-13 Thread Auger Eric
Hi Robin On 12/13/18 1:37 PM, Robin Murphy wrote: > On 2018-12-12 3:27 pm, Auger Eric wrote: >> Hi, >> >> On 12/12/18 3:56 PM, Michael S. Tsirkin wrote: >>> On Fri, Dec 07, 2018 at 06:52:31PM +, Jean-Philippe Brucker wrote: Sorry for the delay, I wanted to do a little more performance

Re: [virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-12-12 Thread Auger Eric
Hi, On 12/12/18 3:56 PM, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2018 at 06:52:31PM +, Jean-Philippe Brucker wrote: >> Sorry for the delay, I wanted to do a little more performance analysis >> before continuing. >> >> On 27/11/2018 18:10, Michael S. Tsirkin wrote: >>> On Tue, Nov 27, 2018

Re: [virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-12-12 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 06:52:31PM +, Jean-Philippe Brucker wrote: > Sorry for the delay, I wanted to do a little more performance analysis > before continuing. > > On 27/11/2018 18:10, Michael S. Tsirkin wrote: > > On Tue, Nov 27, 2018 at 05:55:20PM +, Jean-Philippe Brucker wrote: >

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-12-11 Thread Jean-Philippe Brucker
On 10/12/2018 22:53, Michael S. Tsirkin wrote: > On Mon, Dec 10, 2018 at 03:06:47PM +, Jean-Philippe Brucker wrote: >> On 27/11/2018 18:53, Michael S. Tsirkin wrote: >>> On Tue, Nov 27, 2018 at 06:10:46PM +, Jean-Philippe Brucker wrote: On 27/11/2018 18:04, Michael S. Tsirkin wrote:

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-12-10 Thread Michael S. Tsirkin
On Mon, Dec 10, 2018 at 03:06:47PM +, Jean-Philippe Brucker wrote: > On 27/11/2018 18:53, Michael S. Tsirkin wrote: > > On Tue, Nov 27, 2018 at 06:10:46PM +, Jean-Philippe Brucker wrote: > >> On 27/11/2018 18:04, Michael S. Tsirkin wrote: > >>> On Tue, Nov 27, 2018 at 05:50:50PM +,

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-12-10 Thread Jean-Philippe Brucker
On 27/11/2018 18:53, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2018 at 06:10:46PM +, Jean-Philippe Brucker wrote: >> On 27/11/2018 18:04, Michael S. Tsirkin wrote: >>> On Tue, Nov 27, 2018 at 05:50:50PM +, Jean-Philippe Brucker wrote: On 23/11/2018 22:02, Michael S. Tsirkin wrote:

Re: [virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-12-07 Thread Jean-Philippe Brucker
Sorry for the delay, I wanted to do a little more performance analysis before continuing. On 27/11/2018 18:10, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2018 at 05:55:20PM +, Jean-Philippe Brucker wrote: + if (!virtio_has_feature(vdev, VIRTIO_F_VERSION_1) || +

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 06:10:46PM +, Jean-Philippe Brucker wrote: > On 27/11/2018 18:04, Michael S. Tsirkin wrote: > > On Tue, Nov 27, 2018 at 05:50:50PM +, Jean-Philippe Brucker wrote: > >> On 23/11/2018 22:02, Michael S. Tsirkin wrote: > +/* > + * __viommu_sync_req - Complete

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 05:50:50PM +, Jean-Philippe Brucker wrote: > > I didn't notice this in the past but it seems this will spin > > with interrupts disabled until host handles the request. > > Please do not do this - host execution can be another > > task that needs the same host CPU. This

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 05:58:18PM +, Jean-Philippe Brucker wrote: > On 23/11/2018 21:48, Michael S. Tsirkin wrote: > >> +struct virtio_iommu_config { > >> + /* Supported page sizes */ > >> + __u64 page_size_mask; > >> + /* Supported IOVA range */ > >> +

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Jean-Philippe Brucker
On 27/11/2018 18:04, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2018 at 05:50:50PM +, Jean-Philippe Brucker wrote: >> On 23/11/2018 22:02, Michael S. Tsirkin wrote: +/* + * __viommu_sync_req - Complete all in-flight requests + * + * Wait for all added requests to complete.

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 05:55:20PM +, Jean-Philippe Brucker wrote: > On 23/11/2018 21:56, Michael S. Tsirkin wrote: > >> +config VIRTIO_IOMMU > >> + bool "Virtio IOMMU driver" > >> + depends on VIRTIO=y > >> + select IOMMU_API > >> + select INTERVAL_TREE > >> + select ARM_DMA_USE_IOMMU if

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2018 at 05:50:50PM +, Jean-Philippe Brucker wrote: > On 23/11/2018 22:02, Michael S. Tsirkin wrote: > >> +/* > >> + * __viommu_sync_req - Complete all in-flight requests > >> + * > >> + * Wait for all added requests to complete. When this function returns, > >> all > >> + *

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Jean-Philippe Brucker
On 23/11/2018 21:48, Michael S. Tsirkin wrote: >> +struct virtio_iommu_config { >> +/* Supported page sizes */ >> +__u64 page_size_mask; >> +/* Supported IOVA range */ >> +struct virtio_iommu_range input_range; >> +/* Max domain

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Jean-Philippe Brucker
On 23/11/2018 21:56, Michael S. Tsirkin wrote: >> +config VIRTIO_IOMMU >> +bool "Virtio IOMMU driver" >> +depends on VIRTIO=y >> +select IOMMU_API >> +select INTERVAL_TREE >> +select ARM_DMA_USE_IOMMU if ARM >> +help >> + Para-virtualised IOMMU driver with virtio. >> +

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-27 Thread Jean-Philippe Brucker
On 23/11/2018 22:02, Michael S. Tsirkin wrote: >> +/* >> + * __viommu_sync_req - Complete all in-flight requests >> + * >> + * Wait for all added requests to complete. When this function returns, all >> + * requests that were in-flight at the time of the call have completed. >> + */ >> +static int

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-23 Thread Michael S. Tsirkin
On Thu, Nov 22, 2018 at 07:37:59PM +, Jean-Philippe Brucker wrote: > The virtio IOMMU is a para-virtualized device, allowing to send IOMMU > requests such as map/unmap over virtio transport without emulating page > tables. This implementation handles ATTACH, DETACH, MAP and UNMAP > requests. >

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-23 Thread Michael S. Tsirkin
On Thu, Nov 22, 2018 at 07:37:59PM +, Jean-Philippe Brucker wrote: > The virtio IOMMU is a para-virtualized device, allowing to send IOMMU > requests such as map/unmap over virtio transport without emulating page > tables. This implementation handles ATTACH, DETACH, MAP and UNMAP > requests. >

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-23 Thread Michael S. Tsirkin
On Thu, Nov 22, 2018 at 07:37:59PM +, Jean-Philippe Brucker wrote: > The virtio IOMMU is a para-virtualized device, allowing to send IOMMU > requests such as map/unmap over virtio transport without emulating page > tables. This implementation handles ATTACH, DETACH, MAP and UNMAP > requests. >

[virtio-dev] Re: [PATCH v5 5/7] iommu: Add virtio-iommu driver

2018-11-23 Thread Auger Eric
Hi Jean, On 11/22/18 8:37 PM, Jean-Philippe Brucker wrote: > The virtio IOMMU is a para-virtualized device, allowing to send IOMMU > requests such as map/unmap over virtio transport without emulating page > tables. This implementation handles ATTACH, DETACH, MAP and UNMAP > requests. > > The