[virtio-dev] RE: [virtio-comment] [PATCH 1/4] virtio-net: Place C code under listing

2023-07-13 Thread Parav Pandit



> From: Cornelia Huck 
> Sent: Thursday, July 13, 2023 5:13 AM
> To: Parav Pandit ; virtio-comm...@lists.oasis-open.org;
> m...@redhat.com
> On Thu, Jul 13 2023, Parav Pandit  wrote:
> 
> > With extra white space for the define, pdf generation fails.
> > Also place the C code under listing.
> >
> > Signed-off-by: Parav Pandit 
> > ---
> >  device-types/net/description.tex | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/device-types/net/description.tex
> > b/device-types/net/description.tex
> > index 206020d..6fd4a20 100644
> > --- a/device-types/net/description.tex
> > +++ b/device-types/net/description.tex
> > @@ -1024,12 +1024,14 @@ \subsubsection{Processing of Incoming
> > Packets}\label{sec:Device Types / Network  If VIRTIO_NET_F_HASH_TUNNEL
> > has been negotiated, the driver can send the command
> VIRTIO_NET_CTRL_HASH_TUNNEL_SET to configure the calculation of the inner
> header hash.
> >
> > +\begin{lstlisting}
> >  struct virtnet_hash_tunnel {
> >  le32 enabled_tunnel_types;
> >  };
> >
> >  #define VIRTIO_NET_CTRL_HASH_TUNNEL 7
> > - #define VIRTIO_NET_CTRL_HASH_TUNNEL_SET 0
> > +#define VIRTIO_NET_CTRL_HASH_TUNNEL_SET 0
> 
> I think the indentation here is intentional (as in other, similare
> sections.)
> 
Oh right. It is the command part.

> > +\end{lstlisting}
> >
> >  Field \field{enabled_tunnel_types} contains the bitmask of encapsulation
> types enabled for inner header hash.
> >  See \ref{sec:Device Types / Network Device / Device Operation /
> > Processing of Incoming Packets /


-
To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org



[virtio-dev] Re: [virtio-comment] [PATCH 1/4] virtio-net: Place C code under listing

2023-07-13 Thread Cornelia Huck
On Thu, Jul 13 2023, Parav Pandit  wrote:

> With extra white space for the define, pdf generation fails.
> Also place the C code under listing.
>
> Signed-off-by: Parav Pandit 
> ---
>  device-types/net/description.tex | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/net/description.tex 
> b/device-types/net/description.tex
> index 206020d..6fd4a20 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -1024,12 +1024,14 @@ \subsubsection{Processing of Incoming 
> Packets}\label{sec:Device Types / Network
>  If VIRTIO_NET_F_HASH_TUNNEL has been negotiated, the driver can send the 
> command
>  VIRTIO_NET_CTRL_HASH_TUNNEL_SET to configure the calculation of the inner 
> header hash.
>  
> +\begin{lstlisting}
>  struct virtnet_hash_tunnel {
>  le32 enabled_tunnel_types;
>  };
>  
>  #define VIRTIO_NET_CTRL_HASH_TUNNEL 7
> - #define VIRTIO_NET_CTRL_HASH_TUNNEL_SET 0
> +#define VIRTIO_NET_CTRL_HASH_TUNNEL_SET 0

I think the indentation here is intentional (as in other, similare
sections.)

> +\end{lstlisting}
>  
>  Field \field{enabled_tunnel_types} contains the bitmask of encapsulation 
> types enabled for inner header hash.
>  See \ref{sec:Device Types / Network Device / Device Operation / Processing 
> of Incoming Packets /


-
To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org