[virtio-dev] RE: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-15 Thread Wang, Wei W
On Friday, June 15, 2018 10:29 PM, Michael S. Tsirkin wrote: > On Fri, Jun 15, 2018 at 02:11:23PM +, Wang, Wei W wrote: > > On Friday, June 15, 2018 7:42 PM, Michael S. Tsirkin wrote: > > > On Fri, Jun 15, 2018 at 12:43:11PM +0800, Wei Wang wrote: > > > > Negotiation of the

[virtio-dev] RE: [PATCH v33 1/4] mm: add a function to get free page blocks

2018-06-15 Thread Wang, Wei W
On Saturday, June 16, 2018 7:09 AM, Linus Torvalds wrote: > On Fri, Jun 15, 2018 at 2:08 PM Wei Wang wrote: > > > > This patch adds a function to get free pages blocks from a free page > > list. The obtained free page blocks are hints about free pages, > > because there is no guarantee that they

[virtio-dev] Re: [PATCH v33 0/4] Virtio-balloon: support free page reporting

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 12:43:09PM +0800, Wei Wang wrote: > - remove the cmd id related interface. Now host can just send a free > page hint command to the guest (via the host_cmd config register) > to start the reporting. Here we go again. And what if reporting was already

[virtio-dev] Re: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 12:43:11PM +0800, Wei Wang wrote: > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates the > support of reporting hints of guest free pages to host via virtio-balloon. > > Host requests the guest to report free page hints by sending a command > to the

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Cornelia Huck
On Thu, 14 Jun 2018 18:57:11 -0700 Siwei Liu wrote: > Thank you for sharing your thoughts, Cornelia. With questions below, I > think you raised really good points, some of which I don't have answer > yet and would also like to explore here. > > First off, I don't want to push the discussion to

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-15 Thread Halil Pasic
On 06/11/2018 09:56 AM, Tiwei Bie wrote: Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 --- v2: - Refine the wording (Cornelia); v3: - Refine the wording (MST); content.tex | 7 +++ 1 file changed, 7 insertions(+)

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-15 Thread Halil Pasic
On 06/15/2018 02:19 PM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2018 at 02:10:11PM +0200, Halil Pasic wrote: On 06/11/2018 09:56 AM, Tiwei Bie wrote: Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 --- v2: - Refine

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 02:10:11PM +0200, Halil Pasic wrote: > > > On 06/11/2018 09:56 AM, Tiwei Bie wrote: > > Suggested-by: Michael S. Tsirkin > > Signed-off-by: Tiwei Bie > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 > > --- > > v2: > > - Refine the wording (Cornelia); > >

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-15 Thread Halil Pasic
On 06/15/2018 03:38 PM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2018 at 02:42:58PM +0200, Halil Pasic wrote: On 06/15/2018 02:19 PM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2018 at 02:10:11PM +0200, Halil Pasic wrote: On 06/11/2018 09:56 AM, Tiwei Bie wrote: Suggested-by: Michael

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 02:42:58PM +0200, Halil Pasic wrote: > > > On 06/15/2018 02:19 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 15, 2018 at 02:10:11PM +0200, Halil Pasic wrote: > > > > > > > > > On 06/11/2018 09:56 AM, Tiwei Bie wrote: > > > > Suggested-by: Michael S. Tsirkin > > > >

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-15 Thread Tiwei Bie
On Fri, Jun 15, 2018 at 02:42:58PM +0200, Halil Pasic wrote: > On 06/15/2018 02:19 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 15, 2018 at 02:10:11PM +0200, Halil Pasic wrote: > > > > > > > > > On 06/11/2018 09:56 AM, Tiwei Bie wrote: > > > > Suggested-by: Michael S. Tsirkin > > > >

[virtio-dev] Re: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 02:11:23PM +, Wang, Wei W wrote: > On Friday, June 15, 2018 7:42 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 15, 2018 at 12:43:11PM +0800, Wei Wang wrote: > > > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates > > > the support of reporting hints

[virtio-dev] Re: [PATCH v33 0/4] Virtio-balloon: support free page reporting

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 02:28:49PM +, Wang, Wei W wrote: > On Friday, June 15, 2018 7:30 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 15, 2018 at 12:43:09PM +0800, Wei Wang wrote: > > > - remove the cmd id related interface. Now host can just send a free > > > page hint command

[virtio-dev] RE: [PATCH v33 0/4] Virtio-balloon: support free page reporting

2018-06-15 Thread Wang, Wei W
On Friday, June 15, 2018 7:30 PM, Michael S. Tsirkin wrote: > On Fri, Jun 15, 2018 at 12:43:09PM +0800, Wei Wang wrote: > > - remove the cmd id related interface. Now host can just send a free > > page hint command to the guest (via the host_cmd config register) > > to start

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 04:21:32PM +0200, Halil Pasic wrote: > > > On 06/15/2018 03:39 PM, Tiwei Bie wrote: > > On Fri, Jun 15, 2018 at 02:42:58PM +0200, Halil Pasic wrote: > > > On 06/15/2018 02:19 PM, Michael S. Tsirkin wrote: > > > > On Fri, Jun 15, 2018 at 02:10:11PM +0200, Halil Pasic

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-15 Thread Michael S. Tsirkin
On Fri, Jun 15, 2018 at 05:16:10PM +0200, Halil Pasic wrote: > > > On 06/15/2018 03:38 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 15, 2018 at 02:42:58PM +0200, Halil Pasic wrote: > > > > > > > > > On 06/15/2018 02:19 PM, Michael S. Tsirkin wrote: > > > > On Fri, Jun 15, 2018 at 02:10:11PM

[virtio-dev] RE: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-15 Thread Wang, Wei W
On Friday, June 15, 2018 7:42 PM, Michael S. Tsirkin wrote: > On Fri, Jun 15, 2018 at 12:43:11PM +0800, Wei Wang wrote: > > Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_HINT feature indicates > > the support of reporting hints of guest free pages to host via > > virtio-balloon. > > > > Host

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-15 Thread Halil Pasic
On 06/15/2018 05:36 PM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2018 at 04:21:32PM +0200, Halil Pasic wrote: On 06/15/2018 03:39 PM, Tiwei Bie wrote: On Fri, Jun 15, 2018 at 02:42:58PM +0200, Halil Pasic wrote: On 06/15/2018 02:19 PM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2018 at

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Siwei Liu
On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: > On Thu, 14 Jun 2018 18:57:11 -0700 > Siwei Liu wrote: > >> Thank you for sharing your thoughts, Cornelia. With questions below, I >> think you raised really good points, some of which I don't have answer >> yet and would also like to

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Cornelia Huck
On Fri, 15 Jun 2018 05:34:24 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 14, 2018 at 12:02:31PM +0200, Cornelia Huck wrote: > > > > I am not all that familiar with how Qemu manages network devices. If we > > > > can > > > > do all the > > > > required management of the primary/standby