Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Mon, Oct 14, 2019 at 9:19 PM Gerd Hoffmann wrote: > > > > Well. I think before even discussing the protocol details we need a > > > reasonable plan for buffer handling. I think using virtio-gpu buffers > > > should be an optional optimization and not a requirement. Also the > > > motivation

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Fri, Oct 11, 2019 at 5:54 PM Dmitry Morozov wrote: > > Hi Tomasz, > > On Mittwoch, 9. Oktober 2019 05:55:45 CEST Tomasz Figa wrote: > > On Tue, Oct 8, 2019 at 12:09 AM Dmitry Morozov > > > > wrote: > > > Hi Tomasz, > > > > > > On Montag, 7. Oktober 2019 16:14:13 CEST Tomasz Figa wrote: > > >

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Gerd Hoffmann
Hi, > That said, Chrome OS would use a similar model, except that we don't > use ION. We would likely use minigbm backed by virtio-gpu to allocate > appropriate secure buffers for us and then import them to the V4L2 > driver. What exactly is a "secure buffer"? I guess a gem object where read

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Frank Yang
On Wed, Oct 16, 2019 at 11:58 PM Tomasz Figa wrote: > On Mon, Oct 14, 2019 at 9:19 PM Gerd Hoffmann wrote: > > > > > > Well. I think before even discussing the protocol details we need a > > > > reasonable plan for buffer handling. I think using virtio-gpu > buffers > > > > should be an

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Tue, Oct 15, 2019 at 11:06 PM Dmitry Morozov wrote: > > Hello Gerd, > > On Dienstag, 15. Oktober 2019 09:54:22 CEST Gerd Hoffmann wrote: > > On Mon, Oct 14, 2019 at 03:05:03PM +0200, Dmitry Morozov wrote: > > > On Montag, 14. Oktober 2019 14:34:43 CEST Gerd Hoffmann wrote: > > > > Hi, > > >

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Thu, Oct 17, 2019 at 4:19 PM Gerd Hoffmann wrote: > > Hi, > > > That said, Chrome OS would use a similar model, except that we don't > > use ION. We would likely use minigbm backed by virtio-gpu to allocate > > appropriate secure buffers for us and then import them to the V4L2 > > driver. >

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Thu, Oct 17, 2019 at 4:44 PM Gerd Hoffmann wrote: > > Hi, > > > > Also note that the guest manages the address space, so the host can't > > > simply allocate guest page addresses. > > > > Is this really true? I'm not an expert in this area, but on a bare > > metal system it's the hardware or

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Gerd Hoffmann
Hi, > That could be still a guest physical address. Like on a bare metal > system with TrustZone, there could be physical memory that is not > accessible to the CPU. Hmm. Yes, maybe. We could use the dma address of the (first page of the) guest buffer. In case of a secure buffer the guest

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Gerd Hoffmann
Hi, > > Also note that the guest manages the address space, so the host can't > > simply allocate guest page addresses. > > Is this really true? I'm not an expert in this area, but on a bare > metal system it's the hardware or firmware that sets up the various > physical address allocations on

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Gerd Hoffmann
> > I doubt you can handle pci memory bars like regular ram when it comes to > > dma and iommu support. There is a reason we have p2pdma in the first > > place ... > > The thing is that such bars would be actually backed by regular host > RAM. Do we really need the complexity of real PCI bar

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Frank Yang
On Thu, Oct 17, 2019 at 8:00 AM Frank Yang wrote: > > > On Wed, Oct 16, 2019 at 11:58 PM Tomasz Figa wrote: > >> On Mon, Oct 14, 2019 at 9:19 PM Gerd Hoffmann wrote: >> > >> > > > Well. I think before even discussing the protocol details we need a >> > > > reasonable plan for buffer handling.