Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 11:54:53AM +0800, Liu, Jing2 wrote: > > On 2/11/2020 3:40 PM, Jason Wang wrote: > > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > On 2020/2/11 上午11:35, Liu, Jing2 wrote: > > >

Re: [virtio-dev] Re: [PATCH v2 2/5] virtio-mmio: refactor common functionality

2020-02-11 Thread Liu, Jing2
On 2/11/2020 7:19 PM, Michael S. Tsirkin wrote: On Mon, Feb 10, 2020 at 05:05:18PM +0800, Zha Bin wrote: From: Liu Jiang Common functionality is refactored into virtio_mmio_common.h in order to MSI support in later patch set. Signed-off-by: Liu Jiang Co-developed-by: Zha Bin

[virtio-dev] Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-11 Thread Jason Wang
On 2020/2/11 下午7:33, Michael S. Tsirkin wrote: On Mon, Feb 10, 2020 at 05:05:17PM +0800, Zha Bin wrote: From: Liu Jiang The standard virtio-mmio devices use notification register to signal backend. This will cause vmexits and slow down the performance when we passthrough the virtio-mmio

[virtio-dev] Re: [PATCH v2 3/5] virtio-mmio: create a generic MSI irq domain

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:19PM +0800, Zha Bin wrote: > From: Liu Jiang > > Create a generic irq domain for all architectures which > supports virtio-mmio. The device offering VIRTIO_F_MMIO_MSI > feature bit can use this irq domain. > > Signed-off-by: Liu Jiang > Co-developed-by: Zha Bin >

Re: [virtio-dev] Re: [PATCH v2 2/5] virtio-mmio: refactor common functionality

2020-02-11 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 10:58:13AM +0800, Liu, Jing2 wrote: > > On 2/11/2020 7:19 PM, Michael S. Tsirkin wrote: > > On Mon, Feb 10, 2020 at 05:05:18PM +0800, Zha Bin wrote: > > > From: Liu Jiang > > > > > > Common functionality is refactored into virtio_mmio_common.h > > > in order to MSI

[virtio-dev] Re: [PATCH v2 5/5] x86: virtio-mmio: support virtio-mmio with MSI for x86

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:21PM +0800, Zha Bin wrote: > From: Liu Jiang > > virtio-mmio supports a generic MSI irq domain for all archs. This > patch adds the x86 architecture support. > > Signed-off-by: Liu Jiang > Co-developed-by: Zha Bin > Signed-off-by: Zha Bin > Co-developed-by: Jing

[virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:20PM +0800, Zha Bin wrote: > From: Liu Jiang > > Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using > virtio over mmio devices as a lightweight machine model for modern > cloud. The standard virtio over MMIO transport layer only supports one >

[virtio-dev] Re: [PATCH v2 2/5] virtio-mmio: refactor common functionality

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:18PM +0800, Zha Bin wrote: > From: Liu Jiang > > Common functionality is refactored into virtio_mmio_common.h > in order to MSI support in later patch set. > > Signed-off-by: Liu Jiang > Co-developed-by: Zha Bin > Signed-off-by: Zha Bin > Co-developed-by: Jing

[virtio-dev] Re: [PATCH v2 3/5] virtio-mmio: create a generic MSI irq domain

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:19PM +0800, Zha Bin wrote: > From: Liu Jiang > > Create a generic irq domain for all architectures which > supports virtio-mmio. The device offering VIRTIO_F_MMIO_MSI > feature bit can use this irq domain. > > Signed-off-by: Liu Jiang > Co-developed-by: Zha Bin >

[virtio-dev] Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:17PM +0800, Zha Bin wrote: > From: Liu Jiang > > The standard virtio-mmio devices use notification register to signal > backend. This will cause vmexits and slow down the performance when we > passthrough the virtio-mmio devices to guest virtual machines. > We

[virtio-dev] Re: [PATCH v2 0/5] virtio mmio specification enhancement

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 04:05:41PM +, Chao Peng wrote: > On Mon, Feb 10, 2020 at 06:44:50AM -0500, Michael S. Tsirkin wrote: > > On Mon, Feb 10, 2020 at 05:05:16PM +0800, Zha Bin wrote: > > > We have compared the number of files and the lines of code between > > > virtio-mmio and virio-pci. >

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 11:35:43AM +0800, Liu, Jing2 wrote: > > On 2/11/2020 11:17 AM, Jason Wang wrote: > > > > On 2020/2/10 下午5:05, Zha Bin wrote: > > > From: Liu Jiang > > > > > > Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using > > > virtio over mmio devices as a

[virtio-dev] Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:17PM +0800, Zha Bin wrote: > From: Liu Jiang > > The standard virtio-mmio devices use notification register to signal > backend. This will cause vmexits and slow down the performance when we > passthrough the virtio-mmio devices to guest virtual machines. > We

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > > > > On 2020/2/11 上午11:35, Liu, Jing2 wrote: > > > > > > > > On 2/11/2020 11:17 AM, Jason Wang wrote: > > > > > > > > > > On

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 08:18:54PM +0800, Jason Wang wrote: > > On 2020/2/11 下午8:08, Michael S. Tsirkin wrote: > > On Tue, Feb 11, 2020 at 08:04:24PM +0800, Jason Wang wrote: > > > On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: > > > > On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: >

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Jason Wang
On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: On 2020/2/11 下午2:02, Liu, Jing2 wrote: On 2/11/2020 12:02 PM, Jason Wang wrote: On 2020/2/11 上午11:35, Liu, Jing2 wrote: On 2/11/2020 11:17 AM, Jason Wang wrote: On 2020/2/10 下午5:05,

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Tue, Feb 11, 2020 at 08:04:24PM +0800, Jason Wang wrote: > > On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: > > On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: > > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > > > On 2020/2/11

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Jason Wang
On 2020/2/11 下午8:08, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 08:04:24PM +0800, Jason Wang wrote: On 2020/2/11 下午7:58, Michael S. Tsirkin wrote: On Tue, Feb 11, 2020 at 03:40:23PM +0800, Jason Wang wrote: On 2020/2/11 下午2:02, Liu, Jing2 wrote: On 2/11/2020 12:02 PM, Jason Wang

[virtio-dev] [PATCH v17 QEMU 1/3] virtio-ballon: Implement support for page poison tracking feature

2020-02-11 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison tracking if we want to actually get data on if the guest will be poisoning pages. So if free page hinting is active we should add page poisoning support and let the guest disable it if it isn't using it. Page

[virtio-dev] [PATCH v17 QEMU 4/3 RFC] memory: Add support for MADV_FREE as mechanism to lazy discard pages

2020-02-11 Thread Alexander Duyck
From: Alexander Duyck Add support for the MADV_FREE advice argument when discarding pages. Specifically we add an option to perform a lazy discard for use with free page reporting as this allows us to avoid expensive page zeroing in the case that the system is not under memory pressure. To

[virtio-dev] [PATCH v17 QEMU 2/3] virtio-balloon: Add support for providing free page reports to host

2020-02-11 Thread Alexander Duyck
From: Alexander Duyck Add support for the page reporting feature provided by virtio-balloon. Reporting differs from the regular balloon functionality in that is is much less durable than a standard memory balloon. Instead of creating a list of pages that cannot be accessed the pages are only

[virtio-dev] [PATCH v17 QEMU 3/3] virtio-balloon: Provide a interface for free page reporting

2020-02-11 Thread Alexander Duyck
From: Alexander Duyck Add support for what I am referring to as "free page reporting". Basically the idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic