[virtio-dev] Re: [virtio-comment] Re: [PATCH] Add virtio rpmb device specification

2019-07-30 Thread Michael S. Tsirkin
On Tue, Jul 30, 2019 at 05:51:24AM +, Huang, Yang wrote: > > > +\item The device MUST authenticate write operation by MAC calculated > > > + by authentication key and monotonic write counter . > > > > authenticate how? > > 1. compare the monotonic write counter in RPMB frame with the one

Re: [virtio-dev] [PATCH v5 1/2] content: add virtio file system device

2019-08-03 Thread Michael S. Tsirkin
On Fri, Jul 26, 2019 at 10:53:37AM +0100, Stefan Hajnoczi wrote: > +\subsubsection{Security Considerations}\label{sec:Device Types / File System > Device / Security Considerations} One issue not addressed here at all is sharing the filesystem cache. Is that a security consiteration at all? A

[virtio-dev] Re: [virtio-comment] [PATCH] Add virtio rpmb device specification

2019-08-03 Thread Michael S. Tsirkin
On Tue, Jul 30, 2019 at 12:33:17AM +, Huang, Yang wrote: > > > > -Original Message- > > From: virtio-comm...@lists.oasis-open.org > > [mailto:virtio-comment@lists.oasis- > > open.org] On Behalf Of Paolo Bonzini > > Sent: Monday, July 29, 2019 17:19 > > To: Huang, Yang ;

Re: [virtio-dev] [PATCH v5 1/2] content: add virtio file system device

2019-08-03 Thread Michael S. Tsirkin
On Fri, Jul 26, 2019 at 10:53:37AM +0100, Stefan Hajnoczi wrote: > +\subsubsection{Live migration considerations}\label{sec:Device Types / File > System Device / Live Migration Considerations} > + > +When a guest is migrated to a new host Please use driver and device here and elsewhere. > it is

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] [PATCH] Add virtio rpmb device specification

2019-08-04 Thread Michael S. Tsirkin
On Sun, Aug 04, 2019 at 02:07:49AM +, Huang, Yang wrote: > > > > -Original Message- > > From: virtio-dev@lists.oasis-open.org > > [mailto:virtio-dev@lists.oasis-open.org] > > On Behalf Of Michael S. Tsirkin > > Sent: Sunday, August 4, 2019 5:0

Re: [virtio-dev] [RFC] snd: Add virtio sound device specification

2019-08-18 Thread Michael S. Tsirkin
On Fri, Aug 16, 2019 at 10:26:28PM +0200, Mikhail Golubev wrote: > From: Anton Yakovlev > > The virtio sound device is an extendable virtual audio device. It > provides playback and capture PCM streams to a guest. > > The device is implemented as a collection of a device-specific functions >

[virtio-dev] Re: [PATCH] content: document console vq detach buffer

2019-08-18 Thread Michael S. Tsirkin
On Tue, Aug 13, 2019 at 06:21:33PM +0530, Pankaj Gupta wrote: > This patch documents console special case where vq buffers > are deleted at port hotunplug time. This behavior is different in > other devices where vq buffers are deleted at device unplug time. > > Signed-off-by: Pankaj Gupta > ---

Re: [virtio-dev] [PATCH v5 1/2] content: add virtio file system device

2019-08-13 Thread Michael S. Tsirkin
On Tue, Aug 13, 2019 at 10:07:11AM +0100, Stefan Hajnoczi wrote: > On Sat, Aug 03, 2019 at 05:12:15PM -0400, Michael S. Tsirkin wrote: > > On Fri, Jul 26, 2019 at 10:53:37AM +0100, Stefan Hajnoczi wrote: > > > +\subsubsection{Live migration considerations}\label{sec:Device T

[virtio-dev] Re: [PATCH v5 6/6] virtio-balloon: Add support for providing unused page reports to host

2019-09-03 Thread Michael S. Tsirkin
On Mon, Aug 12, 2019 at 02:33:56PM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > Add support for the page reporting feature provided by virtio-balloon. > Reporting differs from the regular balloon functionality in that is is > much less durable than a standard memory balloon. Instead

[virtio-dev] Re: [PATCH v5 6/6] virtio-balloon: Add support for providing unused page reports to host

2019-09-04 Thread Michael S. Tsirkin
On Tue, Sep 03, 2019 at 07:13:32AM -0700, Alexander Duyck wrote: > On Tue, Sep 3, 2019 at 12:32 AM Michael S. Tsirkin wrote: > > > > On Mon, Aug 12, 2019 at 02:33:56PM -0700, Alexander Duyck wrote: > > > From: Alexander Duyck > > > > > > Add suppo

[virtio-dev] Re: [PATCH v7 6/6] virtio-balloon: Add support for providing unused page reports to host

2019-09-04 Thread Michael S. Tsirkin
On Wed, Sep 04, 2019 at 08:11:02AM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > Add support for the page reporting feature provided by virtio-balloon. > Reporting differs from the regular balloon functionality in that is is > much less durable than a standard memory balloon. Instead

[virtio-dev] Re: [PATCH v7 0/6] mm / virtio: Provide support for unused page reporting

2019-09-04 Thread Michael S. Tsirkin
On Wed, Sep 04, 2019 at 08:10:24AM -0700, Alexander Duyck wrote: > This series provides an asynchronous means of reporting to a hypervisor > that a guest page is no longer in use and can have the data associated > with it dropped. To do this I have implemented functionality that allows > for what

[virtio-dev] Re: [PATCH v7 5/6] virtio-balloon: Pull page poisoning config out of free page hinting

2019-09-04 Thread Michael S. Tsirkin
On Wed, Sep 04, 2019 at 08:10:55AM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > Currently the page poisoning setting wasn't being enabled unless free page > hinting was enabled. However we will need the page poisoning tracking logic > as well for unused page reporting. As such pull

Re: [virtio-dev] Re: [PATCH v9 0/8] stg mail -e --version=v9 \

2019-09-11 Thread Michael S. Tsirkin
On Tue, Sep 10, 2019 at 06:22:37PM +0200, David Hildenbrand wrote: > On 10.09.19 18:18, Dr. David Alan Gilbert wrote: > > * Alexander Duyck (alexander.du...@gmail.com) wrote: > >> On Tue, Sep 10, 2019 at 7:47 AM Michal Hocko wrote: > >>> > >>> On Tue 10-09-19 07:42:43, Alexander Duyck wrote: >

[virtio-dev] Re: [PATCH v9 0/8] stg mail -e --version=v9 \

2019-09-11 Thread Michael S. Tsirkin
On Wed, Sep 11, 2019 at 01:36:19PM +0200, Michal Hocko wrote: > On Tue 10-09-19 14:23:40, Alexander Duyck wrote: > [...] > > We don't put any limitations on the allocator other then that it needs to > > clean up the metadata on allocation, and that it cannot allocate a page > > that is in the

[virtio-dev] Re: [PATCH v8 0/2] virtio-fs: add virtio file system device

2019-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2019 at 05:27:34PM +0200, Stefan Hajnoczi wrote: > On Thu, Aug 29, 2019 at 02:52:04PM +0100, Stefan Hajnoczi wrote: > > v8: > > * Make language about using both FUSE_READ/FUSE_WRITE and the DAX > >Window clearer [Cornelia] > > > > v7: > > * Rename num_queues to

[virtio-dev] Re: [PATCH v8 0/2] virtio-fs: add virtio file system device

2019-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2019 at 05:27:34PM +0200, Stefan Hajnoczi wrote: > On Thu, Aug 29, 2019 at 02:52:04PM +0100, Stefan Hajnoczi wrote: > > v8: > > * Make language about using both FUSE_READ/FUSE_WRITE and the DAX > >Window clearer [Cornelia] > > > > v7: > > * Rename num_queues to

[virtio-dev] Re: [PATCH v10 5/6] virtio-balloon: Pull page poisoning config out of free page hinting

2019-09-18 Thread Michael S. Tsirkin
On Wed, Sep 18, 2019 at 10:53:05AM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > Currently the page poisoning setting wasn't being enabled unless free page > hinting was enabled. However we will need the page poisoning tracking logic > as well for unused page reporting. As such pull

Re: [virtio-dev] [PATCH] content: fix typo in feature bit name

2019-09-08 Thread Michael S. Tsirkin
On Wed, Jul 17, 2019 at 06:59:08AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 17, 2019 at 11:04:26AM +0100, Stefan Hajnoczi wrote: > > On Tue, Jun 11, 2019 at 02:53:04PM +0800, Tiwei Bie wrote: > > > Signed-off-by: Tiwei Bie > > > --- > > > content

Re: [virtio-dev] RE: [PATCH v3] It is a virtio based RPMB (Replay Protected Memory Block) device.

2019-09-08 Thread Michael S. Tsirkin
On Wed, Aug 07, 2019 at 02:36:02AM +, Huang, Yang wrote: > Hi, > I got your points on padding, SHA256, VIRTIO_RPMB_REQ_RESULT_READ etc. > But it cannot keep compatibility with native softwares who also runs on > hardware RPMB. > > Because RPMB frames are packed by other modules who owns

[virtio-dev] Re: [PATCH v8 0/7] mm / virtio: Provide support for unused page reporting

2019-09-06 Thread Michael S. Tsirkin
On Fri, Sep 06, 2019 at 07:53:21AM -0700, Alexander Duyck wrote: > This series provides an asynchronous means of reporting to a hypervisor > that a guest page is no longer in use and can have the data associated > with it dropped. To do this I have implemented functionality that allows > for what

[virtio-dev] Re: [External Email] Re: [PATCH v1 0/2] virtio-mmio: support multiple interrupt vectors

2019-07-30 Thread Michael S. Tsirkin
On Mon, Jul 22, 2019 at 09:43:18PM +0800, 李菲 wrote: > On Mon, Jul 22, 2019 at 4:39 PM Michael S. Tsirkin wrote: > > > > On Mon, Jul 22, 2019 at 11:22:02AM +0800, 李菲 wrote: > > > On Fri, Jul 19, 2019 at 11:14 PM Michael S. Tsirkin > > > wrote: > > > &g

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] [PATCH] Add virtio rpmb device specification

2019-08-04 Thread Michael S. Tsirkin
On Mon, Aug 05, 2019 at 02:39:00AM +, Huang, Yang wrote: > > > > > > > > > On 29/07/19 09:48, Huang Yang wrote: > > > > > > > > > > > > > > > > > > But virtualization software like Qemu doesn't provide > > > > > > > > > eMMC/UFS/NVMe RPMB emulation. It blocks the OS like Trusty > > > > > > >

Re: [virtio-dev] [PATCH v3 0/4] introduce virtio vhost-user backend device type

2019-08-04 Thread Michael S. Tsirkin
On Mon, Aug 05, 2019 at 01:32:14AM +0300, Nikos Dragazis wrote: > On 31/7/19 11:19 μ.μ., Michael S. Tsirkin wrote: > > On Wed, Jul 31, 2019 at 05:49:57PM +0300, Nikos Dragazis wrote: > >> On 21/6/19 11:43 μ.μ., Michael S. Tsirkin wrote: > >>> On Wed, Jun 19, 20

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] [PATCH] Add virtio rpmb device specification

2019-08-05 Thread Michael S. Tsirkin
On Mon, Aug 05, 2019 at 05:45:59AM +, Winkler, Tomas wrote: > > On Sun, Aug 04, 2019 at 01:57:35PM +, Huang, Yang wrote: > > > > > > > > > > -Original Message----- > > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > &g

Re: [virtio-dev] [PATCH v3 0/4] introduce virtio vhost-user backend device type

2019-07-31 Thread Michael S. Tsirkin
On Wed, Jul 31, 2019 at 05:49:57PM +0300, Nikos Dragazis wrote: > On 21/6/19 11:43 μ.μ., Michael S. Tsirkin wrote: > > On Wed, Jun 19, 2019 at 03:54:30PM +0100, Stefan Hajnoczi wrote: > >> On Sat, May 11, 2019 at 09:47:36PM +0300, Nikos Dragazis wrote: > >>> Hi ev

[virtio-dev] reserving virtio device IDs (was Re: [virtio] [PATCH] Reserve id for virtio-audio device)

2019-07-29 Thread Michael S. Tsirkin
On Tue, Mar 26, 2019 at 10:41:06AM +0100, Paolo Bonzini wrote: > From: Paolo Bonzini > > Project ACRN has a virtio-audio device. Unfortunately, the id they are using > is > already reserved in the virtio specification, but it is nevertheless useful to > have one. > > Signed-off-by: Paolo

Re: [virtio-dev] [PATCH v2] Add virtio rpmb device specification

2019-08-01 Thread Michael S. Tsirkin
On Wed, Jul 31, 2019 at 02:41:56PM +, Huang, Yang wrote: > > > > > --- > > > conformance.tex | 19 ++- > > > content.tex | 3 ++ > > > virtio-rpmb.tex | 100 > > > > > > 3 files changed, 121 insertions(+), 1 deletion(-)

[virtio-dev] Re: [PATCH v3] It is a virtio based RPMB (Replay Protected Memory Block) device.

2019-08-06 Thread Michael S. Tsirkin
On Tue, Aug 06, 2019 at 12:04:16PM +0800, Huang Yang wrote: > Signed-off-by: Yang Huang > Reviewed-by: Bing Zhu > Reviewed-by: Tomas Winkler > > v2 -> v3: > 1. Remove conformance changes temporarily >since the draft requires reviews and updates at this phase. > 2. Add eMMC, UFS and NVMe as

[virtio-dev] Re: [virtio-comment] RE: [virtio-dev] Re: [virtio-comment] [PATCH] Add virtio rpmb device specification

2019-08-04 Thread Michael S. Tsirkin
On Sun, Aug 04, 2019 at 01:57:35PM +, Huang, Yang wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Sunday, August 4, 2019 15:49 > > To: Huang, Yang > > Cc: Paolo Bonzini ; virtio-dev@l

[virtio-dev] Re: [RFC] content: explicitly document the VLAN filtering as best-effort

2019-07-18 Thread Michael S. Tsirkin
tions behave. > > Signed-off-by: Tiwei Bie fine by me. Acked-by: Michael S. Tsirkin > --- > This is a RFC for now (Comments would be appreciated!). > More details can be found here: > https://patchwork.ozlabs.org/patch/1113538/ > > content.tex | 5 + > 1 file c

Re: [virtio-dev] [PATCH] content: fix typo in feature bit name

2019-07-17 Thread Michael S. Tsirkin
On Wed, Jul 17, 2019 at 11:04:26AM +0100, Stefan Hajnoczi wrote: > On Tue, Jun 11, 2019 at 02:53:04PM +0800, Tiwei Bie wrote: > > Signed-off-by: Tiwei Bie > > --- > > content.tex | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/content.tex b/content.tex > > index

[virtio-dev] Re: [PATCH v5 2/2] virtio-fs: add DAX window

2019-07-26 Thread Michael S. Tsirkin
On Fri, Jul 26, 2019 at 10:53:38AM +0100, Stefan Hajnoczi wrote: > Describe how shared memory region ID 0 is the DAX window and how > FUSE_SETUPMAPPING maps file ranges into the window. > > Signed-off-by: Stefan Hajnoczi > --- Are there any security considerations with this memory sharing? If

[virtio-dev] Re: [PATCH v5 0/2] virtio-fs: add virtio file system device

2019-07-26 Thread Michael S. Tsirkin
Didn't look at the spec yet, but I have a question: On Fri, Jul 26, 2019 at 10:53:36AM +0100, Stefan Hajnoczi wrote: > v5: > * Explain multiqueue semantics: no ordering, identical functionality on each > queue, one FUSE session state shared between all queues > * Explain how the FUSE session

[virtio-dev] Re: [PATCH v10 3/6] mm: Introduce Reported pages

2019-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2019 at 05:47:24PM +0200, David Hildenbrand wrote: > On 23.09.19 17:45, David Hildenbrand wrote: > > On 23.09.19 17:37, Michael S. Tsirkin wrote: > >> On Mon, Sep 23, 2019 at 08:28:00AM -0700, Alexander Duyck wrote: > >>> On Mon, Sep 23, 2019

[virtio-dev] Re: [PATCH v10 3/6] mm: Introduce Reported pages

2019-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2019 at 07:50:15AM -0700, Alexander Duyck wrote: > > > +static inline void > > > +page_reporting_reset_boundary(struct zone *zone, unsigned int order, int > > > mt) > > > +{ > > > + int index; > > > + > > > + if (order < PAGE_REPORTING_MIN_ORDER) > > > +

[virtio-dev] Re: [PATCH v10 3/6] mm: Introduce Reported pages

2019-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2019 at 05:45:29PM +0200, David Hildenbrand wrote: > On 23.09.19 17:37, Michael S. Tsirkin wrote: > > On Mon, Sep 23, 2019 at 08:28:00AM -0700, Alexander Duyck wrote: > >> On Mon, Sep 23, 2019 at 8:00 AM Michael S. Tsirkin wrote: > >>> > >&

[virtio-dev] Re: [PATCH v10 3/6] mm: Introduce Reported pages

2019-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2019 at 08:28:00AM -0700, Alexander Duyck wrote: > On Mon, Sep 23, 2019 at 8:00 AM Michael S. Tsirkin wrote: > > > > On Mon, Sep 23, 2019 at 07:50:15AM -0700, Alexander Duyck wrote: > > > > > +static inline void > > > > > +page_reporti

[virtio-dev] Re: [PATCH v5] Add virtio rpmb device specification

2019-09-24 Thread Michael S. Tsirkin
On Tue, Sep 24, 2019 at 11:48:13AM +0800, Huang Yang wrote: > It is a virtio based RPMB (Replay Protected Memory Block) device. > > Signed-off-by: Yang Huang > Reviewed-by: Bing Zhu > Reviewed-by: Tomas Winkler > > v4 -> v5: > 1. Add description on the mapping between block_count and virtio

[virtio-dev] Re: [PATCH v11 0/6] mm / virtio: Provide support for unused page reporting

2019-10-01 Thread Michael S. Tsirkin
On Tue, Oct 01, 2019 at 09:21:46AM -0700, Alexander Duyck wrote: > I thought what Michal was asking for was what was the benefit of using the > boundary pointer. I added a bit up above and to the description for patch > 3 as on a 32G VM it adds up to about a 18% difference without factoring in >

[virtio-dev] Re: presentation at kvm forum and pagefaults

2019-10-31 Thread Michael S. Tsirkin
Regarding the presentation I gave at the kvm forum on pagefaults. Two points: 1. pagefaults are important not just for migration. They are important for performance features such as autonuma and huge pages, since this relies on moving pages around. Migration can maybe be solved by switch to

[virtio-dev] [PATCH] content: document speed, dupex

2019-11-01 Thread Michael S. Tsirkin
Document as used by Linux. Signed-off-by: Michael S. Tsirkin --- content.tex | 25 + 1 file changed, 25 insertions(+) diff --git a/content.tex b/content.tex index bff80d0..e89ae44 100644 --- a/content.tex +++ b/content.tex @@ -2951,12 +2951,29 @@ \subsection{Device

[virtio-dev] Re: presentation at kvm forum and pagefaults

2019-11-01 Thread Michael S. Tsirkin
On Fri, Nov 01, 2019 at 12:07:01AM -0400, Michael S. Tsirkin wrote: > Regarding the presentation I gave at the kvm forum > on pagefaults. > > Two points: > > > 1. pagefaults are important not just for migration. > They are important for performance features such as &

[virtio-dev] [PATCH] content: document speed, duplex

2019-11-17 Thread Michael S. Tsirkin
Document as used by Linux. Signed-off-by: Michael S. Tsirkin --- content.tex | 25 + 1 file changed, 25 insertions(+) diff --git a/content.tex b/content.tex index bff80d0..e89ae44 100644 --- a/content.tex +++ b/content.tex @@ -2951,12 +2951,29 @@ \subsection{Device

[virtio-dev] Re: [RFC 00/13] virtio-iommu on non-devicetree platforms

2019-11-22 Thread Michael S. Tsirkin
On Fri, Nov 22, 2019 at 11:49:47AM +0100, Jean-Philippe Brucker wrote: > I'm seeking feedback on multi-platform support for virtio-iommu. At the > moment only devicetree (DT) is supported and we don't have a pleasant > solution for other platforms. Once we figure out the topology > description,

[virtio-dev] [PATCH v3] content: document speed, duplex

2019-12-03 Thread Michael S. Tsirkin
Document as used by Linux. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/59 Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck --- changes from v2: fix up units actually there's no way for driver to know that link up changed: it might have changed

[virtio-dev] [PATCH v2] README.md: document use of virtio-dev

2019-12-02 Thread Michael S. Tsirkin
People still seem to be confused which list is for what. Add a bit more text. Signed-off-by: Michael S. Tsirkin --- Changes from v1: - wording changes to address Cornelia's comments - move to near virtio-comment description README.md | 11 +++ 1 file changed, 11

Re: [virtio-dev] virtio-spec: Clarify /wrt maintaining a split-queue descriptors

2019-10-27 Thread Michael S. Tsirkin
On Sat, Oct 12, 2019 at 09:20:02AM +0200, Jan Kiszka wrote: > Hi all, > > I'm wondering if the spec is clear enough regarding who is in charge of > setting fields in a descriptor of split virtqueues. Background: I just > made the mistake in an experimental backend of writing back the number > of

Re: [virtio-dev] [PATCH v6] Add virtio rpmb device specification

2019-10-27 Thread Michael S. Tsirkin
On Wed, Oct 09, 2019 at 10:36:51AM +0800, Huang Yang wrote: > It is a virtio based RPMB (Replay Protected Memory Block) device. > > Signed-off-by: Yang Huang > Reviewed-by: Bing Zhu > Reviewed-by: Tomas Winkler > > v5 -> v6: > 1. Remove UFS reference, keep eMMC as the only one. > 2. Update

Re: [virtio-dev] [PATCH v6] Add virtio rpmb device specification

2019-10-27 Thread Michael S. Tsirkin
On Wed, Oct 09, 2019 at 10:36:51AM +0800, Huang Yang wrote: > It is a virtio based RPMB (Replay Protected Memory Block) device. > > Signed-off-by: Yang Huang > Reviewed-by: Bing Zhu > Reviewed-by: Tomas Winkler > > v5 -> v6: > 1. Remove UFS reference, keep eMMC as the only one. > 2. Update

[virtio-dev] [PATCH] README.md: document the minor cleanups standing rule

2019-10-27 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- README.md | 15 +++ 1 file changed, 15 insertions(+) diff --git a/README.md b/README.md index 8f11936..ffafb9b 100644 --- a/README.md +++ b/README.md @@ -141,6 +141,21 @@ Fixes: https://github.com/oasis-tcs/virtio-spec/issues/NNN Please make

Re: [virtio-dev] [PATCH] virtio-mmio: Rename remaining QueueAvail/Used references

2019-10-27 Thread Michael S. Tsirkin
On Mon, Oct 14, 2019 at 10:49:53AM +0200, Jan Kiszka wrote: > On 14.10.19 10:45, Stefan Hajnoczi wrote: > > On Sun, Oct 06, 2019 at 06:41:32PM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> These have been changed in ae98c6bc21bc. Convert the rest. > >> > >> Signed-off-by: Jan Kiszka >

Re: [virtio-dev] virtio-console: initial size retrieval, port parameter reporting

2019-10-27 Thread Michael S. Tsirkin
On Sun, Oct 13, 2019 at 07:48:09PM +0200, Jan Kiszka wrote: > Hi all, > > while implementing a basic virtio-console backend, I noticed some grey > area regarding when and how the initial console size should be read by > the driver. > > Linux currently only does that sizing when the device

Re: [virtio-dev] [PATCH] Console Device: Add a missing word

2019-10-27 Thread Michael S. Tsirkin
On Wed, Oct 16, 2019 at 03:23:04PM +0100, Stefan Hajnoczi wrote: > On Mon, Oct 14, 2019 at 03:18:23PM +0200, Jan Kiszka wrote: > > On 14.10.19 12:14, Stefan Hajnoczi wrote: > > > On Sat, Oct 12, 2019 at 09:09:16AM +0200, Jan Kiszka wrote: > > >> From: Jan Kiszka > > >> > > >> Signed-off-by: Jan

[virtio-dev] [PATCH] content: add vendor specific cfg type

2019-10-28 Thread Michael S. Tsirkin
Vendors might want to add their own capability in the PCI capability list. However, Virtio already uses the vendor specific capability ID (0x09) for its own purposes. Provide a structure for vendor specific extensions. Signed-off-by: Michael S. Tsirkin --- content.tex | 80

[virtio-dev] [PATCH] pci: strengthen requirement of the correct subsystem id

2019-10-28 Thread Michael S. Tsirkin
If a hardware implementation of virtio does not have the correct subsystem id, then drivers can't report ir properly, or detect and work around bugs. Change the requirement from MAY to SHOULD. We can't make it a MUST since we did not require this historically. Signed-off-by: Michael S. Tsirkin

Re: [virtio-dev] Virtio device specific MSIX arming

2019-10-24 Thread Michael S. Tsirkin
On Thu, Oct 24, 2019 at 11:22:16AM +, Shahaf Shuler wrote: > Hi, > > > > Below question mainly raise when looking on the ways to have vDPA > implementation of virtio-net device. > > > > One complexity we encounter is with the MSIX relay between the device and the > guest. > > Reading

[virtio-dev] [PATCH v2] content: document speed, duplex

2019-11-19 Thread Michael S. Tsirkin
Document as used by Linux. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/59 Signed-off-by: Michael S. Tsirkin --- content.tex | 26 ++ 1 file changed, 26 insertions(+) diff --git a/content.tex b/content.tex index bff80d0..f6e09bd 100644 --- a/content.tex +++ b

Re: [virtio-dev] [PATCH] content: add vendor specific cfg type

2019-11-25 Thread Michael S. Tsirkin
On Mon, Nov 25, 2019 at 08:45:52AM +0100, Jan Kiszka wrote: > On 28.10.19 11:55, Michael S. Tsirkin wrote: > > Vendors might want to add their own capability > > in the PCI capability list. However, Virtio already > > uses the vendor specific capability ID (0x09) > > for

[virtio-dev] Re: [virtio] Re: [virtio-dev] [PATCH] content: add vendor specific cfg type

2019-11-27 Thread Michael S. Tsirkin
On Wed, Nov 27, 2019 at 08:59:56AM +0100, Cornelia Huck wrote: > On Mon, 25 Nov 2019 03:11:43 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 25, 2019 at 08:45:52AM +0100, Jan Kiszka wrote: > > > On 28.10.19 11:55, Michael S. Tsirkin wrote: > >

[virtio-dev] Re: [virtio] Re: [virtio-dev] [PATCH] content: add vendor specific cfg type

2019-11-27 Thread Michael S. Tsirkin
On Wed, Nov 27, 2019 at 05:59:03AM -0500, Michael S. Tsirkin wrote: > On Wed, Nov 27, 2019 at 08:59:56AM +0100, Cornelia Huck wrote: > > On Mon, 25 Nov 2019 03:11:43 -0500 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Nov 25, 2019 at 08:45:52AM +0100,

[virtio-dev] [PATCH] content: document speed, duplex

2019-11-27 Thread Michael S. Tsirkin
Document as used by Linux. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/59 Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck --- content.tex | 33 + 1 file changed, 33 insertions(+) diff --git a/content.tex b/content.tex index 9157717

Re: [virtio-dev] Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id

2019-11-27 Thread Michael S. Tsirkin
On Mon, Nov 25, 2019 at 11:14:20AM +0100, Cornelia Huck wrote: > On Mon, 25 Nov 2019 03:22:13 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 25, 2019 at 07:41:09AM +0100, Jan Kiszka wrote: > > > On 28.10.19 17:12, Michael S. Tsirkin wrote: > > &g

[virtio-dev] Re: [virtio-comment] [PATCH] content: document speed, duplex

2019-11-27 Thread Michael S. Tsirkin
gt; > Currently there are also link up\down notifications. Should we add something > like: > “The driver should re-read the speed and duplex configuration after receiving > link up notification”. > What do you think? > > Best regards, > Yan. > > > On 27 Nov 2019, at 3:07

[virtio-dev] [PATCH] virtio_pci_cap64: bar/BAR cleanups

2019-11-27 Thread Michael S. Tsirkin
When we mean PCI register we should say BAR. When we mean a virtio config register we should say \field{cap.bar}. Finally, offset_hi/length_hi are not within the cap structure. Reported-by: Christophe de Dinechin Signed-off-by: Michael S. Tsirkin --- content.tex | 8 1 file changed

[virtio-dev] [PATCH v2] virtio_pci_cap64: bar/BAR cleanups

2019-11-27 Thread Michael S. Tsirkin
in Signed-off-by: Michael S. Tsirkin --- changes from v1: minor wording tweak content.tex | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/content.tex b/content.tex index f808c61..a7f4f27 100644 --- a/content.tex +++ b/content.tex @@ -765,7 +765,7 @@ \subsect

[virtio-dev] Re: [virtio-comment] [PATCH] content: add vendor specific cfg type

2019-11-27 Thread Michael S. Tsirkin
On Wed, Nov 27, 2019 at 03:54:17PM +0100, Christophe de Dinechin wrote: > > > > On 28 Oct 2019, at 11:55, Michael S. Tsirkin wrote: > > > > Vendors might want to add their own capability > > in the PCI capability list. However, Virtio already > > uses the

Re: [virtio-dev] [PATCH] virtio-gpu: add 3d command overview

2019-12-02 Thread Michael S. Tsirkin
On Fri, Nov 29, 2019 at 09:31:30AM +0100, Gerd Hoffmann wrote: > Add 3d commands to the command enumeration. > Add a section with a very short overview. > > Signed-off-by: Gerd Hoffmann Pls don't forget to create github issues and request voting when you are ready. > --- > virtio-gpu.tex | 35

[virtio-dev] [PATCH] README.md: document use of virtio-dev

2019-12-02 Thread Michael S. Tsirkin
People still seem to be confused which list is for what. Add a bit more text. Signed-off-by: Michael S. Tsirkin --- README.md | 11 +++ 1 file changed, 11 insertions(+) diff --git a/README.md b/README.md index ffafb9b..1b72dc3 100644 --- a/README.md +++ b/README.md @@ -157,6 +157,17

[virtio-dev] [PATCH] README.md: document use of virtio-dev

2019-12-02 Thread Michael S. Tsirkin
People still seem to be confused which list is for what. Add a bit more text. Signed-off-by: Michael S. Tsirkin --- README.md | 11 +++ 1 file changed, 11 insertions(+) diff --git a/README.md b/README.md index ffafb9b..1b72dc3 100644 --- a/README.md +++ b/README.md @@ -157,6 +157,17

Re: [virtio-dev] [PATCH] virtio-gpu: some edid clarifications

2019-12-02 Thread Michael S. Tsirkin
On Thu, Nov 28, 2019 at 12:42:43PM +0100, Gerd Hoffmann wrote: > Add some notes about fetching the EDID information. > > Signed-off-by: Gerd Hoffmann As a minor nit, it is preferable to send spec patches on virtio-comment. virtio-dev is for code patches (implementation development). > --- >

Re: [virtio-dev] [PATCH RESEND v4 1/1] Add virtio-iommu device specification

2019-11-20 Thread Michael S. Tsirkin
On Wed, Nov 20, 2019 at 06:44:51PM +0100, Jean-Philippe Brucker wrote: > On Wed, Nov 20, 2019 at 06:27:34PM +0100, Cornelia Huck wrote: > > > +\begin{lstlisting} > > > +struct virtio_iommu_config { > > > + le64 page_size_mask; > > > + struct virtio_iommu_range_64 { > > > +le64 start; > > > +

[virtio-dev] Re: [RFC 13/13] iommu/virtio: Add topology description to

2019-11-22 Thread Michael S. Tsirkin
On Fri, Nov 22, 2019 at 11:50:00AM +0100, Jean-Philippe Brucker wrote: > Some hypervisors don't implement either device-tree or ACPI, but still > need a method to describe the IOMMU topology. Read the virtio-iommu > config early and parse the topology description. Hook into the > dma_setup()

[virtio-dev] Re: [PATCH] content: add vendor specific cfg type

2019-11-24 Thread Michael S. Tsirkin
On Mon, Oct 28, 2019 at 06:55:42AM -0400, Michael S. Tsirkin wrote: > Vendors might want to add their own capability > in the PCI capability list. However, Virtio already > uses the vendor specific capability ID (0x09) > for its own purposes. > > Provide a structure for vendor s

[virtio-dev] [PATCH] virtio-rng: fix device/driver confusion

2019-11-24 Thread Michael S. Tsirkin
-by: Michael S. Tsirkin --- content.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content.tex b/content.tex index 678afbe..72e832e 100644 --- a/content.tex +++ b/content.tex @@ -4721,7 +4721,7 @@ \subsection{Device Operation}\label{sec:Device Types / Entropy Device

[virtio-dev] [PATCH v3] content: document speed, duplex

2019-11-24 Thread Michael S. Tsirkin
Document as used by Linux. Fixes: https://github.com/oasis-tcs/virtio-spec/issues/59 Signed-off-by: Michael S. Tsirkin --- changes from v2 - address comments by Cornelia - fix more typos - consistent upper/lower case for hex values - explicitly ask that devices use 0x for unknown speed

[virtio-dev] Re: [virtio] [PATCH] pci: strengthen requirement of the correct subsystem id

2019-11-24 Thread Michael S. Tsirkin
On Mon, Oct 28, 2019 at 12:12:49PM -0400, Michael S. Tsirkin wrote: > If a hardware implementation of virtio does not have > the correct subsystem id, then drivers can't report > ir properly, or detect and work around bugs. > Change the requirement from MAY to SHOULD. > > We ca

[virtio-dev] Re: [PATCH v10 3/6] mm: Introduce Reported pages

2019-09-23 Thread Michael S. Tsirkin
On Wed, Sep 18, 2019 at 10:52:49AM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > In order to pave the way for free page reporting in virtualized > environments we will need a way to get pages out of the free lists and > identify those pages after they have been returned. To

[virtio-dev] [PATCH] README.md: clean up build instructions

2019-09-25 Thread Michael S. Tsirkin
Switch to from manual formatting with and . Clarify wording a bit. Add hints on what to do in case of missing fonts. Signed-off-by: Michael S. Tsirkin --- README.md | 56 --- 1 file changed, 37 insertions(+), 19 deletions(-) diff --git

Re: [virtio-dev] [PATCH v8 2/2] virtio-fs: add DAX window

2019-09-25 Thread Michael S. Tsirkin
On Tue, Sep 10, 2019 at 03:31:45PM +0100, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.ibm.com) wrote: > > On Tue, 10 Sep 2019 14:09:20 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Halil Pasic (pa...@linux.ibm.com) wrote: > > > > On Thu, 29 Aug 2019 14:52:06 +0100 > > > >

[virtio-dev] Re: [PATCH v5] Add virtio rpmb device specification

2019-09-25 Thread Michael S. Tsirkin
On Wed, Sep 25, 2019 at 02:57:00AM +, Huang, Yang wrote: > > > > v4 -> v5: > > > 1. Add description on the mapping between block_count and virtio buffers. > > > 2. Update "Driver Requirements: Device Operation". > > > > > > v3 -> v4: > > > 1. Remove multiple RPMB targets. > > > 2. Remove NVMe

[virtio-dev] [PATCH v2] README.md: clean up build instructions

2019-09-25 Thread Michael S. Tsirkin
Switch to from manual formatting with and . Clarify wording a bit. Add hints on what to do in case of missing fonts. Signed-off-by: Michael S. Tsirkin --- changes from v1: - drop TeX link as it's confusing (you want TeX live) - MacTex-> MacTeX README.md |

Re: [virtio-dev] [PATCH] Fix ^= in example code

2019-10-12 Thread Michael S. Tsirkin
On Fri, Oct 11, 2019 at 01:43:41PM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Trying to escaping ^ here only leaves the backslash in the output. > > Signed-off-by: Jan Kiszka Thanks! I think this kind of typo can be merged with no need for votes, we have a standing rule for typos. > ---

[virtio-dev] Re: [PATCH] pci: use msix_config instead of config_msix_vector

2019-10-11 Thread Michael S. Tsirkin
On Fri, Oct 11, 2019 at 10:42:03AM +0100, Stefan Hajnoczi wrote: > The struct virtio_pci_common_cfg field is called msix_config but the > text refers to this field as config_msix_vector. This is confusing. > > Rename config_msix_vector to msix_config. Although config_msix_vector > is arguably a

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-11 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 11:54:53AM +0800, Liu, Jing2 wrote: > > On 2/11/2020 3:40 PM, Jason Wang wrote: > > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > On 2020/2/11 上午11:35, Liu, Jing2 wrote: > > >

[virtio-dev] Re: [PATCH v2 3/5] virtio-mmio: create a generic MSI irq domain

2020-02-11 Thread Michael S. Tsirkin
On Mon, Feb 10, 2020 at 05:05:19PM +0800, Zha Bin wrote: > From: Liu Jiang > > Create a generic irq domain for all architectures which > supports virtio-mmio. The device offering VIRTIO_F_MMIO_MSI > feature bit can use this irq domain. > > Signed-off-by: Liu Jiang > Co-developed-by: Zha Bin >

Re: [virtio-dev] Re: [PATCH v2 2/5] virtio-mmio: refactor common functionality

2020-02-11 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 10:58:13AM +0800, Liu, Jing2 wrote: > > On 2/11/2020 7:19 PM, Michael S. Tsirkin wrote: > > On Mon, Feb 10, 2020 at 05:05:18PM +0800, Zha Bin wrote: > > > From: Liu Jiang > > > > > > Common functionality is refactored into vir

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 05:06:52PM +0800, Jason Wang wrote: > > On 2020/2/12 上午11:54, Liu, Jing2 wrote: > > > > > > On 2/11/2020 3:40 PM, Jason Wang wrote: > > > > > > On 2020/2/11 下午2:02, Liu, Jing2 wrote: > > > > > > > > > > > > On 2/11/2020 12:02 PM, Jason Wang wrote: > > > > > > > > > >

[virtio-dev] Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 05:33:06PM +0800, Jason Wang wrote: > > On 2020/2/12 下午4:53, Jason Wang wrote: > > > > On 2020/2/12 下午4:18, Michael S. Tsirkin wrote: > > > On Wed, Feb 12, 2020 at 11:39:54AM +0800, Jason Wang wrote: > > > > On 2020/2/11 下午7:33, Mic

[virtio-dev] Re: [PATCH v2 1/5] virtio-mmio: add notify feature for per-queue

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 11:39:54AM +0800, Jason Wang wrote: > > On 2020/2/11 下午7:33, Michael S. Tsirkin wrote: > > On Mon, Feb 10, 2020 at 05:05:17PM +0800, Zha Bin wrote: > > > From: Liu Jiang > > > > > > The standard virtio-mmio devices use notifi

Re: [virtio-dev] Re: [PATCH v2 4/5] virtio-mmio: add MSI interrupt feature support

2020-02-12 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 05:03:00PM +0800, Jason Wang wrote: > > On 2020/2/11 下午10:00, Michael S. Tsirkin wrote: > > > Yes, it can work but it may bring extra effort when you want to mask a > > > vector which is was shared by a lot of queues. > > > > > >

[virtio-dev] Re: [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-01 Thread Michael S. Tsirkin
On Sun, Mar 01, 2020 at 04:33:01PM +0200, Yuri Benditovich wrote: > RSS (Receive-side scaling) defines hash calculation > rules and decision on receive virtqueue according to > the calculated hash, provided mask to apply and > provided indirection table containing indices of > receive virqueues.

[virtio-dev] Re: [PATCH v3 1/3] virtio-net: Introduce extended RSC feature

2020-03-01 Thread Michael S. Tsirkin
On Sun, Mar 01, 2020 at 04:33:00PM +0200, Yuri Benditovich wrote: > VIRTIO_NET_F_RSC_EXT feature bit indicates that the device > is able to provide extended RSC information. When the feature > is negotiatede and 'gso_type' field in received packet is not > GSO_NONE, the device reports number of

[virtio-dev] Re: [PATCH v3 0/3] virtio-net: introduce features defined in the spec

2020-03-01 Thread Michael S. Tsirkin
On Sun, Mar 01, 2020 at 04:32:59PM +0200, Yuri Benditovich wrote: > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT, > VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT. > > Changes from v2: reformatted structure in patch 1 Looks good but I cound a couple more nits. Sorry I missed

[virtio-dev] Re: [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-02 Thread Michael S. Tsirkin
On Mon, Mar 02, 2020 at 10:53:14AM +0200, Yuri Benditovich wrote: > On Sun, Mar 1, 2020 at 9:58 PM Michael S. Tsirkin wrote: > > > > On Sun, Mar 01, 2020 at 04:33:01PM +0200, Yuri Benditovich wrote: > > > RSS (Receive-side scaling) defines hash calculation > > &

Re: [virtio-dev] [PATCH] split-ring: Demand that a device must not change descriptor entries

2020-03-02 Thread Michael S. Tsirkin
On Mon, Mar 02, 2020 at 07:01:37AM -0500, Rob Miller wrote: > In reviewing my comments, I agree that I misunderstood what was being > requested. Please ignore my comments and continue as needed. OK then. Jan should we start the vote?

[virtio-dev] Re: [PATCH v3 2/3] virtio-net: Introduce RSS receive steering feature

2020-03-02 Thread Michael S. Tsirkin
oes not have an indentation. OK then, sorry about the noise. > On Mon, Mar 2, 2020 at 12:54 PM Michael S. Tsirkin wrote: > > > > On Mon, Mar 02, 2020 at 10:53:14AM +0200, Yuri Benditovich wrote: > > > On Sun, Mar 1, 2020 at 9:58 PM Michael S. Tsirkin wrote: > > > > > &

Re: [virtio-dev] [PATCH] split-ring: Demand that a device must not change descriptor entries

2020-02-27 Thread Michael S. Tsirkin
On Mon, Nov 11, 2019 at 06:26:58PM +0100, Jan Kiszka wrote: > On 11.11.19 18:17, Rob Miller wrote: > > what is trying to be solved here? There is a reason why this is allowed > > as some vendors update the table when using RX_MERABLE_BUFFERs & > > F_IN_ORDER features > > OK, good to know. Which

Re: [virtio-dev] Re: [PATCH] virtio-gpu: some edid clarifications

2020-02-27 Thread Michael S. Tsirkin
On Tue, Dec 03, 2019 at 10:35:10AM +0100, Gerd Hoffmann wrote: > On Thu, Nov 28, 2019 at 12:42:43PM +0100, Gerd Hoffmann wrote: > > Add some notes about fetching the EDID information. > > https://github.com/oasis-tcs/virtio-spec/issues/64 > > cheers, > Gerd I pushed it now but it all needed

Re: [virtio-dev] [PATCH] split-ring: Demand that a device must not change descriptor entries

2020-01-30 Thread Michael S. Tsirkin
On Mon, Nov 11, 2019 at 12:17:51PM -0500, Rob Miller wrote: > On Mon, Nov 11, 2019 at 12:13 PM Jan Kiszka wrote: > > From: Jan Kiszka > > So far the spec only indirectly says that a descriptor table entry is > not modified by a device when processing it. Make this explicit by >

  1   2   3   4   5   6   7   8   9   10   >