[virtio-dev] Re: guest / host buffer sharing ...

2019-11-09 Thread Tomasz Figa
On Sat, Nov 9, 2019 at 9:08 PM Stefan Hajnoczi wrote: > > On Sat, Nov 9, 2019 at 12:17 PM Tomasz Figa wrote: > > On Sat, Nov 9, 2019 at 7:12 PM Stefan Hajnoczi wrote: > > > On Sat, Nov 9, 2019 at 2:41 AM Stéphane Marchesin > > > wrote: > > > > On Th

[virtio-dev] Re: guest / host buffer sharing ...

2019-11-09 Thread Tomasz Figa
On Sat, Nov 9, 2019 at 7:12 PM Stefan Hajnoczi wrote: > > On Sat, Nov 9, 2019 at 2:41 AM Stéphane Marchesin > wrote: > > > > On Thu, Nov 7, 2019 at 11:35 PM Stefan Hajnoczi wrote: > > > > > > On Fri, Nov 8, 2019 at 8:22 AM Gerd Hoffmann wrote: > > > > > > Adding a list of common properties to

Re: [virtio-dev] [RFC RESEND] virtio-video: Add virtio video device specification

2019-11-07 Thread Tomasz Figa
On Thu, Nov 7, 2019 at 10:09 PM Dmitry Sepp wrote: > > Hello Gerd, > > Thank you for your feedback. > > There is no relationship between those. As I mentioned earlier. we have also > been working on a virtio video device at the same time. And there is no > relationship between the two specs. > >

Re: [virtio-dev] [RFC RESEND] virtio-video: Add virtio video device specification

2019-11-07 Thread Tomasz Figa
On Fri, Nov 8, 2019 at 4:50 PM Gerd Hoffmann wrote: > > On Thu, Nov 07, 2019 at 02:09:34PM +0100, Dmitry Sepp wrote: > > Hello Gerd, > > > > Thank you for your feedback. > > > > There is no relationship between those. As I mentioned earlier. we have also > > been working on a virtio video device

[virtio-dev] Re: guest / host buffer sharing ...

2019-11-20 Thread Tomasz Figa
On Thu, Nov 21, 2019 at 6:41 AM Geoffrey McRae wrote: > > > > On 2019-11-20 23:13, Tomasz Figa wrote: > > Hi Geoffrey, > > > > On Thu, Nov 7, 2019 at 7:28 AM Geoffrey McRae > > wrote: > >> > >> > >> > >> On 2019-11-06 23:

Re: [virtio-dev] [RFC RESEND] virtio-video: Add virtio video device specification

2019-12-17 Thread Tomasz Figa
On Mon, Dec 16, 2019 at 7:32 PM Gerd Hoffmann wrote: > > Hi, > > > > Hmm, modern GPUs support both encoding and decoding ... > > > > Many SoC architectures have completely separate IP blocks for encoding > > and decoding. Similarly, in GPUs those are usually completely separate > > parts of the

Re: [virtio-dev] [RFC RESEND] virtio-video: Add virtio video device specification

2019-12-16 Thread Tomasz Figa
On Wed, Dec 4, 2019 at 6:16 PM Gerd Hoffmann wrote: > > Hi, > > > 1. Focus on only decoder/encoder functionalities first. > > > > As Tomasz said earlier in this thread, it'd be too complicated to support > > camera > > usage at the same time. So, I'd suggest to make it just a generic

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Mon, Oct 14, 2019 at 9:19 PM Gerd Hoffmann wrote: > > > > Well. I think before even discussing the protocol details we need a > > > reasonable plan for buffer handling. I think using virtio-gpu buffers > > > should be an optional optimization and not a requirement. Also the > > > motivation

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Fri, Oct 11, 2019 at 5:54 PM Dmitry Morozov wrote: > > Hi Tomasz, > > On Mittwoch, 9. Oktober 2019 05:55:45 CEST Tomasz Figa wrote: > > On Tue, Oct 8, 2019 at 12:09 AM Dmitry Morozov > > > > wrote: > > > Hi Tomasz, > > > > > > O

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Tue, Oct 15, 2019 at 11:06 PM Dmitry Morozov wrote: > > Hello Gerd, > > On Dienstag, 15. Oktober 2019 09:54:22 CEST Gerd Hoffmann wrote: > > On Mon, Oct 14, 2019 at 03:05:03PM +0200, Dmitry Morozov wrote: > > > On Montag, 14. Oktober 2019 14:34:43 CEST Gerd Hoffmann wrote: > > > > Hi, > > >

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Thu, Oct 17, 2019 at 4:19 PM Gerd Hoffmann wrote: > > Hi, > > > That said, Chrome OS would use a similar model, except that we don't > > use ION. We would likely use minigbm backed by virtio-gpu to allocate > > appropriate secure buffers for us and then import them to the V4L2 > > driver. >

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Thu, Oct 17, 2019 at 4:44 PM Gerd Hoffmann wrote: > > Hi, > > > > Also note that the guest manages the address space, so the host can't > > > simply allocate guest page addresses. > > > > Is this really true? I'm not an expert in this area, but on a bare > > metal system it's the hardware or

[virtio-dev] Re: guest / host buffer sharing ...

2019-11-20 Thread Tomasz Figa
Hi Stefan, On Mon, Nov 18, 2019 at 7:21 PM Stefan Hajnoczi wrote: > > On Sat, Nov 9, 2019 at 3:12 PM Tomasz Figa wrote: > > > > On Sat, Nov 9, 2019 at 9:08 PM Stefan Hajnoczi wrote: > > > > > > On Sat, Nov 9, 2019 at 12:17 PM Tomasz Figa wrote: > >

[virtio-dev] Re: guest / host buffer sharing ...

2019-11-20 Thread Tomasz Figa
On Wed, Nov 6, 2019 at 6:51 PM Gerd Hoffmann wrote: > > Hi, > > > > Reason is: Meanwhile I'm wondering whenever "just use virtio-gpu > > > resources" is really a good answer for all the different use cases > > > we have collected over time. Maybe it is better to have a dedicated > > > buffer

[virtio-dev] Re: guest / host buffer sharing ...

2019-11-20 Thread Tomasz Figa
Hi Geoffrey, On Thu, Nov 7, 2019 at 7:28 AM Geoffrey McRae wrote: > > > > On 2019-11-06 23:41, Gerd Hoffmann wrote: > > On Wed, Nov 06, 2019 at 05:36:22PM +0900, David Stevens wrote: > >> > (1) The virtio device > >> > = > >> > > >> > Has a single virtio queue, so the guest

[virtio-dev] Re: guest / host buffer sharing ...

2019-11-20 Thread Tomasz Figa
Hi Frank, On Fri, Nov 8, 2019 at 12:10 AM Frank Yang wrote: > > So I'm not really sure why people are having issues sharing buffers that live > on the GPU. Doesn't that show up as some integer ID on the host, and some > $GuestFramework (dmabuf, gralloc) ID on the guest, and it all works out

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-07 Thread Tomasz Figa
r/input/output device. > > We would be glad to share our thoughts and contribute to the discussion. > Please see some comments regarding buffer allocation inline. > > Best regards, > Dmitry. > > On Samstag, 5. Oktober 2019 08:08:12 CEST Tomasz Figa wrote: > > Hi Gerd, &g

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-08 Thread Tomasz Figa
On Tue, Oct 8, 2019 at 12:09 AM Dmitry Morozov wrote: > > Hi Tomasz, > > On Montag, 7. Oktober 2019 16:14:13 CEST Tomasz Figa wrote: > > Hi Dmitry, > > > > On Mon, Oct 7, 2019 at 11:01 PM Dmitry Morozov > > > > wrote: > > > Hello, > >

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-05 Thread Tomasz Figa
Hi Gerd, On Mon, Sep 23, 2019 at 5:56 PM Gerd Hoffmann wrote: > > Hi, > > > Our prototype implementation uses [4], which allows the virtio-vdec > > device to use buffers allocated by virtio-gpu device. > > > [4] https://lkml.org/lkml/2019/9/12/157 First of all, thanks for taking a look at

[virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2019-12-20 Thread Tomasz Figa
On Sat, Dec 21, 2019 at 1:36 PM Keiichi Watanabe wrote: > > Hi Dmitry, > > On Sat, Dec 21, 2019 at 12:59 AM Dmitry Sepp > wrote: > > > > Hi Keiichi, > > > > On Mittwoch, 18. Dezember 2019 14:02:13 CET Keiichi Watanabe wrote: > > > Hi, > > > This is the 2nd version of virtio-video patch. The PDF

[virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2019-12-20 Thread Tomasz Figa
On Sat, Dec 21, 2019 at 3:18 PM Tomasz Figa wrote: > > On Sat, Dec 21, 2019 at 1:36 PM Keiichi Watanabe > wrote: > > > > Hi Dmitry, > > > > On Sat, Dec 21, 2019 at 12:59 AM Dmitry Sepp > > wrote: > > > > > > Hi Keiichi, > > >

[virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2019-12-20 Thread Tomasz Figa
On Sat, Dec 21, 2019 at 12:46 AM Dmitry Sepp wrote: > On Freitag, 20. Dezember 2019 16:26:50 CET Keiichi Watanabe wrote: > > On Thu, Dec 19, 2019 at 10:28 PM Dmitry Sepp > > wrote: > > > On Mittwoch, 18. Dezember 2019 14:02:14 CET Keiichi Watanabe wrote: [snip] > > > > +enum virtio_video_format

Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2019-12-18 Thread Tomasz Figa
On Wed, Dec 18, 2019 at 10:40 PM Gerd Hoffmann wrote: > > Hi, > > > +The device MUST mark the last buffer with the > > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain > > +sequence. > > No, that would build a race condition into the protocol. The device > could complete the

[virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2019-12-19 Thread Tomasz Figa
On Thu, Dec 19, 2019 at 6:26 PM Dmitry Sepp wrote: > > Hi Gerd, > > On Mittwoch, 18. Dezember 2019 14:40:37 CET Gerd Hoffmann wrote: > > Hi, > > > > > +The device MUST mark the last buffer with the > > > +VIRTIO_VIDEO_BUFFER_F_EOS flag to denote completion of the drain > > > +sequence. > > > >

Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2019-12-19 Thread Tomasz Figa
On Thu, Dec 19, 2019 at 6:48 PM Dmitry Sepp wrote: > > Hi, > > On Donnerstag, 19. Dezember 2019 08:46:39 CET Gerd Hoffmann wrote: > > On Wed, Dec 18, 2019 at 11:08:37PM +0900, Tomasz Figa wrote: > > > On Wed, Dec 18, 2019 at 10:40 PM Gerd Ho

Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2019-12-19 Thread Tomasz Figa
On Thu, Dec 19, 2019 at 7:55 PM Dmitry Sepp wrote: > > Hi Tomasz, > > On Donnerstag, 19. Dezember 2019 10:59:02 CET Tomasz Figa wrote: > > On Thu, Dec 19, 2019 at 6:48 PM Dmitry Sepp > wrote: > > > Hi, > > > > > > On Donnerstag, 19. Dezember 2019

Re: [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-11 Thread Tomasz Figa
Dmitry Sepp > > > > > > > > > > > > > wrote: > > > > > > Hi, > > > > > > > > > > > > On Montag, 6. Januar 2020 11:30:22 CET Keiichi Watanabe wrote: > > > > > > > Hi Dmitry,

Re: [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-13 Thread Tomasz Figa
> > > Ok, let's consider the following case: > > - the device expects planes in separate buffers. > > - say, Android on the guest side also imports planes in separate buffers > > into the driver. > > - but he driver only supports one buffer + offsets. > &

Re: [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification

2020-01-15 Thread Tomasz Figa
On Mon, Jan 13, 2020 at 10:27 PM Gerd Hoffmann wrote: > > Hi, > > > > Well, no. Tomasz Figa had splitted the devices into three groups: > > > > > > (1) requires single buffer. > > > (2) allows any layout (including the one (1) devices

Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-15 Thread Tomasz Figa
On Tue, Jan 14, 2020 at 7:35 PM Dmitry Sepp wrote: > > Hi Keiichi, > > thank you for the update. > > On Dienstag, 14. Januar 2020 08:18:50 CET Keiichi Watanabe wrote: > > Hi, > > > > On Thu, Jan 9, 2020 at 11:21 PM Tomasz Figa wrote: > > > On

Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-05 Thread Tomasz Figa
On Mon, Dec 30, 2019 at 9:16 PM Dmitry Sepp wrote: > > > On Donnerstag, 19. Dezember 2019 14:28:23 CET Dmitry Sepp wrote: > > Hi Keiichi, > > > > Thank you for the update. Please see some comments below. > > > > Also, we need to bring the virtio_video_control back as it is in fact used > > by the

[virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-08 Thread Tomasz Figa
On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe wrote: > > Hi Dmitry, > > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp > wrote: > > > > Hi Keiichi, > > > > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote: > > > Hi Dmitry, > > > > > > On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp > >

[virtio-dev] Re: [PATCH v2 1/1] video_video: Add the Virtio Video V4L2 driver

2020-03-13 Thread Tomasz Figa
On Thu, Mar 12, 2020 at 12:48 PM Dmitry Sepp wrote: > > Hi Hans, > > One more thing: > > > GFP_DMA? That's unusual. I'd expect GFP_DMA32. All V4L2 drivers use that. > > GFP_DMA32 had no effect for me on arm64. Probably I need to recheck. > What's the reason to use any specific GFP flags at all?

[virtio-dev] Re: [PATCH RFC v4 0/1] Virtio Video Device Specification

2020-07-08 Thread Tomasz Figa
On Wed, Jul 8, 2020 at 6:35 AM Alexandre Courbot wrote: > > On Fri, Jul 3, 2020 at 6:55 PM Tomasz Figa wrote: > > > > On Fri, Jul 3, 2020 at 11:27 AM Alexandre Courbot > > wrote: > > > > > > On Fri, Jul 3, 2020 at 6:18 PM Michael S. Tsirkin wrote: >

[virtio-dev] Re: [PATCH RFC v4 0/1] Virtio Video Device Specification

2020-07-03 Thread Tomasz Figa
On Fri, Jul 3, 2020 at 11:27 AM Alexandre Courbot wrote: > > On Fri, Jul 3, 2020 at 6:18 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 03, 2020 at 02:45:15PM +0900, Alexandre Courbot wrote: > > > Hi Dmitry, > > > > > > On Thu, Jul 2, 2020 at 10:47 PM Dmitry Sepp > > > wrote: > > > > > > > >

[virtio-dev] Re: [libcamera-devel] [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-05-16 Thread Tomasz Figa
On Sat, May 6, 2023 at 5:12 PM Laurent Pinchart via libcamera-devel wrote: > > Hello, > > On Fri, May 05, 2023 at 04:55:33PM +0100, Alex Bennée via libcamera-devel > wrote: > > Kieran Bingham writes: > > > > > Hi All, > > > > > > Coming in late, thanks to lei/lore spotting the libcamera keyword.