Re: [Virtio-fs] [PATCH 08/12] qom: allow for properties to become "fixed"

Alex Bennée writes: > When specialising general purpose objects it is sometimes useful to > "fix" some of the properties that were configurable by the base > classes. We will use this facility when specialising > vhost-user-device. > > Signed-off-by: Alex Bennée > --- > qapi/qom.json

[Virtio-fs] [PATCH v3 1/3] cleanup: Tweak and re-run return_directly.cocci

/avr/cpu.h and hw/rdma/vmw/pvrdma_cmd.c tidied up manually. Whitespace in tools/virtiofsd/fuse_lowlevel.c tidied up manually. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Acked-by: Dr. David Alan Gilbert --- scripts/coccinelle/return_directly.cocci | 5 +-- include/hw

[Virtio-fs] [PATCH v3 0/3] cleanup: Tweak and re-run return_directly.cocci

ten change to vmdk_co_create() split off as PATCH 2/2 [Peter] * New PATCH 3/2 [Zoltan] Markus Armbruster (3): cleanup: Tweak and re-run return_directly.cocci block/vmdk: Simplify vmdk_co_create() to return directly ppc4xx_sdram: Simplify sdram_ddr_size() to return directly scripts/

[Virtio-fs] [PATCH v3 3/3] ppc4xx_sdram: Simplify sdram_ddr_size() to return directly

Suggested-by: BALATON Zoltan Signed-off-by: Markus Armbruster Reviewed-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé --- hw/ppc/ppc4xx_sdram.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/hw/ppc/ppc4xx_sdram.c b/hw/ppc/ppc4xx_sdram.c index 54bf9a2b44

[Virtio-fs] [PATCH v3 2/3] block/vmdk: Simplify vmdk_co_create() to return directly

Cc: Fam Zheng Cc: Kevin Wolf Cc: Hanna Reitz Cc: qemu-bl...@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- block/vmdk.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/block

Re: [Virtio-fs] [PATCH v2 1/2] cleanup: Tweak and re-run return_directly.cocci

Greg Kurz writes: > On Thu, 24 Nov 2022 16:15:11 +0100 > Greg Kurz wrote: > >> On Tue, 22 Nov 2022 14:49:16 +0100 >> Markus Armbruster wrote: >> >> > Tweak the semantic patch to drop redundant parenthesis around the >> > return expression. >>

[Virtio-fs] [PATCH v2 1/2] cleanup: Tweak and re-run return_directly.cocci

ckpatch.pl. Signed-off-by: Markus Armbruster --- scripts/coccinelle/return_directly.cocci | 5 +-- include/hw/pci/pci.h | 7 +-- target/avr/cpu.h | 4 +- hw/9pfs/9p-synth.c | 14 ++ hw/char/sifive_uart.c| 4

[Virtio-fs] [PATCH v2 0/2] cleanup: Tweak and re-run return_directly.cocci

Markus Armbruster (2): cleanup: Tweak and re-run return_directly.cocci block/vmdk: Simplify vmdk_co_create() to return directly scripts/coccinelle/return_directly.cocci | 5 +-- include/hw/pci/pci.h | 7 +-- target/avr/cpu.h | 4 +- block/vmdk.c

[Virtio-fs] [PATCH v2 2/2] block/vmdk: Simplify vmdk_co_create() to return directly

Cc: Fam Zheng Cc: Kevin Wolf Cc: Hanna Reitz Cc: qemu-bl...@nongnu.org Signed-off-by: Markus Armbruster --- block/vmdk.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 26376352b9..bac3d8db50 100644

Re: [Virtio-fs] [PATCH] cleanup: Tweak and re-run return_directly.cocci

Peter Maydell writes: > On Tue, 22 Nov 2022 at 08:58, Markus Armbruster wrote: >> I don't think complete detailed review is necessary or even sensible. >> >> Review should start with the Coccinelle script: >> >> // replace 'R = X; return R;' with 'return X;

Re: [Virtio-fs] [PATCH] cleanup: Tweak and re-run return_directly.cocci

Thomas Huth writes: > On 21/11/2022 17.32, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 21/11/22 15:36, Peter Maydell wrote: >>>> On Mon, 21 Nov 2022 at 14:03, Markus Armbruster wrote: >>>>> >>>>

Re: [Virtio-fs] [PATCH] cleanup: Tweak and re-run return_directly.cocci

Max Filippov writes: > On Mon, Nov 21, 2022 at 6:01 AM Markus Armbruster wrote: >> .../xtensa/core-dsp3400/xtensa-modules.c.inc | 136 +- >> target/xtensa/core-lx106/xtensa-modules.c.inc | 16 +-- > > These files are generated and were imported from

Re: [Virtio-fs] [PATCH] cleanup: Tweak and re-run return_directly.cocci

Philippe Mathieu-Daudé writes: > On 21/11/22 15:36, Peter Maydell wrote: >> On Mon, 21 Nov 2022 at 14:03, Markus Armbruster wrote: >>> >>> Tweak the semantic patch to drop redundant parenthesis around the >>> return expression. >>> >>>

Re: [Virtio-fs] [PATCH] cleanup: Tweak and re-run return_directly.cocci

Peter Maydell writes: > On Mon, 21 Nov 2022 at 14:03, Markus Armbruster wrote: >> >> Tweak the semantic patch to drop redundant parenthesis around the >> return expression. >> >> Coccinelle drops comments in hw/rdma/vmw/pvrdma_cmd.c; restored >&g