Re: [Virtio-fs] [PATCH 5/7] io: use GDateTime for formatting timestamp for websock headers

2021-06-14 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > ping: anyone willing to review this > Reviewed-by: Dr. David Alan Gilbert > On Wed, May 05, 2021 at 11:37:00AM +0100, Daniel P. Berrangé wrote: > > The GDateTime APIs provided by GLib avoid portability pitfalls, such > > as some platforms wher

Re: [Virtio-fs] [PATCH 5/7] io: use GDateTime for formatting timestamp for websock headers

2021-06-11 Thread Daniel P . Berrangé
ping: anyone willing to review this On Wed, May 05, 2021 at 11:37:00AM +0100, Daniel P. Berrangé wrote: > The GDateTime APIs provided by GLib avoid portability pitfalls, such > as some platforms where 'struct timeval.tv_sec' field is still 'long' > instead of 'time_t'. When combined with automatic

[Virtio-fs] [PATCH 5/7] io: use GDateTime for formatting timestamp for websock headers

2021-05-05 Thread Daniel P . Berrangé
The GDateTime APIs provided by GLib avoid portability pitfalls, such as some platforms where 'struct timeval.tv_sec' field is still 'long' instead of 'time_t'. When combined with automatic cleanup, GDateTime often results in simpler code too. Signed-off-by: Daniel P. Berrangé --- io/channel-webs