Re: [Virtio-fs] Changes in -dev branch

2020-01-14 Thread Boeuf, Sebastien
On Tue, 2020-01-14 at 12:25 +, Dr. David Alan Gilbert wrote: > * Boeuf, Sebastien (sebastien.bo...@intel.com) wrote: > > Hi Dave, > > > > On Fri, 2020-01-10 at 19:03 +, Dr. David Alan Gilbert wrote: > > > Hi, > > >I've just pushed a new version of the virtio-fs-dev branch in > > >

Re: [Virtio-fs] [PATCH 01/19] dax: remove block device dependencies

2020-01-14 Thread Vivek Goyal
On Tue, Jan 14, 2020 at 12:39:00PM -0800, Dan Williams wrote: > On Tue, Jan 14, 2020 at 12:31 PM Vivek Goyal wrote: > > > > On Thu, Jan 09, 2020 at 12:03:01PM -0800, Dan Williams wrote: > > > On Thu, Jan 9, 2020 at 3:27 AM Jan Kara wrote: > > > > > > > > On Tue 07-01-20 10:49:55, Dan Williams

Re: [Virtio-fs] [PATCH 01/19] dax: remove block device dependencies

2020-01-14 Thread Vivek Goyal
On Thu, Jan 09, 2020 at 12:03:01PM -0800, Dan Williams wrote: > On Thu, Jan 9, 2020 at 3:27 AM Jan Kara wrote: > > > > On Tue 07-01-20 10:49:55, Dan Williams wrote: > > > On Tue, Jan 7, 2020 at 10:33 AM Vivek Goyal wrote: > > > > W.r.t partitioning, bdev_dax_pgoff() seems to be the pain point

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-14 Thread Miklos Szeredi
On Tue, Jan 14, 2020 at 6:13 PM Max Reitz wrote: > What worries me most is how to pass that object around to all FUSE > functions, and that they all need a new interface. You mean libfuse API? > I just had a very fuzzy (and maybe stupid) idea: Maybe we could keep an > internal vector of

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-14 Thread Max Reitz
On 14.01.20 17:13, Miklos Szeredi wrote: > On Mon, Jan 13, 2020 at 6:47 PM Max Reitz wrote: >> >> Hi, >> >> As discussed in today’s meeting, there is a problem with uniquely and >> persistently identifying nodes in the guest. >> >> Actually, there are multiple problems: >> >> (1) stat’s st_ino in

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-14 Thread Miklos Szeredi
On Mon, Jan 13, 2020 at 6:47 PM Max Reitz wrote: > > Hi, > > As discussed in today’s meeting, there is a problem with uniquely and > persistently identifying nodes in the guest. > > Actually, there are multiple problems: > > (1) stat’s st_ino in the guest is not necessarily unique. Currently, it

Re: [Virtio-fs] [PATCH] virtiofsd: Fix xattr operations

2020-01-14 Thread Vivek Goyal
On Tue, Jan 14, 2020 at 01:17:37AM +, misono.tomoh...@fujitsu.com wrote: > > On Mon, Jan 13, 2020 at 7:42 PM Vivek Goyal wrote: > > > > > > On Fri, Jan 10, 2020 at 10:07:22AM +0900, Misono Tomohiro wrote: > > > > > > [..] > > > > --- a/tools/virtiofsd/passthrough_ll.c > > > > +++

Re: [Virtio-fs] [PATCH 1/2] vitriofsd/passthrough_ll: Make fallocate() work

2020-01-14 Thread Dr. David Alan Gilbert
* Xiao Yang (yangx...@cn.fujitsu.com) wrote: > On 2020/1/14 20:14, Dr. David Alan Gilbert 写wrote: > > Thanks; I've merged the fh fix into Stefan's 'add fd_map to hide file > > descriptors' > > patch. > > > > I'll merge the ifdef fix with your next fix and take it as a separate > > patch. > Hi

Re: [Virtio-fs] [PATCH 1/2] vitriofsd/passthrough_ll: Make fallocate() work

2020-01-14 Thread Xiao Yang
On 2020/1/14 20:14, Dr. David Alan Gilbert 写wrote: Thanks; I've merged the fh fix into Stefan's 'add fd_map to hide file descriptors' patch. I'll merge the ifdef fix with your next fix and take it as a separate patch. Hi Dave, Thanks for your review and explanation. Do you mean that I don't

Re: [Virtio-fs] Changes in -dev branch

2020-01-14 Thread Dr. David Alan Gilbert
* Boeuf, Sebastien (sebastien.bo...@intel.com) wrote: > Hi Dave, > > On Fri, 2020-01-10 at 19:03 +, Dr. David Alan Gilbert wrote: > > Hi, > >I've just pushed a new version of the virtio-fs-dev branch in > > https://gitlab.com/virtio-fs/qemu > > > > some things to note: > > > > a)

Re: [Virtio-fs] [PATCH 1/2] vitriofsd/passthrough_ll: Make fallocate() work

2020-01-14 Thread Dr. David Alan Gilbert
* Xiao Yang (yangx...@cn.fujitsu.com) wrote: > 1) Use correct CONFIG_FALLOCATE macro to check if fallocate() is > supported.(i.e configure >script sets CONFIG_FALLOCATE intead of HAVE_FALLOCATE if fallocate() is > supported) > 2) Avoid 'Bad file descriptor' error by passing correct fd to

Re: [Virtio-fs] [PATCH] virtiofsd: Fix xattr operations

2020-01-14 Thread misono.tomoh...@fujitsu.com
> On Tue, Jan 14, 2020 at 2:17 AM misono.tomoh...@fujitsu.com > wrote: > > > > > On Mon, Jan 13, 2020 at 7:42 PM Vivek Goyal wrote: > > > > > > > > On Fri, Jan 10, 2020 at 10:07:22AM +0900, Misono Tomohiro wrote: > > > > > > > > [..] > > > > > --- a/tools/virtiofsd/passthrough_ll.c > > > > >