Re: [Virtio-fs] [PATCH 01/19] dax: remove block device dependencies

2020-01-15 Thread Jeff Moyer
Hi, Dan, Dan Williams writes: > I'm going to take a look at how hard it would be to develop a kpartx > fallback in udev. If that can live across the driver transition then > maybe this can be a non-event for end users that already have that > udev update deployed. I just wanted to remind you

Re: [Virtio-fs] [PATCH 01/19] dax: remove block device dependencies

2020-01-15 Thread Dan Williams
On Wed, Jan 15, 2020 at 11:56 AM Vivek Goyal wrote: [..] > > Even the Red Hat > > installation guide example shows mounting on pmem0 directly. [1] > > Below that example it also says. > > "When creating partitions on a pmem device to be used for direct access, > partitions must be aligned on page

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Max Reitz
On 15.01.20 17:01, Miklos Szeredi wrote: > On Wed, Jan 15, 2020 at 4:30 PM Max Reitz wrote: >> >> On 15.01.20 16:05, Miklos Szeredi wrote: >>> On Wed, Jan 15, 2020 at 3:58 PM Miklos Szeredi wrote: On Wed, Jan 15, 2020 at 1:51 PM Max Reitz wrote: > > On 15.01.20 12:51, Miklos

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Miklos Szeredi
On Wed, Jan 15, 2020 at 4:30 PM Max Reitz wrote: > > On 15.01.20 16:05, Miklos Szeredi wrote: > > On Wed, Jan 15, 2020 at 3:58 PM Miklos Szeredi wrote: > >> > >> On Wed, Jan 15, 2020 at 1:51 PM Max Reitz wrote: > >>> > >>> On 15.01.20 12:51, Miklos Szeredi wrote: > On Wed, Jan 15, 2020 at

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Miklos Szeredi
On Wed, Jan 15, 2020 at 4:23 PM Max Reitz wrote: > > On 15.01.20 15:58, Miklos Szeredi wrote: > > On Wed, Jan 15, 2020 at 1:51 PM Max Reitz wrote: > >> > >> On 15.01.20 12:51, Miklos Szeredi wrote: > >>> On Wed, Jan 15, 2020 at 11:10 AM Miklos Szeredi > >>> wrote: > >>> > New operations

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Max Reitz
On 15.01.20 15:58, Miklos Szeredi wrote: > On Wed, Jan 15, 2020 at 1:51 PM Max Reitz wrote: >> >> On 15.01.20 12:51, Miklos Szeredi wrote: >>> On Wed, Jan 15, 2020 at 11:10 AM Miklos Szeredi wrote: >>> New operations needed: LOOKUP_WITH_HANDLE: same as LOOKUP, but returns handle

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Miklos Szeredi
On Wed, Jan 15, 2020 at 1:51 PM Max Reitz wrote: > > On 15.01.20 12:51, Miklos Szeredi wrote: > > On Wed, Jan 15, 2020 at 11:10 AM Miklos Szeredi wrote: > > > >> New operations needed: > >> > >> LOOKUP_WITH_HANDLE: same as LOOKUP, but returns handle in addition to > >> fuse_ino_t and attributes.

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Max Reitz
On 15.01.20 13:50, Stefan Hajnoczi wrote: > On Mon, Jan 13, 2020 at 06:46:49PM +0100, Max Reitz wrote: >> (1) stat’s st_ino in the guest is not necessarily unique. Currently, it >> just the st_ino from the host file, so if you have mounted multiple >> different filesystems in the exported

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Max Reitz
On 15.01.20 13:01, Stefan Hajnoczi wrote: > On Tue, Jan 14, 2020 at 08:24:51PM +0100, Miklos Szeredi wrote: >> On Tue, Jan 14, 2020 at 6:13 PM Max Reitz wrote: >>> What worries me most is how to pass that object around to all FUSE >>> functions, and that they all need a new interface. >> >> You

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Max Reitz
On 15.01.20 11:12, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> Hi, >> >> As discussed in today’s meeting, there is a problem with uniquely and >> persistently identifying nodes in the guest. >> >> Actually, there are multiple problems: >> >> (1) stat’s st_ino in the

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Max Reitz
On 15.01.20 12:51, Miklos Szeredi wrote: > On Wed, Jan 15, 2020 at 11:10 AM Miklos Szeredi wrote: > >> New operations needed: >> >> LOOKUP_WITH_HANDLE: same as LOOKUP, but returns handle in addition to >> fuse_ino_t and attributes. >> LOOKUP_BY_HANDLE: same as LOOKUP, but gets a handle as input.

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Stefan Hajnoczi
On Mon, Jan 13, 2020 at 06:46:49PM +0100, Max Reitz wrote: > (1) stat’s st_ino in the guest is not necessarily unique. Currently, it > just the st_ino from the host file, so if you have mounted multiple > different filesystems in the exported directory tree, you may get > collisions. This must

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Stefan Hajnoczi
On Tue, Jan 14, 2020 at 08:24:51PM +0100, Miklos Szeredi wrote: > On Tue, Jan 14, 2020 at 6:13 PM Max Reitz wrote: > > What worries me most is how to pass that object around to all FUSE > > functions, and that they all need a new interface. > > You mean libfuse API? > > > I just had a very

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Miklos Szeredi
On Wed, Jan 15, 2020 at 11:10 AM Miklos Szeredi wrote: > New operations needed: > > LOOKUP_WITH_HANDLE: same as LOOKUP, but returns handle in addition to > fuse_ino_t and attributes. > LOOKUP_BY_HANDLE: same as LOOKUP, but gets a handle as input. And that can be reduced further to a single

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > Hi, > > As discussed in today’s meeting, there is a problem with uniquely and > persistently identifying nodes in the guest. > > Actually, there are multiple problems: > > (1) stat’s st_ino in the guest is not necessarily unique. Currently, it > just

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Max Reitz
On 15.01.20 10:37, Max Reitz wrote: [...] >>> I just had a very fuzzy (and maybe stupid) idea: Maybe we could keep an >>> internal vector of currently active handles and then when variable-size >>> handles are enabled, fuse_ino_t would just act as an index into that vector? >>> >>> I suppose we

Re: [Virtio-fs] Ways to uniquely and persistently identify nodes

2020-01-15 Thread Max Reitz
On 14.01.20 20:24, Miklos Szeredi wrote: > On Tue, Jan 14, 2020 at 6:13 PM Max Reitz wrote: >> What worries me most is how to pass that object around to all FUSE >> functions, and that they all need a new interface. > > You mean libfuse API? Not only that, but also the FUSE kernel driver. >> I

Re: [Virtio-fs] [PATCH 01/19] dax: remove block device dependencies

2020-01-15 Thread Jan Kara
On Tue 14-01-20 16:28:05, Vivek Goyal wrote: > On Tue, Jan 14, 2020 at 12:39:00PM -0800, Dan Williams wrote: > > I think we should at least try to delete the partition support and see > > if anyone screams. Have a module option to revert the behavior so > > people are not stuck waiting for the