Re: [Virtio-fs] [PATCH] virtiofsd: Add `sigreturn` to the seccomp whitelist

2022-11-28 Thread Dr. David Alan Gilbert
* Marc Hartmayer (mhart...@linux.ibm.com) wrote: > The virtiofsd currently crashes on s390x. This is because of a > `sigreturn` system call. See audit log below: > > type=SECCOMP msg=audit(1669382477.611:459): auid=4294967295 uid=0 gid=0 > ses=4294967295

[Virtio-fs] [PATCH v3 5/7] vhost: enable vrings in vhost_dev_start() for vhost-user devices

2022-11-28 Thread Alex Bennée
From: Stefano Garzarella Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features") properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user backend, but we forgot to enable vrings as specified in docs/interop/vhost-user.rst: If

Re: [Virtio-fs] [PATCH v3 3/3] ppc4xx_sdram: Simplify sdram_ddr_size() to return directly

2022-11-28 Thread Juan Quintela
Markus Armbruster wrote: > Suggested-by: BALATON Zoltan > Signed-off-by: Markus Armbruster > Reviewed-by: BALATON Zoltan > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela ___ Virtio-fs mailing list Virtio-fs@redhat.com

Re: [Virtio-fs] [PATCH v3 2/3] block/vmdk: Simplify vmdk_co_create() to return directly

2022-11-28 Thread Juan Quintela
Markus Armbruster wrote: > Cc: Fam Zheng > Cc: Kevin Wolf > Cc: Hanna Reitz > Cc: qemu-bl...@nongnu.org > Signed-off-by: Markus Armbruster > Reviewed-by: Peter Maydell > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela goto, uninitialized variable at declaraton and can use

Re: [Virtio-fs] [PATCH] virtiofsd: Add `sigreturn` to the seccomp whitelist

2022-11-28 Thread German Maglione
On Mon, Nov 28, 2022 at 10:00 AM Marc Hartmayer wrote: > > German Maglione writes: > > > On Fri, Nov 25, 2022 at 3:40 PM Marc Hartmayer > > wrote: > >> > >> The virtiofsd currently crashes on s390x. This is because of a > >> `sigreturn` system call. See audit log below: > >> > >> type=SECCOMP

[Virtio-fs] [virtiofsd] MR opened: seccomp: Allow `SYS_sigreturn` for s390x

2022-11-28 Thread virtiofs-bot
The virtiofsd currently crashes on s390x. This is because of a `sigreturn` system call. This was originally reported and fixed, for the C version, by Marc Hartmayer https://listman.redhat.com/archives/virtio-fs/2022-November/005292.html Reported-by: Marc Hartmayer Signed-off-by: German

[Virtio-fs] [PATCH v3 1/3] cleanup: Tweak and re-run return_directly.cocci

2022-11-28 Thread Markus Armbruster
Tweak the semantic patch to drop redundant parenthesis around the return expression. Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored manually. Coccinelle messes up vmdk_co_create(), not sure why. Change dropped, will be done manually in the next commit. Line breaks in

[Virtio-fs] [PATCH v3 0/3] cleanup: Tweak and re-run return_directly.cocci

2022-11-28 Thread Markus Armbruster
v3: * Rebased onto Greg's "[PATCH] 9pfs: Fix some return statements in the synth backend", which replaces my change to hw/9pfs/9p-synth.c in PATCH 1/3, along with a paragraph on checkpatch.pl in the commit message. v2: * Changes to imported files dropped [Philippe, Max] * Handwritten change

[Virtio-fs] [PATCH v3 3/3] ppc4xx_sdram: Simplify sdram_ddr_size() to return directly

2022-11-28 Thread Markus Armbruster
Suggested-by: BALATON Zoltan Signed-off-by: Markus Armbruster Reviewed-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé --- hw/ppc/ppc4xx_sdram.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/hw/ppc/ppc4xx_sdram.c b/hw/ppc/ppc4xx_sdram.c index

[Virtio-fs] [PATCH v3 2/3] block/vmdk: Simplify vmdk_co_create() to return directly

2022-11-28 Thread Markus Armbruster
Cc: Fam Zheng Cc: Kevin Wolf Cc: Hanna Reitz Cc: qemu-bl...@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- block/vmdk.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git

Re: [Virtio-fs] [PATCH] virtiofsd: Add `sigreturn` to the seccomp whitelist

2022-11-28 Thread Marc Hartmayer
German Maglione writes: > On Fri, Nov 25, 2022 at 3:40 PM Marc Hartmayer wrote: >> >> The virtiofsd currently crashes on s390x. This is because of a >> `sigreturn` system call. See audit log below: >> >> type=SECCOMP msg=audit(1669382477.611:459): auid=4294967295 uid=0 gid=0 >> ses=4294967295