[Virtio-fs] [PULL 1/4] virtiofsd: Remove test

2023-02-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Rmove the avocado test for virtiofsd, since we're about to remove the C implementation. Signed-off-by: Dr. David Alan Gilbert Acked-by: Stefan Hajnoczi --- .../org.centos/stream/8/x86_64/test-avocado | 7 - tests/avocado/virtiofs_su

[Virtio-fs] [PULL 4/4] virtiofsd: Swing deprecated message to removed-features

2023-02-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Move the deprecation message, since it's now gone. Signed-off-by: Dr. David Alan Gilbert Acked-by: Stefan Hajnoczi --- docs/about/deprecated.rst | 18 -- docs/about/removed-features.rst | 13 + 2 files changed, 13

[Virtio-fs] [PULL 0/4] virtiofs queue

2023-02-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 6dffbe36af79e26a4d23f94a9a1c1201de99c261: Merge tag 'migration-20230215-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-02-16 13:09:51 +) are available in the Git repository at

[Virtio-fs] [PULL 2/4] virtiofsd: Remove build and docs glue

2023-02-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Remove all the virtiofsd build and docs infrastructure. Signed-off-by: Dr. David Alan Gilbert Acked-by: Stefan Hajnoczi --- MAINTAINERS| 2 -- docs/conf.py | 4 docs/m

[Virtio-fs] [PATCH v2 4/4] virtiofsd: Swing deprecated message to removed-features

2023-02-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Move the deprecation message, since it's now gone. Signed-off-by: Dr. David Alan Gilbert --- docs/about/deprecated.rst | 18 -- docs/about/removed-features.rst | 13 + 2 files changed, 13 insertions(+), 18 deletion

[Virtio-fs] [PATCH v2 2/4] virtiofsd: Remove build and docs glue

2023-02-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Remove all the virtiofsd build and docs infrastructure. Signed-off-by: Dr. David Alan Gilbert --- MAINTAINERS| 2 -- docs/conf.py | 4 docs/m

[Virtio-fs] [PATCH v2 1/4] virtiofsd: Remove test

2023-02-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Rmove the avocado test for virtiofsd, since we're about to remove the C implementation. Signed-off-by: Dr. David Alan Gilbert --- .../org.centos/stream/8/x86_64/test-avocado | 7 - tests/avocado/virtiofs_submounts.py | 217 ---

[Virtio-fs] [PATCH v2 0/4] Remove C virtiofsd

2023-02-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a in v7.0 in favour of the Rust implementation at https://gitlab.com/virtio-fs/virtiofsd since then, the Rust version has had more development and has held up well. It's time to say goodby

Re: [Virtio-fs] [PATCH] vhost-user-fs: add capability to allow migration

2023-01-24 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Mon, 23 Jan 2023 at 14:54, Stefan Hajnoczi wrote: > > > > On Mon, Jan 23, 2023 at 06:27:23PM +0000, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Sun, Jan 22, 20

Re: [Virtio-fs] [PATCH] vhost-user-fs: add capability to allow migration

2023-01-23 Thread Dr. David Alan Gilbert
on. I think we just assumed there's no use-case where > > > this is practical for vhost-user-fs so we blocked it. > > > But in any case it's orchestrator's responsibility. > > > > Yes, you are right. So do you think we should just drop the blocker > > without adding a new flag? > > I'd be inclined to. I am curious what do dgilbert and stefanha think though. Yes I think that's probably OK, as long as we use the flag for knowing how to handle the discard bitmap as a proxy for the daemon knowing how to handle *some* migrations; knowing which migrations is then the job for the orchestrator to be careful of. Dave > -- > MST > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK ___ Virtio-fs mailing list Virtio-fs@redhat.com https://listman.redhat.com/mailman/listinfo/virtio-fs

Re: [Virtio-fs] [PATCH] vhost-user-fs: add capability to allow migration

2023-01-19 Thread Dr. David Alan Gilbert
gt; # Features: > > > # @unstable: Members @x-colo and @x-ignore-shared are experimental. > > > @@ -492,7 +497,7 @@ > > > 'dirty-bitmaps', 'postcopy-blocktime', 'late-block-activate', > > > { 'name': 'x-ignore-shared', 'features': [ 'u

[Virtio-fs] [PATCH 0/3] Remove C virtiofsd

2023-01-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a in v7.0 in favour of the Rust implementation at https://gitlab.com/virtio-fs/virtiofsd since then, the Rust version has had more development and has held up well. It's time to say goodby

[Virtio-fs] [PATCH 1/3] virtiofsd: Remove build and docs glue

2023-01-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Remove all the virtiofsd build and docs infrastructure. Signed-off-by: Dr. David Alan Gilbert --- MAINTAINERS| 2 -- docs/conf.py | 4 docs/m

[Virtio-fs] [PATCH 3/3] virtiofsd: Swing deprecated message to removed-features

2023-01-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Move the deprecation message, since it's now gone. Signed-off-by: Dr. David Alan Gilbert --- docs/about/deprecated.rst | 18 -- docs/about/removed-features.rst | 13 + 2 files changed, 13 insertions(+), 18 deletion

Re: [Virtio-fs] [PATCH 3/6] tools/virtiofsd: add G_GNUC_PRINTF for logging functions

2023-01-04 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > Signed-off-by: Daniel P. Berrangé Yes, although I'm a little surprised this hasn't thrown up any warnings. Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_log.c | 1 + > tools/virtiofsd/fuse_log

Re: [Virtio-fs] [PATCH] virtiofsd: Add `sigreturn` to the seccomp whitelist

2022-11-29 Thread Dr. David Alan Gilbert
* Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > > Am 29.11.22 um 10:52 schrieb Christian Borntraeger: > > > > > > Am 29.11.22 um 10:42 schrieb Dr. David Alan Gilbert: > > > * Marc Hartmayer (mhart...@linux.ibm.com) wrote: >

Re: [Virtio-fs] [PATCH] virtiofsd: Add `sigreturn` to the seccomp whitelist

2022-11-29 Thread Dr. David Alan Gilbert
* Marc Hartmayer (mhart...@linux.ibm.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Marc Hartmayer (mhart...@linux.ibm.com) wrote: > >> The virtiofsd currently crashes on s390x. This is because of a > >> `sigreturn` system call. See audit log

Re: [Virtio-fs] [PATCH] virtiofsd: Add `sigreturn` to the seccomp whitelist

2022-11-28 Thread Dr. David Alan Gilbert
SCMP_SYS(setxattr), > +SCMP_SYS(sigreturn), > SCMP_SYS(symlinkat), > SCMP_SYS(syncfs), > SCMP_SYS(time), /* Rarely needed, except on static builds */ > -- > 2.34.1 > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK ___ Virtio-fs mailing list Virtio-fs@redhat.com https://listman.redhat.com/mailman/listinfo/virtio-fs

Re: [Virtio-fs] [PATCH v2 1/2] cleanup: Tweak and re-run return_directly.cocci

2022-11-24 Thread Dr. David Alan Gilbert
hould typically be -ve" > two times for hw/9pfs/9p-synth.c. Preexisting, the patch merely makes > it visible to checkpatch.pl. > > Signed-off-by: Markus Armbruster For migration and virtiofs: Acked-by: Dr. David Alan Gilbert > --- > scripts/coccinelle/return

Re: [Virtio-fs] [PATCH] virtiofsd: use g_date_time_get_microsecond to get subsecond

2022-08-24 Thread Dr. David Alan Gilbert
eld as "%06d" > and let next snprintf to format with g_date_time_get_microsecond. > > Signed-off-by: Yusuke Okada Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passthrough_ll.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions

Re: [Virtio-fs] [PATCH] virtiofsd: Disable killpriv_v2 by default

2022-08-02 Thread Dr. David Alan Gilbert
not > + * specify anything. Disable killpriv_v2 in both the cases. > */ > fuse_log(FUSE_LOG_DEBUG, "lo_init: disabling killpriv_v2\n"); > conn->want &= ~FUSE_CAP_HANDLE_KILLPRIV_V2; > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK ___ Virtio-fs mailing list Virtio-fs@redhat.com https://listman.redhat.com/mailman/listinfo/virtio-fs

Re: [Virtio-fs] [PATCH] virtiofsd: Disable killpriv_v2 by default

2022-08-02 Thread Dr. David Alan Gilbert
l OK, yes I see the corresponding 9b03f65d commit in the Rust version. Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passthrough_ll.c | 13 ++--- > 1 file changed, 2 insertions(+), 11 deletions(-) > > Index: rhvgoyal-qemu/tools/virtiofsd/passthrough_ll

Re: [Virtio-fs] [Qemu] how to use viriofs in qemu without NUMA

2022-07-05 Thread Dr. David Alan Gilbert
4 is quite old, what qemu version is it? I'd have to check when the memdev= went in. Dave > > Thanks. > - Shirley > > -Original Message- > From: Dr. David Alan Gilbert > Sent: Tuesday, July 5, 2022 4:04 PM > To: Thomas Huth > Cc: Zhao, Shirley ; qemu-de...@no

Re: [Virtio-fs] [Qemu] how to use viriofs in qemu without NUMA

2022-07-05 Thread Dr. David Alan Gilbert
y I do it on x86. We wrote virtiofs before the memory-backend option existed, which is why the old docs talk about using the NUMA stuff. Dave > Thomas > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK ___ Virtio-fs mailing list Virtio-fs@redhat.com https://listman.redhat.com/mailman/listinfo/virtio-fs

Re: [Virtio-fs] [PULL 09/12] virtiofsd: Create new file with security context

2022-04-07 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 17 Feb 2022 at 17:40, Dr. David Alan Gilbert (git) > wrote: > > > > From: Vivek Goyal > > > > This patch adds support for creating new file with security context > > as sent by cl

Re: [Virtio-fs] [PATCH] virtiofsd: Let meson check for statx.stx_mnt_id

2022-03-02 Thread Dr. David Alan Gilbert
ls/virtiofsd/passthrough_ll.c > @@ -1039,7 +1039,7 @@ static int do_statx(struct lo_data *lo, int dirfd, > const char *pathname, > { > int res; > > -#if defined(CONFIG_STATX) && defined(STATX_MNT_ID) > +#if defined(

Re: [Virtio-fs] [PATCH] virtiofsd: Let meson check for statx.stx_mnt_id

2022-02-23 Thread Dr. David Alan Gilbert
ps://gitlab.com/qemu-project/qemu/-/issues/882 > Signed-off-by: Hanna Reitz Reviewed-by: Dr. David Alan Gilbert > --- > meson.build | 13 + > tools/virtiofsd/passthrough_ll.c | 2 +- > 2 files changed, 14 insertions(+), 1 deletion(-) >

[Virtio-fs] [PULL 10/12] virtiofsd: Create new file using O_TMPFILE and set security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
ot support O_TMPFILE, we fallback to non-atomic behavior. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-10-vgo...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 80 1

[Virtio-fs] [PULL 11/12] virtiofsd: Add an option to enable/disable security label

2022-02-17 Thread Dr. David Alan Gilbert (git)
Typically this is expected to be a SELinux label. File server will set this label on the file. It will try to set it atomically wherever possible. But its not possible in all the cases. Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-11-vgo...@redhat.com> Reviewed-by: Dr. David Alan Gil

[Virtio-fs] [PULL 12/12] virtiofsd: Add basic support for FUSE_SYNCFS request

2022-02-17 Thread Dr. David Alan Gilbert (git)
if the submounts are being hammered by some unrelated workload on the host. The only solution to prevent that is to avoid shared mounts. Signed-off-by: Greg Kurz Message-Id: <20220215181529.164070-2-gr...@kaod.org> Reviewed-by: Vivek Goyal Signed-off-by: Dr. David Alan Gilbert --- tools/vir

[Virtio-fs] [PULL 09/12] virtiofsd: Create new file with security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
ate SELinux policies. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-9-vgo...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 229 +++ 1 file changed, 200 insertions(+), 2

[Virtio-fs] [PULL 08/12] virtiofsd: Add helpers to work with /proc/self/task/tid/attr/fscreate

2022-02-17 Thread Dr. David Alan Gilbert (git)
set in fscreate. This works basically for SELinux and its per thread. This patch just introduces the helper functions. Subsequent patches will make use of these helpers. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-8-vgo...@redhat.com>

[Virtio-fs] [PULL 07/12] virtiofsd: Move core file creation code in separate function

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Move core file creation bits in a separate function. Soon this is going to get more complex as file creation need to set security context also. And there will be multiple modes of file creation in next patch. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal

[Virtio-fs] [PULL 06/12] virtiofsd, fuse_lowlevel.c: Add capability to parse security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
viewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_common.h | 5 ++ tools/virtiofsd/fuse_i.h| 7 +++ tools/virtiofsd/fuse_lowlevel.c | 102 +++- 3 files changed, 113 insertions(+), 1 deletion(-) diff --git a

[Virtio-fs] [PULL 04/12] virtiofsd: Parse extended "struct fuse_init_in"

2022-02-17 Thread Dr. David Alan Gilbert (git)
n". Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-4-vgo...@redhat.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert dgilbert: Fixed up long line --- tools/virtiofsd/fuse_lowlevel.c | 61 + 1 file change

[Virtio-fs] [PULL 03/12] linux-headers: Update headers to v5.17-rc1

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Update headers to 5.17-rc1. I need latest fuse changes. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-3-vgo...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- include/standard-headers/asm-x86/kvm_para.h

Re: [Virtio-fs] [PULL 00/12] virtiofs queue

2022-02-17 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit c13b8e9973635f34f3ce4356af27a311c993729c: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20220216' in

[Virtio-fs] [PULL 02/12] virtiofsd: Fix breakage due to fuse_init_in size change

2022-02-17 Thread Dr. David Alan Gilbert (git)
arate patches will be posted which will parse rest of the bytes and enable new functionality. Right now we don't support any of the new functionality, so we don't lose anything by not parsing bytes beyond 16. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204

[Virtio-fs] [PULL 01/12] virtiofsd: Do not support blocking flock

2022-02-17 Thread Dr. David Alan Gilbert (git)
uni-stuttgart.de> Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Vivek Goyal Reviewed-by: Greg Kurz --- tools/virtiofsd/passthrough_ll.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index b3d0674f6d..3e56d1cd95

[Virtio-fs] [PULL 00/12] virtiofs queue

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit c13b8e9973635f34f3ce4356af27a311c993729c: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20220216' into staging (2022-02-16 09:57:11 +) are available in the Git repository at

[Virtio-fs] [PULL 09/12] virtiofsd: Create new file with security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
ate SELinux policies. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-9-vgo...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 229 +++ 1 file changed, 200 insertions(+), 2

[Virtio-fs] [PULL 11/12] virtiofsd: Add an option to enable/disable security label

2022-02-17 Thread Dr. David Alan Gilbert (git)
Typically this is expected to be a SELinux label. File server will set this label on the file. It will try to set it atomically wherever possible. But its not possible in all the cases. Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-11-vgo...@redhat.com> Reviewed-by: Dr. David Alan Gil

[Virtio-fs] [PULL 10/12] virtiofsd: Create new file using O_TMPFILE and set security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
ot support O_TMPFILE, we fallback to non-atomic behavior. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-10-vgo...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 80 1

[Virtio-fs] [PULL 12/12] virtiofsd: Add basic support for FUSE_SYNCFS request

2022-02-17 Thread Dr. David Alan Gilbert (git)
if the submounts are being hammered by some unrelated workload on the host. The only solution to prevent that is to avoid shared mounts. Signed-off-by: Greg Kurz Message-Id: <20220215181529.164070-2-gr...@kaod.org> Reviewed-by: Vivek Goyal Signed-off-by: Dr. David Alan Gilbert --- tools/vir

[Virtio-fs] [PULL 08/12] virtiofsd: Add helpers to work with /proc/self/task/tid/attr/fscreate

2022-02-17 Thread Dr. David Alan Gilbert (git)
set in fscreate. This works basically for SELinux and its per thread. This patch just introduces the helper functions. Subsequent patches will make use of these helpers. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-8-vgo...@redhat.com>

[Virtio-fs] [PULL 06/12] virtiofsd, fuse_lowlevel.c: Add capability to parse security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
viewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_common.h | 5 ++ tools/virtiofsd/fuse_i.h| 7 +++ tools/virtiofsd/fuse_lowlevel.c | 102 +++- 3 files changed, 113 insertions(+), 1 deletion(-) diff --git a

[Virtio-fs] [PULL 05/12] virtiofsd: Extend size of fuse_conn_info->capable and ->want fields

2022-02-17 Thread Dr. David Alan Gilbert (git)
ans 32 bit fields are not suffcient anymore. Increase size to 64 bit so that we can add newer capabilities and still be able to use existing code to check and set the capabilities. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-5-vgo...@r

[Virtio-fs] [PULL 04/12] virtiofsd: Parse extended "struct fuse_init_in"

2022-02-17 Thread Dr. David Alan Gilbert (git)
n". Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-4-vgo...@redhat.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_lowlevel.c | 61 + 1 file changed, 39 insertions(+), 22

[Virtio-fs] [PULL 03/12] linux-headers: Update headers to v5.17-rc1

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Update headers to 5.17-rc1. I need latest fuse changes. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-3-vgo...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- include/standard-headers/asm-x86/kvm_para.h

[Virtio-fs] [PULL 02/12] virtiofsd: Fix breakage due to fuse_init_in size change

2022-02-17 Thread Dr. David Alan Gilbert (git)
arate patches will be posted which will parse rest of the bytes and enable new functionality. Right now we don't support any of the new functionality, so we don't lose anything by not parsing bytes beyond 16. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204

[Virtio-fs] [PULL 01/12] virtiofsd: Do not support blocking flock

2022-02-17 Thread Dr. David Alan Gilbert (git)
uni-stuttgart.de> Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Vivek Goyal Reviewed-by: Greg Kurz --- tools/virtiofsd/passthrough_ll.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index b3d0674f6d..3e56d1cd95

[Virtio-fs] [PULL 00/12] virtiofs queue

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit c13b8e9973635f34f3ce4356af27a311c993729c: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20220216' into staging (2022-02-16 09:57:11 +) are available in the Git repository at

Re: [Virtio-fs] [PULL 00/12] virtiofs queue

2022-02-17 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Wed, Feb 16, 2022 at 07:40:14PM +0000, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > > > From: "Dr. David Alan Gilbert" > > > >

Re: [Virtio-fs] [PULL 00/12] virtiofs queue

2022-02-16 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit c13b8e9973635f34f3ce4356af27a311c993729c: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20220216' in

[Virtio-fs] [PULL 12/12] virtiofsd: Add basic support for FUSE_SYNCFS request

2022-02-16 Thread Dr. David Alan Gilbert (git)
if the submounts are being hammered by some unrelated workload on the host. The only solution to prevent that is to avoid shared mounts. Signed-off-by: Greg Kurz Message-Id: <20220215181529.164070-2-gr...@kaod.org> Reviewed-by: Vivek Goyal Signed-off-by: Dr. David Alan Gilbert --- tools/vir

[Virtio-fs] [PULL 11/12] virtiofsd: Add an option to enable/disable security label

2022-02-16 Thread Dr. David Alan Gilbert (git)
Typically this is expected to be a SELinux label. File server will set this label on the file. It will try to set it atomically wherever possible. But its not possible in all the cases. Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-11-vgo...@redhat.com> Reviewed-by: Dr. David Alan Gil

[Virtio-fs] [PULL 09/12] virtiofsd: Create new file with security context

2022-02-16 Thread Dr. David Alan Gilbert (git)
ate SELinux policies. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-9-vgo...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 229 +++ 1 file changed, 200 insertions(+), 2

[Virtio-fs] [PULL 08/12] virtiofsd: Add helpers to work with /proc/self/task/tid/attr/fscreate

2022-02-16 Thread Dr. David Alan Gilbert (git)
set in fscreate. This works basically for SELinux and its per thread. This patch just introduces the helper functions. Subsequent patches will make use of these helpers. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-8-vgo...@redhat.com>

[Virtio-fs] [PULL 07/12] virtiofsd: Move core file creation code in separate function

2022-02-16 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Move core file creation bits in a separate function. Soon this is going to get more complex as file creation need to set security context also. And there will be multiple modes of file creation in next patch. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal

[Virtio-fs] [PULL 06/12] virtiofsd, fuse_lowlevel.c: Add capability to parse security context

2022-02-16 Thread Dr. David Alan Gilbert (git)
viewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_common.h | 5 ++ tools/virtiofsd/fuse_i.h| 7 +++ tools/virtiofsd/fuse_lowlevel.c | 102 +++- 3 files changed, 113 insertions(+), 1 deletion(-) diff --git a

[Virtio-fs] [PULL 05/12] virtiofsd: Extend size of fuse_conn_info->capable and ->want fields

2022-02-16 Thread Dr. David Alan Gilbert (git)
ans 32 bit fields are not suffcient anymore. Increase size to 64 bit so that we can add newer capabilities and still be able to use existing code to check and set the capabilities. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-5-vgo...@r

[Virtio-fs] [PULL 04/12] virtiofsd: Parse extended "struct fuse_init_in"

2022-02-16 Thread Dr. David Alan Gilbert (git)
n". Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-4-vgo...@redhat.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_lowlevel.c | 61 + 1 file changed, 39 insertions(+), 22

[Virtio-fs] [PULL 03/12] linux-headers: Update headers to v5.17-rc1

2022-02-16 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Update headers to 5.17-rc1. I need latest fuse changes. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-3-vgo...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- include/standard-headers/asm-x86/kvm_para.h

[Virtio-fs] [PULL 01/12] virtiofsd: Do not support blocking flock

2022-02-16 Thread Dr. David Alan Gilbert (git)
uni-stuttgart.de> Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Vivek Goyal Reviewed-by: Greg Kurz --- tools/virtiofsd/passthrough_ll.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index b3d0674f6d..3e56d1cd95

[Virtio-fs] [PULL 02/12] virtiofsd: Fix breakage due to fuse_init_in size change

2022-02-16 Thread Dr. David Alan Gilbert (git)
arate patches will be posted which will parse rest of the bytes and enable new functionality. Right now we don't support any of the new functionality, so we don't lose anything by not parsing bytes beyond 16. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204

[Virtio-fs] [PULL 00/12] virtiofs queue

2022-02-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit c13b8e9973635f34f3ce4356af27a311c993729c: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20220216' into staging (2022-02-16 09:57:11 +) are available in the Git repository at

Re: [Virtio-fs] [PATCH v6 1/1] virtiofsd: Add basic support for FUSE_SYNCFS request

2022-02-16 Thread Dr. David Alan Gilbert
f submounts aren't announced, the client only sends a request to > > + * sync the root inode. TODO: Track submounts internally and iterate > > + * over them as well. > > + */ > > + > > +fuse_reply_err(req, err); > > +} > > + > > static

Re: [Virtio-fs] [PATCH v6 00/10] virtiofsd: Add support for file security context at file creation

2022-02-16 Thread Dr. David Alan Gilbert
(-) > create mode 100644 include/standard-headers/linux/virtio_gpio.h > create mode 100644 include/standard-headers/linux/virtio_i2c.h > create mode 100644 include/standard-headers/linux/virtio_pcidev.h > create mode 100644 include/standard-headers/linux/virtio_scmi.h > create mode 100644 linux-headers/asm-riscv/bitsperlong.h > create mode 100644 linux-headers/asm-riscv/mman.h > create mode 100644 linux-headers/asm-riscv/unistd.h > > -- > 2.34.1 > > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK ___ Virtio-fs mailing list Virtio-fs@redhat.com https://listman.redhat.com/mailman/listinfo/virtio-fs

Re: [Virtio-fs] [PATCH v2] virtiofsd: Do not support blocking flock

2022-02-15 Thread Dr. David Alan Gilbert
g flock can deadlock as there is only one thread > + * serving the queue. > + */ > +fuse_reply_err(req, EOPNOTSUPP); > +return; > +} > + > res = flock(lo_fi_fd(req, fi), op); > > fuse_reply_err(req, res ==

Re: [Virtio-fs] [PATCH v6 10/10] virtiofsd: Add an option to enable/disable security label

2022-02-14 Thread Dr. David Alan Gilbert
ecurity label during file creation. Typically this is expected to > be a SELinux label. File server will set this label on the file. It will > try to set it atomically wherever possible. But its not possible in > all the cases. > > Signed-off-by: Vivek Goyal Reviewed-by: Dr. David Ala

Re: [Virtio-fs] [PATCH v6 05/10] virtiofsd, fuse_lowlevel.c: Add capability to parse security context

2022-02-14 Thread Dr. David Alan Gilbert
tempted to move the secctx_enabled check into parse_secctx_fill_req - but OK. Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_common.h | 5 ++ > tools/virtiofsd/fuse_i.h| 7 +++ > tools/virtiofsd/fuse_lowlevel.c | 102 +++- > 3 files

Re: [Virtio-fs] [PATCH v6 03/10] virtiofsd: Parse extended "struct fuse_init_in"

2022-02-14 Thread Dr. David Alan Gilbert
t; and ->flags2) in "fuse_struct_in". > > Signed-off-by: Vivek Goyal Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_lowlevel.c | 61 + > 1 file changed, 39 insertions(+), 22 deletions(-) > > diff --git a/tool

Re: [Virtio-fs] [PATCH v2] Deprecate C virtiofsd

2022-02-14 Thread Dr. David Alan Gilbert
* Richard W.M. Jones (rjo...@redhat.com) wrote: > On Thu, Feb 10, 2022 at 05:47:14PM +0000, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > There's a nice new Rust implementation out there; recommend people > > do new work on th

[Virtio-fs] [PATCH v2] Deprecate C virtiofsd

2022-02-10 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" There's a nice new Rust implementation out there; recommend people do new work on that. Signed-off-by: Dr. David Alan Gilbert --- docs/about/deprecated.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/docs/about/deprecated.

Re: [Virtio-fs] [PATCH] Deprecate C virtiofsd

2022-02-10 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Feb 10, 2022 at 05:13:19PM +0000, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Wed, Feb 09, 2022 at 04:50:40PM +0000, Dr. David Alan Gilbert (git) > > > wrote: &g

Re: [Virtio-fs] [PATCH] Deprecate C virtiofsd

2022-02-10 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Feb 09, 2022 at 04:50:40PM +0000, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > There's a nice new Rust implementation out there; recommend people > > do new wor

Re: [Virtio-fs] [PATCH] Deprecate C virtiofsd

2022-02-10 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Wed, 9 Feb 2022 at 16:57, Dr. David Alan Gilbert (git) > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > There's a nice new Rust implementation out there; recommend people > > do new work

[Virtio-fs] [PATCH] Deprecate C virtiofsd

2022-02-09 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" There's a nice new Rust implementation out there; recommend people do new work on that. Signed-off-by: Dr. David Alan Gilbert --- docs/about/deprecated.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/about/deprecated.rst b/

Re: [Virtio-fs] [PATCH v5 0/9] virtiofsd: Add support for file security context at file creation

2022-02-08 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Mon, Feb 07, 2022 at 12:49:24PM +0000, Dr. David Alan Gilbert wrote: > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > Hi, > > > > > > This is V5 of the patches. I posted V4 here. > > > > > &

Re: [Virtio-fs] [PATCH v5 7/9] virtiofsd: Create new file with fscreate set

2022-02-08 Thread Dr. David Alan Gilbert
ily useful when either there is no SELinux enabled on > host or host and guest policies are in sync and don't conflict. > > Signed-off-by: Vivek Goyal Minor nit below, but I think this is right: Reviewed-by: Dr. David Alan Gilbert I would however prefer if you could split this patch; i

Re: [Virtio-fs] [PATCH v5 0/9] virtiofsd: Add support for file security context at file creation

2022-02-08 Thread Dr. David Alan Gilbert
ard-headers/linux/virtio_i2c.h > create mode 100644 include/standard-headers/linux/virtio_pcidev.h > create mode 100644 include/standard-headers/linux/virtio_scmi.h > create mode 100644 linux-headers/asm-riscv/bitsperlong.h > create mode 100644 linux-headers/asm-riscv/mman.h &g

Re: [Virtio-fs] [PATCH v5 9/9] virtiofsd: Add an option to enable/disable security label

2022-02-08 Thread Dr. David Alan Gilbert
his case - or at least clear the flag? Dave > +conn->want |= FUSE_CAP_SECURITY_CTX; > +} else { > +fuse_log(FUSE_LOG_DEBUG, "lo_init: disabling security label\n"); > + conn->want &= ~FUSE_CAP_SECURITY_CTX; > +} &

Re: [Virtio-fs] [PATCH v5 8/9] virtiofsd: Create new file using O_TMPFILE and set security context

2022-02-08 Thread Dr. David Alan Gilbert
, symlinks will continue > to be non-atomic. > > Also if host filesystem does not support O_TMPFILE, we fallback to > non-atomic behavior. > > Signed-off-by: Vivek Goyal Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passthrough_ll.c | 80 ++

Re: [Virtio-fs] [PATCH v5 5/9] virtiofsd, fuse_lowlevel.c: Add capability to parse security context

2022-02-03 Thread Dr. David Alan Gilbert
E_VMSPLICE > se->conn.capable |= FUSE_CAP_SPLICE_WRITE | FUSE_CAP_SPLICE_MOVE; > @@ -2155,8 +2242,14 @@ static void do_init(fuse_req_t req, fuse_ino_t nodeid, > outarg.flags |= FUSE_SETXATTR_EXT; > } > > +if (se->conn.want & FUSE_CAP_SECURITY_

Re: [Virtio-fs] [PATCH v5 3/9] virtiofsd: Parse extended "struct fuse_init_in"

2022-02-03 Thread Dr. David Alan Gilbert
gt; +if (flags & FUSE_SUBMOUNTS) { > se->conn.capable |= FUSE_CAP_SUBMOUNTS; > } > -if (arg->flags & FUSE_HANDLE_KILLPRIV_V2) { > +if (flags & FUSE_HANDLE_KILLPRIV_V2) { > se->conn.capable |= FUSE_CAP_HANDLE_KILLPRIV_V2; > } > -if (arg->flags & FUSE_SETXATTR_EXT) { > +if (flags & FUSE_SETXATTR_EXT) { > se->conn.capable |= FUSE_CAP_SETXATTR_EXT; > } > #ifdef HAVE_SPLICE > @@ -2063,7 +2081,7 @@ static void do_init(fuse_req_t req, fuse_ino_t nodeid, > if (se->conn.max_write < bufsize - FUSE_BUFFER_HEADER_SIZE) { > se->bufsize = se->conn.max_write + FUSE_BUFFER_HEADER_SIZE; > } > -if (arg->flags & FUSE_MAX_PAGES) { > +if (flags & FUSE_MAX_PAGES) { > outarg.flags |= FUSE_MAX_PAGES; > outarg.max_pages = (se->conn.max_write - 1) / getpagesize() + 1; > } > -- > 2.34.1 > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK ___ Virtio-fs mailing list Virtio-fs@redhat.com https://listman.redhat.com/mailman/listinfo/virtio-fs

Re: [Virtio-fs] [PATCH v4 6/9] virtiofsd: Move core file creation code in separate function

2022-01-27 Thread Dr. David Alan Gilbert
oyal Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passthrough_ll.c | 36 ++-- > 1 file changed, 25 insertions(+), 11 deletions(-) > > diff --git a/tools/virtiofsd/passthrough_ll.c > b/tools/virtiofsd/passthrough_ll.c >

Re: [Virtio-fs] [PATCH v4 1/9] linux-headers: Update headers to v5.17-rc1

2022-01-27 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Thu, Jan 27, 2022 at 05:21:02PM +0000, Dr. David Alan Gilbert wrote: > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > Update headers to 5.17-rc1. I need latest fuse changes. > > > > > > Signed-off-by: Vivek

Re: [Virtio-fs] [PATCH v4 4/9] virtiofsd: Extend size of fuse_conn_info->capable and ->want fields

2022-01-27 Thread Dr. David Alan Gilbert
that are not supported by kernel, aborting.\n", > + "0x%lx that are not supported by kernel, aborting.\n", I think this will be OK in practice (need to check 32 bit); but weren't you using llx in the last patch? Reviewed-by: Dr. David Alan Gilbert Dave >

Re: [Virtio-fs] [PATCH v4 3/9] virtiofsd: Parse extended "struct fuse_init_in"

2022-01-27 Thread Dr. David Alan Gilbert
f (bufsize > max_bufsize) { > bufsize = max_bufsize; > } > } > -if (arg->flags & FUSE_SUBMOUNTS) { > +if (flags & FUSE_SUBMOUNTS) { > se->conn.capable |= FUSE_CAP_SUBMOUNTS; > } > -if (arg->flags & FUSE_HANDLE

Re: [Virtio-fs] [PATCH v4 1/9] linux-headers: Update headers to v5.17-rc1

2022-01-27 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > Update headers to 5.17-rc1. I need latest fuse changes. > > Signed-off-by: Vivek Goyal Can you just confirm that this lot was generated by running qemu's scripts/update-linux-headers.sh ? Dave > --- > include/standard-headers/asm-x86/kvm_para.h

Re: [Virtio-fs] [PATCH v4 2/9] virtiofsd: Fix breakage due to fuse_init_in size change

2022-01-27 Thread Dr. David Alan Gilbert
> Signed-off-by: Vivek Goyal OK, I think we should make this 1/9 and get this in quickly; that way bisect works. Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_lowlevel.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/vi

Re: [Virtio-fs] [PATCH] virtiofsd: Drop membership of all supplementary groups (CVE-2022-0358)

2022-01-26 Thread Dr. David Alan Gilbert
> privilege escalation. > > > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2044863 > > Fixes: CVE-2022-0358 > > Reported-by: JIETAO XIAO > > Suggested-by: Miklos Szeredi > > Reviewed-by: Stefan Hajnoczi > > Reviewed-by: Dr. David A

[Virtio-fs] [PULL 0/1] virtiofs queue

2022-01-26 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit aeb0ae95b7f18c66158792641cb6ba0cde5789ab: Merge remote-tracking branch 'remotes/jsnow-gitlab/tags/python-pull-request' into staging (2022-01-22 12:03:22 +) are available in the Git repository at: https://

[Virtio-fs] [PULL 1/1] virtiofsd: Drop membership of all supplementary groups (CVE-2022-0358)

2022-01-26 Thread Dr. David Alan Gilbert (git)
gzilla.redhat.com/show_bug.cgi?id=2044863 Fixes: CVE-2022-0358 Reported-by: JIETAO XIAO Suggested-by: Miklos Szeredi Reviewed-by: Stefan Hajnoczi Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: Signed-off-by: Dr. David Alan Gilbert dgilbert: Fixed missing {}'s

Re: [Virtio-fs] [PATCH] virtiofsd: Error on bad socket group name

2021-10-25 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Make the '--socket-group=' option fail if the group name is unknown: > > ./tools/virtiofsd/virtiofsd --socket-group=zaphod > vhost socket: unable to find

Re: [Virtio-fs] [PATCH] virtiofsd: Error on bad socket group name

2021-10-25 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Thu, Oct 14, 2021 at 01:25:54PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Make the '--socket-group=' option fail if the group name is unknown: > > > > ./tools/vir

Re: [Virtio-fs] [PATCH 00/13] virtiofsd: Support notification queue and

2021-10-25 Thread Dr. David Alan Gilbert
s/virtiofsd/tpool.c| 331 > tools/virtiofsd/tpool.h| 18 ++ > 14 files changed, 915 insertions(+), 113 deletions(-) > create mode 100644 tools/virtiofsd/tpool.c > create mode 100644 tools/virtiofsd/tpool.h > > -- > 2.31.

Re: [Virtio-fs] [PATCH] virtiofsd: xattr mapping add a new type "unsupported"

2021-10-25 Thread Dr. David Alan Gilbert
> security.selinux xattr and allow others. > > "-o xattrmap=/unsupported/all/security.selinux/security.selinux//ok/all///" > > Suggested-by: "Dr. David Alan Gilbert" > Signed-off-by: Vivek Goyal Queued > --- > docs/tools/virtiofsd.rst |6 ++

[Virtio-fs] [PATCH] virtiofsd: Error on bad socket group name

2021-10-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Make the '--socket-group=' option fail if the group name is unknown: ./tools/virtiofsd/virtiofsd --socket-group=zaphod vhost socket: unable to find group 'zaphod' Reported-by: Xiaoling Gao Signed-off-by: Dr. David Alan Gilbert --- tools

Re: [Virtio-fs] [PATCH] virtiofsd: xattr mapping add a new type "unsupported"

2021-10-05 Thread Dr. David Alan Gilbert
> security.selinux xattr and allow others. > > "-o xattrmap=/unsupported/all/security.selinux/security.selinux//ok/all///" > > Suggested-by: "Dr. David Alan Gilbert" > Signed-off-by: Vivek Goyal Yes, that's nice and simple. Reviewed-by: Dr. David Alan Gilbert > -

  1   2   3   4   5   6   7   >