Re: [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()

2020-01-06 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Niels de Vos (nde...@redhat.com) wrote: > > On Thu, Jan 02, 2020 at 06:55:40PM +, Dr. David Alan Gilbert wrote: > > > * Xiao Yang (yangx...@cn.fujitsu.com) wrote: > > > > lo_copy_file_range() passes -errno to fuse_reply_err() and then

Re: [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()

2020-01-06 Thread Dr. David Alan Gilbert
* Niels de Vos (nde...@redhat.com) wrote: > On Thu, Jan 02, 2020 at 06:55:40PM +, Dr. David Alan Gilbert wrote: > > * Xiao Yang (yangx...@cn.fujitsu.com) wrote: > > > lo_copy_file_range() passes -errno to fuse_reply_err() and then > > > fuse_reply_err() > > > changes it to errno again, so

Re: [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()

2020-01-06 Thread Niels de Vos
On Thu, Jan 02, 2020 at 06:55:40PM +, Dr. David Alan Gilbert wrote: > * Xiao Yang (yangx...@cn.fujitsu.com) wrote: > > lo_copy_file_range() passes -errno to fuse_reply_err() and then > > fuse_reply_err() > > changes it to errno again, so that subsequent fuse_send_reply_iov_nofree() > >

Re: [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()

2020-01-03 Thread Stefan Hajnoczi
On Thu, Jan 02, 2020 at 11:53:12AM +0800, Xiao Yang wrote: > lo_copy_file_range() passes -errno to fuse_reply_err() and then > fuse_reply_err() > changes it to errno again, so that subsequent fuse_send_reply_iov_nofree() > catches > the wrong errno.(i.e. reports "fuse: bad error value: ..."). >

Re: [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()

2020-01-02 Thread Dr. David Alan Gilbert
* Xiao Yang (yangx...@cn.fujitsu.com) wrote: > lo_copy_file_range() passes -errno to fuse_reply_err() and then > fuse_reply_err() > changes it to errno again, so that subsequent fuse_send_reply_iov_nofree() > catches > the wrong errno.(i.e. reports "fuse: bad error value: ..."). > > Make

Re: [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()

2020-01-01 Thread Xiao Yang
On 2020/1/2 12:50, Eryu Guan wrote: On Thu, Jan 02, 2020 at 11:53:12AM +0800, Xiao Yang wrote: > lo_copy_file_range() passes -errno to fuse_reply_err() and then fuse_reply_err() > changes it to errno again, so that subsequent fuse_send_reply_iov_nofree() catches > the wrong errno.(i.e.

Re: [Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()

2020-01-01 Thread Eryu Guan
On Thu, Jan 02, 2020 at 11:53:12AM +0800, Xiao Yang wrote: > lo_copy_file_range() passes -errno to fuse_reply_err() and then > fuse_reply_err() > changes it to errno again, so that subsequent fuse_send_reply_iov_nofree() > catches > the wrong errno.(i.e. reports "fuse: bad error value: ..."). >

[Virtio-fs] [PATCH] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err()

2020-01-01 Thread Xiao Yang
lo_copy_file_range() passes -errno to fuse_reply_err() and then fuse_reply_err() changes it to errno again, so that subsequent fuse_send_reply_iov_nofree() catches the wrong errno.(i.e. reports "fuse: bad error value: ..."). Make fuse_send_reply_iov_nofree() accept the correct -errno by passing