Re: [Virtio-fs] [PATCH v2 1/2] cleanup: Tweak and re-run return_directly.cocci

2022-11-24 Thread Markus Armbruster
Greg Kurz writes: > On Thu, 24 Nov 2022 16:15:11 +0100 > Greg Kurz wrote: > >> On Tue, 22 Nov 2022 14:49:16 +0100 >> Markus Armbruster wrote: >> >> > Tweak the semantic patch to drop redundant parenthesis around the >> > return expression. >> > >> > Coccinelle drops a comment in

Re: [Virtio-fs] [PATCH v2 1/2] cleanup: Tweak and re-run return_directly.cocci

2022-11-24 Thread Greg Kurz
On Tue, 22 Nov 2022 14:49:16 +0100 Markus Armbruster wrote: > Tweak the semantic patch to drop redundant parenthesis around the > return expression. > > Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored > manually. > > Coccinelle messes up vmdk_co_create(), not sure why. Change

Re: [Virtio-fs] [PATCH v2 1/2] cleanup: Tweak and re-run return_directly.cocci

2022-11-24 Thread Greg Kurz
On Thu, 24 Nov 2022 16:15:11 +0100 Greg Kurz wrote: > On Tue, 22 Nov 2022 14:49:16 +0100 > Markus Armbruster wrote: > > > Tweak the semantic patch to drop redundant parenthesis around the > > return expression. > > > > Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored > >

Re: [Virtio-fs] [PATCH v2 1/2] cleanup: Tweak and re-run return_directly.cocci

2022-11-24 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Tweak the semantic patch to drop redundant parenthesis around the > return expression. > > Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored > manually. > > Coccinelle messes up vmdk_co_create(), not sure why. Change dropped, >

Re: [Virtio-fs] [PATCH v2 1/2] cleanup: Tweak and re-run return_directly.cocci

2022-11-22 Thread Philippe Mathieu-Daudé
On 22/11/22 14:49, Markus Armbruster wrote: Tweak the semantic patch to drop redundant parenthesis around the return expression. Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored manually. Coccinelle messes up vmdk_co_create(), not sure why. Change dropped, will be done

[Virtio-fs] [PATCH v2 1/2] cleanup: Tweak and re-run return_directly.cocci

2022-11-22 Thread Markus Armbruster
Tweak the semantic patch to drop redundant parenthesis around the return expression. Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored manually. Coccinelle messes up vmdk_co_create(), not sure why. Change dropped, will be done manually in the next commit. Line breaks in