Re: [Virtio-fs] [PATCH 0/2] Convert to cap-ng
* Vivek Goyal (vgo...@redhat.com) wrote: > On Tue, Dec 03, 2019 at 01:14:21PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Hi, > > This changes virtiofsd to use cap-ng rather than cap > > (qemu is moving in that direction). It's a little painful > > because of an interaction with our sandboxing. > > > > I intend to flatten the conversion into Vivek's patch that > > adds the libcap use. > > It feels ugly that we store the parent process's state in a global > variable and all the threads load their state from there. At the > same time I don't have any good idea how to solve this problem given > libcap-ng relies on /proc being there. So I am fine with the patches. Yep; I raised a cap-ng bug to show the issue, and Steve agrees it's a pain; so at least it's recorded. Dave > > Thanks > Vivek > > > > Dave > > > > Dr. David Alan Gilbert (2): > > virtiofsd: cap-ng helpers > > virtiofsd: Convert to libcap-ng > > > > Makefile | 2 +- > > contrib/virtiofsd/Makefile.objs| 2 - > > contrib/virtiofsd/passthrough_ll.c | 162 +++-- > > 3 files changed, 106 insertions(+), 60 deletions(-) > > > > -- > > 2.23.0 > > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK ___ Virtio-fs mailing list Virtio-fs@redhat.com https://www.redhat.com/mailman/listinfo/virtio-fs
Re: [Virtio-fs] [PATCH 0/2] Convert to cap-ng
On Tue, Dec 03, 2019 at 01:14:21PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This changes virtiofsd to use cap-ng rather than cap > (qemu is moving in that direction). It's a little painful > because of an interaction with our sandboxing. > > I intend to flatten the conversion into Vivek's patch that > adds the libcap use. It feels ugly that we store the parent process's state in a global variable and all the threads load their state from there. At the same time I don't have any good idea how to solve this problem given libcap-ng relies on /proc being there. So I am fine with the patches. Thanks Vivek > > Dave > > Dr. David Alan Gilbert (2): > virtiofsd: cap-ng helpers > virtiofsd: Convert to libcap-ng > > Makefile | 2 +- > contrib/virtiofsd/Makefile.objs| 2 - > contrib/virtiofsd/passthrough_ll.c | 162 +++-- > 3 files changed, 106 insertions(+), 60 deletions(-) > > -- > 2.23.0 > ___ Virtio-fs mailing list Virtio-fs@redhat.com https://www.redhat.com/mailman/listinfo/virtio-fs
[Virtio-fs] [PATCH 0/2] Convert to cap-ng
From: "Dr. David Alan Gilbert" Hi, This changes virtiofsd to use cap-ng rather than cap (qemu is moving in that direction). It's a little painful because of an interaction with our sandboxing. I intend to flatten the conversion into Vivek's patch that adds the libcap use. Dave Dr. David Alan Gilbert (2): virtiofsd: cap-ng helpers virtiofsd: Convert to libcap-ng Makefile | 2 +- contrib/virtiofsd/Makefile.objs| 2 - contrib/virtiofsd/passthrough_ll.c | 162 +++-- 3 files changed, 106 insertions(+), 60 deletions(-) -- 2.23.0 ___ Virtio-fs mailing list Virtio-fs@redhat.com https://www.redhat.com/mailman/listinfo/virtio-fs
